[GitHub] [ignite] alex-plekhanov commented on a change in pull request #9819: IGNITE-14916 Calcite. RuntimeHashIndex scan must filter result by predicate

[GitBox <gi...@apache.org>]

alex-plekhanov commented on a change in pull request #9819:
URL: https://github.com/apache/ignite/pull/9819#discussion_r804487654



##########
File path: modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/HashIndexSpoolExecutionTest.java
##########
@@ -115,6 +115,7 @@ public void testIndexSpool() throws Exception {
                     ctx,
                     rowType,
                     ImmutableBitSet.of(0),
+                    null,

Review comment:
       Let's use `testFilter` and add some test case with filtering, for example, something like:
   ```
                           new GridTuple3(
                               (Predicate<Object[]>)(r -> ((int)r[2]) == 0),
                               new Object[] {size / 2 + 1, null, null},
                               1
                           )
   ```

##########
File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/RuntimeHashIndex.java
##########
@@ -108,11 +109,15 @@ private GroupKey key(Row r) {
         /** Search row. */
         private final Supplier<Row> searchRow;
 
+        /** Row filter. */
+        private final Predicate<Row> filter;
+
         /**
          * @param searchRow Search row.
          */
-        IndexScan(Supplier<Row> searchRow) {
+        IndexScan(Supplier<Row> searchRow, Predicate<Row> filter) {

Review comment:
       Let's mark filter as `@Nullable` (here and up in the stack)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org