You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2020/11/19 10:49:44 UTC
[spark] branch branch-3.0 updated: [SPARK-33483][INFRA][TESTS][3.0]
Fix rat exclusion patterns and add a LICENSE
This is an automated email from the ASF dual-hosted git repository.
gurwls223 pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new 6b7172b [SPARK-33483][INFRA][TESTS][3.0] Fix rat exclusion patterns and add a LICENSE
6b7172b is described below
commit 6b7172bc3b8275df9b88ea8d22b331acedaf75bb
Author: Dongjoon Hyun <do...@apache.org>
AuthorDate: Thu Nov 19 19:42:20 2020 +0900
[SPARK-33483][INFRA][TESTS][3.0] Fix rat exclusion patterns and add a LICENSE
### What changes were proposed in this pull request?
This PR fixes the RAT exclusion rule which was originated from SPARK-1144 (Apache Spark 1.0)
### Why are the changes needed?
This prevents the situation like https://github.com/apache/spark/pull/30415.
Currently, it missed `catalog` directory due to `.log` rule.
```
$ dev/check-license
Could not find Apache license headers in the following files:
!????? /Users/dongjoon/APACHE/spark-merge/sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/MetadataColumn.java
!????? /Users/dongjoon/APACHE/spark-merge/sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsMetadataColumns.java
```
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the CI with the new rule.
Closes #30424 from dongjoon-hyun/SPARK-33483-3.0.
Authored-by: Dongjoon Hyun <do...@apache.org>
Signed-off-by: HyukjinKwon <gu...@apache.org>
---
dev/.rat-excludes | 28 ++++++++++++++--------
.../test/resources/data/scripts/test_transform.py | 18 ++++++++++++++
2 files changed, 36 insertions(+), 10 deletions(-)
diff --git a/dev/.rat-excludes b/dev/.rat-excludes
index 7ce00b7..20a4002 100644
--- a/dev/.rat-excludes
+++ b/dev/.rat-excludes
@@ -39,11 +39,11 @@ jquery.dataTables.1.10.18.min.js
jquery.mustache.js
jsonFormatter.min.css
jsonFormatter.min.js
-.*avsc
-.*txt
-.*json
-.*data
-.*log
+.*\.avsc
+.*\.txt
+.*\.json
+.*\.data
+.*\.log
pyspark-coverage-site/
cloudpickle.py
heapq3.py
@@ -96,17 +96,17 @@ local-1430917381535_2
DESCRIPTION
NAMESPACE
test_support/*
-.*Rd
+.*\.Rd
help/*
html/*
INDEX
.lintr
gen-java.*
-.*avpr
-.*parquet
+.*\.avpr
+.*\.parquet
spark-deps-.*
-.*csv
-.*tsv
+.*\.csv
+.*\.tsv
.*\.sql
.Rbuildignore
META-INF/*
@@ -119,3 +119,11 @@ vote.tmpl
SessionManager.java
SessionHandler.java
GangliaReporter.java
+_metadata
+_SUCCESS
+part-00000
+.*\.res
+flights_tiny.txt.1
+over1k
+over10k
+exported_table/*
diff --git a/sql/hive/src/test/resources/data/scripts/test_transform.py b/sql/hive/src/test/resources/data/scripts/test_transform.py
index ac6d11d..dedb370 100755
--- a/sql/hive/src/test/resources/data/scripts/test_transform.py
+++ b/sql/hive/src/test/resources/data/scripts/test_transform.py
@@ -1,3 +1,21 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
import sys
delim = sys.argv[1]
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org