You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/01/08 09:56:10 UTC
[GitHub] [skywalking] bootsrc commented on a change in pull request #6159: Dubbo link tracing- show "group" attribute value in OperationName
bootsrc commented on a change in pull request #6159:
URL: https://github.com/apache/skywalking/pull/6159#discussion_r553847689
##########
File path: apm-sniffer/apm-sdk-plugin/dubbo-2.7.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/asf/dubbo/DubboInterceptor.java
##########
@@ -136,6 +137,9 @@ private void dealException(Throwable throwable) {
*/
private String generateOperationName(URL requestURL, Invocation invocation) {
StringBuilder operationName = new StringBuilder();
+ String groupStr = requestURL.getParameter(Constants.GROUP_KEY);
+ groupStr = null == groupStr ? "" : groupStr + " ";
+ operationName.append(groupStr);
Review comment:
Which separator is better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org