[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5237: cleaned up ExecutionHandlerContext dependencies

[GitBox <gi...@apache.org>]

jdeppe-pivotal commented on a change in pull request #5237:
URL: https://github.com/apache/geode/pull/5237#discussion_r438999736



##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java
##########
@@ -264,7 +238,7 @@ private void moveSubscribeToNewEventLoopGroup(ChannelHandlerContext ctx, Command
     if (command.isOfType(SUBSCRIBE)) {
       CountDownLatch latch = new CountDownLatch(0);
       ctx.channel().deregister().addListener((ChannelFutureListener) future -> {
-        subscriberEventLoopGroup.register(ctx.channel()).sync();
+        server.getSubscriberGroup().register(ctx.channel()).sync();

Review comment:
       I wonder if there is some 'feature-envy' creep happening here. What do you think about pushing the registration functionality onto the `server`? I'm also fine with this approach.

##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java
##########
@@ -264,7 +238,7 @@ private void moveSubscribeToNewEventLoopGroup(ChannelHandlerContext ctx, Command
     if (command.isOfType(SUBSCRIBE)) {
       CountDownLatch latch = new CountDownLatch(0);

Review comment:
       This looks like a bug in that the latch should be initialized with `1`. This is my bug :(.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org