You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2023/05/25 09:18:11 UTC
[native-toolchain-CR] IMPALA-12128: Bump ORC C++ version to 1.7.9-p10
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19934
Change subject: IMPALA-12128: Bump ORC C++ version to 1.7.9-p10
......................................................................
IMPALA-12128: Bump ORC C++ version to 1.7.9-p10
This bumps ORC C++ version to 1.7.9-p10 to have the fix of ORC-1041 and
ORC-1304.
Tests:
- Build locally
Change-Id: I901470295157c51e0db8be3deb6b7ac53421e7d5
---
M buildall.sh
A source/orc/orc-1.7.9-patches/0001-ORC-1020-C-Optimize-RleDecoderV2-nextDirect-base-on-.patch
A source/orc/orc-1.7.9-patches/0002-ORC-1128-C-Replace-protobuf-MessageLite-ByteSize-wit.patch
A source/orc/orc-1.7.9-patches/0003-ORC-1122-C-Add-buffer-to-decode-the-whole-run-in-Rle.patch
A source/orc/orc-1.7.9-patches/0004-ORC-1137-C-Unroll-loops-and-copy-data-directly-in-Do.patch
A source/orc/orc-1.7.9-patches/0005-ORC-1125-C-Support-reading-decimal64-in-ORCv2.patch
A source/orc/orc-1.7.9-patches/0006-ORC-969-C-Evaluate-SearchArguments-using-file-and-st.patch
A source/orc/orc-1.7.9-patches/0007-ORC-1150-C-Optimize-RowReaderImpl-computeBatchSize-b.patch
A source/orc/orc-1.7.9-patches/0008-ORC-1160-C-Fix-seekToRow-can-t-seek-within-selected-.patch
A source/orc/orc-1.7.9-patches/0009-ORC-1159-C-Fix-crash-when-the-last-stripe-is-skipped.patch
A source/orc/orc-1.7.9-patches/0010-ORC-1304-C-Fix-seeking-over-empty-PRESENT-stream-152.patch
11 files changed, 3,729 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/34/19934/1
--
To view, visit http://gerrit.cloudera.org:8080/19934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I901470295157c51e0db8be3deb6b7ac53421e7d5
Gerrit-Change-Number: 19934
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[native-toolchain-CR] IMPALA-12128: Bump ORC C++ version to 1.7.9-p10
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19934 )
Change subject: IMPALA-12128: Bump ORC C++ version to 1.7.9-p10
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I901470295157c51e0db8be3deb6b7ac53421e7d5
Gerrit-Change-Number: 19934
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Jun 2023 00:02:19 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-12128: Bump ORC C++ version to 1.7.9-p10
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19934 )
Change subject: IMPALA-12128: Bump ORC C++ version to 1.7.9-p10
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I901470295157c51e0db8be3deb6b7ac53421e7d5
Gerrit-Change-Number: 19934
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 May 2023 00:22:21 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-12128: Bump ORC C++ version to 1.7.9-p10
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19934 )
Change subject: IMPALA-12128: Bump ORC C++ version to 1.7.9-p10
......................................................................
IMPALA-12128: Bump ORC C++ version to 1.7.9-p10
This bumps ORC C++ version to 1.7.9-p10 to have the fix of ORC-1041 and
ORC-1304.
Tests:
- Build locally
Change-Id: I901470295157c51e0db8be3deb6b7ac53421e7d5
Reviewed-on: http://gerrit.cloudera.org:8080/19934
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Quanlong Huang <hu...@gmail.com>
---
M buildall.sh
A source/orc/orc-1.7.9-patches/0001-ORC-1020-C-Optimize-RleDecoderV2-nextDirect-base-on-.patch
A source/orc/orc-1.7.9-patches/0002-ORC-1128-C-Replace-protobuf-MessageLite-ByteSize-wit.patch
A source/orc/orc-1.7.9-patches/0003-ORC-1122-C-Add-buffer-to-decode-the-whole-run-in-Rle.patch
A source/orc/orc-1.7.9-patches/0004-ORC-1137-C-Unroll-loops-and-copy-data-directly-in-Do.patch
A source/orc/orc-1.7.9-patches/0005-ORC-1125-C-Support-reading-decimal64-in-ORCv2.patch
A source/orc/orc-1.7.9-patches/0006-ORC-969-C-Evaluate-SearchArguments-using-file-and-st.patch
A source/orc/orc-1.7.9-patches/0007-ORC-1150-C-Optimize-RowReaderImpl-computeBatchSize-b.patch
A source/orc/orc-1.7.9-patches/0008-ORC-1160-C-Fix-seekToRow-can-t-seek-within-selected-.patch
A source/orc/orc-1.7.9-patches/0009-ORC-1159-C-Fix-crash-when-the-last-stripe-is-skipped.patch
A source/orc/orc-1.7.9-patches/0010-ORC-1304-C-Fix-seeking-over-empty-PRESENT-stream-152.patch
11 files changed, 3,729 insertions(+), 1 deletion(-)
Approvals:
Wenzhe Zhou: Looks good to me, but someone else must approve
Joe McDonnell: Looks good to me, approved
Quanlong Huang: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I901470295157c51e0db8be3deb6b7ac53421e7d5
Gerrit-Change-Number: 19934
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[native-toolchain-CR] IMPALA-12128: Bump ORC C++ version to 1.7.9-p10
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19934 )
Change subject: IMPALA-12128: Bump ORC C++ version to 1.7.9-p10
......................................................................
Patch Set 1: Code-Review+2
I'm ok with bumping this version.
--
To view, visit http://gerrit.cloudera.org:8080/19934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I901470295157c51e0db8be3deb6b7ac53421e7d5
Gerrit-Change-Number: 19934
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 May 2023 23:54:06 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-12128: Bump ORC C++ version to 1.7.9-p10
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19934 )
Change subject: IMPALA-12128: Bump ORC C++ version to 1.7.9-p10
......................................................................
Patch Set 1:
Since we are no longer using the 1.7.0 patches (and no longer have the BUILD_HISTORICAL option), we can safely remove the orc-1.7.0-patches directory.
--
To view, visit http://gerrit.cloudera.org:8080/19934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I901470295157c51e0db8be3deb6b7ac53421e7d5
Gerrit-Change-Number: 19934
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 May 2023 23:53:23 +0000
Gerrit-HasComments: No