You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/05 15:10:41 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6211: armv7-a: Inner Shareable TLB maintenance operations
xiaoxiang781216 commented on code in PR #6211:
URL: https://github.com/apache/incubator-nuttx/pull/6211#discussion_r866018049
##########
arch/arm/src/armv7-a/arm_head.S:
##########
@@ -326,11 +326,17 @@ __start:
*/
mov r0, #0
+#ifdef CONFIG_ARCH_CORTEXA8
Review Comment:
ditto
##########
arch/arm/src/armv7-a/arm_cpuhead.S:
##########
@@ -200,11 +200,17 @@ __cpu3_start:
*/
mov r0, #0
+#ifdef CONFIG_ARCH_CORTEXA8
Review Comment:
why A8 need special treatment?
##########
arch/arm/src/armv7-a/mmu.h:
##########
@@ -1227,7 +1227,16 @@ static inline void cp15_invalidate_tlbs(void)
{
__asm__ __volatile__
(
+ "\tdsb\n"
+#ifdef CONFIG_ARCH_CORTEXA8
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org