You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Veena Basavaraj <vb...@cloudera.com> on 2014/10/07 19:56:30 UTC

Review Request 26419: SQOOP-1551: Repository Upgrader api rename

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26419/
-----------------------------------------------------------

Review request for Sqoop.


Repository: sqoop-SQOOP-1367


Description
-------

Few more pending renames as per the agreement on Sqoop 1551 


Diffs
-----

  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConfigUpgrader.java PRE-CREATION 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 87ac2af 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java a069b3e 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java b17aa21 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 606b9fa 
  core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb1 
  core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 54bdd13 
  core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 5226926 
  core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb 
  core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 847b73d 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3ade247 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d 
  core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java c2f8505 
  core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java e6e4760 
  execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 74e41df 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 39702ca 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java bf72626 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java d597bd8 
  spi/src/main/java/org/apache/sqoop/connector/spi/ConfigUpgrader.java PRE-CREATION 
  spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java 879e428 
  spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 849f091 
  submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef 

Diff: https://reviews.apache.org/r/26419/diff/


Testing
-------

yes test pastss


Thanks,

Veena Basavaraj


Re: Review Request 26419: SQOOP-1566: Fix the upgrade logic for SQOOP-1498

Posted by Veena Basavaraj <vb...@cloudera.com>.

> On Oct. 8, 2014, 2:49 p.m., Abraham Elmahrek wrote:
> > A couple of thoughts that might help me review:
> > 1. JobConstants was renamed to MRJobConstants. Please pull out this change to a separate Jira.
> > 2. We've changed a bunch of things to Configurable it seems. Could we pull out this change to a separate Jira?
> > 
> > It'll be much easier to review that way.

sure I can split it up. once you ship this for functional changes. I amm addressing all comments soon


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26419/#review55877
-----------------------------------------------------------


On Oct. 8, 2014, 12:50 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26419/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 12:50 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-SQOOP-1367
> 
> 
> Description
> -------
> 
> Few more pending renames as per the agreement on Sqoop 1551 
> 
> - Mainly fix the upgrade logic for 1498 changes
> - rename the repository upgrader to Configurable upgrader - agreed by Jarcec. 
> 
> - rename configuration utils to MRConfigurationUtils, so it is not be confused with the sqoop configuration/ configs
> - rename mapreduce to MR ( if this is not acceptable, happy to change it back)
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 290e7fc 
>   common/src/main/java/org/apache/sqoop/model/MConfigurable.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MConfigurableType.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MConnector.java 2f42191 
>   common/src/main/java/org/apache/sqoop/model/MDriver.java 685439e 
>   common/src/main/java/org/apache/sqoop/utils/ClassUtils.java 0be4d41 
>   common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java eac789e 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 87ac2af 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java a069b3e 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java b17aa21 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 606b9fa 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb1 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 54bdd13 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 5226926 
>   core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb 
>   core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 847b73d 
>   core/src/main/java/org/apache/sqoop/driver/DriverUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java df2a5ab 
>   core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3ade247 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 97de893 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d 
>   core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java c2f8505 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java dc4e8c8 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverUpgrader.java PRE-CREATION 
>   core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 3b475c6 
>   core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java e6e4760 
>   execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 74e41df 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 73d8387 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java ad749ed 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 478afe2 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 2da084f 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java d597bd8 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java 0eb9df4 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 7109ae5 
>   server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 462579c 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 80e65b8 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java cbd34f5 
>   spi/src/main/java/org/apache/sqoop/connector/spi/ConfigurableUpgrader.java PRE-CREATION 
>   spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java 879e428 
>   spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 849f091 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef 
> 
> Diff: https://reviews.apache.org/r/26419/diff/
> 
> 
> Testing
> -------
> 
> yes test pass
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Re: Review Request 26419: SQOOP-1566: Fix the upgrade logic for SQOOP-1498

Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26419/#review55877
-----------------------------------------------------------


A couple of thoughts that might help me review:
1. JobConstants was renamed to MRJobConstants. Please pull out this change to a separate Jira.
2. We've changed a bunch of things to Configurable it seems. Could we pull out this change to a separate Jira?

It'll be much easier to review that way.


common/src/main/java/org/apache/sqoop/model/MConfigurable.java
<https://reviews.apache.org/r/26419/#comment96254>

    Space!



core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java
<https://reviews.apache.org/r/26419/#comment96255>

    Or just: "setConfigurable" and "getConfigurable".



core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java
<https://reviews.apache.org/r/26419/#comment96256>

    Probably needs to be renamed as well.



core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java
<https://reviews.apache.org/r/26419/#comment96257>

    getConnectorConfigurable?



core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
<https://reviews.apache.org/r/26419/#comment96258>

    This is not just Schema but Data as well. I'd rename back to "Internals" or make it "SchemaAndData".



core/src/main/java/org/apache/sqoop/repository/Repository.java
<https://reviews.apache.org/r/26419/#comment96260>

    Same thoughts as above... could be Schema and Data that's being upgraded.


- Abraham Elmahrek


On Oct. 8, 2014, 7:50 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26419/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 7:50 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-SQOOP-1367
> 
> 
> Description
> -------
> 
> Few more pending renames as per the agreement on Sqoop 1551 
> 
> - Mainly fix the upgrade logic for 1498 changes
> - rename the repository upgrader to Configurable upgrader - agreed by Jarcec. 
> 
> - rename configuration utils to MRConfigurationUtils, so it is not be confused with the sqoop configuration/ configs
> - rename mapreduce to MR ( if this is not acceptable, happy to change it back)
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 290e7fc 
>   common/src/main/java/org/apache/sqoop/model/MConfigurable.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MConfigurableType.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MConnector.java 2f42191 
>   common/src/main/java/org/apache/sqoop/model/MDriver.java 685439e 
>   common/src/main/java/org/apache/sqoop/utils/ClassUtils.java 0be4d41 
>   common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java eac789e 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 87ac2af 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java a069b3e 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java b17aa21 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 606b9fa 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb1 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 54bdd13 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 5226926 
>   core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb 
>   core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 847b73d 
>   core/src/main/java/org/apache/sqoop/driver/DriverUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java df2a5ab 
>   core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3ade247 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 97de893 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d 
>   core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java c2f8505 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java dc4e8c8 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverUpgrader.java PRE-CREATION 
>   core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 3b475c6 
>   core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java e6e4760 
>   execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 74e41df 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 73d8387 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java ad749ed 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 478afe2 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 2da084f 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java d597bd8 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java 0eb9df4 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 7109ae5 
>   server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 462579c 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 80e65b8 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java cbd34f5 
>   spi/src/main/java/org/apache/sqoop/connector/spi/ConfigurableUpgrader.java PRE-CREATION 
>   spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java 879e428 
>   spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 849f091 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef 
> 
> Diff: https://reviews.apache.org/r/26419/diff/
> 
> 
> Testing
> -------
> 
> yes test pass
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Re: Review Request 26419: SQOOP-1566: Fix the upgrade logic for SQOOP-1498

Posted by Veena Basavaraj <vb...@cloudera.com>.

> On Oct. 8, 2014, 2:56 p.m., Abraham Elmahrek wrote:
> > The upgrade seems fine... does it upgrade from previous version of sqoop2 with the existence of a job and connection?

yes, that was my understanding that we support upgrade to latest. It guards if tables dont exist.


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26419/#review55879
-----------------------------------------------------------


On Oct. 8, 2014, 12:50 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26419/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 12:50 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-SQOOP-1367
> 
> 
> Description
> -------
> 
> Few more pending renames as per the agreement on Sqoop 1551 
> 
> - Mainly fix the upgrade logic for 1498 changes
> - rename the repository upgrader to Configurable upgrader - agreed by Jarcec. 
> 
> - rename configuration utils to MRConfigurationUtils, so it is not be confused with the sqoop configuration/ configs
> - rename mapreduce to MR ( if this is not acceptable, happy to change it back)
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 290e7fc 
>   common/src/main/java/org/apache/sqoop/model/MConfigurable.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MConfigurableType.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MConnector.java 2f42191 
>   common/src/main/java/org/apache/sqoop/model/MDriver.java 685439e 
>   common/src/main/java/org/apache/sqoop/utils/ClassUtils.java 0be4d41 
>   common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java eac789e 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 87ac2af 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java a069b3e 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java b17aa21 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 606b9fa 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb1 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 54bdd13 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 5226926 
>   core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb 
>   core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 847b73d 
>   core/src/main/java/org/apache/sqoop/driver/DriverUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java df2a5ab 
>   core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3ade247 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 97de893 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d 
>   core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java c2f8505 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java dc4e8c8 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverUpgrader.java PRE-CREATION 
>   core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 3b475c6 
>   core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java e6e4760 
>   execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 74e41df 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 73d8387 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java ad749ed 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 478afe2 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 2da084f 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java d597bd8 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java 0eb9df4 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 7109ae5 
>   server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 462579c 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 80e65b8 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java cbd34f5 
>   spi/src/main/java/org/apache/sqoop/connector/spi/ConfigurableUpgrader.java PRE-CREATION 
>   spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java 879e428 
>   spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 849f091 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef 
> 
> Diff: https://reviews.apache.org/r/26419/diff/
> 
> 
> Testing
> -------
> 
> yes test pass
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Re: Review Request 26419: SQOOP-1566: Fix the upgrade logic for SQOOP-1498

Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26419/#review55879
-----------------------------------------------------------


The upgrade seems fine... does it upgrade from previous version of sqoop2 with the existence of a job and connection?


repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
<https://reviews.apache.org/r/26419/#comment96262>

    This should be moved to the same scope as 'updateRepositoryVersion'.



repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
<https://reviews.apache.org/r/26419/#comment96263>

    QUERY_UPGRADE_...?



repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
<https://reviews.apache.org/r/26419/#comment96264>

    QUERY_UPGRADE_...?
    
    A bunch of these is missing QUERY_UPGRADE_... I think. This is just for consistency... more of a NIT.


- Abraham Elmahrek


On Oct. 8, 2014, 7:50 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26419/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 7:50 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-SQOOP-1367
> 
> 
> Description
> -------
> 
> Few more pending renames as per the agreement on Sqoop 1551 
> 
> - Mainly fix the upgrade logic for 1498 changes
> - rename the repository upgrader to Configurable upgrader - agreed by Jarcec. 
> 
> - rename configuration utils to MRConfigurationUtils, so it is not be confused with the sqoop configuration/ configs
> - rename mapreduce to MR ( if this is not acceptable, happy to change it back)
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 290e7fc 
>   common/src/main/java/org/apache/sqoop/model/MConfigurable.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MConfigurableType.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MConnector.java 2f42191 
>   common/src/main/java/org/apache/sqoop/model/MDriver.java 685439e 
>   common/src/main/java/org/apache/sqoop/utils/ClassUtils.java 0be4d41 
>   common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java eac789e 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 87ac2af 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java a069b3e 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java b17aa21 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 606b9fa 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb1 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 54bdd13 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 5226926 
>   core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb 
>   core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 847b73d 
>   core/src/main/java/org/apache/sqoop/driver/DriverUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java df2a5ab 
>   core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3ade247 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 97de893 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d 
>   core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java c2f8505 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java dc4e8c8 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverUpgrader.java PRE-CREATION 
>   core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 3b475c6 
>   core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java e6e4760 
>   execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 74e41df 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 73d8387 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java ad749ed 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 478afe2 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 2da084f 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java d597bd8 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java 0eb9df4 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 7109ae5 
>   server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 462579c 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 80e65b8 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java cbd34f5 
>   spi/src/main/java/org/apache/sqoop/connector/spi/ConfigurableUpgrader.java PRE-CREATION 
>   spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java 879e428 
>   spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 849f091 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef 
> 
> Diff: https://reviews.apache.org/r/26419/diff/
> 
> 
> Testing
> -------
> 
> yes test pass
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Re: Review Request 26419: SQOOP-1566: Fix the upgrade logic for SQOOP-1498

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26419/
-----------------------------------------------------------

(Updated Oct. 9, 2014, 11:02 a.m.)


Review request for Sqoop.


Repository: sqoop-SQOOP-1367


Description
-------

Few more pending renames as per the agreement on Sqoop 1551 

- Mainly fix the upgrade logic for 1498 changes
- rename the repository upgrader to Configurable upgrader - agreed by Jarcec. 

- rename configuration utils to MRConfigurationUtils, so it is not be confused with the sqoop configuration/ configs
- rename mapreduce to MR ( if this is not acceptable, happy to change it back)


Diffs (updated)
-----

  common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 290e7fc 
  common/src/main/java/org/apache/sqoop/model/MConfigurable.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MConfigurableType.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MConnector.java 2f42191 
  common/src/main/java/org/apache/sqoop/model/MDriver.java 685439e 
  common/src/main/java/org/apache/sqoop/utils/ClassUtils.java 0be4d41 
  common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java eac789e 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 87ac2af 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java a069b3e 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java b17aa21 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 606b9fa 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorUpgrader.java PRE-CREATION 
  core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb1 
  core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 54bdd13 
  core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 5226926 
  core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb 
  core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 847b73d 
  core/src/main/java/org/apache/sqoop/driver/DriverUpgrader.java PRE-CREATION 
  core/src/main/java/org/apache/sqoop/driver/JobManager.java df2a5ab 
  core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3ade247 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 97de893 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d 
  core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java c2f8505 
  core/src/main/resources/driver-config.properties 78c3b38 
  core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java dc4e8c8 
  core/src/test/java/org/apache/sqoop/driver/TestDriverUpgrader.java PRE-CREATION 
  core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 3b475c6 
  core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java e6e4760 
  execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 74e41df 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 73d8387 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java ad749ed 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 478afe2 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 2da084f 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java d597bd8 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java 0eb9df4 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 7109ae5 
  server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 462579c 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 80e65b8 
  shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java cbd34f5 
  spi/src/main/java/org/apache/sqoop/connector/spi/ConfigurableUpgrader.java PRE-CREATION 
  spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java 879e428 
  spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 849f091 
  submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef 

Diff: https://reviews.apache.org/r/26419/diff/


Testing
-------

yes test pass


Thanks,

Veena Basavaraj


Re: Review Request 26419: SQOOP-1566: Fix the upgrade logic for SQOOP-1498

Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26419/#review55941
-----------------------------------------------------------


I can't seem to upgrade from a sqoop2 repo. to the from/to repo.

  2014-10-08 19:22:49,007 ERROR core.SqoopServer [org.apache.sqoop.core.SqoopServer.initialize(SqoopServer.java:56)] Server startup failure
org.apache.sqoop.common.SqoopException: DERBYREPO_0003:Unable to run specified query - RENAME COLUMN SQOOP.SQ_CONFIG.SQ_CFG_OPERATION TO SQ_CFG_DIRECTION
        at org.apache.sqoop.repository.derby.DerbyRepositoryHandler.runQuery(DerbyRepositoryHandler.java:2157)
        at org.apache.sqoop.repository.derby.DerbyRepositoryHandler.createOrUpgradeRepositorySchemaAndData(DerbyRepositoryHandler.java:405)
        at org.apache.sqoop.repository.JdbcRepository$1.doIt(JdbcRepository.java:131)
        at org.apache.sqoop.repository.JdbcRepository.doWithConnection(JdbcRepository.java:90)
        at org.apache.sqoop.repository.JdbcRepository.doWithConnection(JdbcRepository.java:61)
        at org.apache.sqoop.repository.JdbcRepository.createOrUpgradeRepositorySchemaAndData(JdbcRepository.java:127)
        at org.apache.sqoop.repository.RepositoryManager.initialize(RepositoryManager.java:122)
        at org.apache.sqoop.repository.RepositoryManager.initialize(RepositoryManager.java:75)
        at org.apache.sqoop.core.SqoopServer.initialize(SqoopServer.java:50)
        at org.apache.sqoop.server.ServerInitializer.contextInitialized(ServerInitializer.java:38)
        at org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4206)
        at org.apache.catalina.core.StandardContext.start(StandardContext.java:4705)
        at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:799)
        at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:779)
        at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:601)
        at org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:943)
        at org.apache.catalina.startup.HostConfig.deployWARs(HostConfig.java:778)
        at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:504)
        at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1317)
        at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:324)
        at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:142)
        at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1065)
        at org.apache.catalina.core.StandardHost.start(StandardHost.java:840)
        at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1057)
        at org.apache.catalina.core.StandardEngine.start(StandardEngine.java:463)
        at org.apache.catalina.core.StandardService.start(StandardService.java:525)
        at org.apache.catalina.core.StandardServer.start(StandardServer.java:754)
        at org.apache.catalina.startup.Catalina.start(Catalina.java:595)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:289)
        at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:414)
Caused by: org.apache.commons.dbcp.SQLNestedException: Borrow prepareStatement from pool failed
        at org.apache.commons.dbcp.PoolingConnection.prepareStatement(PoolingConnection.java:113)
        at org.apache.commons.dbcp.DelegatingConnection.prepareStatement(DelegatingConnection.java:281)
        at org.apache.commons.dbcp.PoolingDataSource$PoolGuardConnectionWrapper.prepareStatement(PoolingDataSource.java:313)
        at org.apache.sqoop.repository.derby.DerbyRepositoryHandler.runQuery(DerbyRepositoryHandler.java:2133)
        ... 33 more
Caused by: java.sql.SQLSyntaxErrorException: 'RENAME COLUMN' cannot be performed on 'SQOOP.SQ_CONFIG' because it does not exist.
        at org.apache.derby.impl.jdbc.SQLExceptionFactory40.getSQLException(Unknown Source)
        at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown Source)
        at org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unknown Source)
        at org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(Unknown Source)
        at org.apache.derby.impl.jdbc.EmbedConnection.handleException(Unknown Source)
        at org.apache.derby.impl.jdbc.ConnectionChild.handleException(Unknown Source)
        at org.apache.derby.impl.jdbc.EmbedPreparedStatement.<init>(Unknown Source)
        at org.apache.derby.impl.jdbc.EmbedPreparedStatement20.<init>(Unknown Source)
        at org.apache.derby.impl.jdbc.EmbedPreparedStatement30.<init>(Unknown Source)
        at org.apache.derby.impl.jdbc.EmbedPreparedStatement40.<init>(Unknown Source)
        at org.apache.derby.jdbc.Driver40.newEmbedPreparedStatement(Unknown Source)
        at org.apache.derby.impl.jdbc.EmbedConnection.prepareStatement(Unknown Source)
        at org.apache.derby.impl.jdbc.EmbedConnection.prepareStatement(Unknown Source)
        at org.apache.commons.dbcp.PoolingConnection.makeObject(PoolingConnection.java:285)
        at org.apache.commons.pool.impl.GenericKeyedObjectPool.borrowObject(GenericKeyedObjectPool.java:1179)
        at org.apache.commons.dbcp.PoolingConnection.prepareStatement(PoolingConnection.java:107)
        ... 36 more
Caused by: java.sql.SQLException: 'RENAME COLUMN' cannot be performed on 'SQOOP.SQ_CONFIG' because it does not exist.
        at org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown Source)
        at org.apache.derby.impl.jdbc.SQLExceptionFactory40.wrapArgsForTransportAcrossDRDA(Unknown Source)
        ... 52 more
Caused by: ERROR 42Y55: 'RENAME COLUMN' cannot be performed on 'SQOOP.SQ_CONFIG' because it does not exist.
        at org.apache.derby.iapi.error.StandardException.newException(Unknown Source)
        at org.apache.derby.impl.sql.compile.DDLStatementNode.justGetDescriptor(Unknown Source)
        t org.apache.derby.impl.sql.compile.DDLStatementNode.getTableDescriptor(Unknown Source)

- Abraham Elmahrek


On Oct. 8, 2014, 11:29 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26419/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 11:29 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-SQOOP-1367
> 
> 
> Description
> -------
> 
> Few more pending renames as per the agreement on Sqoop 1551 
> 
> - Mainly fix the upgrade logic for 1498 changes
> - rename the repository upgrader to Configurable upgrader - agreed by Jarcec. 
> 
> - rename configuration utils to MRConfigurationUtils, so it is not be confused with the sqoop configuration/ configs
> - rename mapreduce to MR ( if this is not acceptable, happy to change it back)
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 290e7fc 
>   common/src/main/java/org/apache/sqoop/model/MConfigurable.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MConfigurableType.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MConnector.java 2f42191 
>   common/src/main/java/org/apache/sqoop/model/MDriver.java 685439e 
>   common/src/main/java/org/apache/sqoop/utils/ClassUtils.java 0be4d41 
>   common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java eac789e 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 87ac2af 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java a069b3e 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java b17aa21 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 606b9fa 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb1 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 54bdd13 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 5226926 
>   core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb 
>   core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 847b73d 
>   core/src/main/java/org/apache/sqoop/driver/DriverUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java df2a5ab 
>   core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3ade247 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 97de893 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d 
>   core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java c2f8505 
>   core/src/main/resources/driver-config.properties 78c3b38 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java dc4e8c8 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverUpgrader.java PRE-CREATION 
>   core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 3b475c6 
>   core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java e6e4760 
>   execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 74e41df 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 73d8387 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java ad749ed 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 478afe2 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 2da084f 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java d597bd8 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java 0eb9df4 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 7109ae5 
>   server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 462579c 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 80e65b8 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java cbd34f5 
>   spi/src/main/java/org/apache/sqoop/connector/spi/ConfigurableUpgrader.java PRE-CREATION 
>   spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java 879e428 
>   spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 849f091 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef 
> 
> Diff: https://reviews.apache.org/r/26419/diff/
> 
> 
> Testing
> -------
> 
> yes test pass
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Re: Review Request 26419: SQOOP-1566: Fix the upgrade logic for SQOOP-1498

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26419/
-----------------------------------------------------------

(Updated Oct. 8, 2014, 4:29 p.m.)


Review request for Sqoop.


Changes
-------

fix the exception
Exception has occurred during processing command 
Exception: java.util.MissingResourceException Message: Can't find resource for bundle org.apache.sqoop.utils.MapResourceBundle, key throttlingConfig.label
Stack trace:
at java.util.ResourceBundle (ResourceBundle.java:395) 
at java.util.ResourceBundle (ResourceBundle.java:355) 
at org.apache.sqoop.shell.utils.ConfigFiller (ConfigFiller.java:434)
at org.apache.sqoop.shell.utils.ConfigFiller (ConfigFiller.java:422)
at org.apache.sqoop.shell.utils.ConfigFiller (ConfigFiller.java:412)
at org.apache.sqoop.shell.utils.ConfigFiller (ConfigFiller.java:375)
at 


Repository: sqoop-SQOOP-1367


Description
-------

Few more pending renames as per the agreement on Sqoop 1551 

- Mainly fix the upgrade logic for 1498 changes
- rename the repository upgrader to Configurable upgrader - agreed by Jarcec. 

- rename configuration utils to MRConfigurationUtils, so it is not be confused with the sqoop configuration/ configs
- rename mapreduce to MR ( if this is not acceptable, happy to change it back)


Diffs (updated)
-----

  common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 290e7fc 
  common/src/main/java/org/apache/sqoop/model/MConfigurable.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MConfigurableType.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MConnector.java 2f42191 
  common/src/main/java/org/apache/sqoop/model/MDriver.java 685439e 
  common/src/main/java/org/apache/sqoop/utils/ClassUtils.java 0be4d41 
  common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java eac789e 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 87ac2af 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java a069b3e 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java b17aa21 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 606b9fa 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorUpgrader.java PRE-CREATION 
  core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb1 
  core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 54bdd13 
  core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 5226926 
  core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb 
  core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 847b73d 
  core/src/main/java/org/apache/sqoop/driver/DriverUpgrader.java PRE-CREATION 
  core/src/main/java/org/apache/sqoop/driver/JobManager.java df2a5ab 
  core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3ade247 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 97de893 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d 
  core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java c2f8505 
  core/src/main/resources/driver-config.properties 78c3b38 
  core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java dc4e8c8 
  core/src/test/java/org/apache/sqoop/driver/TestDriverUpgrader.java PRE-CREATION 
  core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 3b475c6 
  core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java e6e4760 
  execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 74e41df 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 73d8387 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java ad749ed 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 478afe2 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 2da084f 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java d597bd8 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java 0eb9df4 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 7109ae5 
  server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 462579c 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 80e65b8 
  shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java cbd34f5 
  spi/src/main/java/org/apache/sqoop/connector/spi/ConfigurableUpgrader.java PRE-CREATION 
  spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java 879e428 
  spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 849f091 
  submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef 

Diff: https://reviews.apache.org/r/26419/diff/


Testing
-------

yes test pass


Thanks,

Veena Basavaraj


Re: Review Request 26419: SQOOP-1566: Fix the upgrade logic for SQOOP-1498

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26419/
-----------------------------------------------------------

(Updated Oct. 8, 2014, 3:58 p.m.)


Review request for Sqoop.


Repository: sqoop-SQOOP-1367


Description
-------

Few more pending renames as per the agreement on Sqoop 1551 

- Mainly fix the upgrade logic for 1498 changes
- rename the repository upgrader to Configurable upgrader - agreed by Jarcec. 

- rename configuration utils to MRConfigurationUtils, so it is not be confused with the sqoop configuration/ configs
- rename mapreduce to MR ( if this is not acceptable, happy to change it back)


Diffs (updated)
-----

  common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 290e7fc 
  common/src/main/java/org/apache/sqoop/model/MConfigurable.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MConfigurableType.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MConnector.java 2f42191 
  common/src/main/java/org/apache/sqoop/model/MDriver.java 685439e 
  common/src/main/java/org/apache/sqoop/utils/ClassUtils.java 0be4d41 
  common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java eac789e 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 87ac2af 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java a069b3e 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java b17aa21 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 606b9fa 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorUpgrader.java PRE-CREATION 
  core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb1 
  core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 54bdd13 
  core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 5226926 
  core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb 
  core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 847b73d 
  core/src/main/java/org/apache/sqoop/driver/DriverUpgrader.java PRE-CREATION 
  core/src/main/java/org/apache/sqoop/driver/JobManager.java df2a5ab 
  core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3ade247 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 97de893 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d 
  core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java c2f8505 
  core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java dc4e8c8 
  core/src/test/java/org/apache/sqoop/driver/TestDriverUpgrader.java PRE-CREATION 
  core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 3b475c6 
  core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java e6e4760 
  execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 74e41df 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 73d8387 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java ad749ed 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 478afe2 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 2da084f 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java d597bd8 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java 0eb9df4 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 7109ae5 
  server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 462579c 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 80e65b8 
  shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java cbd34f5 
  spi/src/main/java/org/apache/sqoop/connector/spi/ConfigurableUpgrader.java PRE-CREATION 
  spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java 879e428 
  spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 849f091 
  submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef 

Diff: https://reviews.apache.org/r/26419/diff/


Testing
-------

yes test pass


Thanks,

Veena Basavaraj


Re: Review Request 26419: SQOOP-1566: Fix the upgrade logic for SQOOP-1498

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26419/
-----------------------------------------------------------

(Updated Oct. 8, 2014, 3:47 p.m.)


Review request for Sqoop.


Changes
-------

address comments


Repository: sqoop-SQOOP-1367


Description
-------

Few more pending renames as per the agreement on Sqoop 1551 

- Mainly fix the upgrade logic for 1498 changes
- rename the repository upgrader to Configurable upgrader - agreed by Jarcec. 

- rename configuration utils to MRConfigurationUtils, so it is not be confused with the sqoop configuration/ configs
- rename mapreduce to MR ( if this is not acceptable, happy to change it back)


Diffs (updated)
-----

  common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 290e7fc 
  common/src/main/java/org/apache/sqoop/model/MConfigurable.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MConfigurableType.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MConnector.java 2f42191 
  common/src/main/java/org/apache/sqoop/model/MDriver.java 685439e 
  common/src/main/java/org/apache/sqoop/utils/ClassUtils.java 0be4d41 
  common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java eac789e 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 87ac2af 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java a069b3e 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java b17aa21 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 606b9fa 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorUpgrader.java PRE-CREATION 
  core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb1 
  core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 54bdd13 
  core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 5226926 
  core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb 
  core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 847b73d 
  core/src/main/java/org/apache/sqoop/driver/DriverUpgrader.java PRE-CREATION 
  core/src/main/java/org/apache/sqoop/driver/JobManager.java df2a5ab 
  core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3ade247 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 97de893 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d 
  core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java c2f8505 
  core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java dc4e8c8 
  core/src/test/java/org/apache/sqoop/driver/TestDriverUpgrader.java PRE-CREATION 
  core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 3b475c6 
  core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java e6e4760 
  execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 74e41df 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 73d8387 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java ad749ed 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 478afe2 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 2da084f 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java d597bd8 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java 0eb9df4 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 7109ae5 
  server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 462579c 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 80e65b8 
  shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java cbd34f5 
  spi/src/main/java/org/apache/sqoop/connector/spi/ConfigurableUpgrader.java PRE-CREATION 
  spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java 879e428 
  spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 849f091 
  submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef 

Diff: https://reviews.apache.org/r/26419/diff/


Testing
-------

yes test pass


Thanks,

Veena Basavaraj


Re: Review Request 26419: SQOOP-1566: Fix the upgrade logic for SQOOP-1498

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26419/
-----------------------------------------------------------

(Updated Oct. 8, 2014, 12:50 p.m.)


Review request for Sqoop.


Changes
-------

cleaned up a few warnings 
adding a mconfigurable to be more explicit of what the configurableUpgrader should represent


Repository: sqoop-SQOOP-1367


Description
-------

Few more pending renames as per the agreement on Sqoop 1551 

- Mainly fix the upgrade logic for 1498 changes
- rename the repository upgrader to Configurable upgrader - agreed by Jarcec. 

- rename configuration utils to MRConfigurationUtils, so it is not be confused with the sqoop configuration/ configs
- rename mapreduce to MR ( if this is not acceptable, happy to change it back)


Diffs (updated)
-----

  common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 290e7fc 
  common/src/main/java/org/apache/sqoop/model/MConfigurable.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MConfigurableType.java PRE-CREATION 
  common/src/main/java/org/apache/sqoop/model/MConnector.java 2f42191 
  common/src/main/java/org/apache/sqoop/model/MDriver.java 685439e 
  common/src/main/java/org/apache/sqoop/utils/ClassUtils.java 0be4d41 
  common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java eac789e 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 87ac2af 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java a069b3e 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java b17aa21 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 606b9fa 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorUpgrader.java PRE-CREATION 
  core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb1 
  core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 54bdd13 
  core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 5226926 
  core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb 
  core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 847b73d 
  core/src/main/java/org/apache/sqoop/driver/DriverUpgrader.java PRE-CREATION 
  core/src/main/java/org/apache/sqoop/driver/JobManager.java df2a5ab 
  core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3ade247 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 97de893 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d 
  core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java c2f8505 
  core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java dc4e8c8 
  core/src/test/java/org/apache/sqoop/driver/TestDriverUpgrader.java PRE-CREATION 
  core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 3b475c6 
  core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java e6e4760 
  execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 74e41df 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 73d8387 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java ad749ed 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 478afe2 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 2da084f 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java d597bd8 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java 0eb9df4 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 7109ae5 
  server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 462579c 
  server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 80e65b8 
  shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java cbd34f5 
  spi/src/main/java/org/apache/sqoop/connector/spi/ConfigurableUpgrader.java PRE-CREATION 
  spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java 879e428 
  spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 849f091 
  submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef 

Diff: https://reviews.apache.org/r/26419/diff/


Testing
-------

yes test pass


Thanks,

Veena Basavaraj


Re: Review Request 26419: SQOOP-1566: Fix the upgrade logic for SQOOP-1498

Posted by Gwen Shapira <gs...@cloudera.com>.

> On Oct. 8, 2014, 5:46 p.m., Veena Basavaraj wrote:
> > core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java, line 136
> > <https://reviews.apache.org/r/26419/diff/3/?file=715511#file715511line136>
> >
> >     MConnector is config + the name associated with it. Hence he naming
> >     
> >     public final class MConnector extends MPersistableEntity implements MClonable {
> >     
> >       private final String uniqueName;
> >       private final String className;
> >       private final String version;
> >       private final MLinkConfig linkConfig;
> >       private final MFromConfig fromConfig;
> >       private final MToConfig toConfig;

I would expect getConnector to return a Connector, not an MConnector (i.e. just the config, not the connector object itself). Thats why I see this name as confusing. getConnectorConfig or getMConnector are both good alternatives IMO.


- Gwen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26419/#review55841
-----------------------------------------------------------


On Oct. 8, 2014, 4:21 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26419/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 4:21 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-SQOOP-1367
> 
> 
> Description
> -------
> 
> Few more pending renames as per the agreement on Sqoop 1551 
> 
> - Mainly fix the upgrade logic for 1498 changes
> - rename the repository upgrader to Configurable upgrader - agreed by Jarcec. 
> 
> - rename configuration utils to MRConfigurationUtils, so it is not be confused with the sqoop configuration/ configs
> - rename mapreduce to MR ( if this is not acceptable, happy to change it back)
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/model/MConfigurableType.java PRE-CREATION 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 87ac2af 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java a069b3e 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java b17aa21 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 606b9fa 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb1 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 54bdd13 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 5226926 
>   core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb 
>   core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 847b73d 
>   core/src/main/java/org/apache/sqoop/driver/DriverUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java df2a5ab 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3ade247 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 97de893 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d 
>   core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java c2f8505 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java dc4e8c8 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverUpgrader.java PRE-CREATION 
>   core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java e6e4760 
>   execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 74e41df 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 73d8387 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java ad749ed 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 478afe2 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 2da084f 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java d597bd8 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java 0eb9df4 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 462579c 
>   spi/src/main/java/org/apache/sqoop/connector/spi/ConfigurableUpgrader.java PRE-CREATION 
>   spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java 879e428 
>   spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 849f091 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef 
> 
> Diff: https://reviews.apache.org/r/26419/diff/
> 
> 
> Testing
> -------
> 
> yes test pass
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Re: Review Request 26419: SQOOP-1566: Fix the upgrade logic for SQOOP-1498

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26419/#review55841
-----------------------------------------------------------



core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java
<https://reviews.apache.org/r/26419/#comment96220>

    MConnector is config + the name associated with it. Hence he naming
    
    public final class MConnector extends MPersistableEntity implements MClonable {
    
      private final String uniqueName;
      private final String className;
      private final String version;
      private final MLinkConfig linkConfig;
      private final MFromConfig fromConfig;
      private final MToConfig toConfig;


- Veena Basavaraj


On Oct. 8, 2014, 9:21 a.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26419/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 9:21 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-SQOOP-1367
> 
> 
> Description
> -------
> 
> Few more pending renames as per the agreement on Sqoop 1551 
> 
> - Mainly fix the upgrade logic for 1498 changes
> - rename the repository upgrader to Configurable upgrader - agreed by Jarcec. 
> 
> - rename configuration utils to MRConfigurationUtils, so it is not be confused with the sqoop configuration/ configs
> - rename mapreduce to MR ( if this is not acceptable, happy to change it back)
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/model/MConfigurableType.java PRE-CREATION 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 87ac2af 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java a069b3e 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java b17aa21 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 606b9fa 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb1 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 54bdd13 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 5226926 
>   core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb 
>   core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 847b73d 
>   core/src/main/java/org/apache/sqoop/driver/DriverUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java df2a5ab 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3ade247 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 97de893 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d 
>   core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java c2f8505 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java dc4e8c8 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverUpgrader.java PRE-CREATION 
>   core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java e6e4760 
>   execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 74e41df 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 73d8387 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java ad749ed 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 478afe2 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 2da084f 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java d597bd8 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java 0eb9df4 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 462579c 
>   spi/src/main/java/org/apache/sqoop/connector/spi/ConfigurableUpgrader.java PRE-CREATION 
>   spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java 879e428 
>   spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 849f091 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef 
> 
> Diff: https://reviews.apache.org/r/26419/diff/
> 
> 
> Testing
> -------
> 
> yes test pass
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Re: Review Request 26419: SQOOP-1566: Fix the upgrade logic for SQOOP-1498

Posted by Veena Basavaraj <vb...@cloudera.com>.

> On Oct. 8, 2014, 10:31 a.m., Gwen Shapira wrote:
> > core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java, line 140
> > <https://reviews.apache.org/r/26419/diff/3/?file=715511#file715511line140>
> >
> >     I think the name should indicate that this is connector config, not a connector object.
> 
> Veena Basavaraj wrote:
>     its a configurable rather than config.
> 
> Gwen Shapira wrote:
>     Connector is a configurable, but MConnector contains configs - linkConfig, fromConfig, toConfig. Therefore what we are setting is basically a bunch of configs relavant to the connector.

Am I missing something here, the MConnector is a object that represents the connecto class, its name, its version and the config objects it provides. so it is not just the configs.


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26419/#review55826
-----------------------------------------------------------


On Oct. 8, 2014, 9:21 a.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26419/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 9:21 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-SQOOP-1367
> 
> 
> Description
> -------
> 
> Few more pending renames as per the agreement on Sqoop 1551 
> 
> - Mainly fix the upgrade logic for 1498 changes
> - rename the repository upgrader to Configurable upgrader - agreed by Jarcec. 
> 
> - rename configuration utils to MRConfigurationUtils, so it is not be confused with the sqoop configuration/ configs
> - rename mapreduce to MR ( if this is not acceptable, happy to change it back)
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/model/MConfigurableType.java PRE-CREATION 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 87ac2af 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java a069b3e 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java b17aa21 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 606b9fa 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb1 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 54bdd13 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 5226926 
>   core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb 
>   core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 847b73d 
>   core/src/main/java/org/apache/sqoop/driver/DriverUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java df2a5ab 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3ade247 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 97de893 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d 
>   core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java c2f8505 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java dc4e8c8 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverUpgrader.java PRE-CREATION 
>   core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java e6e4760 
>   execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 74e41df 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 73d8387 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java ad749ed 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 478afe2 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 2da084f 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java d597bd8 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java 0eb9df4 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 462579c 
>   spi/src/main/java/org/apache/sqoop/connector/spi/ConfigurableUpgrader.java PRE-CREATION 
>   spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java 879e428 
>   spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 849f091 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef 
> 
> Diff: https://reviews.apache.org/r/26419/diff/
> 
> 
> Testing
> -------
> 
> yes test pass
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Re: Review Request 26419: SQOOP-1566: Fix the upgrade logic for SQOOP-1498

Posted by Gwen Shapira <gs...@cloudera.com>.

> On Oct. 8, 2014, 5:31 p.m., Gwen Shapira wrote:
> > core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java, line 140
> > <https://reviews.apache.org/r/26419/diff/3/?file=715511#file715511line140>
> >
> >     I think the name should indicate that this is connector config, not a connector object.
> 
> Veena Basavaraj wrote:
>     its a configurable rather than config.

Connector is a configurable, but MConnector contains configs - linkConfig, fromConfig, toConfig. Therefore what we are setting is basically a bunch of configs relavant to the connector.


- Gwen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26419/#review55826
-----------------------------------------------------------


On Oct. 8, 2014, 4:21 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26419/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 4:21 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-SQOOP-1367
> 
> 
> Description
> -------
> 
> Few more pending renames as per the agreement on Sqoop 1551 
> 
> - Mainly fix the upgrade logic for 1498 changes
> - rename the repository upgrader to Configurable upgrader - agreed by Jarcec. 
> 
> - rename configuration utils to MRConfigurationUtils, so it is not be confused with the sqoop configuration/ configs
> - rename mapreduce to MR ( if this is not acceptable, happy to change it back)
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/model/MConfigurableType.java PRE-CREATION 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 87ac2af 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java a069b3e 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java b17aa21 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 606b9fa 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb1 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 54bdd13 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 5226926 
>   core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb 
>   core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 847b73d 
>   core/src/main/java/org/apache/sqoop/driver/DriverUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java df2a5ab 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3ade247 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 97de893 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d 
>   core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java c2f8505 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java dc4e8c8 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverUpgrader.java PRE-CREATION 
>   core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java e6e4760 
>   execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 74e41df 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 73d8387 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java ad749ed 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 478afe2 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 2da084f 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java d597bd8 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java 0eb9df4 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 462579c 
>   spi/src/main/java/org/apache/sqoop/connector/spi/ConfigurableUpgrader.java PRE-CREATION 
>   spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java 879e428 
>   spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 849f091 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef 
> 
> Diff: https://reviews.apache.org/r/26419/diff/
> 
> 
> Testing
> -------
> 
> yes test pass
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Re: Review Request 26419: SQOOP-1566: Fix the upgrade logic for SQOOP-1498

Posted by Veena Basavaraj <vb...@cloudera.com>.

> On Oct. 8, 2014, 10:31 a.m., Gwen Shapira wrote:
> > core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java, line 140
> > <https://reviews.apache.org/r/26419/diff/3/?file=715511#file715511line140>
> >
> >     I think the name should indicate that this is connector config, not a connector object.

its a configurable rather than config.


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26419/#review55826
-----------------------------------------------------------


On Oct. 8, 2014, 9:21 a.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26419/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 9:21 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-SQOOP-1367
> 
> 
> Description
> -------
> 
> Few more pending renames as per the agreement on Sqoop 1551 
> 
> - Mainly fix the upgrade logic for 1498 changes
> - rename the repository upgrader to Configurable upgrader - agreed by Jarcec. 
> 
> - rename configuration utils to MRConfigurationUtils, so it is not be confused with the sqoop configuration/ configs
> - rename mapreduce to MR ( if this is not acceptable, happy to change it back)
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/model/MConfigurableType.java PRE-CREATION 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 87ac2af 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java a069b3e 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java b17aa21 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 606b9fa 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb1 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 54bdd13 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 5226926 
>   core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb 
>   core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 847b73d 
>   core/src/main/java/org/apache/sqoop/driver/DriverUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java df2a5ab 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3ade247 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 97de893 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d 
>   core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java c2f8505 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java dc4e8c8 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverUpgrader.java PRE-CREATION 
>   core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java e6e4760 
>   execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 74e41df 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 73d8387 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java ad749ed 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 478afe2 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 2da084f 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java d597bd8 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java 0eb9df4 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 462579c 
>   spi/src/main/java/org/apache/sqoop/connector/spi/ConfigurableUpgrader.java PRE-CREATION 
>   spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java 879e428 
>   spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 849f091 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef 
> 
> Diff: https://reviews.apache.org/r/26419/diff/
> 
> 
> Testing
> -------
> 
> yes test pass
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Re: Review Request 26419: SQOOP-1566: Fix the upgrade logic for SQOOP-1498

Posted by Gwen Shapira <gs...@cloudera.com>.

> On Oct. 8, 2014, 5:31 p.m., Gwen Shapira wrote:
> > core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java, line 140
> > <https://reviews.apache.org/r/26419/diff/3/?file=715511#file715511line140>
> >
> >     I think the name should indicate that this is connector config, not a connector object.
> 
> Veena Basavaraj wrote:
>     its a configurable rather than config.
> 
> Gwen Shapira wrote:
>     Connector is a configurable, but MConnector contains configs - linkConfig, fromConfig, toConfig. Therefore what we are setting is basically a bunch of configs relavant to the connector.
> 
> Veena Basavaraj wrote:
>     Am I missing something here, the MConnector is a object that represents the connecto class, its name, its version and the config objects it provides. so it is not just the configs.

MConnector reperesents the connector metadata (confs, name and version as you noted). There is a different Connector class. If we leave the name getConnector, it sounds like we are returning a Connector object (not just the metadata object).

I got seriously confused connector object vs. connector metadata object when writing the dump/load utils. I think the new naming will increase confusion rather than decrease it. Therefore a name that will clarify that this method only returns the metadata will be appreciated.


- Gwen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26419/#review55826
-----------------------------------------------------------


On Oct. 8, 2014, 7:50 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26419/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 7:50 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-SQOOP-1367
> 
> 
> Description
> -------
> 
> Few more pending renames as per the agreement on Sqoop 1551 
> 
> - Mainly fix the upgrade logic for 1498 changes
> - rename the repository upgrader to Configurable upgrader - agreed by Jarcec. 
> 
> - rename configuration utils to MRConfigurationUtils, so it is not be confused with the sqoop configuration/ configs
> - rename mapreduce to MR ( if this is not acceptable, happy to change it back)
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 290e7fc 
>   common/src/main/java/org/apache/sqoop/model/MConfigurable.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MConfigurableType.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MConnector.java 2f42191 
>   common/src/main/java/org/apache/sqoop/model/MDriver.java 685439e 
>   common/src/main/java/org/apache/sqoop/utils/ClassUtils.java 0be4d41 
>   common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java eac789e 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 87ac2af 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java a069b3e 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java b17aa21 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 606b9fa 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb1 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 54bdd13 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 5226926 
>   core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb 
>   core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 847b73d 
>   core/src/main/java/org/apache/sqoop/driver/DriverUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java df2a5ab 
>   core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3ade247 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 97de893 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d 
>   core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java c2f8505 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java dc4e8c8 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverUpgrader.java PRE-CREATION 
>   core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 3b475c6 
>   core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java e6e4760 
>   execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 74e41df 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 73d8387 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java ad749ed 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 478afe2 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 2da084f 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java d597bd8 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java 0eb9df4 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 7109ae5 
>   server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 462579c 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 80e65b8 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java cbd34f5 
>   spi/src/main/java/org/apache/sqoop/connector/spi/ConfigurableUpgrader.java PRE-CREATION 
>   spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java 879e428 
>   spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 849f091 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef 
> 
> Diff: https://reviews.apache.org/r/26419/diff/
> 
> 
> Testing
> -------
> 
> yes test pass
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Re: Review Request 26419: SQOOP-1566: Fix the upgrade logic for SQOOP-1498

Posted by Gwen Shapira <gs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26419/#review55826
-----------------------------------------------------------


LGTM! http://i.imgur.com/paAYX8J.jpg

Just one small comment.


core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java
<https://reviews.apache.org/r/26419/#comment96207>

    This function returns connector configuration, not an actual connector object. I think the new name is misleading.



core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java
<https://reviews.apache.org/r/26419/#comment96209>

    I think the name should indicate that this is connector config, not a connector object.


- Gwen Shapira


On Oct. 8, 2014, 4:21 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26419/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 4:21 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-SQOOP-1367
> 
> 
> Description
> -------
> 
> Few more pending renames as per the agreement on Sqoop 1551 
> 
> - Mainly fix the upgrade logic for 1498 changes
> - rename the repository upgrader to Configurable upgrader - agreed by Jarcec. 
> 
> - rename configuration utils to MRConfigurationUtils, so it is not be confused with the sqoop configuration/ configs
> - rename mapreduce to MR ( if this is not acceptable, happy to change it back)
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/model/MConfigurableType.java PRE-CREATION 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 87ac2af 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java a069b3e 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java b17aa21 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 606b9fa 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb1 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 54bdd13 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 5226926 
>   core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb 
>   core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 847b73d 
>   core/src/main/java/org/apache/sqoop/driver/DriverUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java df2a5ab 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3ade247 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 97de893 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d 
>   core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java c2f8505 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java dc4e8c8 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverUpgrader.java PRE-CREATION 
>   core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java e6e4760 
>   execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 74e41df 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 73d8387 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java ad749ed 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 478afe2 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 2da084f 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java d597bd8 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java 0eb9df4 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 462579c 
>   spi/src/main/java/org/apache/sqoop/connector/spi/ConfigurableUpgrader.java PRE-CREATION 
>   spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java 879e428 
>   spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 849f091 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef 
> 
> Diff: https://reviews.apache.org/r/26419/diff/
> 
> 
> Testing
> -------
> 
> yes test pass
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Re: Review Request 26419: SQOOP-1566: Fix the upgrade logic for SQOOP-1498

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26419/
-----------------------------------------------------------

(Updated Oct. 8, 2014, 9:21 a.m.)


Review request for Sqoop.


Repository: sqoop-SQOOP-1367


Description
-------

Few more pending renames as per the agreement on Sqoop 1551 

- Mainly fix the upgrade logic for 1498 changes
- rename the repository upgrader to Configurable upgrader - agreed by Jarcec. 

- rename configuration utils to MRConfigurationUtils, so it is not be confused with the sqoop configuration/ configs
- rename mapreduce to MR ( if this is not acceptable, happy to change it back)


Diffs (updated)
-----

  common/src/main/java/org/apache/sqoop/model/MConfigurableType.java PRE-CREATION 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 87ac2af 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java a069b3e 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java b17aa21 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 606b9fa 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorUpgrader.java PRE-CREATION 
  core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb1 
  core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 54bdd13 
  core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 5226926 
  core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb 
  core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 847b73d 
  core/src/main/java/org/apache/sqoop/driver/DriverUpgrader.java PRE-CREATION 
  core/src/main/java/org/apache/sqoop/driver/JobManager.java df2a5ab 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3ade247 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 97de893 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d 
  core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java c2f8505 
  core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java dc4e8c8 
  core/src/test/java/org/apache/sqoop/driver/TestDriverUpgrader.java PRE-CREATION 
  core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java e6e4760 
  execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 74e41df 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 73d8387 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java ad749ed 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 478afe2 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 2da084f 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java d597bd8 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java 0eb9df4 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java PRE-CREATION 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 462579c 
  spi/src/main/java/org/apache/sqoop/connector/spi/ConfigurableUpgrader.java PRE-CREATION 
  spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java 879e428 
  spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 849f091 
  submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef 

Diff: https://reviews.apache.org/r/26419/diff/


Testing
-------

yes test pass


Thanks,

Veena Basavaraj


Re: Review Request 26419: SQOOP-1566: Fix the upgrade logic for SQOOP-1498

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26419/
-----------------------------------------------------------

(Updated Oct. 8, 2014, 8:58 a.m.)


Review request for Sqoop.


Summary (updated)
-----------------

SQOOP-1566: Fix the upgrade logic for SQOOP-1498


Repository: sqoop-SQOOP-1367


Description (updated)
-------

Few more pending renames as per the agreement on Sqoop 1551 

- Mainly fix the upgrade logic for 1498 changes
- rename the repository upgrader to Configurable upgrader - agreed by Jarcec. 

- rename configuration utils to MRConfigurationUtils, so it is not be confused with the sqoop configuration/ configs
- rename mapreduce to MR ( if this is not acceptable, happy to change it back)


Diffs (updated)
-----

  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 87ac2af 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java a069b3e 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcUpgrader.java PRE-CREATION 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java b17aa21 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 606b9fa 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorUpgrader.java PRE-CREATION 
  core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb1 
  core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 54bdd13 
  core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 5226926 
  core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb 
  core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 847b73d 
  core/src/main/java/org/apache/sqoop/driver/DriverUpgrader.java PRE-CREATION 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3ade247 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 97de893 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d 
  core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java c2f8505 
  core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java dc4e8c8 
  core/src/test/java/org/apache/sqoop/driver/TestDriverUpgrader.java PRE-CREATION 
  core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java e6e4760 
  execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 74e41df 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 39702ca 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java fc3ec18 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 951d9b4 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java bf72626 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java d597bd8 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java 1292168 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java PRE-CREATION 
  spi/src/main/java/org/apache/sqoop/connector/spi/ConfigurableUpgrader.java PRE-CREATION 
  spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java 879e428 
  spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 849f091 
  submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef 

Diff: https://reviews.apache.org/r/26419/diff/


Testing
-------

yes test pass


Thanks,

Veena Basavaraj


Re: Review Request 26419: SQOOP-1551: Repository Upgrader api rename

Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26419/
-----------------------------------------------------------

(Updated Oct. 7, 2014, 11:01 a.m.)


Review request for Sqoop.


Repository: sqoop-SQOOP-1367


Description (updated)
-------

Few more pending renames as per the agreement on Sqoop 1551 

- rename the repository upgrader to config upgrader - agreed by Jarcec. 

- rename configuration utils to MRConfigurationUtils, so it is not be confused with the sqoop configuration/ configs
- rename mapreduce to MR ( if this is not acceptable, happy to change it back)


Diffs
-----

  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConfigUpgrader.java PRE-CREATION 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java 87ac2af 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java a069b3e 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java b17aa21 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 606b9fa 
  core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb1 
  core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 54bdd13 
  core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 5226926 
  core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb 
  core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 847b73d 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3ade247 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d 
  core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java c2f8505 
  core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java e6e4760 
  execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 47f8478 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 349bb60 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MRExecutionError.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MRJobConstants.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java 1dc12d1 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java 0fa07f7 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/MRConfigurationUtils.java PRE-CREATION 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopDestroyerExecutor.java 8d2a1da 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopFileOutputFormat.java ca77e16 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java 594b5e9 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java 1ebd3e4 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e3b68e2 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMatching.java 7f9a147 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java f5742a2 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java 501e32c 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestMRConfigurationUtils.java PRE-CREATION 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java 1f411d2 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java 74e41df 
  repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 39702ca 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java bf72626 
  repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java d597bd8 
  spi/src/main/java/org/apache/sqoop/connector/spi/ConfigUpgrader.java PRE-CREATION 
  spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java 879e428 
  spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 849f091 
  submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java 0c492ef 

Diff: https://reviews.apache.org/r/26419/diff/


Testing (updated)
-------

yes test pass


Thanks,

Veena Basavaraj