You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2020/05/29 19:33:02 UTC
[Impala-ASF-CR] Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16006
Change subject: Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"
......................................................................
Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"
The change in decimal-util.h introduced undefined behavior.
See IMPALA-9800.
This reverts commit 227da84c3757eb857008e7b82aad622ed959eb84.
Change-Id: Id2b2e43c478a220ff545fdbca712e47905c8d22b
---
M be/src/exprs/slot-ref.cc
M be/src/util/decimal-util.h
M be/src/util/dict-encoding.h
3 files changed, 4 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/16006/1
--
To view, visit http://gerrit.cloudera.org:8080/16006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2b2e43c478a220ff545fdbca712e47905c8d22b
Gerrit-Change-Number: 16006
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16006 )
Change subject: Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"
......................................................................
Patch Set 1: Code-Review+2
Clean revert of my own change, +2ing
--
To view, visit http://gerrit.cloudera.org:8080/16006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2b2e43c478a220ff545fdbca712e47905c8d22b
Gerrit-Change-Number: 16006
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 May 2020 19:41:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16006 )
Change subject: Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2b2e43c478a220ff545fdbca712e47905c8d22b
Gerrit-Change-Number: 16006
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 May 2020 20:03:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16006 )
Change subject: Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"
......................................................................
Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"
The change in decimal-util.h introduced undefined behavior.
See IMPALA-9800.
This reverts commit 227da84c3757eb857008e7b82aad622ed959eb84.
Change-Id: Id2b2e43c478a220ff545fdbca712e47905c8d22b
Reviewed-on: http://gerrit.cloudera.org:8080/16006
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exprs/slot-ref.cc
M be/src/util/decimal-util.h
M be/src/util/dict-encoding.h
3 files changed, 4 insertions(+), 9 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2b2e43c478a220ff545fdbca712e47905c8d22b
Gerrit-Change-Number: 16006
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16006 )
Change subject: Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6167/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2b2e43c478a220ff545fdbca712e47905c8d22b
Gerrit-Change-Number: 16006
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 May 2020 20:17:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16006 )
Change subject: Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5909/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2b2e43c478a220ff545fdbca712e47905c8d22b
Gerrit-Change-Number: 16006
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 May 2020 19:40:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16006 )
Change subject: Revert "IMPALA-9781: Fix GCC 7 unaligned 128-bit loads / stores"
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16006
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2b2e43c478a220ff545fdbca712e47905c8d22b
Gerrit-Change-Number: 16006
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 30 May 2020 00:56:16 +0000
Gerrit-HasComments: No