You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Nicolas Malin <ni...@nereide.fr> on 2017/12/13 12:46:05 UTC
Re: svn commit: r1818005 [1/3] - in /ofbiz:
ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/
ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/payment/
ofbiz-framework/tr...
Le 13/12/2017 à 13:43, jleroux@apache.org a écrit :
> @@ -2157,7 +2157,7 @@ public class InvoiceServices {
> return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResults));
> }
> if (Debug.verboseOn()) {
> - Debug.logVerbose("Creating Invoice Item with amount " + returnPrice + " and quantity " + quantity
> + if (Debug.verboseOn()) Debug.logVerbose("Creating Invoice Item with amount " + returnPrice + " and quantity " + quantity
> + " for shipment [" + item.getString("shipmentId") + ":" + item.getString("shipmentItemSeqId") + "]", module);
> }
Jacques, maybe you failed your replaceAll because you have a double
check sometime ^^
Nicolas
Re: svn commit: r1818005 [1/3] - in /ofbiz: ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbi
z/accounting/invoice/ ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbi
z/accounting/payment/ ofbiz-framework/tr...
Posted by Taher Alkhateeb <sl...@gmail.com>.
There is a reason why we had this "mass-update" topic many times in
multiple threads. Seeking out patterns of code all over the code base might
be dangerous. And that is why I always recommend refactoring by focusing
very intensely on a specific piece of code with very careful attention to
the context surrounding that code.
My recommendation makes coding slower, but it makes things cleaner and
safer.
On Dec 13, 2017 4:02 PM, "Jacques Le Roux" <ja...@les7arts.com>
wrote:
> Thanks Nicolas,
>
> My fast review was not enough, I'll fix that :)
>
> Jacques
>
>
> Le 13/12/2017 à 13:46, Nicolas Malin a écrit :
>
>>
>>
>> Le 13/12/2017 à 13:43, jleroux@apache.org a écrit :
>>
>>> @@ -2157,7 +2157,7 @@ public class InvoiceServices {
>>> return ServiceUtil.returnError(Servic
>>> eUtil.getErrorMessage(serviceResults));
>>> }
>>> if (Debug.verboseOn()) {
>>> - Debug.logVerbose("Creating Invoice Item with amount
>>> " + returnPrice + " and quantity " + quantity
>>> + if (Debug.verboseOn()) Debug.logVerbose("Creating
>>> Invoice Item with amount " + returnPrice + " and quantity " + quantity
>>> + " for shipment [" +
>>> item.getString("shipmentId") + ":" + item.getString("shipmentItemSeqId")
>>> + "]", module);
>>> }
>>>
>> Jacques, maybe you failed your replaceAll because you have a double check
>> sometime ^^
>>
>> Nicolas
>>
>>
>
Re: svn commit: r1818005 [1/3] - in /ofbiz:
ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbi
z/accounting/invoice/
ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbi
z/accounting/payment/ ofbiz-framework/tr...
Posted by Jacques Le Roux <ja...@les7arts.com>.
Thanks Nicolas,
My fast review was not enough, I'll fix that :)
Jacques
Le 13/12/2017 à 13:46, Nicolas Malin a écrit :
>
>
> Le 13/12/2017 à 13:43, jleroux@apache.org a écrit :
>> @@ -2157,7 +2157,7 @@ public class InvoiceServices {
>> return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResults));
>> }
>> if (Debug.verboseOn()) {
>> - Debug.logVerbose("Creating Invoice Item with amount " + returnPrice + " and quantity " + quantity
>> + if (Debug.verboseOn()) Debug.logVerbose("Creating Invoice Item with amount " + returnPrice + " and quantity " + quantity
>> + " for shipment [" + item.getString("shipmentId") + ":" + item.getString("shipmentItemSeqId") + "]", module);
>> }
> Jacques, maybe you failed your replaceAll because you have a double check sometime ^^
>
> Nicolas
>