You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/24 16:34:05 UTC

[GitHub] [incubator-superset] willbarrett commented on a change in pull request #10128: fix: [search query view] edit link is broken

willbarrett commented on a change in pull request #10128:
URL: https://github.com/apache/incubator-superset/pull/10128#discussion_r445023599



##########
File path: superset/app.py
##########
@@ -241,14 +241,6 @@ def init_views(self) -> None:
             category_label=__("Manage"),
             category_icon="",
         )
-        appbuilder.add_view(

Review comment:
       This changes a public API - are we sure this won't break anything? Should it go through deprecation before being removed? Could this be done as a separate PR from the bugfix?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org