[jira] [Commented] (DRILL-4295) Obsolete protobuf generated files under protocol/

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-4295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134601#comment-15134601 ] 

ASF GitHub Bot commented on DRILL-4295:
---------------------------------------

Github user jaltekruse commented on the pull request:

    https://github.com/apache/drill/pull/333#issuecomment-180477807
  
    +1 on the clean change and removal of unnecessary files.
    
    If we want to try to clean up the build process to not check in the generated files, I assume that will be done in a follow up PR.
    For now it doesn't sound like it's worth the hassle though.


> Obsolete protobuf generated files under protocol/
> -------------------------------------------------
>
>                 Key: DRILL-4295
>                 URL: https://issues.apache.org/jira/browse/DRILL-4295
>             Project: Apache Drill
>          Issue Type: Task
>          Components: Tools, Build & Test
>            Reporter: Laurent Goujon
>            Assignee: Laurent Goujon
>            Priority: Trivial
>
> The following two files don't have a protobuf definition anymore, and are not generated when running {{mvn process-sources -P proto-compile}} under {{protocol/}}:
> {noformat}
> src/main/java/org/apache/drill/exec/proto/beans/RpcFailure.java
> src/main/java/org/apache/drill/exec/proto/beans/ViewPointer.java
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)