You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2024/04/22 22:59:57 UTC

[Impala-ASF-CR] IMPALA-12777: Fix tpcds/tpcds-q66.test

Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21344


Change subject: IMPALA-12777: Fix tpcds/tpcds-q66.test
......................................................................

IMPALA-12777: Fix tpcds/tpcds-q66.test

PlannerTest/tpcds/tpcds-q66.test was mistakenly a copy of
PlannerTest/tpcds/tpcds-q61.test with different predicate values. This
patch replace the wrong test file with correct TPC-DS Q66 query.

Testing:
- Pass FE test TpcdsPlannerTest#testQ66.

Change-Id: I5b886f5dc1da213d25f33bd7b01dacca53eaef1b
---
M testdata/workloads/functional-planner/queries/PlannerTest/tpcds/tpcds-q66.test
1 file changed, 962 insertions(+), 1,020 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/21344/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b886f5dc1da213d25f33bd7b01dacca53eaef1b
Gerrit-Change-Number: 21344
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-12777: Fix tpcds/tpcds-q66.test

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21344 )

Change subject: IMPALA-12777: Fix tpcds/tpcds-q66.test
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review+2

Thank you, Wenzhe!


-- 
To view, visit http://gerrit.cloudera.org:8080/21344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b886f5dc1da213d25f33bd7b01dacca53eaef1b
Gerrit-Change-Number: 21344
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Apr 2024 23:41:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12777: Fix tpcds/tpcds-q66.test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21344 )

Change subject: IMPALA-12777: Fix tpcds/tpcds-q66.test
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10573/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/21344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b886f5dc1da213d25f33bd7b01dacca53eaef1b
Gerrit-Change-Number: 21344
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Apr 2024 23:40:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12777: Fix tpcds/tpcds-q66.test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21344 )

Change subject: IMPALA-12777: Fix tpcds/tpcds-q66.test
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/15988/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/21344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b886f5dc1da213d25f33bd7b01dacca53eaef1b
Gerrit-Change-Number: 21344
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Apr 2024 23:24:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12777: Fix tpcds/tpcds-q66.test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21344 )

Change subject: IMPALA-12777: Fix tpcds/tpcds-q66.test
......................................................................

IMPALA-12777: Fix tpcds/tpcds-q66.test

PlannerTest/tpcds/tpcds-q66.test was mistakenly a copy of
PlannerTest/tpcds/tpcds-q61.test with different predicate values. This
patch replace the wrong test file with correct TPC-DS Q66 query.

Testing:
- Pass FE test TpcdsPlannerTest#testQ66.

Change-Id: I5b886f5dc1da213d25f33bd7b01dacca53eaef1b
Reviewed-on: http://gerrit.cloudera.org:8080/21344
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/functional-planner/queries/PlannerTest/tpcds/tpcds-q66.test
1 file changed, 962 insertions(+), 1,020 deletions(-)

Approvals:
  Wenzhe Zhou: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/21344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b886f5dc1da213d25f33bd7b01dacca53eaef1b
Gerrit-Change-Number: 21344
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-12777: Fix tpcds/tpcds-q66.test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21344 )

Change subject: IMPALA-12777: Fix tpcds/tpcds-q66.test
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b886f5dc1da213d25f33bd7b01dacca53eaef1b
Gerrit-Change-Number: 21344
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Apr 2024 04:50:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12777: Fix tpcds/tpcds-q66.test

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21344 )

Change subject: IMPALA-12777: Fix tpcds/tpcds-q66.test
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b886f5dc1da213d25f33bd7b01dacca53eaef1b
Gerrit-Change-Number: 21344
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Apr 2024 23:37:09 +0000
Gerrit-HasComments: No