[GitHub] [kafka] ijuma commented on a diff in pull request #12781: KAFKA-14132; Replace EasyMock with Mockito in KafkaBasedLogTest

["ijuma (via GitHub)" <gi...@apache.org>]

ijuma commented on code in PR #12781:
URL: https://github.com/apache/kafka/pull/12781#discussion_r1084369349


##########
connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java:
##########
@@ -98,7 +98,7 @@
     private Optional<Producer<K, V>> producer;
     private TopicAdmin admin;
 
-    private Thread thread;

Review Comment:
   We have to mutate this variable from a test? Generally, it's better to expose a method for what you need to do versus exposing the mutable variable in this way.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org