You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Sebastian Annies (JIRA)" <ji...@codehaus.org> on 2008/03/17 12:07:49 UTC

[jira] Created: (SCM-370) generated client spec contains backslashes leading die problems on unix os

generated client spec contains backslashes leading die problems on unix os
--------------------------------------------------------------------------

                 Key: SCM-370
                 URL: http://jira.codehaus.org/browse/SCM-370
             Project: Maven SCM
          Issue Type: Improvement
          Components: maven-scm-provider-perforce
    Affects Versions: 1.0
         Environment: UNIX
            Reporter: Sebastian Annies


When a client is created it is named:

E.g. {{sannies-sojus-MavenSCM-\opt\continuum-1.1-beta-3-SNAPSHOT\apps\continuum\webapp\WEB-INF\working-directory\6}}

that is ok, but now comes the sync command and uses following commandline

{{/bin/bash c "p4 -d /opt/continuum-1.1-beta-3-SNAPSHOT/apps/continuum/webapp/WEB-INF/working-directory/1 -cbackground-sojus-MavenSCM\opt\continuum-1.1-beta-3-SNAPSHOT\apps\continuum\webapp\WEB-INF\working-directory\1 sync"}}

The Bash now removes the backslashes in the client name! The result is that the client is not existent and perforce returns with an error. 
This is related to [PLXUTILS-44] and [CONTINUUM-1402]

I propose to use the underscore character instead of the backslash. 


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SCM-370) generated client spec contains backslashes leading die problems on unix os

Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SCM-370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Venisse updated SCM-370:
---------------------------------

      Fix Version/s: 1.1
    Patch Submitted: [Yes]

> generated client spec contains backslashes leading die problems on unix os
> --------------------------------------------------------------------------
>
>                 Key: SCM-370
>                 URL: http://jira.codehaus.org/browse/SCM-370
>             Project: Maven SCM
>          Issue Type: Improvement
>          Components: maven-scm-provider-perforce
>    Affects Versions: 1.0
>         Environment: UNIX
>            Reporter: Sebastian Annies
>             Fix For: 1.1
>
>         Attachments: SCM-351_&_SCM-370.patch
>
>
> When a client is created it is named:
> E.g. {{sannies-sojus-MavenSCM-\opt\continuum-1.1-beta-3-SNAPSHOT\apps\continuum\webapp\WEB-INF\working-directory\6}}
> that is ok, but now comes the sync command and uses following commandline
> {{/bin/bash c "p4 -d /opt/continuum-1.1-beta-3-SNAPSHOT/apps/continuum/webapp/WEB-INF/working-directory/1 -cbackground-sojus-MavenSCM\opt\continuum-1.1-beta-3-SNAPSHOT\apps\continuum\webapp\WEB-INF\working-directory\1 sync"}}
> The Bash now removes the backslashes in the client name! The result is that the client is not existent and perforce returns with an error. 
> This is related to [PLXUTILS-44] and [CONTINUUM-1402]
> I propose to use the underscore character instead of the backslash. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Issue Comment Edited: (SCM-370) generated client spec contains backslashes leading die problems on unix os

Posted by "Sebastian Annies (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SCM-370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_127449 ] 

sannies edited comment on SCM-370 at 3/17/08 6:35 AM:
---------------------------------------------------------------

Patch: 

Modified generateDefaultClientspecName in PerforceScmProvider to generate client spec without spaces, ~ and backslashes. This will fix [SCM-370] and [SCM-351]

workdir is now translated to specname this way:  path = workDir.getCanonicalPath().replaceAll("[/ ~]", "-");

      was (Author: sannies):
    Modified generateDefaultClientspecName in PerforceScmProvider to generate client spec without spaces, ~ and backslashes. This will fix [SCM-370] and [SCM-351]
  
> generated client spec contains backslashes leading die problems on unix os
> --------------------------------------------------------------------------
>
>                 Key: SCM-370
>                 URL: http://jira.codehaus.org/browse/SCM-370
>             Project: Maven SCM
>          Issue Type: Improvement
>          Components: maven-scm-provider-perforce
>    Affects Versions: 1.0
>         Environment: UNIX
>            Reporter: Sebastian Annies
>         Attachments: SCM-351_&_SCM-370.patch
>
>
> When a client is created it is named:
> E.g. {{sannies-sojus-MavenSCM-\opt\continuum-1.1-beta-3-SNAPSHOT\apps\continuum\webapp\WEB-INF\working-directory\6}}
> that is ok, but now comes the sync command and uses following commandline
> {{/bin/bash c "p4 -d /opt/continuum-1.1-beta-3-SNAPSHOT/apps/continuum/webapp/WEB-INF/working-directory/1 -cbackground-sojus-MavenSCM\opt\continuum-1.1-beta-3-SNAPSHOT\apps\continuum\webapp\WEB-INF\working-directory\1 sync"}}
> The Bash now removes the backslashes in the client name! The result is that the client is not existent and perforce returns with an error. 
> This is related to [PLXUTILS-44] and [CONTINUUM-1402]
> I propose to use the underscore character instead of the backslash. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (SCM-370) generated client spec contains backslashes leading die problems on unix os

Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SCM-370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Venisse closed SCM-370.
--------------------------------

      Assignee: Emmanuel Venisse
    Resolution: Fixed

Applied. Thanks.

> generated client spec contains backslashes leading die problems on unix os
> --------------------------------------------------------------------------
>
>                 Key: SCM-370
>                 URL: http://jira.codehaus.org/browse/SCM-370
>             Project: Maven SCM
>          Issue Type: Improvement
>          Components: maven-scm-provider-perforce
>    Affects Versions: 1.0
>         Environment: UNIX
>            Reporter: Sebastian Annies
>            Assignee: Emmanuel Venisse
>             Fix For: 1.1
>
>         Attachments: SCM-351_&_SCM-370.patch
>
>
> When a client is created it is named:
> E.g. {{sannies-sojus-MavenSCM-\opt\continuum-1.1-beta-3-SNAPSHOT\apps\continuum\webapp\WEB-INF\working-directory\6}}
> that is ok, but now comes the sync command and uses following commandline
> {{/bin/bash c "p4 -d /opt/continuum-1.1-beta-3-SNAPSHOT/apps/continuum/webapp/WEB-INF/working-directory/1 -cbackground-sojus-MavenSCM\opt\continuum-1.1-beta-3-SNAPSHOT\apps\continuum\webapp\WEB-INF\working-directory\1 sync"}}
> The Bash now removes the backslashes in the client name! The result is that the client is not existent and perforce returns with an error. 
> This is related to [PLXUTILS-44] and [CONTINUUM-1402]
> I propose to use the underscore character instead of the backslash. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SCM-370) generated client spec contains backslashes leading die problems on unix os

Posted by "Sebastian Annies (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SCM-370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebastian Annies updated SCM-370:
---------------------------------

    Attachment: SCM-351_&_SCM-370.patch

Modified generateDefaultClientspecName in PerforceScmProvider to generate client spec without spaces, ~ and backslashes. This will fix [SCM-370] and [SCM-351]

> generated client spec contains backslashes leading die problems on unix os
> --------------------------------------------------------------------------
>
>                 Key: SCM-370
>                 URL: http://jira.codehaus.org/browse/SCM-370
>             Project: Maven SCM
>          Issue Type: Improvement
>          Components: maven-scm-provider-perforce
>    Affects Versions: 1.0
>         Environment: UNIX
>            Reporter: Sebastian Annies
>         Attachments: SCM-351_&_SCM-370.patch
>
>
> When a client is created it is named:
> E.g. {{sannies-sojus-MavenSCM-\opt\continuum-1.1-beta-3-SNAPSHOT\apps\continuum\webapp\WEB-INF\working-directory\6}}
> that is ok, but now comes the sync command and uses following commandline
> {{/bin/bash c "p4 -d /opt/continuum-1.1-beta-3-SNAPSHOT/apps/continuum/webapp/WEB-INF/working-directory/1 -cbackground-sojus-MavenSCM\opt\continuum-1.1-beta-3-SNAPSHOT\apps\continuum\webapp\WEB-INF\working-directory\1 sync"}}
> The Bash now removes the backslashes in the client name! The result is that the client is not existent and perforce returns with an error. 
> This is related to [PLXUTILS-44] and [CONTINUUM-1402]
> I propose to use the underscore character instead of the backslash. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira