You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Zack Shoylev <no...@github.com> on 2014/01/07 23:27:25 UTC
[jclouds-labs-openstack] Renames multiple domain classes for
consistency (#74)
You can merge this Pull Request by running:
git pull https://github.com/rackerlabs/jclouds-labs-openstack rename-consitency-autoscale
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-openstack/pull/74
-- Commit Summary --
* Renames multiple domain classes for consistency
-- File Changes --
M rackspace-autoscale/src/main/java/org/jclouds/rackspace/autoscale/v1/binders/BindScalingPolicyToJson.java (4)
M rackspace-autoscale/src/main/java/org/jclouds/rackspace/autoscale/v1/binders/BindWebhooksToJson.java (4)
M rackspace-autoscale/src/main/java/org/jclouds/rackspace/autoscale/v1/domain/Group.java (12)
M rackspace-autoscale/src/main/java/org/jclouds/rackspace/autoscale/v1/domain/ScalingPolicy.java (361)
A rackspace-autoscale/src/main/java/org/jclouds/rackspace/autoscale/v1/domain/ScalingPolicyCreate.java (396)
D rackspace-autoscale/src/main/java/org/jclouds/rackspace/autoscale/v1/domain/ScalingPolicyResponse.java (91)
M rackspace-autoscale/src/main/java/org/jclouds/rackspace/autoscale/v1/domain/Webhook.java (126)
A rackspace-autoscale/src/main/java/org/jclouds/rackspace/autoscale/v1/domain/WebhookCreate.java (134)
D rackspace-autoscale/src/main/java/org/jclouds/rackspace/autoscale/v1/domain/WebhookResponse.java (106)
M rackspace-autoscale/src/main/java/org/jclouds/rackspace/autoscale/v1/features/GroupApi.java (6)
M rackspace-autoscale/src/main/java/org/jclouds/rackspace/autoscale/v1/features/PolicyApi.java (22)
M rackspace-autoscale/src/main/java/org/jclouds/rackspace/autoscale/v1/features/WebhookApi.java (34)
M rackspace-autoscale/src/main/java/org/jclouds/rackspace/autoscale/v1/functions/ParseGroupResponse.java (12)
M rackspace-autoscale/src/main/java/org/jclouds/rackspace/autoscale/v1/functions/ParseScalingPoliciesResponse.java (16)
M rackspace-autoscale/src/main/java/org/jclouds/rackspace/autoscale/v1/functions/ParseScalingPolicyResponse.java (14)
M rackspace-autoscale/src/main/java/org/jclouds/rackspace/autoscale/v1/internal/ParseHelper.java (10)
M rackspace-autoscale/src/main/java/org/jclouds/rackspace/autoscale/v1/utils/AutoscaleUtils.java (4)
M rackspace-autoscale/src/test/java/org/jclouds/rackspace/autoscale/v1/features/GroupApiLiveTest.java (10)
M rackspace-autoscale/src/test/java/org/jclouds/rackspace/autoscale/v1/features/GroupApiMockTest.java (14)
M rackspace-autoscale/src/test/java/org/jclouds/rackspace/autoscale/v1/features/ScalingPolicyApiLiveTest.java (66)
M rackspace-autoscale/src/test/java/org/jclouds/rackspace/autoscale/v1/features/ScalingPolicyApiMockTest.java (44)
M rackspace-autoscale/src/test/java/org/jclouds/rackspace/autoscale/v1/features/WebhookApiLiveTest.java (42)
M rackspace-autoscale/src/test/java/org/jclouds/rackspace/autoscale/v1/features/WebhookApiMockTest.java (26)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-openstack/pull/74.patch
https://github.com/jclouds/jclouds-labs-openstack/pull/74.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/74
Re: [jclouds-labs-openstack] Renames multiple domain classes for
consistency (#74)
Posted by Andrew Phillips <no...@github.com>.
> * @author Zack Shoylev
> */
> -public class Webhook {
> - private final String name;
> - private final ImmutableMap<String, Object> metadata;
> -
> - @ConstructorProperties({ "name", "metadata" })
> - protected Webhook(String name, @Nullable Map<String, Object> metadata) {
> - this.name = checkNotNull(name, "name should not be null");
> - if (metadata == null) {
> - this.metadata = ImmutableMap.of();
> - } else {
> - this.metadata = ImmutableMap.copyOf(metadata);
> - }
> +public class Webhook extends CreateWebhook{
[minor] Space after "CreateWebhook"?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/74/files#r8710467
Re: [jclouds-labs-openstack] Renames multiple domain classes for
consistency (#74)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #144](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/144/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/74#issuecomment-31869834
Re: [jclouds-labs-openstack] Renames multiple domain classes for
consistency (#74)
Posted by Andrew Phillips <no...@github.com>.
> +
> +import com.google.common.base.Objects;
> +import com.google.common.base.Objects.ToStringHelper;
> +import com.google.common.base.Optional;
> +import com.google.common.collect.ImmutableMap;
> +import com.google.common.collect.Maps;
> +
> +/**
> + * Auto Scale ScalingPolicy. This class is used for requests.
> + *
> + * @see GroupApi#create(GroupConfiguration, LaunchConfiguration, java.util.List)
> + * @see Group#getScalingPolicies()
> + * @see ScalingPolicy
> + * @author Zack Shoylev
> + */
> +public class CreateScalingPolicy implements Comparable<CreateScalingPolicy>{
[minor] Space before `{`?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/74/files#r8710488
Re: [jclouds-labs-openstack] Renames multiple domain classes for
consistency (#74)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #145](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/145/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/74#issuecomment-31870225
Re: [jclouds-labs-openstack] Renames multiple domain classes for
consistency (#74)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #143](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/143/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/74#issuecomment-31787619
Re: [jclouds-labs-openstack] Renames multiple domain classes for
consistency (#74)
Posted by Andrew Phillips <no...@github.com>.
Just briefly scanned through this - I trust the refactoring tool ;-) A couple of minors, otherwise +1 from me if the PR builders look happy.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/74#issuecomment-31789493
Re: [jclouds-labs-openstack] Renames multiple domain classes for
consistency (#74)
Posted by Zack Shoylev <no...@github.com>.
This will have to be backported as well.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/74#issuecomment-31876481
Re: [jclouds-labs-openstack] Renames multiple domain classes for
consistency (#74)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #142](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/142/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/74#issuecomment-31787261