You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by remibergsma <gi...@git.apache.org> on 2015/10/23 11:13:29 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/970
CLOUDSTACK-8987 call s3xen/swiftxen plugins with their name
It's called `s3xen`, not `s3xenserver`. While investigating, I found the same issue for `swiftxen`.
Regresion from a8212d9ef458dd7ac64b021e6fa33fcf64b3cce0 where things were massively renamed, without proper verification.
Error seen:
```
2015-10-22 21:42:30,372 WARN [c.c.h.x.r.CitrixResourceBase] (DirectAgent-261:ctx-862ebceb) callHostPlugin failed for cmd: s3 with args maxErrorRetry: 10, secretKey: +XGy4yPPbAH9AijYxFTr1yVCCiVQuSfXWWj1Invs,
connectionTtl: null, iSCSIFlag: false, maxSingleUploadSizeInBytes: 5368709120, bucket: mccx-nl2, endPoint: s3.storage.acc.schubergphilis.com, filename: /var/run/sr-mount/9414f970-0afd-42db-972f-aa4743293430/2
cf0c24b-a596-4039-b50a-7ce87da4f273.vhd, accessKey: 16efbc4e870f24338141, socketTimeout: null, https: false, connectionTimeout: 300000, operation: put, key: snapshots/2/10/2cf0c24b-a596-4039-b50a-7ce87da4f273
.vhd, useTCPKeepAlive: null, due to Task failed! Task record: uuid: 4be8a515-1e2a-59de-6301-029fb0326651
nameLabel: Async.host.call_plugin
nameDescription:
allowedOperations: []
currentOperations: {}
created: Thu Oct 22 21:42:44 CEST 2015
finished: Thu Oct 22 21:42:44 CEST 2015
status: failure
residentOn: com.xensource.xenapi.Host@9c7aad90
progress: 1.0
type: <none/>
result:
errorInfo: [XENAPI_MISSING_PLUGIN, s3xenserver]
otherConfig: {}
subtaskOf: com.xensource.xenapi.Task@aaf13f6f
subtasks: []
Task failed! Task record: uuid: 4be8a515-1e2a-59de-6301-029fb0326651
nameLabel: Async.host.call_plugin
nameDescription:
allowedOperations: []
currentOperations: {}
created: Thu Oct 22 21:42:44 CEST 2015
finished: Thu Oct 22 21:42:44 CEST 2015
status: failure
residentOn: com.xensource.xenapi.Host@9c7aad90
progress: 1.0
type: <none/>
result:
errorInfo: [XENAPI_MISSING_PLUGIN, s3xenserver]
otherConfig: {}
subtaskOf: com.xensource.xenapi.Task@aaf13f6f
subtasks: []
```
Here we see the correct name:
```
scripts/vm/hypervisor/xenserver/s3xen:lib.setup_logging("/var/log/cloud/s3xen.log")
scripts/vm/hypervisor/xenserver/xenserver56/patch:s3xen=..,0755,/etc/xapi.d/plugins
scripts/vm/hypervisor/xenserver/xenserver56fp1/patch:s3xen=..,0755,/etc/xapi.d/plugins
scripts/vm/hypervisor/xenserver/xenserver60/patch:s3xen=..,0755,/etc/xapi.d/plugins
scripts/vm/hypervisor/xenserver/xenserver62/patch:s3xen=..,0755,/etc/xapi.d/plugins
scripts/vm/hypervisor/xenserver/xenserver65/patch:s3xen=..,0755,/etc/xapi.d/plugins
```
And:
```
scripts/vm/hypervisor/xenserver/xenserver56/patch:swiftxen=..,0755,/etc/xapi.d/plugins
scripts/vm/hypervisor/xenserver/xenserver56fp1/patch:swiftxen=..,0755,/etc/xapi.d/plugins
scripts/vm/hypervisor/xenserver/xenserver60/patch:swiftxen=..,0755,/etc/xapi.d/plugins
scripts/vm/hypervisor/xenserver/xenserver62/patch:swiftxen=..,0755,/etc/xapi.d/plugins
scripts/vm/hypervisor/xenserver/xenserver65/patch:swiftxen=..,0755,/etc/xapi.d/plugins
```
These plugins are pushed to the hypervisor.
Finally, s3xen logrotate wasn't setup properly as the logfile was missing `.log`.
Build succeeds:
```
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6:27.763s
[INFO] Finished at: Fri Oct 23 09:08:14 GMT 2015
[INFO] Final Memory: 92M/415M
[INFO] ------------------------------------------------------------------------
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building Apache CloudStack Developer Mode 4.6.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
```
After this, S3 works as expected on XenServer. Couldn't test swift but it's the same issue. Pinging @pdion891 to have look at swift.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/remibergsma/cloudstack s3xen-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/970.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #970
----
commit 4bf1b0166f338837fe272d7f3d4e406cbc35d9ee
Author: Remi Bergsma <gi...@remi.nl>
Date: 2015-10-23T07:39:38Z
CLOUDSTACK-8987 call s3xen plugin with its name
It's called s3xen, not s3xenserver
Regresion from a8212d9ef458dd7ac64b021e6fa33fcf64b3cce0
commit 2bf9f28816607758117ed9ed9ac4568596063ce3
Author: Remi Bergsma <gi...@remi.nl>
Date: 2015-10-23T08:02:42Z
CLOUDSTACK-8987 call swiftxen plugin with its name
It's called swiftxen, not swiftxenserver
Regresion from a8212d9ef458dd7ac64b021e6fa33fcf64b3cce0
commit 0e7abe45a0200abe8f606a5318e7de65b7a99e58
Author: Remi Bergsma <gi...@remi.nl>
Date: 2015-10-23T08:14:11Z
CLOUDSTACK-8987 s3xen uses s3xen.log
Apart from s3xen / s3xenserver it missed .log so it never worked.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-150663941
@borisroman Thanks, will ask @wilderrodrigues to run some integration tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-151083526
Code look good to me, no rocket science involved.
I will test it with XenServer 6.5, but I might need help figuring out how to get it covered.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...
Posted by xenserverarmy <gi...@git.apache.org>.
Github user xenserverarmy commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-151157372
@koushik-das One of the goals of a8212d9ef458dd7ac64b021e6fa33fcf64b3cce0 was to ensure that we have clarity in which hypervisor we support since Xen != XenServer. Reverting based on name IMO might be the simple solution, but could ultimately cause additional confusion as we don't currently have a pure Xen hypervisor implementation.
@wilderrodrigues @remibergsma, I didn't have s3 or swift storage to test with at the time of my changes. Would not the better solution be to rename the plugin s3xenserver and swiftxenserver?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-150526387
Verified this is also broken in `4.5` btw.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-151081518
@remibergsma @borisroman - I'm starting tests now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-151206019
New PR #982
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-151092704
Ping @runseb.
Is there a handle/userid for Tim Mackey?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-150664161
@remibergsma @wilderrodrigues Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-150662299
Based on code review, LGTM :+1:
I haven't spun up a cluster to run integration tests...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-151091001
Since a8212d9 changed names from "xen" to "xenserver", shouldn't the change be to rename the files s3xen to s3xenserver and swiftxen to swiftxenserver in scripts/vm/hypervisor/xenserver/?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-151182430
I will test if renaming the plugin works (and make sure there are no links to its name).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma closed the pull request at:
https://github.com/apache/cloudstack/pull/970
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8987 call s3xen/swiftxen plugi...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-151104185
Good point, @koushik-das.
@remibergsma: do you agree on that one as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---