You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "harikrishna-patnala (via GitHub)" <gi...@apache.org> on 2023/06/09 09:42:21 UTC
[GitHub] [cloudstack] harikrishna-patnala opened a new pull request, #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
harikrishna-patnala opened a new pull request, #7408:
URL: https://github.com/apache/cloudstack/pull/7408
### Description
This feature allows the storage migration for ScaleIO volumes between the ScaleIO storage pools of the same and different ScaleIO storage clusters. Previously this operation was blocked and now we are allowing it from API/UI.
The volume migration within the same storage cluster is performed using ScaleIO’s native V-Tree migration operation where the volume will be live migrated to another storage pool. The volume migration across the different storage cluster is performed using libvirt’s live blockcopy operation which will first copy the volume to the destination storage pool and after a successful copy, the source volume will be deleted. Upon any failures during the block copy, source volume will remain to continue and other blockcopy operations will be reverted.
A document PR is added here https://github.com/apache/cloudstack-documentation/pull/321
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [x] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1498766790
## [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7408?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7408](https://codecov.io/gh/apache/cloudstack/pull/7408?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0827495) into [main](https://codecov.io/gh/apache/cloudstack/commit/9abf5cf5df2d76837d12d8ca1d7f53e2485b705e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9abf5cf) will **decrease** coverage by `0.02%`.
> The diff coverage is `4.54%`.
```diff
@@ Coverage Diff @@
## main #7408 +/- ##
============================================
- Coverage 12.69% 12.68% -0.02%
- Complexity 8665 8668 +3
============================================
Files 2718 2718
Lines 256355 256600 +245
Branches 39965 39998 +33
============================================
+ Hits 32548 32552 +4
- Misses 219670 219908 +238
- Partials 4137 4140 +3
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7408?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...n/java/com/cloud/vm/VirtualMachineManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7408?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9jb20vY2xvdWQvdm0vVmlydHVhbE1hY2hpbmVNYW5hZ2VySW1wbC5qYXZh) | `6.20% <0.00%> (-0.04%)` | :arrow_down: |
| [...oud/hypervisor/kvm/resource/LibvirtConnection.java](https://codecov.io/gh/apache/cloudstack/pull/7408?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydENvbm5lY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ce/wrapper/LibvirtMigrateVolumeCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/7408?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2Uvd3JhcHBlci9MaWJ2aXJ0TWlncmF0ZVZvbHVtZUNvbW1hbmRXcmFwcGVyLmphdmE=) | `1.63% <0.00%> (-5.51%)` | :arrow_down: |
| [...age/datastore/client/ScaleIOGatewayClientImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7408?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9zdG9yYWdlL3ZvbHVtZS9zY2FsZWlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N0b3JhZ2UvZGF0YXN0b3JlL2NsaWVudC9TY2FsZUlPR2F0ZXdheUNsaWVudEltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...atastore/driver/ScaleIOPrimaryDataStoreDriver.java](https://codecov.io/gh/apache/cloudstack/pull/7408?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9zdG9yYWdlL3ZvbHVtZS9zY2FsZWlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N0b3JhZ2UvZGF0YXN0b3JlL2RyaXZlci9TY2FsZUlPUHJpbWFyeURhdGFTdG9yZURyaXZlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/java/com/cloud/storage/VolumeApiServiceImpl.java](https://codecov.io/gh/apache/cloudstack/pull/7408?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3N0b3JhZ2UvVm9sdW1lQXBpU2VydmljZUltcGwuamF2YQ==) | `15.09% <60.00%> (+0.40%)` | :arrow_up: |
... and [2 files with indirect coverage changes](https://codecov.io/gh/apache/cloudstack/pull/7408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1563510991
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1597897062
<b>[SF] Trillian test result (tid-6761)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 56589 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7408-t6761-vmware-67u3.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_deploy_vm_on_specific_host | `Error` | 18.73 | test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster | `Error` | 3605.89 | test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod | `Error` | 40.36 | test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 3604.32 | test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod | `Error` | 11.55 | test_vm_deployment_planner.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1579245118
<b>[SF] Trillian test result (tid-6690)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 36767 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7408-t6690-vmware-67u3.zip
Smoke tests completed. 86 look OK, 0 have errors, 24 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
all_test_safe_shutdown | `Skipped` | --- | test_safe_shutdown.py
all_test_metrics_api | `Skipped` | --- | test_metrics_api.py
all_test_outofbandmanagement | `Skipped` | --- | test_outofbandmanagement.py
all_test_outofbandmanagement_nestedplugin | `Skipped` | --- | test_outofbandmanagement_nestedplugin.py
all_test_routers_iptables_default_policy | `Skipped` | --- | test_routers_iptables_default_policy.py
all_test_secondary_storage | `Skipped` | --- | test_secondary_storage.py
all_test_service_offerings | `Skipped` | --- | test_service_offerings.py
all_test_storage_policy | `Skipped` | --- | test_storage_policy.py
all_test_templates | `Skipped` | --- | test_templates.py
all_test_update_security_group | `Skipped` | --- | test_update_security_group.py
all_test_usage_events | `Skipped` | --- | test_usage_events.py
all_test_vm_autoscaling | `Skipped` | --- | test_vm_autoscaling.py
all_test_vm_deployment_planner | `Skipped` | --- | test_vm_deployment_planner.py
all_test_vm_life_cycle | `Skipped` | --- | test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import | `Skipped` | --- | test_vm_lifecycle_unmanage_import.py
all_test_vm_snapshot_kvm | `Skipped` | --- | test_vm_snapshot_kvm.py
all_test_vm_snapshots | `Skipped` | --- | test_vm_snapshots.py
all_test_volumes | `Skipped` | --- | test_volumes.py
all_test_vpc_ipv6 | `Skipped` | --- | test_vpc_ipv6.py
all_test_vpc_redundant | `Skipped` | --- | test_vpc_redundant.py
all_test_vpc_router_nics | `Skipped` | --- | test_vpc_router_nics.py
all_test_vpc_vpn | `Skipped` | --- | test_vpc_vpn.py
all_test_host_maintenance | `Skipped` | --- | test_host_maintenance.py
all_test_hostha_kvm | `Skipped` | --- | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "borisstoyanov (via GitHub)" <gi...@apache.org>.
borisstoyanov commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1501600853
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1501601144
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1502432718
<b>Trillian test result (tid-6403)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46723 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7408-t6403-kvm-centos7.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1571316114
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1584193920
@harikrishna-patnala a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "borisstoyanov (via GitHub)" <gi...@apache.org>.
borisstoyanov commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1598322612
@blueorangutan test centos8
> [SF] Trillian test result (tid-6761) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 56589 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7408-t6761-vmware-67u3.zip Smoke tests completed. 107 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:
>
> Test Result Time (s) Test File
> test_01_deploy_vm_on_specific_host `Error` 18.73 test_vm_deployment_planner.py
> test_02_deploy_vm_on_specific_cluster `Error` 3605.89 test_vm_deployment_planner.py
> test_03_deploy_vm_on_specific_pod `Error` 40.36 test_vm_deployment_planner.py
> test_04_deploy_vm_on_host_override_pod_and_cluster `Error` 3604.32 test_vm_deployment_planner.py
> test_05_deploy_vm_on_cluster_override_pod `Error` 11.55 test_vm_deployment_planner.py
Manually passed
=== TestName: test_01_deploy_vm_on_specific_host | Status : SUCCESS ===
=== TestName: test_02_deploy_vm_on_specific_cluster | Status : SUCCESS ===
=== TestName: test_03_deploy_vm_on_specific_pod | Status : SUCCESS ===
=== TestName: test_04_deploy_vm_on_host_override_pod_and_cluster | Status : SUCCESS ===
=== TestName: test_05_deploy_vm_on_cluster_override_pod | Status : SUCCESS ===
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1577877638
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1570067803
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1590989978
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "borisstoyanov (via GitHub)" <gi...@apache.org>.
borisstoyanov commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1598331331
> [SF] Trillian test result (tid-6765) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46162 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7408-t6765-kvm-centos7.zip Smoke tests completed. 107 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:
>
> Test Result Time (s) Test File
> test_01_migrate_VM_and_root_volume `Error` 83.95 test_vm_life_cycle.py
> test_02_migrate_VM_with_two_data_disks `Error` 52.30 test_vm_life_cycle.py
This has been seen in other 4.18 PRs as well, it's not related to the changes of this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1597038523
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1584279032
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala closed pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala closed pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
URL: https://github.com/apache/cloudstack/pull/7408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1594361964
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1594304138
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1577878899
@harikrishna-patnala a [LL] Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1580277444
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1584222683
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "borisstoyanov (via GitHub)" <gi...@apache.org>.
borisstoyanov commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1590905400
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1572493354
<b>[SF] Trillian test result (tid-6643)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39209 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7408-t6643-kvm-centos7.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1571285310
@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1570069586
@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1498694801
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1498693484
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "borisstoyanov (via GitHub)" <gi...@apache.org>.
borisstoyanov commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1571413388
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1571499179
@borisstoyanov a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "borisstoyanov (via GitHub)" <gi...@apache.org>.
borisstoyanov commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1571989709
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "borisstoyanov (via GitHub)" <gi...@apache.org>.
borisstoyanov commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1578098156
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1590906867
@borisstoyanov a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1597774323
<b>[SF] Trillian test result (tid-6762)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45976 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7408-t6762-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_migrate_VM_and_root_volume | `Error` | 78.68 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 57.52 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1597270020
@borisstoyanov a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "borisstoyanov (via GitHub)" <gi...@apache.org>.
borisstoyanov commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1582302303
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "borisstoyanov (via GitHub)" <gi...@apache.org>.
borisstoyanov commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1596702397
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala merged pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala merged PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1637597498
@borisstoyanov a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1637600085
Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 6493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1570154420
Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 6183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1584225568
@harikrishna-patnala a [LL] Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1582388629
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1587519304
@harikrishna-patnala @borisstoyanov should this bugfix/improvement be targeted for 4.18 since there are no DB changes and essentially you're addressing a limitation of the scaleio storage plugin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1588142782
<b>[SF] Trillian test result (tid-6726)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45288 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7408-t6726-kvm-centos7.zip
Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_rvpc_multi_tiers | `Failure` | 495.08 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 495.10 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#discussion_r1226903045
##########
plugins/storage/volume/scaleio/src/test/java/org/apache/cloudstack/storage/datastore/driver/ScaleIOPrimaryDataStoreDriverTest.java:
##########
@@ -0,0 +1,527 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package org.apache.cloudstack.storage.datastore.driver;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.storage.MigrateVolumeAnswer;
+import com.cloud.agent.api.to.DataTO;
+import com.cloud.agent.api.to.DiskTO;
+import com.cloud.configuration.Config;
+import com.cloud.host.Host;
+import com.cloud.host.HostVO;
+import com.cloud.host.dao.HostDao;
+import com.cloud.storage.Storage;
+import com.cloud.storage.Volume;
+import com.cloud.storage.VolumeVO;
+import com.cloud.storage.dao.VolumeDao;
+import com.cloud.storage.dao.VolumeDetailsDao;
+import com.cloud.utils.exception.CloudRuntimeException;
+import com.cloud.vm.VMInstanceVO;
+import com.cloud.vm.VirtualMachine;
+import com.cloud.vm.dao.VMInstanceDao;
+import org.apache.cloudstack.engine.subsystem.api.storage.DataObject;
+import org.apache.cloudstack.engine.subsystem.api.storage.DataStore;
+import org.apache.cloudstack.engine.subsystem.api.storage.VolumeInfo;
+import org.apache.cloudstack.engine.subsystem.api.storage.VolumeService;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.apache.cloudstack.storage.RemoteHostEndPoint;
+import org.apache.cloudstack.storage.command.CreateObjectAnswer;
+import org.apache.cloudstack.storage.datastore.client.ScaleIOGatewayClient;
+import org.apache.cloudstack.storage.datastore.db.PrimaryDataStoreDao;
+import org.apache.cloudstack.storage.datastore.db.StoragePoolDetailVO;
+import org.apache.cloudstack.storage.datastore.db.StoragePoolDetailsDao;
+import org.apache.cloudstack.storage.datastore.db.StoragePoolVO;
+import org.apache.cloudstack.storage.to.VolumeObjectTO;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+import org.mockito.MockitoAnnotations;
+import org.mockito.Spy;
+import org.powermock.api.mockito.PowerMockito;
+import org.powermock.core.classloader.annotations.PrepareForTest;
+import org.powermock.modules.junit4.PowerMockRunner;
+
+import java.util.Optional;
+
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.doNothing;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.when;
+
+@RunWith(PowerMockRunner.class)
+@PrepareForTest(RemoteHostEndPoint.class)
+public class ScaleIOPrimaryDataStoreDriverTest {
+
+ @Spy
+ @InjectMocks
+ ScaleIOPrimaryDataStoreDriver scaleIOPrimaryDataStoreDriver = new ScaleIOPrimaryDataStoreDriver();
+ @Mock
+ StoragePoolDetailsDao storagePoolDetailsDao;
+ @Mock
+ PrimaryDataStoreDao storagePoolDao;
+ @Mock
+ VolumeDao volumeDao;
+ @Mock
+ VolumeDetailsDao volumeDetailsDao;
+ @Mock
+ VolumeService volumeService;
+ @Mock
+ VMInstanceDao vmInstanceDao;
+ @Mock
+ HostDao hostDao;
+ @Mock
+ ConfigurationDao configDao;
+
+ @Before
+ public void initMocks() {
+ MockitoAnnotations.initMocks(this);
+ }
+ @Test
+ public void testSameScaleIOStorageInstance() {
+ DataStore srcStore = Mockito.mock(DataStore.class);
+ DataStore destStore = Mockito.mock(DataStore.class);
+ when(srcStore.getId()).thenReturn(1L);
+ when(destStore.getId()).thenReturn(2L);
+
+ StoragePoolDetailVO srcPoolSystemIdDetail = Mockito.mock(StoragePoolDetailVO.class);
+ String srcPoolSystemId = "610204d03e3ad60f";
+ when(srcPoolSystemIdDetail.getValue()).thenReturn(srcPoolSystemId);
+
+ StoragePoolDetailVO destPoolSystemIdDetail = Mockito.mock(StoragePoolDetailVO.class);
+ String destPoolSystemId = "610204d03e3ad60f";
+ when(destPoolSystemIdDetail.getValue()).thenReturn(destPoolSystemId);
+
+ when(storagePoolDetailsDao.findDetail(1L,ScaleIOGatewayClient.STORAGE_POOL_SYSTEM_ID)).thenReturn(srcPoolSystemIdDetail);
+ when(storagePoolDetailsDao.findDetail(2L,ScaleIOGatewayClient.STORAGE_POOL_SYSTEM_ID)).thenReturn(destPoolSystemIdDetail);
+
+ boolean result = scaleIOPrimaryDataStoreDriver.isSameScaleIOStorageInstance(srcStore, destStore);
+
+ Assert.assertTrue(result);
+ }
+
+ @Test
+ public void testDifferentScaleIOStorageInstance() {
+ DataStore srcStore = Mockito.mock(DataStore.class);
+ DataStore destStore = Mockito.mock(DataStore.class);
+ when(srcStore.getId()).thenReturn(1L);
+ when(destStore.getId()).thenReturn(2L);
+
+ StoragePoolDetailVO srcPoolSystemIdDetail = Mockito.mock(StoragePoolDetailVO.class);
+ String srcPoolSystemId = "610204d03e3ad60f";
+ when(srcPoolSystemIdDetail.getValue()).thenReturn(srcPoolSystemId);
+
+ StoragePoolDetailVO destPoolSystemIdDetail = Mockito.mock(StoragePoolDetailVO.class);
+ String destPoolSystemId = "7332760565f6340f";
+ when(destPoolSystemIdDetail.getValue()).thenReturn(destPoolSystemId);
+
+ when(storagePoolDetailsDao.findDetail(1L,ScaleIOGatewayClient.STORAGE_POOL_SYSTEM_ID)).thenReturn(srcPoolSystemIdDetail);
+ when(storagePoolDetailsDao.findDetail(2L,ScaleIOGatewayClient.STORAGE_POOL_SYSTEM_ID)).thenReturn(destPoolSystemIdDetail);
+
+ boolean result = scaleIOPrimaryDataStoreDriver.isSameScaleIOStorageInstance(srcStore, destStore);
+
+ Assert.assertFalse(result);
+ }
+
+ @Test (expected = CloudRuntimeException.class)
+ public void testCheckVolumeOnDifferentScaleIOStorageInstanceSystemIdShouldNotBeNull() {
+ DataStore srcStore = Mockito.mock(DataStore.class);
+ DataStore destStore = Mockito.mock(DataStore.class);
+ when(srcStore.getId()).thenReturn(1L);
+ when(destStore.getId()).thenReturn(2L);
+
+ StoragePoolDetailVO srcPoolSystemIdDetail = Mockito.mock(StoragePoolDetailVO.class);
+ String srcPoolSystemId = "610204d03e3ad60f";
+ when(srcPoolSystemIdDetail.getValue()).thenReturn(srcPoolSystemId);
+
+ StoragePoolDetailVO destPoolSystemIdDetail = Mockito.mock(StoragePoolDetailVO.class);
+ when(destPoolSystemIdDetail.getValue()).thenReturn(null);
+
+ when(storagePoolDetailsDao.findDetail(1L,ScaleIOGatewayClient.STORAGE_POOL_SYSTEM_ID)).thenReturn(srcPoolSystemIdDetail);
+ when(storagePoolDetailsDao.findDetail(2L,ScaleIOGatewayClient.STORAGE_POOL_SYSTEM_ID)).thenReturn(destPoolSystemIdDetail);
+
+ scaleIOPrimaryDataStoreDriver.isSameScaleIOStorageInstance(srcStore, destStore);
+ }
+
+ @Test
+ public void testMigrateVolumeWithinSameScaleIOClusterSuccess() throws Exception {
+ VolumeInfo srcData = Mockito.mock(VolumeInfo.class);
+ VolumeInfo destData = Mockito.mock(VolumeInfo.class);
+
+ DataStore srcStore = Mockito.mock(DataStore.class);
+ DataStore destStore = Mockito.mock(DataStore.class);
+
+ when(srcData.getDataStore()).thenReturn(srcStore);
+ when(destData.getDataStore()).thenReturn(destStore);
+
+ fillSrcVolumeDetails(srcData, srcStore);
+ fillDestVolumeDetails(destData, destStore);
+
+ VolumeObjectTO destVolTO = Mockito.mock(VolumeObjectTO.class);
+ when(destData.getTO()).thenReturn(destVolTO);
+ Host host = prepareEndpointForVolumeOperation(srcData);
+ PowerMockito.mockStatic(RemoteHostEndPoint.class);
+ RemoteHostEndPoint ep = Mockito.mock(RemoteHostEndPoint.class);
+ when(RemoteHostEndPoint.getHypervisorHostEndPoint(host)).thenReturn(ep);
+
+ DataTO dataTO = Mockito.mock(DataTO.class);
+ CreateObjectAnswer createAnswer = new CreateObjectAnswer(dataTO);
+ doReturn(createAnswer).when(scaleIOPrimaryDataStoreDriver).createVolume(destData, 2L, true);
+ when(dataTO.getPath()).thenReturn("bec0ba7700000007:vol-11-6aef-10ee");
+ doReturn(true).when(scaleIOPrimaryDataStoreDriver)
+ .grantAccess(any(), any(), any());
+
+ when(configDao.getValue(Config.MigrateWait.key())).thenReturn("3600");
+ MigrateVolumeAnswer migrateVolumeAnswer = Mockito.mock(MigrateVolumeAnswer.class);
+ when(ep.sendMessage(any())).thenReturn(migrateVolumeAnswer);
+ when(migrateVolumeAnswer.getResult()).thenReturn(true);
+
+ Mockito.doNothing().when(scaleIOPrimaryDataStoreDriver)
+ .updateVolumeAfterCopyVolume(any(), any());
+ Mockito.doNothing().when(scaleIOPrimaryDataStoreDriver)
+ .updateSnapshotsAfterCopyVolume(any(), any());
+ Mockito.doNothing().when(scaleIOPrimaryDataStoreDriver)
+ .deleteSourceVolumeAfterSuccessfulBlockCopy(any(), any());
+
+ Answer answer = scaleIOPrimaryDataStoreDriver.liveMigrateVolume(srcData, destData);
+
+ Assert.assertTrue(answer.getResult());
+ }
+
+ @Test
+ public void testMigrateVolumeWithinSameScaleIOClusterFailure() throws Exception {
+ VolumeInfo srcData = Mockito.mock(VolumeInfo.class);
+ VolumeInfo destData = Mockito.mock(VolumeInfo.class);
+
+ DataStore srcStore = Mockito.mock(DataStore.class);
+ DataStore destStore = Mockito.mock(DataStore.class);
+
+ when(srcData.getDataStore()).thenReturn(srcStore);
+ when(destData.getDataStore()).thenReturn(destStore);
+
+ fillSrcVolumeDetails(srcData, srcStore);
+ fillDestVolumeDetails(destData, destStore);
+
+ VolumeObjectTO destVolTO = Mockito.mock(VolumeObjectTO.class);
+ when(destData.getTO()).thenReturn(destVolTO);
+ Host host = prepareEndpointForVolumeOperation(srcData);
+ PowerMockito.mockStatic(RemoteHostEndPoint.class);
+ RemoteHostEndPoint ep = Mockito.mock(RemoteHostEndPoint.class);
+ when(RemoteHostEndPoint.getHypervisorHostEndPoint(host)).thenReturn(ep);
+
+ DataTO dataTO = Mockito.mock(DataTO.class);
+ CreateObjectAnswer createAnswer = new CreateObjectAnswer(dataTO);
+ doReturn(createAnswer).when(scaleIOPrimaryDataStoreDriver).createVolume(destData, 2L, true);
+ when(dataTO.getPath()).thenReturn("bec0ba7700000007:vol-11-6aef-10ee");
+ doReturn(true).when(scaleIOPrimaryDataStoreDriver)
+ .grantAccess(any(), any(), any());
+
+ when(configDao.getValue(Config.MigrateWait.key())).thenReturn("3600");
+ MigrateVolumeAnswer migrateVolumeAnswer = Mockito.mock(MigrateVolumeAnswer.class);
+ when(ep.sendMessage(any())).thenReturn(migrateVolumeAnswer);
+ when(migrateVolumeAnswer.getResult()).thenReturn(false);
+ Mockito.doNothing().when(scaleIOPrimaryDataStoreDriver)
+ .revertBlockCopyVolumeOperations(any(), any(), any(), any());
+
+ Answer answer = scaleIOPrimaryDataStoreDriver.liveMigrateVolume(srcData, destData);
+
+ Assert.assertFalse(answer.getResult());
+ }
+
+ private void fillSrcVolumeDetails(VolumeInfo srcData, DataStore srcStore) {
+ when(srcStore.getId()).thenReturn(1L);
+ when(srcData.getId()).thenReturn(1L);
+
+ StoragePoolVO storagePoolVO = Mockito.mock(StoragePoolVO.class);
+ when(storagePoolDao.findById(1L)).thenReturn(storagePoolVO);
+ when(storagePoolVO.isManaged()).thenReturn(true);
+
+ VolumeVO volumeVO = Mockito.mock(VolumeVO.class);
+ when(volumeDao.findById(1L)).thenReturn(volumeVO);
+
+ when(volumeDetailsDao.findDetail(1L, DiskTO.SCSI_NAA_DEVICE_ID)).thenReturn(null);
+ when(volumeService.getChapInfo(srcData, srcStore)).thenReturn(null);
+
+ StoragePoolDetailVO srcStoragePoolDetail = Mockito.mock(StoragePoolDetailVO.class);
+ when(srcStoragePoolDetail.getValue()).thenReturn("610204d03e3ad60f");
+ when(storagePoolDetailsDao.findDetail(1L, ScaleIOGatewayClient.STORAGE_POOL_SYSTEM_ID)).thenReturn(srcStoragePoolDetail);
+ }
+
+ private void fillDestVolumeDetails(VolumeInfo srcData, DataStore srcStore) {
+ when(srcStore.getId()).thenReturn(2L);
+ when(srcData.getId()).thenReturn(2L);
+
+ StoragePoolVO storagePoolVO = Mockito.mock(StoragePoolVO.class);
+ when(storagePoolDao.findById(2L)).thenReturn(storagePoolVO);
+ when(storagePoolVO.isManaged()).thenReturn(true);
+
+ VolumeVO volumeVO = Mockito.mock(VolumeVO.class);
+ when(volumeDao.findById(2L)).thenReturn(volumeVO);
+
+ when(volumeDetailsDao.findDetail(2L, DiskTO.SCSI_NAA_DEVICE_ID)).thenReturn(null);
+ when(volumeService.getChapInfo(srcData, srcStore)).thenReturn(null);
+
+ StoragePoolDetailVO srcStoragePoolDetail = Mockito.mock(StoragePoolDetailVO.class);
+ when(srcStoragePoolDetail.getValue()).thenReturn("7332760565f6340f");
+ when(storagePoolDetailsDao.findDetail(2L, ScaleIOGatewayClient.STORAGE_POOL_SYSTEM_ID)).thenReturn(srcStoragePoolDetail);
+ }
+
+ private Host prepareEndpointForVolumeOperation(VolumeInfo srcData) {
+ VMInstanceVO instance = Mockito.mock(VMInstanceVO.class);
+ when(srcData.getAttachedVmName()).thenReturn("i-2-VM");
+ when(vmInstanceDao.findVMByInstanceName("i-2-VM")).thenReturn(instance);
+ when(instance.getHostId()).thenReturn(4L);
+ when(instance.getState()).thenReturn(VirtualMachine.State.Running);
+ HostVO host = Mockito.mock(HostVO.class);
+ when(hostDao.findById(4L)).thenReturn(host);
+
+ return host;
+ }
+
+ @Test
+ public void updateVolumeAfterCopyVolumeLiveMigrate() {
+ VolumeInfo srcData = Mockito.mock(VolumeInfo.class);
+ VolumeInfo destData = Mockito.mock(VolumeInfo.class);
+
+ when(srcData.getId()).thenReturn(1L);
+ when(destData.getId()).thenReturn(1L);
+
+ VolumeVO volume = new VolumeVO("root", 1L, 1L, 1L, 1L, 1L, "root", "root", Storage.ProvisioningType.THIN, 1, null, null, "root", Volume.Type.ROOT);
+ volume.setPoolId(2L);
+ when(volumeDao.findById(1L)).thenReturn(volume);
+ when(volumeDao.update(1L, volume)).thenReturn(true);
+
+ scaleIOPrimaryDataStoreDriver.updateVolumeAfterCopyVolume(srcData, destData);
+
+ Assert.assertEquals(Optional.of(2L), Optional.of(volume.getLastPoolId()));
+ }
+
+ @Test
+ public void updateVolumeAfterCopyVolumeOffline() {
+ VolumeInfo srcData = Mockito.mock(VolumeInfo.class);
+ VolumeInfo destData = Mockito.mock(VolumeInfo.class);
+
+ when(srcData.getId()).thenReturn(1L);
+ when(destData.getId()).thenReturn(2L);
+
+ VolumeVO volume = new VolumeVO("root", 1L, 1L, 1L, 1L, 1L, "root", "root", Storage.ProvisioningType.THIN, 1, null, null, "root", Volume.Type.ROOT);
+ when(volumeDao.findById(1L)).thenReturn(volume);
+ when(volumeDao.update(1L, volume)).thenReturn(true);
+
+ scaleIOPrimaryDataStoreDriver.updateVolumeAfterCopyVolume(srcData, destData);
+
+ Assert.assertNull(volume.get_iScsiName());
+ Assert.assertNull(volume.getPath());
+ Assert.assertNull(volume.getFolder());
+ }
+
+ @Test
+ public void revertBlockCopyVolumeOperationsOnDeleteSuccess() throws Exception{
+ //Either destination volume delete success or failure, DB operations should get revert
+
+ VolumeInfo srcData = Mockito.mock(VolumeInfo.class);
+ VolumeInfo destData = Mockito.mock(VolumeInfo.class);
+ Host host = Mockito.mock(Host.class);
+ String destVolumePath = "01b332b300000007:vol-11-b9e2-10ee";
+
+ when(srcData.getId()).thenReturn(1L);
+ when(srcData.getPoolId()).thenReturn(1L);
+ when(destData.getId()).thenReturn(1L);
+
+ when(srcData.getPath()).thenReturn("bec0ba7700000007:vol-11-6aef-10ee");
+ when(srcData.getFolder()).thenReturn("921c364500000007");
+ DataStore destStore = Mockito.mock(DataStore.class);
+ when(destStore.getId()).thenReturn(2L);
+ when(destData.getDataStore()).thenReturn(destStore);
+ doNothing().when(scaleIOPrimaryDataStoreDriver)
+ .revokeAccess(any(), any(), any());
+
+ ScaleIOGatewayClient client = Mockito.mock(ScaleIOGatewayClient.class);
+ doReturn(client).when(scaleIOPrimaryDataStoreDriver)
+ .getScaleIOClient(any());
+ when(client.deleteVolume(any())).thenReturn(true);
+
+ VolumeVO volume = new VolumeVO("root", 1L, 1L, 1L, 1L, 1L, "root", "root", Storage.ProvisioningType.THIN, 1, null, null, "root", Volume.Type.ROOT);
+ when(volumeDao.findById(1L)).thenReturn(volume);
+ when(volumeDao.update(1L, volume)).thenReturn(true);
+
+ scaleIOPrimaryDataStoreDriver.revertBlockCopyVolumeOperations(srcData, destData, host, destVolumePath);
+
+ Assert.assertEquals("bec0ba7700000007:vol-11-6aef-10ee", volume.get_iScsiName());
+ Assert.assertEquals("bec0ba7700000007:vol-11-6aef-10ee", volume.getPath());
+ Assert.assertEquals("921c364500000007", volume.getFolder());
+ }
+
+ @Test
+ public void revertBlockCopyVolumeOperationsOnDeleteFailure() throws Exception{
+ //Either destination volume delete success or failure, DB operations should get revert
+
+ VolumeInfo srcData = Mockito.mock(VolumeInfo.class);
+ VolumeInfo destData = Mockito.mock(VolumeInfo.class);
+ Host host = Mockito.mock(Host.class);
+ String srcVolumePath = "bec0ba7700000007:vol-11-6aef-10ee";
+ String destVolumePath = "01b332b300000007:vol-11-b9e2-10ee";
+
+ when(srcData.getId()).thenReturn(1L);
+ when(srcData.getPoolId()).thenReturn(1L);
+ when(destData.getId()).thenReturn(1L);
+
+ when(srcData.getPath()).thenReturn(srcVolumePath);
+ when(srcData.getFolder()).thenReturn("921c364500000007");
+ DataStore destStore = Mockito.mock(DataStore.class);
+ when(destStore.getId()).thenReturn(2L);
+ when(destData.getDataStore()).thenReturn(destStore);
+ doNothing().when(scaleIOPrimaryDataStoreDriver).revokeAccess(any(), any(), any());
+
+ ScaleIOGatewayClient client = Mockito.mock(ScaleIOGatewayClient.class);
+ doReturn(client).when(scaleIOPrimaryDataStoreDriver)
+ .getScaleIOClient(any());
+ when(client.deleteVolume(any())).thenReturn(false);
+
+ VolumeVO volume = new VolumeVO("root", 1L, 1L, 1L, 1L, 1L, "root", "root", Storage.ProvisioningType.THIN, 1, null, null, "root", Volume.Type.ROOT);
+ when(volumeDao.findById(1L)).thenReturn(volume);
+ when(volumeDao.update(1L, volume)).thenReturn(true);
+
+ scaleIOPrimaryDataStoreDriver.revertBlockCopyVolumeOperations(srcData, destData, host, destVolumePath);
+
+ Assert.assertEquals(srcVolumePath, volume.get_iScsiName());
+ Assert.assertEquals(srcVolumePath, volume.getPath());
+ Assert.assertEquals("921c364500000007", volume.getFolder());
+ }
+
+ @Test
+ public void deleteSourceVolumeSuccessScenarioAfterSuccessfulBlockCopy() throws Exception {
+ // Either Volume deletion success or failure method should complete
+
+ VolumeInfo srcData = Mockito.mock(VolumeInfo.class);
+ Host host = Mockito.mock(Host.class);
+ String srcVolumePath = "bec0ba7700000007:vol-11-6aef-10ee";
+
+ DataStore srcStore = Mockito.mock(DataStore.class);
+ DataTO volumeTO = Mockito.mock(DataTO.class);
+ when(srcData.getDataStore()).thenReturn(srcStore);
+ when(srcData.getTO()).thenReturn(volumeTO);
+ when(volumeTO.getPath()).thenReturn(srcVolumePath);
+ doNothing().when(scaleIOPrimaryDataStoreDriver).revokeVolumeAccess(any(), any(), any());
+
+ ScaleIOGatewayClient client = Mockito.mock(ScaleIOGatewayClient.class);
+ doReturn(client).when(scaleIOPrimaryDataStoreDriver)
+ .getScaleIOClient(any());
+ when(client.deleteVolume(any())).thenReturn(true);
+
+ scaleIOPrimaryDataStoreDriver.deleteSourceVolumeAfterSuccessfulBlockCopy(srcData, host);
+ }
+
+ @Test
+ public void deleteSourceVolumeFailureScenarioAfterSuccessfulBlockCopy() throws Exception {
+ // Either Volume deletion success or failure method should complete
+
+ VolumeInfo srcData = Mockito.mock(VolumeInfo.class);
+ Host host = Mockito.mock(Host.class);
+ when(host.getId()).thenReturn(1L);
+ String srcVolumePath = "bec0ba7700000007:vol-11-6aef-10ee";
+
+ DataStore srcStore = Mockito.mock(DataStore.class);
+ when(srcStore.getId()).thenReturn(1L);
+ DataTO volumeTO = Mockito.mock(DataTO.class);
+ when(srcData.getDataStore()).thenReturn(srcStore);
+ when(srcData.getTO()).thenReturn(volumeTO);
+ when(volumeTO.getPath()).thenReturn(srcVolumePath);
+ String sdcId = "7332760565f6340f";
+ doReturn(sdcId).when(scaleIOPrimaryDataStoreDriver).getConnectedSdc(1L, 1L);
+
+ ScaleIOGatewayClient client = Mockito.mock(ScaleIOGatewayClient.class);
+ doReturn(client).when(scaleIOPrimaryDataStoreDriver)
+ .getScaleIOClient(any());
+ doReturn(true).when(client).unmapVolumeFromSdc(any(), any());
+ when(client.deleteVolume(any())).thenReturn(false);
+
+ scaleIOPrimaryDataStoreDriver.deleteSourceVolumeAfterSuccessfulBlockCopy(srcData, host);
+ }
+
+ @Test
+ public void deleteSourceVolumeFailureScenarioWhenNoSDCisFound() {
+ // Either Volume deletion success or failure method should complete
+
+ VolumeInfo srcData = Mockito.mock(VolumeInfo.class);
+ Host host = Mockito.mock(Host.class);
+ when(host.getId()).thenReturn(1L);
+ String srcVolumePath = "bec0ba7700000007:vol-11-6aef-10ee";
+
+ DataStore srcStore = Mockito.mock(DataStore.class);
+ when(srcStore.getId()).thenReturn(1L);
+ DataTO volumeTO = Mockito.mock(DataTO.class);
+ when(srcData.getDataStore()).thenReturn(srcStore);
+ when(srcData.getTO()).thenReturn(volumeTO);
+ when(volumeTO.getPath()).thenReturn(srcVolumePath);
+ String sdcId = "7332760565f6340f";
+ doReturn(null).when(scaleIOPrimaryDataStoreDriver).getConnectedSdc(1L, 1L);
+
+ scaleIOPrimaryDataStoreDriver.deleteSourceVolumeAfterSuccessfulBlockCopy(srcData, host);
+ }
+
+ @Test
+ public void testCopyOfflineVolume() {
+ when(configDao.getValue(Config.CopyVolumeWait.key())).thenReturn("3600");
+
+ DataObject srcData = Mockito.mock(DataObject.class);
+ DataTO srcDataTO = Mockito.mock(DataTO.class);
+ when(srcData.getTO()).thenReturn(srcDataTO);
+ DataObject destData = Mockito.mock(DataObject.class);
+ DataTO destDataTO = Mockito.mock(DataTO.class);
+ when(destData.getTO()).thenReturn(destDataTO);
+ Host destHost = Mockito.mock(Host.class);
+
+ doReturn(false).when(scaleIOPrimaryDataStoreDriver).anyVolumeRequiresEncryption(srcData, destData);
+ PowerMockito.mockStatic(RemoteHostEndPoint.class);
+ RemoteHostEndPoint ep = Mockito.mock(RemoteHostEndPoint.class);
+ when(RemoteHostEndPoint.getHypervisorHostEndPoint(destHost)).thenReturn(ep);
+ Answer answer = Mockito.mock(Answer.class);
+ when(ep.sendMessage(any())).thenReturn(answer);
+
+ Answer expectedAnswer = scaleIOPrimaryDataStoreDriver.copyOfflineVolume(srcData, destData, destHost);
+
+ Assert.assertEquals(expectedAnswer, answer);
+ }
+
+ @Test
+ public void testCopyOfflineVolumeFailureWhenNoEndpointFound() {
+ when(configDao.getValue(Config.CopyVolumeWait.key())).thenReturn("3600");
+
+ DataObject srcData = Mockito.mock(DataObject.class);
+ DataTO srcDataTO = Mockito.mock(DataTO.class);
+ when(srcData.getTO()).thenReturn(srcDataTO);
+ DataObject destData = Mockito.mock(DataObject.class);
+ DataTO destDataTO = Mockito.mock(DataTO.class);
+ when(destData.getTO()).thenReturn(destDataTO);
+ Host destHost = Mockito.mock(Host.class);
+
+ doReturn(false).when(scaleIOPrimaryDataStoreDriver).anyVolumeRequiresEncryption(srcData, destData);
+ PowerMockito.mockStatic(RemoteHostEndPoint.class);
+ when(RemoteHostEndPoint.getHypervisorHostEndPoint(destHost)).thenReturn(null);
+
+ Answer answer = scaleIOPrimaryDataStoreDriver.copyOfflineVolume(srcData, destData, destHost);
+
+ Assert.assertEquals(false, answer.getResult());
+ }
+}
Review Comment:
can you ad a line ending @harikrishna-patnala ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1580212002
@harikrishna-patnala a [LL] Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1578838286
<b>[SF] Trillian test result (tid-6691)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 21714 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7408-t6691-kvm-centos7.zip
Smoke tests completed. 86 look OK, 0 have errors, 24 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
all_test_safe_shutdown | `Skipped` | --- | test_safe_shutdown.py
all_test_metrics_api | `Skipped` | --- | test_metrics_api.py
all_test_outofbandmanagement | `Skipped` | --- | test_outofbandmanagement.py
all_test_outofbandmanagement_nestedplugin | `Skipped` | --- | test_outofbandmanagement_nestedplugin.py
all_test_routers_iptables_default_policy | `Skipped` | --- | test_routers_iptables_default_policy.py
all_test_secondary_storage | `Skipped` | --- | test_secondary_storage.py
all_test_service_offerings | `Skipped` | --- | test_service_offerings.py
all_test_storage_policy | `Skipped` | --- | test_storage_policy.py
all_test_templates | `Skipped` | --- | test_templates.py
all_test_update_security_group | `Skipped` | --- | test_update_security_group.py
all_test_usage_events | `Skipped` | --- | test_usage_events.py
all_test_vm_autoscaling | `Skipped` | --- | test_vm_autoscaling.py
all_test_vm_deployment_planner | `Skipped` | --- | test_vm_deployment_planner.py
all_test_vm_life_cycle | `Skipped` | --- | test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import | `Skipped` | --- | test_vm_lifecycle_unmanage_import.py
all_test_vm_snapshot_kvm | `Skipped` | --- | test_vm_snapshot_kvm.py
all_test_vm_snapshots | `Skipped` | --- | test_vm_snapshots.py
all_test_volumes | `Skipped` | --- | test_volumes.py
all_test_vpc_ipv6 | `Skipped` | --- | test_vpc_ipv6.py
all_test_vpc_redundant | `Skipped` | --- | test_vpc_redundant.py
all_test_vpc_router_nics | `Skipped` | --- | test_vpc_router_nics.py
all_test_vpc_vpn | `Skipped` | --- | test_vpc_vpn.py
all_test_host_maintenance | `Skipped` | --- | test_host_maintenance.py
all_test_hostha_kvm | `Skipped` | --- | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1584216279
Packaging result [LL]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 6114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1597040341
@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1596704882
@borisstoyanov a [SF] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1571414935
@borisstoyanov a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1571990899
@borisstoyanov a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "borisstoyanov (via GitHub)" <gi...@apache.org>.
borisstoyanov commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1571498374
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1498783035
SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7408)
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7408&resolved=false&types=BUG) [![C](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/C-16px.png 'C')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7408&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7408&resolved=false&types=BUG)
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7408&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7408&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7408&resolved=false&types=VULNERABILITY)
[![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7408&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7408&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7408&resolved=false&types=SECURITY_HOTSPOT)
[![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7408&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7408&resolved=false&types=CODE_SMELL) [15 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7408&resolved=false&types=CODE_SMELL)
[![8.7%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '8.7%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7408&metric=new_coverage&view=list) [8.7% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7408&metric=new_coverage&view=list)
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7408&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7408&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1498769206
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1582306310
@borisstoyanov a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1586859121
@borisstoyanov a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "borisstoyanov (via GitHub)" <gi...@apache.org>.
borisstoyanov commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1586857941
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1592565425
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1580427493
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1592505825
@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1597097765
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1572141827
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1571283475
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1578101309
@borisstoyanov a [SF] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1580211433
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1580306551
@harikrishna-patnala a [LL] Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1571316485
@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1571314082
Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 6190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1588562279
@harikrishna-patnala a [LL] Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "borisstoyanov (via GitHub)" <gi...@apache.org>.
borisstoyanov commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1637594638
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1594306522
@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1498758731
Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 5869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1498770828
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "borisstoyanov (via GitHub)" <gi...@apache.org>.
borisstoyanov commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1597267982
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1598056054
<b>[SF] Trillian test result (tid-6765)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46162 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7408-t6765-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_migrate_VM_and_root_volume | `Error` | 83.95 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 52.30 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1597674478
<b>[SF] Trillian test result (tid-6760)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40579 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7408-t6760-xenserver-71.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1571601419
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1571349265
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1580305768
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1584193287
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1578876991
<b>[SF] Trillian test result (tid-6689)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 23132 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7408-t6689-xenserver-71.zip
Smoke tests completed. 86 look OK, 0 have errors, 24 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
all_test_safe_shutdown | `Skipped` | --- | test_safe_shutdown.py
all_test_metrics_api | `Skipped` | --- | test_metrics_api.py
all_test_outofbandmanagement | `Skipped` | --- | test_outofbandmanagement.py
all_test_outofbandmanagement_nestedplugin | `Skipped` | --- | test_outofbandmanagement_nestedplugin.py
all_test_routers_iptables_default_policy | `Skipped` | --- | test_routers_iptables_default_policy.py
all_test_secondary_storage | `Skipped` | --- | test_secondary_storage.py
all_test_service_offerings | `Skipped` | --- | test_service_offerings.py
all_test_storage_policy | `Skipped` | --- | test_storage_policy.py
all_test_templates | `Skipped` | --- | test_templates.py
all_test_update_security_group | `Skipped` | --- | test_update_security_group.py
all_test_usage_events | `Skipped` | --- | test_usage_events.py
all_test_vm_autoscaling | `Skipped` | --- | test_vm_autoscaling.py
all_test_vm_deployment_planner | `Skipped` | --- | test_vm_deployment_planner.py
all_test_vm_life_cycle | `Skipped` | --- | test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import | `Skipped` | --- | test_vm_lifecycle_unmanage_import.py
all_test_vm_snapshot_kvm | `Skipped` | --- | test_vm_snapshot_kvm.py
all_test_vm_snapshots | `Skipped` | --- | test_vm_snapshots.py
all_test_volumes | `Skipped` | --- | test_volumes.py
all_test_vpc_ipv6 | `Skipped` | --- | test_vpc_ipv6.py
all_test_vpc_redundant | `Skipped` | --- | test_vpc_redundant.py
all_test_vpc_router_nics | `Skipped` | --- | test_vpc_router_nics.py
all_test_vpc_vpn | `Skipped` | --- | test_vpc_vpn.py
all_test_host_maintenance | `Skipped` | --- | test_host_maintenance.py
all_test_hostha_kvm | `Skipped` | --- | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1588589180
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1588561423
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1577907261
Packaging result [LL]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7408: Allow volume migrations in ScaleIO within and across ScaleIO storage clusters
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1592503313
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7408: Allow volume live storage migration in ScaleIO
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7408:
URL: https://github.com/apache/cloudstack/pull/7408#issuecomment-1498852770
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org