[GitHub] spark pull request #17014: [SPARK-18608][ML] Fix double-caching in ML algori...

[WeichenXu123 <gi...@git.apache.org>]

Github user WeichenXu123 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17014#discussion_r135534873
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/Predictor.scala ---
    @@ -85,6 +86,10 @@ abstract class Predictor[
         M <: PredictionModel[FeaturesType, M]]
       extends Estimator[M] with PredictorParams {
     
    +  protected[spark] var storageLevel = StorageLevel.NONE
    +
    +  protected def handlePersistence = storageLevel == StorageLevel.NONE
    --- End diff --
    
    This design may cause some concurrency issue I think.
    For example, if we want to use the predictor to train different dataset parallelly, the `storageLevel` status will be in a mess.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org