You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/18 23:24:13 UTC

[GitHub] [airflow] dimberman opened a new pull request #7761: [AIRFLOW-7086] /dags/paused should be a POST

dimberman opened a new pull request #7761: [AIRFLOW-7086] /dags/paused should be a POST
URL: https://github.com/apache/airflow/pull/7761
 
 
   We shouldn't change state using a get method. We should change the
   /dags/paused endpoint to a POST where the data contains the desired
   pause state
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7761: [AIRFLOW-7086] /dags/paused should be a PUT

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7761: [AIRFLOW-7086] /dags/paused should be a PUT
URL: https://github.com/apache/airflow/pull/7761#discussion_r395353337
 
 

 ##########
 File path: tests/runtime/kubernetes/test_kubernetes_executor.py
 ##########
 @@ -142,9 +142,9 @@ def ensure_dag_expected_state(self, host, execution_date, dag_id,
         # Maybe check if we can retrieve the logs, but then we need to extend the API
 
     def start_dag(self, dag_id, host):
-        result = self.session.get(
+        result = self.session.post(
             'http://{host}/api/experimental/'
-            'dags/{dag_id}/paused/false'.format(host=host, dag_id=dag_id)
+            'dags/{dag_id}/pause/false'.format(host=host, dag_id=dag_id)
 
 Review comment:
   Let's change the name in a separate PR and keep this one limited to changing GET to POST please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] dimberman commented on issue #7761: [AIRFLOW-7086] /dags/paused should be a PUT

Posted by GitBox <gi...@apache.org>.
dimberman commented on issue #7761: [AIRFLOW-7086] /dags/paused should be a PUT
URL: https://github.com/apache/airflow/pull/7761#issuecomment-601443324
 
 
   @ashb do you have any idea why the k8s test is failing? It seems that the endpoint is returning a 404 so I'm trying to figure out if there's somewhere else I need to change as well
   
   ```
   ---------------------------- Captured stdout setup -----------------------------
   
   Skipping db initialization. Tests do not require database
   
   tests/runtime/kubernetes/test_kubernetes_executor.py F
   
   ____ TestKubernetesExecutor.test_integration_run_dag_with_scheduler_failure ____
   
   self = <tests.runtime.kubernetes.test_kubernetes_executor.TestKubernetesExecutor testMethod=test_integration_run_dag_with_scheduler_failure>
   
       def test_integration_run_dag_with_scheduler_failure(self):
   
           host = KUBERNETES_HOST
   
           dag_id = 'example_kubernetes_executor_config'
   
       
   
   >       result_json = self.start_dag(dag_id=dag_id, host=host)
   
   tests/runtime/kubernetes/test_kubernetes_executor.py:209: 
   
   _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
   
   tests/runtime/kubernetes/test_kubernetes_executor.py:155: in start_dag
   
       .format(result=result_json))
   
   E   AssertionError: 400 != 200 : Could not enable DAG: <Response [400]>```
   
   
   Here is the code
   
   ```
           result = self.session.put(
               'http://{host}/api/experimental/'
               'dags/{dag_id}/pause/false'.format(host=host, dag_id=dag_id)
           )
           try:
               result_json = result.json()
           except ValueError:
               result_json = str(result)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] dimberman edited a comment on issue #7761: [AIRFLOW-7086] /dags/paused should be a PUT

Posted by GitBox <gi...@apache.org>.
dimberman edited a comment on issue #7761: [AIRFLOW-7086] /dags/paused should be a PUT
URL: https://github.com/apache/airflow/pull/7761#issuecomment-601443324
 
 
   @ashb do you have any idea why the k8s test is failing? It seems that the endpoint is returning a 404 so I'm trying to figure out if there's somewhere else I need to change as well
   
   ```
   ---------------------------- Captured stdout setup -----------------------------
   
   Skipping db initialization. Tests do not require database
   
   tests/runtime/kubernetes/test_kubernetes_executor.py F
   
   ____ TestKubernetesExecutor.test_integration_run_dag_with_scheduler_failure ____
   
   self = <tests.runtime.kubernetes.test_kubernetes_executor.TestKubernetesExecutor testMethod=test_integration_run_dag_with_scheduler_failure>
   
       def test_integration_run_dag_with_scheduler_failure(self):
   
           host = KUBERNETES_HOST
   
           dag_id = 'example_kubernetes_executor_config'
   
       
   
   >       result_json = self.start_dag(dag_id=dag_id, host=host)
   
   tests/runtime/kubernetes/test_kubernetes_executor.py:209: 
   
   _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
   
   tests/runtime/kubernetes/test_kubernetes_executor.py:155: in start_dag
   
       .format(result=result_json))
   
   E   AssertionError: 400 != 200 : Could not enable DAG: <Response [400]>
   ```
   
   
   Here is the code
   
   ```
           result = self.session.put(
               'http://{host}/api/experimental/'
               'dags/{dag_id}/pause/false'.format(host=host, dag_id=dag_id)
           )
           try:
               result_json = result.json()
           except ValueError:
               result_json = str(result)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] dimberman commented on a change in pull request #7761: [AIRFLOW-7086] /dags/paused should be a PUT

Posted by GitBox <gi...@apache.org>.
dimberman commented on a change in pull request #7761: [AIRFLOW-7086] /dags/paused should be a PUT
URL: https://github.com/apache/airflow/pull/7761#discussion_r395353758
 
 

 ##########
 File path: tests/runtime/kubernetes/test_kubernetes_executor.py
 ##########
 @@ -142,9 +142,9 @@ def ensure_dag_expected_state(self, host, execution_date, dag_id,
         # Maybe check if we can retrieve the logs, but then we need to extend the API
 
     def start_dag(self, dag_id, host):
-        result = self.session.get(
+        result = self.session.post(
             'http://{host}/api/experimental/'
-            'dags/{dag_id}/paused/false'.format(host=host, dag_id=dag_id)
+            'dags/{dag_id}/pause/false'.format(host=host, dag_id=dag_id)
 
 Review comment:
   ok

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7761: [AIRFLOW-7086] /dags/paused should be a PUT

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7761: [AIRFLOW-7086] /dags/paused should be a PUT
URL: https://github.com/apache/airflow/pull/7761#issuecomment-601460503
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7761?src=pr&el=h1) Report
   > Merging [#7761](https://codecov.io/gh/apache/airflow/pull/7761?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/029c84e5527b6db6bdbdbe026f455da325bedef3&el=desc) will **decrease** coverage by `0.34%`.
   > The diff coverage is `84.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7761/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7761?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7761      +/-   ##
   ==========================================
   - Coverage   86.96%   86.61%   -0.35%     
   ==========================================
     Files         920      921       +1     
     Lines       44436    44471      +35     
   ==========================================
   - Hits        38644    38520     -124     
   - Misses       5792     5951     +159     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7761?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ers/google/cloud/example\_dags/example\_cloud\_sql.py](https://codecov.io/gh/apache/airflow/pull/7761/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2Nsb3VkX3NxbC5weQ==) | `100.00% <ø> (ø)` | |
   | [...ers/google/cloud/example\_dags/example\_gcs\_to\_bq.py](https://codecov.io/gh/apache/airflow/pull/7761/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2djc190b19icS5weQ==) | `100.00% <ø> (ø)` | |
   | [airflow/providers/google/cloud/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/7761/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL2F1dG9tbC5weQ==) | `88.52% <ø> (-1.03%)` | :arrow_down: |
   | [...rflow/providers/google/cloud/hooks/bigquery\_dts.py](https://codecov.io/gh/apache/airflow/pull/7761/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL2JpZ3F1ZXJ5X2R0cy5weQ==) | `79.31% <ø> (-1.34%)` | :arrow_down: |
   | [...ogle/cloud/hooks/cloud\_storage\_transfer\_service.py](https://codecov.io/gh/apache/airflow/pull/7761/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL2Nsb3VkX3N0b3JhZ2VfdHJhbnNmZXJfc2VydmljZS5weQ==) | `88.67% <ø> (-0.67%)` | :arrow_down: |
   | [...w/providers/google/cloud/hooks/natural\_language.py](https://codecov.io/gh/apache/airflow/pull/7761/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL25hdHVyYWxfbGFuZ3VhZ2UucHk=) | `100.00% <ø> (ø)` | |
   | [airflow/providers/google/cloud/hooks/tasks.py](https://codecov.io/gh/apache/airflow/pull/7761/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL3Rhc2tzLnB5) | `91.17% <ø> (-1.00%)` | :arrow_down: |
   | [airflow/providers/google/cloud/hooks/vision.py](https://codecov.io/gh/apache/airflow/pull/7761/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL3Zpc2lvbi5weQ==) | `87.04% <ø> (-0.89%)` | :arrow_down: |
   | [...flow/providers/google/cloud/operators/cloud\_sql.py](https://codecov.io/gh/apache/airflow/pull/7761/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9jbG91ZF9zcWwucHk=) | `84.68% <ø> (ø)` | |
   | [airflow/providers/google/cloud/operators/gcs.py](https://codecov.io/gh/apache/airflow/pull/7761/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9nY3MucHk=) | `85.71% <ø> (ø)` | |
   | ... and [38 more](https://codecov.io/gh/apache/airflow/pull/7761/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7761?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7761?src=pr&el=footer). Last update [029c84e...9c0b67c](https://codecov.io/gh/apache/airflow/pull/7761?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7761: [AIRFLOW-7086] /dags/paused should be a PUT

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7761: [AIRFLOW-7086] /dags/paused should be a PUT
URL: https://github.com/apache/airflow/pull/7761#discussion_r395352636
 
 

 ##########
 File path: tests/runtime/kubernetes/test_kubernetes_executor.py
 ##########
 @@ -142,9 +142,9 @@ def ensure_dag_expected_state(self, host, execution_date, dag_id,
         # Maybe check if we can retrieve the logs, but then we need to extend the API
 
     def start_dag(self, dag_id, host):
-        result = self.session.get(
+        result = self.session.post(
             'http://{host}/api/experimental/'
-            'dags/{dag_id}/paused/false'.format(host=host, dag_id=dag_id)
+            'dags/{dag_id}/pause/false'.format(host=host, dag_id=dag_id)
 
 Review comment:
   Why are we changing endpoint from `paused` to `pause`, is that intended?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] dimberman commented on a change in pull request #7761: [AIRFLOW-7086] /dags/paused should be a PUT

Posted by GitBox <gi...@apache.org>.
dimberman commented on a change in pull request #7761: [AIRFLOW-7086] /dags/paused should be a PUT
URL: https://github.com/apache/airflow/pull/7761#discussion_r395352903
 
 

 ##########
 File path: tests/runtime/kubernetes/test_kubernetes_executor.py
 ##########
 @@ -142,9 +142,9 @@ def ensure_dag_expected_state(self, host, execution_date, dag_id,
         # Maybe check if we can retrieve the logs, but then we need to extend the API
 
     def start_dag(self, dag_id, host):
-        result = self.session.get(
+        result = self.session.post(
             'http://{host}/api/experimental/'
-            'dags/{dag_id}/paused/false'.format(host=host, dag_id=dag_id)
+            'dags/{dag_id}/pause/false'.format(host=host, dag_id=dag_id)
 
 Review comment:
   @kaxil yes, because paused is a question, this is a directive.
   
   Paused is "is this dag paused?"
   
   Pause is "set this to paused"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7761: [AIRFLOW-7086] /dags/paused should be a PUT

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7761: [AIRFLOW-7086] /dags/paused should be a PUT
URL: https://github.com/apache/airflow/pull/7761#discussion_r395352156
 
 

 ##########
 File path: airflow/www/api/experimental/endpoints.py
 ##########
 @@ -184,13 +184,11 @@ def task_info(dag_id, task_id):
     return jsonify(fields)
 
 
-# ToDo: Shouldn't this be a PUT method?
-@api_experimental.route('/dags/<string:dag_id>/paused/<string:paused>', methods=['GET'])
+@api_experimental.route('/dags/<string:dag_id>/pause/<string:pause_state>', methods=['POST'])
 
 Review comment:
   ```suggestion
   @api_experimental.route('/dags/<string:dag_id>/paused/<string:pause_state>', methods=['POST'])
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7761: [AIRFLOW-7086] /dags/paused should be a PUT

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7761: [AIRFLOW-7086] /dags/paused should be a PUT
URL: https://github.com/apache/airflow/pull/7761#issuecomment-601460503
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7761?src=pr&el=h1) Report
   > Merging [#7761](https://codecov.io/gh/apache/airflow/pull/7761?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/029c84e5527b6db6bdbdbe026f455da325bedef3&el=desc) will **decrease** coverage by `0.34%`.
   > The diff coverage is `84.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7761/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7761?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7761      +/-   ##
   ==========================================
   - Coverage   86.96%   86.61%   -0.35%     
   ==========================================
     Files         920      921       +1     
     Lines       44436    44471      +35     
   ==========================================
   - Hits        38644    38520     -124     
   - Misses       5792     5951     +159     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7761?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ers/google/cloud/example\_dags/example\_cloud\_sql.py](https://codecov.io/gh/apache/airflow/pull/7761/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2Nsb3VkX3NxbC5weQ==) | `100.00% <ø> (ø)` | |
   | [...ers/google/cloud/example\_dags/example\_gcs\_to\_bq.py](https://codecov.io/gh/apache/airflow/pull/7761/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2djc190b19icS5weQ==) | `100.00% <ø> (ø)` | |
   | [airflow/providers/google/cloud/hooks/automl.py](https://codecov.io/gh/apache/airflow/pull/7761/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL2F1dG9tbC5weQ==) | `88.52% <ø> (-1.03%)` | :arrow_down: |
   | [...rflow/providers/google/cloud/hooks/bigquery\_dts.py](https://codecov.io/gh/apache/airflow/pull/7761/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL2JpZ3F1ZXJ5X2R0cy5weQ==) | `79.31% <ø> (-1.34%)` | :arrow_down: |
   | [...ogle/cloud/hooks/cloud\_storage\_transfer\_service.py](https://codecov.io/gh/apache/airflow/pull/7761/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL2Nsb3VkX3N0b3JhZ2VfdHJhbnNmZXJfc2VydmljZS5weQ==) | `88.67% <ø> (-0.67%)` | :arrow_down: |
   | [...w/providers/google/cloud/hooks/natural\_language.py](https://codecov.io/gh/apache/airflow/pull/7761/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL25hdHVyYWxfbGFuZ3VhZ2UucHk=) | `100.00% <ø> (ø)` | |
   | [airflow/providers/google/cloud/hooks/tasks.py](https://codecov.io/gh/apache/airflow/pull/7761/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL3Rhc2tzLnB5) | `91.17% <ø> (-1.00%)` | :arrow_down: |
   | [airflow/providers/google/cloud/hooks/vision.py](https://codecov.io/gh/apache/airflow/pull/7761/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL3Zpc2lvbi5weQ==) | `87.04% <ø> (-0.89%)` | :arrow_down: |
   | [...flow/providers/google/cloud/operators/cloud\_sql.py](https://codecov.io/gh/apache/airflow/pull/7761/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9jbG91ZF9zcWwucHk=) | `84.68% <ø> (ø)` | |
   | [airflow/providers/google/cloud/operators/gcs.py](https://codecov.io/gh/apache/airflow/pull/7761/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9nY3MucHk=) | `85.71% <ø> (ø)` | |
   | ... and [38 more](https://codecov.io/gh/apache/airflow/pull/7761/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7761?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7761?src=pr&el=footer). Last update [029c84e...9c0b67c](https://codecov.io/gh/apache/airflow/pull/7761?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] dimberman commented on a change in pull request #7761: [AIRFLOW-7086] /dags/paused should be a PUT

Posted by GitBox <gi...@apache.org>.
dimberman commented on a change in pull request #7761: [AIRFLOW-7086] /dags/paused should be a PUT
URL: https://github.com/apache/airflow/pull/7761#discussion_r395352595
 
 

 ##########
 File path: airflow/www/api/experimental/endpoints.py
 ##########
 @@ -184,13 +184,11 @@ def task_info(dag_id, task_id):
     return jsonify(fields)
 
 
-# ToDo: Shouldn't this be a PUT method?
-@api_experimental.route('/dags/<string:dag_id>/paused/<string:paused>', methods=['GET'])
+@api_experimental.route('/dags/<string:dag_id>/pause/<string:pause_state>', methods=['POST'])
 
 Review comment:
   @kaxil Why paused? It seems if we are asking it to do a thing that should be in present tense, no?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #7761: [AIRFLOW-7086] /dags/paused should be a PUT

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7761: [AIRFLOW-7086] /dags/paused should be a PUT
URL: https://github.com/apache/airflow/pull/7761#discussion_r395348576
 
 

 ##########
 File path: airflow/www/api/experimental/endpoints.py
 ##########
 @@ -184,13 +184,11 @@ def task_info(dag_id, task_id):
     return jsonify(fields)
 
 
-# ToDo: Shouldn't this be a PUT method?
-@api_experimental.route('/dags/<string:dag_id>/paused/<string:paused>', methods=['GET'])
+@api_experimental.route('/dags/<string:dag_id>/pause/<string:pause_state>', methods=['PUT'])
 
 Review comment:
   POST is more typical here -- it's not wrong here, but I don't think we use PUT anywhere else in the current experimental API do we?
   
   Can you also add a note to UPDATING.md, and then we can pull this in to 1.10.10

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services