You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by ijuma <gi...@git.apache.org> on 2017/11/24 13:59:20 UTC

[GitHub] kafka pull request #4261: MINOR: Avoid intermediate strings when parsing/dec...

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/4261

    MINOR: Avoid intermediate strings when parsing/decoding ZK JSON

    Also:
    - Fix bug in result type of `createSequentialPersistentPath`
    - Remove duplicated code from `ReplicationUtils`
    - Move `propagateIsrChanges` from `ReplicationUtils` to `KafkaZkClient`
    - Add tests
    - Minor clean-ups
    
    ### Committer Checklist (excluded from commit message)
    - [ ] Verify design and implementation 
    - [ ] Verify test coverage and CI build status
    - [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka zk-data-improvements

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4261.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4261
    
----
commit df33ed9ef331931cc32a5310d2717f1c65fae202
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-11-24T12:52:06Z

    Avoid intermediate Strings when parsing/encoding JSON

commit 2e7f1913fde1a5a041e382e21d6355c322815b97
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-11-24T12:52:34Z

    Minor clean-ups

commit fc2c8f8f153ec6a01477445c426115687680b7bd
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-11-24T13:18:09Z

    Add test for `createSequentialPersistentPath` and fix bug

commit 8296e3e98121fadacdff00def7277c2f852b8079
Author: Ismael Juma <is...@juma.me.uk>
Date:   2017-11-24T13:55:39Z

    Remove isr change duplication and more tests

----


---

[GitHub] kafka pull request #4261: MINOR: Avoid intermediate strings when parsing/dec...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/4261


---