You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/02 16:46:39 UTC

[GitHub] [flink] becketqin commented on pull request #11554: [FLINK-15101][connector/common] Add SourceCoordinator implementation.

becketqin commented on pull request #11554:
URL: https://github.com/apache/flink/pull/11554#issuecomment-622981830


   Thanks for the review @StephanEwen. I just updated the patch. 
   
   Re: (1) Yes, keeping the code style consistent make sense. I did not find `DataOutputStream`, though. Do you mean `DataOutputViewStreamWrapper`?
   
   Re: (2) Sounds good to me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org