You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2012/11/14 01:45:57 UTC

Review Request: Temporary fix for binary JSON data.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8044/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Vinod Kone.


Description
-------

At twitter, we had an executor using binary data in the TaskInfo.data field. Since we can't encode unicode / binary data, this breaks the JSON endpoint and the webui.

This change is a short term fix to not dump that data from our JSON endpoints.
I say short term because in the longer term, we should use a unicode library to fix our JSON encoding.


Diffs
-----

  src/slave/http.cpp b94197013ac0d5dd95d6dabb44812905a123184a 

Diff: https://reviews.apache.org/r/8044/diff/


Testing
-------

None.


Thanks,

Ben Mahler

Re: Review Request: Temporary fix for binary JSON data.

Posted by Ben Mahler <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8044/
-----------------------------------------------------------

(Updated Nov. 14, 2012, 12:46 a.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Description
-------

At twitter, we had an executor using binary data in the TaskInfo.data field. Since we can't encode unicode / binary data, this breaks the JSON endpoint and the webui.

This change is a short term fix to not dump that data from our JSON endpoints.
I say short term because in the longer term, we should use a unicode library to fix our JSON encoding.


Diffs
-----

  src/slave/http.cpp b94197013ac0d5dd95d6dabb44812905a123184a 

Diff: https://reviews.apache.org/r/8044/diff/


Testing
-------

None.


Thanks,

Ben Mahler