You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Johan Oskarsson (JIRA)" <ji...@apache.org> on 2008/10/23 11:42:44 UTC
[jira] Created: (HADOOP-4504) Adapt chukwa code to hadoop codestyle
Adapt chukwa code to hadoop codestyle
-------------------------------------
Key: HADOOP-4504
URL: https://issues.apache.org/jira/browse/HADOOP-4504
Project: Hadoop Core
Issue Type: Improvement
Components: contrib/chukwa
Reporter: Johan Oskarsson
Priority: Trivial
It seems large parts of the Chukwa code doesn't conform to the Hadoop code style, we should reformat it to fit the rest of the project.
"Code should be formatted according to Sun's conventions, with one exception: Indent two spaces per level, not four."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4504) Adapt chukwa code to hadoop
codestyle
Posted by "Ari Rabkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676850#action_12676850 ]
Ari Rabkin commented on HADOOP-4504:
------------------------------------
I'm tempted to starting dealing with this issue fairly soon. Once Chukwa is its own subproject, I was thinking to just do a big automated reformat locally, then commit. Is that unwise? What's the right way to deal with this sort of thing?
> Adapt chukwa code to hadoop codestyle
> -------------------------------------
>
> Key: HADOOP-4504
> URL: https://issues.apache.org/jira/browse/HADOOP-4504
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Reporter: Johan Oskarsson
> Priority: Trivial
>
> It seems large parts of the Chukwa code doesn't conform to the Hadoop code style, we should reformat it to fit the rest of the project.
> "Code should be formatted according to Sun's conventions, with one exception: Indent two spaces per level, not four."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4504) Adapt chukwa code to hadoop
codestyle
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642125#action_12642125 ]
Johan Oskarsson commented on HADOOP-4504:
-----------------------------------------
I'm assuming the contrib directories should conform to the Hadoop guidelines, if not please close this issue.
> Adapt chukwa code to hadoop codestyle
> -------------------------------------
>
> Key: HADOOP-4504
> URL: https://issues.apache.org/jira/browse/HADOOP-4504
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Reporter: Johan Oskarsson
> Priority: Trivial
>
> It seems large parts of the Chukwa code doesn't conform to the Hadoop code style, we should reformat it to fit the rest of the project.
> "Code should be formatted according to Sun's conventions, with one exception: Indent two spaces per level, not four."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4504) Adapt chukwa code to hadoop
codestyle
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677060#action_12677060 ]
Doug Cutting commented on HADOOP-4504:
--------------------------------------
> What's the right way to deal with this sort of thing?
Doing it as a single commit in a separate issue is probably best. It unfortunately confuses tools like 'svn blame', making it harder to find the origin of a line of code, but it's better to get it done sooner than later.
> Adapt chukwa code to hadoop codestyle
> -------------------------------------
>
> Key: HADOOP-4504
> URL: https://issues.apache.org/jira/browse/HADOOP-4504
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/chukwa
> Reporter: Johan Oskarsson
> Priority: Trivial
>
> It seems large parts of the Chukwa code doesn't conform to the Hadoop code style, we should reformat it to fit the rest of the project.
> "Code should be formatted according to Sun's conventions, with one exception: Indent two spaces per level, not four."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.