You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by tdas <gi...@git.apache.org> on 2016/02/11 05:17:50 UTC
[GitHub] spark pull request: [STREAMING][TEST] Fix flaky streaming.FailureS...
GitHub user tdas opened a pull request:
https://github.com/apache/spark/pull/11166
[STREAMING][TEST] Fix flaky streaming.FailureSuite
Under some corner cases, the test suite failed to shutdown the SparkContext causing cascaded failures.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tdas/spark fix-failuresuite
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11166.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11166
----
commit abaabb99b4d4cb118879f85adc69160d6b9a011a
Author: Tathagata Das <ta...@gmail.com>
Date: 2016-02-11T04:13:02Z
Fix flakiness
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [STREAMING][TEST] Fix flaky streaming.FailureS...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11166#issuecomment-182719929
**[Test build #51079 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51079/consoleFull)** for PR 11166 at commit [`abaabb9`](https://github.com/apache/spark/commit/abaabb99b4d4cb118879f85adc69160d6b9a011a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [STREAMING][TEST] Fix flaky streaming.FailureS...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11166#issuecomment-182700800
**[Test build #51079 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51079/consoleFull)** for PR 11166 at commit [`abaabb9`](https://github.com/apache/spark/commit/abaabb99b4d4cb118879f85adc69160d6b9a011a).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [STREAMING][TEST] Fix flaky streaming.FailureS...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/11166#discussion_r52564904
--- Diff: streaming/src/test/scala/org/apache/spark/streaming/FailureSuite.scala ---
@@ -43,6 +43,9 @@ class FailureSuite extends SparkFunSuite with BeforeAndAfter with Logging {
Utils.deleteRecursively(directory)
}
StreamingContext.getActive().foreach { _.stop() }
+
+ // Stop SparkContext if active
+ SparkContext.getOrCreate(new SparkConf().setMaster("local").setAppName("bla")).stop()
--- End diff --
could you explain where leaks `SparkContext`? I cannot find any clue from the log
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [STREAMING][TEST] Fix flaky streaming.FailureS...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/11166#issuecomment-182982724
LGTM. Merging to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [STREAMING][TEST] Fix flaky streaming.FailureS...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11166#issuecomment-182719984
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [STREAMING][TEST] Fix flaky streaming.FailureS...
Posted by tdas <gi...@git.apache.org>.
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/11166#discussion_r52604381
--- Diff: streaming/src/test/scala/org/apache/spark/streaming/FailureSuite.scala ---
@@ -43,6 +43,9 @@ class FailureSuite extends SparkFunSuite with BeforeAndAfter with Logging {
Utils.deleteRecursively(directory)
}
StreamingContext.getActive().foreach { _.stop() }
+
+ // Stop SparkContext if active
+ SparkContext.getOrCreate(new SparkConf().setMaster("local").setAppName("bla")).stop()
--- End diff --
I am not entirely sure. I think somehow a StreamingContext is not shutdown cleanly, which causes the SparkContext to leak. This fix at least prevents the issue to cascade to other testsuites.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [STREAMING][TEST] Fix flaky streaming.FailureS...
Posted by tdas <gi...@git.apache.org>.
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/11166#issuecomment-182695516
@zsxwing Could you take a look at this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [STREAMING][TEST] Fix flaky streaming.FailureS...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11166
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [STREAMING][TEST] Fix flaky streaming.FailureS...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11166#issuecomment-182719985
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51079/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org