You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/04/01 17:58:05 UTC

[jira] [Work logged] (HIVE-21279) Avoid moving/rename operation in FileSink op for SELECT queries

     [ https://issues.apache.org/jira/browse/HIVE-21279?focusedWorklogId=221382&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221382 ]

ASF GitHub Bot logged work on HIVE-21279:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Apr/19 17:57
            Start Date: 01/Apr/19 17:57
    Worklog Time Spent: 10m 
      Work Description: jdere commented on pull request #582: Hive 21386: Extend the fetch task enhancement done in HIVE-21279 to make it work with query result cache
URL: https://github.com/apache/hive/pull/582#discussion_r270975672
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
 ##########
 @@ -15072,13 +15093,13 @@ private boolean queryTypeCanUseCache() {
       return false;
     }
 
-    if (qb.getParseInfo().isAnalyzeCommand()) {
-      return false;
-    }
+      if (qb.getParseInfo().isAnalyzeCommand()) {
 
 Review comment:
   What are these whitespace changes for? Was the nesting bad before?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 221382)
    Time Spent: 40m  (was: 0.5h)

> Avoid moving/rename operation in FileSink op for SELECT queries
> ---------------------------------------------------------------
>
>                 Key: HIVE-21279
>                 URL: https://issues.apache.org/jira/browse/HIVE-21279
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Planning
>            Reporter: Vineet Garg
>            Assignee: Vineet Garg
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>         Attachments: HIVE-21279.1.patch, HIVE-21279.10.patch, HIVE-21279.11.patch, HIVE-21279.12.patch, HIVE-21279.13.patch, HIVE-21279.2.patch, HIVE-21279.3.patch, HIVE-21279.4.patch, HIVE-21279.5.patch, HIVE-21279.6.patch, HIVE-21279.7.patch, HIVE-21279.8.patch, HIVE-21279.9.patch
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Currently at the end of a job FileSink operator moves/rename temp directory to another directory from which FetchTask fetches result. This is done to avoid fetching potential partial/invalid files by failed/runway tasks. This operation is expensive for cloud storage. It could be avoided if FetchTask is passed on set of files to read from instead of whole directory.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)