You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/02/28 00:15:59 UTC
[GitHub] [incubator-tvm] tqchen edited a comment on issue #4960:
[Relay][Pass] Add submodule extraction pass
tqchen edited a comment on issue #4960: [Relay][Pass] Add submodule extraction pass
URL: https://github.com/apache/incubator-tvm/pull/4960#issuecomment-592243459
Thanks @anwang2009 , it would be great to discuss where do we want to put the related features. We can either treat is as a transform pass, or analysis pass.
- T0: we should make it ```relay.analysis.extract_primitive_tasks```
- T1: in the later case, we might want to make it as a ModulePass, and make it return a single IRModule, whose top-level functions are the the-deduplicated function that is extracted.
In both cases, given that this is a new feature that others can reuse, perhaps we should open a discuss forum RFC post to describe the motivation a bit and API setups
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services