You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/10/30 06:09:57 UTC

Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27371/
-----------------------------------------------------------

Review request for Aurora, Joshua Cohen and Maxim Khutornenko.


Bugs: AURORA-884
    https://issues.apache.org/jira/browse/AURORA-884


Repository: aurora


Description
-------

This change also alters the coverage check, which would always trip for anonymous classes like `TypeLiteral` and `Clazz`.


Diffs
-----

  buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy 06d25c065b5c4272ccc011bd884440b2201b5782 
  config/legacy_untested_classes.txt 542ac31996d76fd4ab4e0583a737496c0e217a50 
  src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 90b26e573e530950314b28a47121acc5195e2f94 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 31498fae3e24a38e723c83ae44543b5d806c0795 
  src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java abf6868b34a2fe68a4fd2a0268a6ca2e0d518c83 
  src/test/java/org/apache/aurora/scheduler/testing/FakeStatsProvider.java 273129eb1f00ed8e116fba405e5db6a5a6170a8b 
  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 61b6b8e872120a0106141f9fd7527d71d282624d 

Diff: https://reviews.apache.org/r/27371/diff/


Testing
-------


Thanks,

Bill Farner

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

Posted by Bill Farner <wf...@apache.org>.

> On Oct. 30, 2014, 5 p.m., Joshua Cohen wrote:
> > src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java, line 58
> > <https://reviews.apache.org/r/27371/diff/1/?file=742675#file742675line58>
> >
> >     Each test is invoking this method, then accessing the injector instance var. Nothing else accesses that var though; can you have this return the injector instead?

Good call, done.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27371/#review59224
-----------------------------------------------------------


On Oct. 30, 2014, 5:09 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27371/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 5:09 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-884
>     https://issues.apache.org/jira/browse/AURORA-884
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This change also alters the coverage check, which would always trip for anonymous classes like `TypeLiteral` and `Clazz`.
> 
> 
> Diffs
> -----
> 
>   buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy 06d25c065b5c4272ccc011bd884440b2201b5782 
>   config/legacy_untested_classes.txt 542ac31996d76fd4ab4e0583a737496c0e217a50 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 90b26e573e530950314b28a47121acc5195e2f94 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 31498fae3e24a38e723c83ae44543b5d806c0795 
>   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java abf6868b34a2fe68a4fd2a0268a6ca2e0d518c83 
>   src/test/java/org/apache/aurora/scheduler/testing/FakeStatsProvider.java 273129eb1f00ed8e116fba405e5db6a5a6170a8b 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 61b6b8e872120a0106141f9fd7527d71d282624d 
> 
> Diff: https://reviews.apache.org/r/27371/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27371/#review59224
-----------------------------------------------------------

Ship it!



src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java
<https://reviews.apache.org/r/27371/#comment100502>

    Each test is invoking this method, then accessing the injector instance var. Nothing else accesses that var though; can you have this return the injector instead?


- Joshua Cohen


On Oct. 30, 2014, 5:09 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27371/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 5:09 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-884
>     https://issues.apache.org/jira/browse/AURORA-884
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This change also alters the coverage check, which would always trip for anonymous classes like `TypeLiteral` and `Clazz`.
> 
> 
> Diffs
> -----
> 
>   buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy 06d25c065b5c4272ccc011bd884440b2201b5782 
>   config/legacy_untested_classes.txt 542ac31996d76fd4ab4e0583a737496c0e217a50 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 90b26e573e530950314b28a47121acc5195e2f94 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 31498fae3e24a38e723c83ae44543b5d806c0795 
>   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java abf6868b34a2fe68a4fd2a0268a6ca2e0d518c83 
>   src/test/java/org/apache/aurora/scheduler/testing/FakeStatsProvider.java 273129eb1f00ed8e116fba405e5db6a5a6170a8b 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 61b6b8e872120a0106141f9fd7527d71d282624d 
> 
> Diff: https://reviews.apache.org/r/27371/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27371/#review59412
-----------------------------------------------------------

Ship it!


Master (02a1c04) is green with this patch.
  ./build-support/jenkins/build.sh

- Aurora ReviewBot


On Oct. 31, 2014, 8:31 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27371/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2014, 8:31 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-884
>     https://issues.apache.org/jira/browse/AURORA-884
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This change also alters the coverage check, which would always trip for anonymous classes like `TypeLiteral` and `Clazz`.
> 
> 
> Diffs
> -----
> 
>   buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy 06d25c065b5c4272ccc011bd884440b2201b5782 
>   config/legacy_untested_classes.txt 542ac31996d76fd4ab4e0583a737496c0e217a50 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 90b26e573e530950314b28a47121acc5195e2f94 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 31498fae3e24a38e723c83ae44543b5d806c0795 
>   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java abf6868b34a2fe68a4fd2a0268a6ca2e0d518c83 
>   src/test/java/org/apache/aurora/scheduler/testing/FakeStatsProvider.java 273129eb1f00ed8e116fba405e5db6a5a6170a8b 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 61b6b8e872120a0106141f9fd7527d71d282624d 
> 
> Diff: https://reviews.apache.org/r/27371/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27371/
-----------------------------------------------------------

(Updated Oct. 31, 2014, 8:31 p.m.)


Review request for Aurora, Joshua Cohen and Maxim Khutornenko.


Bugs: AURORA-884
    https://issues.apache.org/jira/browse/AURORA-884


Repository: aurora


Description
-------

This change also alters the coverage check, which would always trip for anonymous classes like `TypeLiteral` and `Clazz`.


Diffs (updated)
-----

  buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy 06d25c065b5c4272ccc011bd884440b2201b5782 
  config/legacy_untested_classes.txt 542ac31996d76fd4ab4e0583a737496c0e217a50 
  src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 90b26e573e530950314b28a47121acc5195e2f94 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 31498fae3e24a38e723c83ae44543b5d806c0795 
  src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java abf6868b34a2fe68a4fd2a0268a6ca2e0d518c83 
  src/test/java/org/apache/aurora/scheduler/testing/FakeStatsProvider.java 273129eb1f00ed8e116fba405e5db6a5a6170a8b 
  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 61b6b8e872120a0106141f9fd7527d71d282624d 

Diff: https://reviews.apache.org/r/27371/diff/


Testing
-------


Thanks,

Bill Farner

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

Posted by Bill Farner <wf...@apache.org>.

> On Oct. 30, 2014, 5:29 p.m., Kevin Sweeney wrote:
> > buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy, line 89
> > <https://reviews.apache.org/r/27371/diff/1/?file=742671#file742671line89>
> >
> >     looks like your sentence got cut off here - the legacyClassesWithoutCoverage file?

added ' list' to match the message below


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27371/#review59232
-----------------------------------------------------------


On Oct. 30, 2014, 5:09 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27371/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 5:09 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-884
>     https://issues.apache.org/jira/browse/AURORA-884
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This change also alters the coverage check, which would always trip for anonymous classes like `TypeLiteral` and `Clazz`.
> 
> 
> Diffs
> -----
> 
>   buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy 06d25c065b5c4272ccc011bd884440b2201b5782 
>   config/legacy_untested_classes.txt 542ac31996d76fd4ab4e0583a737496c0e217a50 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 90b26e573e530950314b28a47121acc5195e2f94 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 31498fae3e24a38e723c83ae44543b5d806c0795 
>   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java abf6868b34a2fe68a4fd2a0268a6ca2e0d518c83 
>   src/test/java/org/apache/aurora/scheduler/testing/FakeStatsProvider.java 273129eb1f00ed8e116fba405e5db6a5a6170a8b 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 61b6b8e872120a0106141f9fd7527d71d282624d 
> 
> Diff: https://reviews.apache.org/r/27371/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27371/#review59232
-----------------------------------------------------------

Ship it!



buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy
<https://reviews.apache.org/r/27371/#comment100511>

    looks like your sentence got cut off here - the legacyClassesWithoutCoverage file?


- Kevin Sweeney


On Oct. 29, 2014, 10:09 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27371/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2014, 10:09 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-884
>     https://issues.apache.org/jira/browse/AURORA-884
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This change also alters the coverage check, which would always trip for anonymous classes like `TypeLiteral` and `Clazz`.
> 
> 
> Diffs
> -----
> 
>   buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy 06d25c065b5c4272ccc011bd884440b2201b5782 
>   config/legacy_untested_classes.txt 542ac31996d76fd4ab4e0583a737496c0e217a50 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 90b26e573e530950314b28a47121acc5195e2f94 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 31498fae3e24a38e723c83ae44543b5d806c0795 
>   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java abf6868b34a2fe68a4fd2a0268a6ca2e0d518c83 
>   src/test/java/org/apache/aurora/scheduler/testing/FakeStatsProvider.java 273129eb1f00ed8e116fba405e5db6a5a6170a8b 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 61b6b8e872120a0106141f9fd7527d71d282624d 
> 
> Diff: https://reviews.apache.org/r/27371/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27371/#review59140
-----------------------------------------------------------

Ship it!


Master (d85e616) is green with this patch.
  ./build-support/jenkins/build.sh

- Aurora ReviewBot


On Oct. 30, 2014, 5:09 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27371/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 5:09 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-884
>     https://issues.apache.org/jira/browse/AURORA-884
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This change also alters the coverage check, which would always trip for anonymous classes like `TypeLiteral` and `Clazz`.
> 
> 
> Diffs
> -----
> 
>   buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy 06d25c065b5c4272ccc011bd884440b2201b5782 
>   config/legacy_untested_classes.txt 542ac31996d76fd4ab4e0583a737496c0e217a50 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 90b26e573e530950314b28a47121acc5195e2f94 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 31498fae3e24a38e723c83ae44543b5d806c0795 
>   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java abf6868b34a2fe68a4fd2a0268a6ca2e0d518c83 
>   src/test/java/org/apache/aurora/scheduler/testing/FakeStatsProvider.java 273129eb1f00ed8e116fba405e5db6a5a6170a8b 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 61b6b8e872120a0106141f9fd7527d71d282624d 
> 
> Diff: https://reviews.apache.org/r/27371/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

Posted by Bill Farner <wf...@apache.org>.

> On Oct. 30, 2014, 3:48 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, line 212
> > <https://reviews.apache.org/r/27371/diff/1/?file=742673#file742673line212>
> >
> >     s/public//

Done.  I also realized the constructor injection was a hack, refactored to us a startup action so this actually works with the bound StatsProvider.


> On Oct. 30, 2014, 3:48 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, line 243
> > <https://reviews.apache.org/r/27371/diff/1/?file=742673#file742673line243>
> >
> >     Any reason it has to be Number here?

s/Number/Long/


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27371/#review59206
-----------------------------------------------------------


On Oct. 30, 2014, 5:09 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27371/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 5:09 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-884
>     https://issues.apache.org/jira/browse/AURORA-884
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This change also alters the coverage check, which would always trip for anonymous classes like `TypeLiteral` and `Clazz`.
> 
> 
> Diffs
> -----
> 
>   buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy 06d25c065b5c4272ccc011bd884440b2201b5782 
>   config/legacy_untested_classes.txt 542ac31996d76fd4ab4e0583a737496c0e217a50 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 90b26e573e530950314b28a47121acc5195e2f94 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 31498fae3e24a38e723c83ae44543b5d806c0795 
>   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java abf6868b34a2fe68a4fd2a0268a6ca2e0d518c83 
>   src/test/java/org/apache/aurora/scheduler/testing/FakeStatsProvider.java 273129eb1f00ed8e116fba405e5db6a5a6170a8b 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 61b6b8e872120a0106141f9fd7527d71d282624d 
> 
> Diff: https://reviews.apache.org/r/27371/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27371/#review59206
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java
<https://reviews.apache.org/r/27371/#comment100489>

    s/public//



src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java
<https://reviews.apache.org/r/27371/#comment100487>

    Any reason it has to be Number here?


- Maxim Khutornenko


On Oct. 30, 2014, 5:09 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27371/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 5:09 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-884
>     https://issues.apache.org/jira/browse/AURORA-884
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This change also alters the coverage check, which would always trip for anonymous classes like `TypeLiteral` and `Clazz`.
> 
> 
> Diffs
> -----
> 
>   buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy 06d25c065b5c4272ccc011bd884440b2201b5782 
>   config/legacy_untested_classes.txt 542ac31996d76fd4ab4e0583a737496c0e217a50 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 90b26e573e530950314b28a47121acc5195e2f94 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 31498fae3e24a38e723c83ae44543b5d806c0795 
>   src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java abf6868b34a2fe68a4fd2a0268a6ca2e0d518c83 
>   src/test/java/org/apache/aurora/scheduler/testing/FakeStatsProvider.java 273129eb1f00ed8e116fba405e5db6a5a6170a8b 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 61b6b8e872120a0106141f9fd7527d71d282624d 
> 
> Diff: https://reviews.apache.org/r/27371/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>