You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Bruce Atherton <br...@callenish.com> on 2002/05/30 06:47:16 UTC
[PATCH] Core Selector Tests
Container and custom selector tests to come later.
Log:
Unit tests for core selectors, along with some minor bug fixes for problems
discovered when writing the tests.
Re: [PATCH] Core Selector Tests
Posted by Bruce Atherton <br...@callenish.com>.
At 05:01 PM 5/30/2002 -0400, Erik Hatcher wrote:
>Bruce,
>
>I'm going to apply your patches, but I'm getting this:
>
>Testcase:
>testSelectionBehaviour(org.apache.tools.ant.types.selectors.DateSelect
>orTest): FAILED
>expected:<TTFFTFFFTTTT> but was:<TFFFFFFFFFFT>
>junit.framework.AssertionFailedError: expected:<TTFFTFFFTTTT> but
>was:<TFFFFFFFF
>FFT>
> at junit.framework.Assert.fail(Assert.java:51)
> at junit.framework.Assert.failNotEquals(Assert.java:234)
> at junit.framework.Assert.assertEquals(Assert.java:68)
> at junit.framework.Assert.assertEquals(Assert.java:75)
> at
>org.apache.tools.ant.types.selectors.DateSelectorTest.testSelectionBe
>haviour(DateSelectorTest.java:194)
Well, at least the tests are working as they should. It passes on my
platform, which is Debian Linux running JDK 1.3.1_02. The problem is
platform specific.
This test is explicitly setting the number of milliseconds since January
1st, 1970 to 1006347300000L and checking for files which have exactly the
same lastModified() timestamp. Now that I think of it, doesn't Windows have
a 2 second granularity to its file system? I'm guessing the test failed for
you on a Windows box. This failure is telling me that we need a granularity
attribute on DateSelector in addition to DependSelector.
I'll whip up a patch to add this attribute and try to get it out tonight. I
should probably set the default granularity to 2000 on Windows systems, 0
on everything else. If the patch is too late for Beta 2, you can just
comment out the assertion on line 194 of DateSelectorTest and I'll get it
all fixed up afterwards.
Thanks.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
RE: [PATCH] Core Selector Tests
Posted by John Morrison <jo...@ntlworld.com>.
It should have zero side effects for non-cygwin users.
System.getProperties(<name>,<default>)
so if it can't get cygwin.user.home (which is only set under
cygwin) it defaults to System.getProperties("user.home")
which is the current behaviour.
I did wonder if there was a way to pass arguments specific
to ant (ie, didn't clash with user -D options), but I couldn't
find one...?
J.
> -----Original Message-----
> From: Erik Hatcher [mailto:jakarta-ant@ehatchersolutions.com]
> Sent: Friday, 31 May 2002 6:29 pm
> To: Ant Developers List
> Subject: Re: [PATCH] Core Selector Tests
>
>
> I was concerned about the patch and how it sets ANT_OPTS. Does this work
> fine for non-cygwin users?
>
>
> ----- Original Message -----
> From: "Diane Holt" <ho...@yahoo.com>
> To: "Ant Developers List" <an...@jakarta.apache.org>
> Sent: Friday, May 31, 2002 12:59 PM
> Subject: Re: [PATCH] Core Selector Tests
>
>
> > --- Magesh Umasankar <um...@apache.org> wrote:
> > > You have 5 hours for the 11th hour, Bruce ;-)
> >
> > Magesh,
> >
> > What do you think about John's patch to set a cygwin.user.home property
> > and its companion changes to the CVS stuff? I think it's probably fine,
> > and I think Stefan thought so as well, and I don't think there are any
> > objections from anyone else. If you're okay with it, would you
> (or one of
> > the other committers) be able to apply it and run the tests?
> (I'm kind of
> > time-crunched today, so I don't think I'd have time to do it.)
> >
> > Diane
> >
> > =====
> > (holtdl@yahoo.com)
> >
> >
> >
> > __________________________________________________
> > Do You Yahoo!?
> > Yahoo! - Official partner of 2002 FIFA World Cup
> > http://fifaworldcup.yahoo.com
> >
> > --
> > To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] Core Selector Tests
Posted by Diane Holt <ho...@yahoo.com>.
--- Erik Hatcher <ja...@ehatchersolutions.com> wrote:
> I was concerned about the patch and how it sets ANT_OPTS. Does this
> work fine for non-cygwin users?
It looked to me like that addition was within the if on $cygwin.
Diane
=====
(holtdl@yahoo.com)
__________________________________________________
Do You Yahoo!?
Yahoo! - Official partner of 2002 FIFA World Cup
http://fifaworldcup.yahoo.com
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] Core Selector Tests
Posted by Erik Hatcher <ja...@ehatchersolutions.com>.
I was concerned about the patch and how it sets ANT_OPTS. Does this work
fine for non-cygwin users?
----- Original Message -----
From: "Diane Holt" <ho...@yahoo.com>
To: "Ant Developers List" <an...@jakarta.apache.org>
Sent: Friday, May 31, 2002 12:59 PM
Subject: Re: [PATCH] Core Selector Tests
> --- Magesh Umasankar <um...@apache.org> wrote:
> > You have 5 hours for the 11th hour, Bruce ;-)
>
> Magesh,
>
> What do you think about John's patch to set a cygwin.user.home property
> and its companion changes to the CVS stuff? I think it's probably fine,
> and I think Stefan thought so as well, and I don't think there are any
> objections from anyone else. If you're okay with it, would you (or one of
> the other committers) be able to apply it and run the tests? (I'm kind of
> time-crunched today, so I don't think I'd have time to do it.)
>
> Diane
>
> =====
> (holtdl@yahoo.com)
>
>
>
> __________________________________________________
> Do You Yahoo!?
> Yahoo! - Official partner of 2002 FIFA World Cup
> http://fifaworldcup.yahoo.com
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] Core Selector Tests
Posted by Magesh Umasankar <um...@apache.org>.
I am planning to commit it.
Cheers,
Magesh
*************************************************
* Politician: One who shakes your hand before *
* elections and your confidence after. *
*************************************************
----- Original Message -----
From: "Diane Holt" <ho...@yahoo.com>
To: "Ant Developers List" <an...@jakarta.apache.org>
Sent: Friday, May 31, 2002 12:59 PM
Subject: Re: [PATCH] Core Selector Tests
> --- Magesh Umasankar <um...@apache.org> wrote:
> > You have 5 hours for the 11th hour, Bruce ;-)
>
> Magesh,
>
> What do you think about John's patch to set a cygwin.user.home property
> and its companion changes to the CVS stuff? I think it's probably fine,
> and I think Stefan thought so as well, and I don't think there are any
> objections from anyone else. If you're okay with it, would you (or one of
> the other committers) be able to apply it and run the tests? (I'm kind of
> time-crunched today, so I don't think I'd have time to do it.)
>
> Diane
>
> =====
> (holtdl@yahoo.com)
>
>
>
> __________________________________________________
> Do You Yahoo!?
> Yahoo! - Official partner of 2002 FIFA World Cup
> http://fifaworldcup.yahoo.com
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] Core Selector Tests
Posted by Diane Holt <ho...@yahoo.com>.
--- Magesh Umasankar <um...@apache.org> wrote:
> You have 5 hours for the 11th hour, Bruce ;-)
Magesh,
What do you think about John's patch to set a cygwin.user.home property
and its companion changes to the CVS stuff? I think it's probably fine,
and I think Stefan thought so as well, and I don't think there are any
objections from anyone else. If you're okay with it, would you (or one of
the other committers) be able to apply it and run the tests? (I'm kind of
time-crunched today, so I don't think I'd have time to do it.)
Diane
=====
(holtdl@yahoo.com)
__________________________________________________
Do You Yahoo!?
Yahoo! - Official partner of 2002 FIFA World Cup
http://fifaworldcup.yahoo.com
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] Core Selector Tests
Posted by Magesh Umasankar <um...@apache.org>.
I knew you would come thru' though it is 11.5 now ;-)
I will get this one in now.
Cheers,
Magesh
*****************************************************
* Conference: The confusion of one man multiplied *
* by the number present. *
*****************************************************
----- Original Message -----
From: "Bruce Atherton" <br...@callenish.com>
To: "Ant Developers List" <an...@jakarta.apache.org>
Sent: Friday, May 31, 2002 5:21 PM
Subject: Re: [PATCH] Core Selector Tests
> At 12:48 PM 5/31/2002 -0400, Magesh Umasankar wrote:
> >You have 5 hours for the 11th hour, Bruce ;-)
>
> Piece of cake. :-)
>
> [And to think I had overcome the curse of last minute commits by
submitting
> a couple of days early this time.]
>
> Anyway, here is the updated patch. I've run it on Linux, Cygwin, and
> Windows, and all pass the tests. I had to comment out one test that
exposed
> a bug I couldn't find right away, but I'll get to it post Beta 2.
>
----------------------------------------------------------------------------
----
>
>
----------------------------------------------------------------------------
----
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] Core Selector Tests
Posted by Bruce Atherton <br...@callenish.com>.
At 08:54 PM 5/31/02 -0400, Magesh Umasankar wrote:
>Bad old NT 4.0. My guess is that you have an outdated
>copy of the files for which you are comparing the
>datetimes, maybe. But I am not sure - haven't looked
>into it too much yet.
No, that can't be it. I am explicitly setting the dates and times when I
create the testbed. See src/etc/testcases/types/selectors.xml for the
buildfile that creates it. It sets the default time on "**/*" to
"11/21/2001 4:55AM". Then it adjusts the dates on selected files to get a
range of behaviours to test.
Unless.... could it be that <touch> doesn't consistently set the seconds
portion to 0 when it isn't specified? Perhaps I should specify milliseconds
in the touch tasks to be absolutely sure.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] Core Selector Tests
Posted by Steve Loughran <st...@iseran.com>.
----- Original Message -----
From: "Bruce Atherton" <br...@callenish.com>
To: "Ant Developers List" <an...@jakarta.apache.org>
Sent: Friday, May 31, 2002 10:23 PM
Subject: Re: [PATCH] Core Selector Tests
> At 08:54 PM 5/31/02 -0400, Magesh Umasankar wrote:
> >Bad old NT 4.0.
>
> I think I asked the wrong question. After going through the other code,
> googling usenet, performing experiments and finally as a last resort
> checking the documentation, I have a suspicion I know what is going on.
You
> are using JDK 1.1, aren't you?
>
> Here is the important line from the touch task documentation page. I had
> read it before but hadn't fully registered it until now.
>
> For JDK 1.1 only the creation of new files with a modification time
of
> now works, all other cases will emit a warning.
I knew that :)
>
> What this implies (in case you had as much trouble with that line as I
> originally did) is that my use of the <touch> task to set the timestamps
on
> existing files won't work for a JDK 1.1 VM. The File.setLastModified()
call
> is @since 1.2. The fix in this case is obvious, skip all date testing if
> running under a JDK 1.1 VM. To be safe, depend testing should be turned
off
> as well because, although it works now, it could fail any time in the
> future if the original files' dates are changed.
If you look at the tests for <copy>, we set dates on files not by using
<touch timestamp>, but raw <touch> followed by <sleep>. So we push the date
of files into the past not by altering their timestamp, but by keeping it in
place moving the planets' clock forward, relativity restricting how much
affect that has on the rest of the universe
> In trying to tickle this bug out of hiding I went back to my old Windows
98
> box and found another, more subtle one. It turns out that on Windows 98,
at
> least in my setup (JDK1.3.1_03), Java is unable to affect the timestamp on
> a directory. Because of this a depend test that includes a test on a
> directory timestamp is returning the wrong value. All other platforms I've
> encountered (including apparently NT, since Magesh did not encounter an
> error with depend testing) can change the timestamp on a directory without
> a problem. For now, I'll just ignore the return value from the directory
in
> that test.
>
> I've attached a patch for both these issues. Magesh, perhaps you could
test
> this with your setup once you've had a chance to catch your breath after
> releasing Beta 2. Please don't hold Beta 2 on account of this, I don't
> think that anything here is that critical in my opinion.
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] Core Selector Tests
Posted by Bruce Atherton <br...@callenish.com>.
At 08:54 PM 5/31/02 -0400, Magesh Umasankar wrote:
>Bad old NT 4.0.
I think I asked the wrong question. After going through the other code,
googling usenet, performing experiments and finally as a last resort
checking the documentation, I have a suspicion I know what is going on. You
are using JDK 1.1, aren't you?
Here is the important line from the touch task documentation page. I had
read it before but hadn't fully registered it until now.
For JDK 1.1 only the creation of new files with a modification time of
now works, all other cases will emit a warning.
What this implies (in case you had as much trouble with that line as I
originally did) is that my use of the <touch> task to set the timestamps on
existing files won't work for a JDK 1.1 VM. The File.setLastModified() call
is @since 1.2. The fix in this case is obvious, skip all date testing if
running under a JDK 1.1 VM. To be safe, depend testing should be turned off
as well because, although it works now, it could fail any time in the
future if the original files' dates are changed.
In trying to tickle this bug out of hiding I went back to my old Windows 98
box and found another, more subtle one. It turns out that on Windows 98, at
least in my setup (JDK1.3.1_03), Java is unable to affect the timestamp on
a directory. Because of this a depend test that includes a test on a
directory timestamp is returning the wrong value. All other platforms I've
encountered (including apparently NT, since Magesh did not encounter an
error with depend testing) can change the timestamp on a directory without
a problem. For now, I'll just ignore the return value from the directory in
that test.
I've attached a patch for both these issues. Magesh, perhaps you could test
this with your setup once you've had a chance to catch your breath after
releasing Beta 2. Please don't hold Beta 2 on account of this, I don't
think that anything here is that critical in my opinion.
Re: [PATCH] Core Selector Tests
Posted by Steve Loughran <st...@iseran.com>.
----- Original Message -----
From: "Magesh Umasankar" <um...@apache.org>
To: "Ant Developers List" <an...@jakarta.apache.org>
Sent: Friday, May 31, 2002 5:54 PM
Subject: Re: [PATCH] Core Selector Tests
> Bad old NT 4.0. My guess is that you have an outdated
> copy of the files for which you are comparing the
> datetimes, maybe. But I am not sure - haven't looked
> into it too much yet.
>
> Cheers,
> Magesh
what filesystem do you have magesh. DOS FS has the 2 sec resolution; NTFS
is closer to a real file system, even if it doesnt have symlinks and its
mount point system is brain dead.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] Core Selector Tests
Posted by Magesh Umasankar <um...@apache.org>.
Bad old NT 4.0. My guess is that you have an outdated
copy of the files for which you are comparing the
datetimes, maybe. But I am not sure - haven't looked
into it too much yet.
Cheers,
Magesh
***********************************************************
* Smile: A curve that can set a lot of things straight. *
***********************************************************
----- Original Message -----
From: "Bruce Atherton" <br...@callenish.com>
To: "Ant Developers List" <an...@jakarta.apache.org>
Sent: Friday, May 31, 2002 8:49 PM
Subject: Re: [PATCH] Core Selector Tests
> At 06:20 PM 5/31/2002 -0400, you wrote:
> >The "equals" tests in DateSelectorTest fail with
> >the same message that Erik had reported earlier.
>
> Whaa? What platform are you on? Exactly which line failed? As I said, I
> tried it on several different platforms including Cygwin and Windows 2000,
> and all passed without complaint.
>
> >I suggest that a good way for checking equality
> >would be for you to create a file during testing,
> >store its time as the expected one and then test
> >the DateSelector.
>
> Yes, that is yet another approach, and one that I will add. I tried to
> create as many variations on the theme as I could think of. They should
all
> work or there is a bug that needs fixing.
>
> > Anyway, for now, I am
> >commenting out all the "equals" tests and committing
> >it. We will try to see what is going on after Beta2.
>
> Fair enough. Thanks for fixing and committing.
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] Core Selector Tests
Posted by Bruce Atherton <br...@callenish.com>.
At 06:20 PM 5/31/2002 -0400, you wrote:
>The "equals" tests in DateSelectorTest fail with
>the same message that Erik had reported earlier.
Whaa? What platform are you on? Exactly which line failed? As I said, I
tried it on several different platforms including Cygwin and Windows 2000,
and all passed without complaint.
>I suggest that a good way for checking equality
>would be for you to create a file during testing,
>store its time as the expected one and then test
>the DateSelector.
Yes, that is yet another approach, and one that I will add. I tried to
create as many variations on the theme as I could think of. They should all
work or there is a bug that needs fixing.
> Anyway, for now, I am
>commenting out all the "equals" tests and committing
>it. We will try to see what is going on after Beta2.
Fair enough. Thanks for fixing and committing.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] Core Selector Tests
Posted by Magesh Umasankar <um...@apache.org>.
The "equals" tests in DateSelectorTest fail with
the same message that Erik had reported earlier.
I suggest that a good way for checking equality
would be for you to create a file during testing,
store its time as the expected one and then test
the DateSelector. Anyway, for now, I am
commenting out all the "equals" tests and committing
it. We will try to see what is going on after Beta2.
Cheers,
Magesh
***********************************************************
* Smile: A curve that can set a lot of things straight. *
***********************************************************
----- Original Message -----
From: "Bruce Atherton" <br...@callenish.com>
To: "Ant Developers List" <an...@jakarta.apache.org>
Sent: Friday, May 31, 2002 5:21 PM
Subject: Re: [PATCH] Core Selector Tests
> At 12:48 PM 5/31/2002 -0400, Magesh Umasankar wrote:
> >You have 5 hours for the 11th hour, Bruce ;-)
>
> Piece of cake. :-)
>
> [And to think I had overcome the curse of last minute commits by
submitting
> a couple of days early this time.]
>
> Anyway, here is the updated patch. I've run it on Linux, Cygwin, and
> Windows, and all pass the tests. I had to comment out one test that
exposed
> a bug I couldn't find right away, but I'll get to it post Beta 2.
>
----------------------------------------------------------------------------
----
>
>
----------------------------------------------------------------------------
----
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] Core Selector Tests
Posted by Bruce Atherton <br...@callenish.com>.
At 12:48 PM 5/31/2002 -0400, Magesh Umasankar wrote:
>You have 5 hours for the 11th hour, Bruce ;-)
Piece of cake. :-)
[And to think I had overcome the curse of last minute commits by submitting
a couple of days early this time.]
Anyway, here is the updated patch. I've run it on Linux, Cygwin, and
Windows, and all pass the tests. I had to comment out one test that exposed
a bug I couldn't find right away, but I'll get to it post Beta 2.
Re: [PATCH] Core Selector Tests
Posted by Magesh Umasankar <um...@apache.org>.
You have 5 hours for the 11th hour, Bruce ;-)
Cheers,
Magesh
************************************************
* Criminal: A guy no different from the rest *
* ...except that he got caught. *
************************************************
----- Original Message -----
From: "Bruce Atherton" <br...@callenish.com>
To: "Ant Developers List" <an...@jakarta.apache.org>
Sent: Friday, May 31, 2002 12:27 PM
Subject: Re: [PATCH] Core Selector Tests
> Ok, I didn't get the patch out last night. Here's why:
>
> It turns out there are several other tests that can fail. I am now testing
> on cygwin, Win98, and Windows 2000 as well as Linux, and I got some
> failures that I don't quite understand. Everything works perfectly on
> Linux. I'll try to get this fixed by tonight, though.
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] Core Selector Tests
Posted by Bruce Atherton <br...@callenish.com>.
Ok, I didn't get the patch out last night. Here's why:
It turns out there are several other tests that can fail. I am now testing
on cygwin, Win98, and Windows 2000 as well as Linux, and I got some
failures that I don't quite understand. Everything works perfectly on
Linux. I'll try to get this fixed by tonight, though.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] Core Selector Tests
Posted by Erik Hatcher <ja...@ehatchersolutions.com>.
Bruce,
I'm going to apply your patches, but I'm getting this:
Testcase:
testSelectionBehaviour(org.apache.tools.ant.types.selectors.DateSelect
orTest): FAILED
expected:<TTFFTFFFTTTT> but was:<TFFFFFFFFFFT>
junit.framework.AssertionFailedError: expected:<TTFFTFFFTTTT> but
was:<TFFFFFFFF
FFT>
at junit.framework.Assert.fail(Assert.java:51)
at junit.framework.Assert.failNotEquals(Assert.java:234)
at junit.framework.Assert.assertEquals(Assert.java:68)
at junit.framework.Assert.assertEquals(Assert.java:75)
at
org.apache.tools.ant.types.selectors.DateSelectorTest.testSelectionBe
haviour(DateSelectorTest.java:194)
I haven't looked into it - could you?
Erik
----- Original Message -----
From: "Bruce Atherton" <br...@callenish.com>
To: "Ant Developers List" <an...@jakarta.apache.org>
Sent: Thursday, May 30, 2002 12:47 AM
Subject: [PATCH] Core Selector Tests
> Container and custom selector tests to come later.
>
> Log:
> Unit tests for core selectors, along with some minor bug fixes for
problems
> discovered when writing the tests.
----------------------------------------------------------------------------
----
>
>
----------------------------------------------------------------------------
----
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [PATCH] Core Selector Tests
Posted by Bruce Atherton <br...@callenish.com>.
Oops. In deleting local changes to my build.xml file out of that patch, I
managed to lose one change that is required for those unit tests to pass.
For your convenience, included both inline and as an attachment:
Index: build.xml
===================================================================
RCS file: /home/cvspublic/jakarta-ant/build.xml,v
retrieving revision 1.304.2.12
diff -u -r1.304.2.12 build.xml
--- build.xml 28 May 2002 11:50:38 -0000 1.304.2.12
+++ build.xml 30 May 2002 05:08:21 -0000
@@ -1235,6 +1235,7 @@
<exclude name="${regexp.package}/RegexpTest.java" />
<exclude name="${optional.package}/AbstractXSLTLiaisonTest.java" />
<exclude name="${ant.package}/types/AbstractFileSetTest.java" />
+ <exclude
name="${ant.package}/types/selectors/BaseSelectorTest.java" />
<!-- helper classes, not testcases -->
<exclude name="org/example/**" />