You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/16 03:43:01 UTC
[GitHub] [fineract] thesmallstar opened a new pull request #1072: FINERACT-821 Added Rightcurly checkstyle
thesmallstar opened a new pull request #1072:
URL: https://github.com/apache/fineract/pull/1072
This PR is in continuation to #1060
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger merged pull request #1072: FINERACT-821 Added Rightcurly checkstyle
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #1072:
URL: https://github.com/apache/fineract/pull/1072
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1072: FINERACT-821 Added Rightcurly checkstyle
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #1072:
URL: https://github.com/apache/fineract/pull/1072#issuecomment-644538531
So I had to modify the checkstyle a little bit:
I have modified from option => ALONE to ALONE_OR_SINGLELINE
Reason:
Checkstyle would treat:
function Xyz() {} //violation
I think @vorburger you would agree to keep it this way rather than
function XyZ(){
}
Spotless love the first one too (With current config). Also if you are wondering that it would also allow:
function Xyz() { something }
Nope, it won't, spotless would take care ;)
This is actually completely automated by spotless, but just an extra check, just in case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org