You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/25 02:51:25 UTC
[GitHub] [pulsar] 315157973 opened a new pull request #9705: Fix flaky test MultiTopicsConsumerImplTest#testConsumerCleanupOnSubscribeFailure
315157973 opened a new pull request #9705:
URL: https://github.com/apache/pulsar/pull/9705
### Modifications
The thread pool is used in the unit test to complete the delay failure, but the time left for the thread pool is only 5ms. The time of thread switching is uncontrollable, so failures often occur.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #9705: Fix flaky test MultiTopicsConsumerImplTest#testConsumerCleanupOnSubscribeFailure
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #9705:
URL: https://github.com/apache/pulsar/pull/9705#issuecomment-785658065
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #9705: Fix flaky test MultiTopicsConsumerImplTest#testConsumerCleanupOnSubscribeFailure
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #9705:
URL: https://github.com/apache/pulsar/pull/9705#issuecomment-785659750
@sijie @jiazhai @codelipenghui I hope this fix gets merged asap. This PR fixes a test that is extremely flaky and causes a lot of builds to fail. The test was introduced in #9419 fairly recently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #9705: Fix flaky test MultiTopicsConsumerImplTest#testConsumerCleanupOnSubscribeFailure
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #9705:
URL: https://github.com/apache/pulsar/pull/9705
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #9705: Fix flaky test MultiTopicsConsumerImplTest#testConsumerCleanupOnSubscribeFailure
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #9705:
URL: https://github.com/apache/pulsar/pull/9705#issuecomment-785972307
@merlimat @sijie please merge this asap, it fixes a really flaky test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org