You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/10/09 13:03:13 UTC

Re: Review Request 14227: CLOUDSTACK-4707: "sourcetemplateid" field is not getting set for derived templates

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14227/
-----------------------------------------------------------

(Updated Oct. 9, 2013, 11:03 a.m.)


Review request for cloudstack and Kishan Kavala.


Bugs: CLOUDSTACK-4707


Repository: cloudstack-git


Description
-------

CLOUDSTACK-4707:  "sourcetemplateid" field is not getting set for derived templates 
 Template created from a volume or snapshot did not have the sourcetemplateid field set in vm_template table. 


Diffs (updated)
-----

  engine/schema/src/com/cloud/storage/VolumeVO.java ea3d6bf 

Diff: https://reviews.apache.org/r/14227/diff/


Testing
-------

Tested by 
1) creating template from root volume of VM
2) created snapshot of root volume and create template from that snapshot
In both the cases sourcetemplateId is set in vm_template table


Thanks,

Harikrishna Patnala


Re: Review Request 14227: CLOUDSTACK-4707: "sourcetemplateid" field is not getting set for derived templates

Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14227/#review26863
-----------------------------------------------------------

Ship it!


4.2
commit 4392a47d1dfac656e645ac7620ac95a839745a29
master
commit bb7493775c202f9a0345482b7a9cb478ed48ba11

- Kishan Kavala


On Oct. 9, 2013, 4:33 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14227/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2013, 4:33 p.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-4707
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-4707:  "sourcetemplateid" field is not getting set for derived templates 
>  Template created from a volume or snapshot did not have the sourcetemplateid field set in vm_template table. 
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/storage/VolumeVO.java ea3d6bf 
> 
> Diff: https://reviews.apache.org/r/14227/diff/
> 
> 
> Testing
> -------
> 
> Tested by 
> 1) creating template from root volume of VM
> 2) created snapshot of root volume and create template from that snapshot
> In both the cases sourcetemplateId is set in vm_template table
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request 14227: CLOUDSTACK-4707: "sourcetemplateid" field is not getting set for derived templates

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14227/#review26862
-----------------------------------------------------------


Commit bb7493775c202f9a0345482b7a9cb478ed48ba11 in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=bb74937 ]

CLOUDSTACK-4707: "sourcetemplateid" field is not getting set for derived templates Template created from a volume or snapshot did not have the sourcetemplateid field set in vm_template table.


- ASF Subversion and Git Services


On Oct. 9, 2013, 11:03 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14227/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2013, 11:03 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-4707
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-4707:  "sourcetemplateid" field is not getting set for derived templates 
>  Template created from a volume or snapshot did not have the sourcetemplateid field set in vm_template table. 
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/storage/VolumeVO.java ea3d6bf 
> 
> Diff: https://reviews.apache.org/r/14227/diff/
> 
> 
> Testing
> -------
> 
> Tested by 
> 1) creating template from root volume of VM
> 2) created snapshot of root volume and create template from that snapshot
> In both the cases sourcetemplateId is set in vm_template table
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request 14227: CLOUDSTACK-4707: "sourcetemplateid" field is not getting set for derived templates

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14227/#review26861
-----------------------------------------------------------


Commit 4392a47d1dfac656e645ac7620ac95a839745a29 in branch refs/heads/4.2 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4392a47 ]

CLOUDSTACK-4707: "sourcetemplateid" field is not getting set for derived templates Template created from a volume or snapshot did not have the sourcetemplateid field set in vm_template table.


- ASF Subversion and Git Services


On Oct. 9, 2013, 11:03 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14227/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2013, 11:03 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-4707
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-4707:  "sourcetemplateid" field is not getting set for derived templates 
>  Template created from a volume or snapshot did not have the sourcetemplateid field set in vm_template table. 
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/storage/VolumeVO.java ea3d6bf 
> 
> Diff: https://reviews.apache.org/r/14227/diff/
> 
> 
> Testing
> -------
> 
> Tested by 
> 1) creating template from root volume of VM
> 2) created snapshot of root volume and create template from that snapshot
> In both the cases sourcetemplateId is set in vm_template table
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>