You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by Kami <gi...@git.apache.org> on 2016/04/19 19:36:27 UTC
[GitHub] libcloud pull request: Hook up pylint and run pylint target on Tra...
GitHub user Kami opened a pull request:
https://github.com/apache/libcloud/pull/768
Hook up pylint and run pylint target on Travis C
This is probably like 5th attempt to get pylint working in some form or another on the Libcloud code base.
I tried it a couple of times myself, but I always started with `libcloud/compute/` which has tons of false positives so I always kinda lost the motivation to continue.
Best approach to avoid that is to do it step by step (baby steps!). In this PR I'm starting with `libcloud/dns/` and we can slowly continue from there towards `libcloud/compute/` which will be a massive beast :)
There are still tons of false positives in other places which will need to be addressed. For now, we can disable some of those warnings, but down the road we will need to change some code and / or write some pylint plugins which let pylint know how to handle some of the more convoluted code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Kami/libcloud pylint_1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/768.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #768
----
commit 3bb3d8d90e0f49e0a35a75054c8421f41c2d949b
Author: Tomaz Muraus <to...@tomaz.me>
Date: 2016-04-19T16:57:14Z
Run pylint on libcloud/dns/.
commit c231005fcbb67d275fdf20fea93d0103b18a1d62
Author: Tomaz Muraus <to...@tomaz.me>
Date: 2016-04-19T16:57:51Z
Add missing license.
commit 1a8189d673bc5172fc30a09bf4c70d162f15ff34
Author: Tomaz Muraus <to...@tomaz.me>
Date: 2016-04-19T17:15:52Z
Fix pylint violations and some actual code bugs discovered by pylint.
commit da3e4335b2c3c438fd96baa4bef4f291728c2f5a
Author: Tomaz Muraus <to...@tomaz.me>
Date: 2016-04-19T17:16:50Z
Use -E flag, we don't care about warnings.
commit e6a1c48d21f4e4288692f204503338cae37a9ca6
Author: Tomaz Muraus <to...@tomaz.me>
Date: 2016-04-19T17:32:41Z
Also run pylint tox target on travis.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] libcloud pull request: Hook up pylint and run pylint target on Tra...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/libcloud/pull/768
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---