You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/12/14 18:55:55 UTC
[GitHub] [incubator-mxnet] bartekkuncer opened a new pull request #19670: [1.x][submodule] Upgrade oneDNN to v2.0
bartekkuncer opened a new pull request #19670:
URL: https://github.com/apache/incubator-mxnet/pull/19670
This change upgrades oneDNN on branch 1.x to v2.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19670: [1.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19670:
URL: https://github.com/apache/incubator-mxnet/pull/19670#issuecomment-774089120
> @bartekkuncer I think we can, provided that downstream users/developers don't have to make code changes to integrate with mxnet. This means everything should be consistent, including function signatures (and integrating with a compatibility layer is ok), header files and locations, dynamically loaded dependencies.
@szha I believe the change keeps the file location consistency with previous state of the branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19670: [1.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19670:
URL: https://github.com/apache/incubator-mxnet/pull/19670#issuecomment-756652834
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19670: [1.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19670:
URL: https://github.com/apache/incubator-mxnet/pull/19670#issuecomment-744640729
Hey @bartekkuncer , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-cpu, miscellaneous, windows-cpu, website, centos-gpu, sanity, clang, edge, unix-cpu, windows-gpu, unix-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19670: [1.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19670:
URL: https://github.com/apache/incubator-mxnet/pull/19670#issuecomment-756711490
@szha Hi, can this change be merged now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19670: [1.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19670:
URL: https://github.com/apache/incubator-mxnet/pull/19670#issuecomment-770748020
@szha Hi, can we upgrade oneDNN to v2.0 on 1.x? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer edited a comment on pull request #19670: [1.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
bartekkuncer edited a comment on pull request #19670:
URL: https://github.com/apache/incubator-mxnet/pull/19670#issuecomment-745816821
> I think this will impact those who integrate with pip through the included header files.
@szha Is there a way I can help with that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19670: [1.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19670:
URL: https://github.com/apache/incubator-mxnet/pull/19670#issuecomment-745198013
@szha Please help with the merge. This change just upgrades oneDNN used by mxnet to v2.0 on branch 1.x.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19670: [1.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19670:
URL: https://github.com/apache/incubator-mxnet/pull/19670#issuecomment-756652798
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #19670: [1.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #19670:
URL: https://github.com/apache/incubator-mxnet/pull/19670#issuecomment-776275937
I cannot see UNIX CPU and GPU for this PR. I get the following error:
```
URI: | /job/mxnet-validation/job/unix-cpu/job/PR-19670/4/display/redirect
-- | --
404
Not Found
Stapler
````
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19670: [1.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19670:
URL: https://github.com/apache/incubator-mxnet/pull/19670#issuecomment-745816821
> I think this will impact those who integrate with pip through the included header files.
Is there a way I can help with that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #19670: [1.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #19670:
URL: https://github.com/apache/incubator-mxnet/pull/19670#issuecomment-776402782
https://jenkins.mxnet-ci.amazon-ml.com/job/mxnet-validation/job/unix-cpu/job/PR-19670/4/display/redirect
https://jenkins.mxnet-ci.amazon-ml.com/job/mxnet-validation/job/unix-gpu/job/PR-19670/6/display/redirect
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19670: [1.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19670:
URL: https://github.com/apache/incubator-mxnet/pull/19670#issuecomment-745239968
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #19670: [1.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #19670:
URL: https://github.com/apache/incubator-mxnet/pull/19670#issuecomment-756652798
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #19670: [1.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
szha merged pull request #19670:
URL: https://github.com/apache/incubator-mxnet/pull/19670
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19670: [1.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19670:
URL: https://github.com/apache/incubator-mxnet/pull/19670#issuecomment-745240004
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19670: [1.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19670:
URL: https://github.com/apache/incubator-mxnet/pull/19670#issuecomment-756652834
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #19670: [1.x][submodule] Upgrade oneDNN to v2.0
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #19670:
URL: https://github.com/apache/incubator-mxnet/pull/19670#issuecomment-770917986
@bartekkuncer I think we can, provided that downstream users/developers don't have to make code changes to integrate with mxnet. This means everything should be consistent, including function signatures (and integrating with a compatibility layer is ok), header files and locations, dynamically loaded dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org