You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Yikun (via GitHub)" <gi...@apache.org> on 2023/07/10 09:02:05 UTC

[GitHub] [spark] Yikun commented on a diff in pull request #41918: [DO_NOT_MERGE][INFRA] test dockerfile

Yikun commented on code in PR #41918:
URL: https://github.com/apache/spark/pull/41918#discussion_r1257947508


##########
dev/infra/Dockerfile:
##########
@@ -55,10 +55,9 @@ RUN $APT_INSTALL r-base libcurl4-openssl-dev qpdf libssl-dev zlib1g-dev
 RUN Rscript -e "install.packages(c('knitr', 'markdown', 'rmarkdown', 'testthat', 'devtools', 'e1071', 'survival', 'arrow', 'roxygen2', 'xml2'), repos='https://cloud.r-project.org/')"
 
 # See more in SPARK-39959, roxygen2 < 7.2.1
-RUN apt-get install -y libcurl4-openssl-dev libgit2-dev libssl-dev libxml2-dev \
+RUN apt-get install -y libgit2-dev libssl-dev libxml2-dev \

Review Comment:
   We need to add `apt update` in here:
   - L1-L57 are using cache layers
   - L58 changed, so that will reinstall but still use the old apt update results (L37), so CI failed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org