[jira] [Commented] (KAFKA-9881) Verify whether RocksDBMetrics Get Measurements from RocksDB in a Unit Test instead of an Intergration Test

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-9881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084881#comment-17084881 ] 

ASF GitHub Bot commented on KAFKA-9881:
---------------------------------------

cadonna commented on pull request #8501: KAFKA-9881: Convert integration test to verify measurements from RocksDB to unit test
URL: https://github.com/apache/kafka/pull/8501
 
 
   The integration test RocksDBMetricsIntegrationTest takes pretty long to complete.
   Most of the runtime is spent in the two tests that verify whether the RocksDB
   metrics get actual measurements from RocksDB. Those tests need to wait for the thread
   that collects the measurements of the RocksDB metrics to trigger the first recordings
   of the metrics.
   
   This PR adds a unit test that verifies whether the Kafka Streams metrics get the
   measurements from RocksDB and removes the two integration tests that verified it
   before. The verification of the creation and scheduling of the RocksDB metrics
   recording trigger thread is already contained in KafkaStreamsTest and consequently
   it is not part of this PR.
   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Verify whether RocksDBMetrics Get Measurements from RocksDB in a Unit Test instead of an Intergration Test
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-9881
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9881
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>    Affects Versions: 2.5.0
>            Reporter: Bruno Cadonna
>            Priority: Major
>
> The integration test {{RocksDBMetricsIntegrationTest}} takes pretty long to complete. The main part of the runtime is spent in the two tests that verify whether the rocksDB metrics get actual measurements from RocksDB. Those tests need to wait for the thread that collects the measurements of the RocksDB metrics to trigger the first recordings of the metrics. These tests do not need to run as integration tests and thus they shall be converted into unit tests to save runtime.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)