You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/01/20 16:19:18 UTC

[GitHub] [beam] jrmccluskey commented on pull request #16575: [WIP] Remove Fatalf calls in non-test goroutines for tests/benchmarks

jrmccluskey commented on pull request #16575:
URL: https://github.com/apache/beam/pull/16575#issuecomment-1017676051


   R: @lostluck
   CC: @riteshghorse @youngoli 
   
   First run at fixing these. Had a lot of trouble with blocking on channel reads piping out of the goroutine, but found a suggestion to replace it with Errorf() + immediate return out instead. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org