You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/06 01:21:23 UTC

[GitHub] [spark] HeartSaVioR commented on a diff in pull request #39406: [SPARK-41894][SS][TESTS] Restore the write permission of `commitDir` after run `testAsyncWriteErrorsPermissionsIssue`

HeartSaVioR commented on code in PR #39406:
URL: https://github.com/apache/spark/pull/39406#discussion_r1063022949


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/AsyncProgressTrackingMicroBatchExecutionSuite.scala:
##########
@@ -750,6 +750,12 @@ class AsyncProgressTrackingMicroBatchExecutionSuite
             }
             e.getCause.getCause.getMessage should include("Permission denied")
           }
+      },
+      Execute { _ =>
+        // SPARK-41894: Restore the write permission of `commitDir`
+        // so that `mvn clean` can run successfully.
+        val commitDir = new File(checkpointLocation + path)
+        commitDir.setWritable(true)

Review Comment:
   I'd prefer restoring the permission in finally block.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org