You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/02/22 21:18:07 UTC
[GitHub] [netbeans] KacerCZ opened a new pull request #2776: [NETBEANS-5373] Fixed compatibility with Phing 3
KacerCZ opened a new pull request #2776:
URL: https://github.com/apache/netbeans/pull/2776
https://issues.apache.org/jira/browse/NETBEANS-5373
Removed parameter `-logger` because its value is incompatible with Phing 3.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on a change in pull request #2776: [NETBEANS-5373] Fixed compatibility with Phing 3
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on a change in pull request #2776:
URL: https://github.com/apache/netbeans/pull/2776#discussion_r594612055
##########
File path: php/php.phing/src/org/netbeans/modules/php/phing/exec/PhingExecutable.java
##########
@@ -163,10 +161,7 @@ private PhpExecutable getExecutable(String title) {
}
private List<String> getRunParams(String[] args) {
- List<String> params = new ArrayList<>(args.length + 2);
- params.add(LOGGER_PARAM);
- params.add(LOGGER_COLOR_VALUE);
- params.addAll(Arrays.asList(args));
+ List<String> params = Arrays.asList(args);
Review comment:
Hopefully it is correct this time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #2776: [NETBEANS-5373] Fixed compatibility with Phing 3
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2776:
URL: https://github.com/apache/netbeans/pull/2776#issuecomment-800606688
Thank you for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2776: [NETBEANS-5373] Fixed compatibility with Phing 3
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2776:
URL: https://github.com/apache/netbeans/pull/2776#issuecomment-800569736
Looks good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2776: [NETBEANS-5373] Fixed compatibility with Phing 3
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2776:
URL: https://github.com/apache/netbeans/pull/2776#discussion_r593738184
##########
File path: php/php.phing/src/org/netbeans/modules/php/phing/exec/PhingExecutable.java
##########
@@ -163,10 +161,7 @@ private PhpExecutable getExecutable(String title) {
}
private List<String> getRunParams(String[] args) {
- List<String> params = new ArrayList<>(args.length + 2);
- params.add(LOGGER_PARAM);
- params.add(LOGGER_COLOR_VALUE);
- params.addAll(Arrays.asList(args));
+ List<String> params = Arrays.asList(args);
Review comment:
Sorry, still different semantics - before you got a `java.util.ArrayList`, after the change it will be `java.util.Arrays.ArrayList`. The latter is modifiable, but has fixed length, which is not true for the first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on a change in pull request #2776: [NETBEANS-5373] Fixed compatibility with Phing 3
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on a change in pull request #2776:
URL: https://github.com/apache/netbeans/pull/2776#discussion_r593286537
##########
File path: php/php.phing/src/org/netbeans/modules/php/phing/exec/PhingExecutable.java
##########
@@ -163,10 +161,7 @@ private PhpExecutable getExecutable(String title) {
}
private List<String> getRunParams(String[] args) {
- List<String> params = new ArrayList<>(args.length + 2);
- params.add(LOGGER_PARAM);
- params.add(LOGGER_COLOR_VALUE);
- params.addAll(Arrays.asList(args));
+ List<String> params = Collections.unmodifiableList(Arrays.asList(args));
Review comment:
I changed it to normal list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2776: [NETBEANS-5373] Fixed compatibility with Phing 3
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2776:
URL: https://github.com/apache/netbeans/pull/2776#discussion_r592657119
##########
File path: php/php.phing/src/org/netbeans/modules/php/phing/exec/PhingExecutable.java
##########
@@ -163,10 +161,7 @@ private PhpExecutable getExecutable(String title) {
}
private List<String> getRunParams(String[] args) {
- List<String> params = new ArrayList<>(args.length + 2);
- params.add(LOGGER_PARAM);
- params.add(LOGGER_COLOR_VALUE);
- params.addAll(Arrays.asList(args));
+ List<String> params = Collections.unmodifiableList(Arrays.asList(args));
Review comment:
this changes the semantics of getRunParams - before the change the returned list was modifiable, now its not anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #2776: [NETBEANS-5373] Fixed compatibility with Phing 3
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #2776:
URL: https://github.com/apache/netbeans/pull/2776
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists