You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Rainer Jung <ra...@kippdata.de> on 2007/03/12 15:07:08 UTC
mod_jk 1.2.22-dev test
Hi,
thanks to all for you feedback about the version numbers. I've uploaded
mod_jk 1.2.22-dev-517211 to http://people.apache.org/~rjung/mod_jk-dev/.
This release will be primarily targeted at closing BZ 41770. So there
are intentionally no heavy changes in it. I should better say: all risky
changes have been introduced unintentionally :).
Whoever likes to investigate some spare time is invited to do a quick
test. If I don't get any negative responses, I would adjust the STATUS,
news and index page, tag and upload to dev/dist tomorrow evening at 7 pm
GMT, inform the list and start the vote.
The changes in 1.2.22 are:
- local_worker and local_worker_only are tolerated during startup and
logged as deprecated. This way of handling old directives was introduced
some releases ago, but local_worker slipped our attention.
- Apache: Fix startup error if no JkWorkersFile is used.
- Apache: Delete unused check for empty init_map during startup.
- Apache: add a better log message, in case wc_open() fails
- fix logging during startup, in case the host name of a worker could
not be resolved. We logged "localhost" instead of the configured name
- logging more precise error messages, if property parsing during
startup fails
- Apache 2.3+: use ap_get_server_description() instead of
ap_get_server_banner() (sic!) and optimize MMN detection.
- Apache 2.x: Replace APR precompiler directive by httpd mpm_query to
detect MPM threading and add an info log message about auto-detected
pool size.
- Apache: Add STDERR logging to jk_error_exit()
- Apache: Increase log level for message about using default shm file
and log file to warning
- Apache 2.x: remove deprecated APLOG_NOERRNO
- Apache 2.x: add virtual server instead of NULL to ap_log_error() where
appropriate
- Apache: simplify logic for shm open error log message
- Apache: make code between apache 1.3 and 2.0 more consistent around
wc_open()
- Apache 2.x: Use jk return values for init_jk(), because it's not part
of httpd API
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: mod_jk 1.2.22-dev test
Posted by Henri Gomez <he...@gmail.com>.
Well I may be the only one to work on mod_jk on iSeries :)
2007/3/12, Mladen Turk <mt...@apache.org>:
> Henri Gomez wrote:
> > I'm tracking right now the iSeries problem (present in 1.2.20 and
> > 1.2.21) and it's located somewhere in jk_log() (jk_util.c).
> >
>
> That would be great, since only you reported that there is
> a core on that platform.
> Nevertheless, I presume it is either compiler or
> OS issue, since nothing like was detected on any
> other platform, and thus should not be an show stopper.
> Of course, it would be great if you find a problem, cause
> it might be silently skipped for other platform.
>
> Regards,
> Mladen
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: mod_jk 1.2.22-dev test
Posted by Mladen Turk <mt...@apache.org>.
Henri Gomez wrote:
> I'm tracking right now the iSeries problem (present in 1.2.20 and
> 1.2.21) and it's located somewhere in jk_log() (jk_util.c).
>
That would be great, since only you reported that there is
a core on that platform.
Nevertheless, I presume it is either compiler or
OS issue, since nothing like was detected on any
other platform, and thus should not be an show stopper.
Of course, it would be great if you find a problem, cause
it might be silently skipped for other platform.
Regards,
Mladen
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: mod_jk 1.2.22-dev test
Posted by Guenter Knauf <fu...@apache.org>.
Hi Rainer,
> I'll take care of your comments (before 1.2.22).
ok; beside this small build issue I can say that two other testers and I found no other issues so far with our applications using Tomcat on NetWare, so:
+ for NetWare platform.
greetz, Guenter.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: mod_jk 1.2.22-dev test
Posted by Rainer Jung <ra...@kippdata.de>.
Hi Henri, hi Günter,
I'll take care of your comments (before 1.2.22).
Henri: I'll have a concentrated look at jk_log(). Maybe I can produce a
standalone version of jk_log(), so we might be able to reproduce the
problem without apache around.
Thanks so far to you both.
Regards,
Rainer
Guenter Knauf wrote:
> Hi Henri,
>> Testing jk 1.2.22 on iSeries :
>
>> A little quirk on this OS (variables defined inside code ) :)
>
> yes, same here on NetWare:
>
> --- jk_map.c.orig Fri Mar 09 22:42:06 2007
> +++ jk_map.c Mon Mar 12 17:37:42 2007
> @@ -718,12 +718,12 @@
> unsigned int i;
> for (i = 0; i < m->size; i++) {
> if (!strncmp(m->names[i], from, strlen(from))) {
> - rc = JK_TRUE;
> const char *prp = m->names[i] + strlen(from);
> char *to_prp = jk_pool_alloc(&m->p,
> (sizeof(char) *
> (strlen(to) +
> strlen(prp) + 1)));
> + rc = JK_TRUE;
> if (!to_prp) {
> jk_log(l, JK_LOG_ERROR,
> "Error in string allocation for attribute '%s.%s'",
>
>
> that fixes it for NetWare.
>
> greetz, Guen.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: mod_jk 1.2.22-dev test
Posted by Guenter Knauf <fu...@apache.org>.
Hi Henri,
> Testing jk 1.2.22 on iSeries :
> A little quirk on this OS (variables defined inside code ) :)
yes, same here on NetWare:
--- jk_map.c.orig Fri Mar 09 22:42:06 2007
+++ jk_map.c Mon Mar 12 17:37:42 2007
@@ -718,12 +718,12 @@
unsigned int i;
for (i = 0; i < m->size; i++) {
if (!strncmp(m->names[i], from, strlen(from))) {
- rc = JK_TRUE;
const char *prp = m->names[i] + strlen(from);
char *to_prp = jk_pool_alloc(&m->p,
(sizeof(char) *
(strlen(to) +
strlen(prp) + 1)));
+ rc = JK_TRUE;
if (!to_prp) {
jk_log(l, JK_LOG_ERROR,
"Error in string allocation for attribute '%s.%s'",
that fixes it for NetWare.
greetz, Guen.
Re: mod_jk 1.2.22-dev test
Posted by Henri Gomez <he...@gmail.com>.
Testing jk 1.2.22 on iSeries :
A little quirk on this OS (variables defined inside code ) :)
/**
* Inherit properties
*
*/
int jk_map_inherit_properties(jk_map_t *m, const char *from, const
char *to, jk_logger_t *l)
{
int rc = JK_FALSE;
if (m && from && to) {
unsigned int i;
for (i = 0; i < m->size; i++) {
if (!strncmp(m->names[i], from, strlen(from))) {
rc = JK_TRUE;
const char *prp = m->names[i] + strlen(from);
char *to_prp = jk_pool_alloc(&m->p,
(sizeof(char) *
(strlen(to) +
strlen(prp) + 1)));
==>
/**
* Inherit properties
*
*/
int jk_map_inherit_properties(jk_map_t *m, const char *from, const
char *to, jk_logger_t *l)
{
int rc = JK_FALSE;
const char *prp;
char *to_prp;
if (m && from && to) {
unsigned int i;
for (i = 0; i < m->size; i++) {
if (!strncmp(m->names[i], from, strlen(from))) {
rc = JK_TRUE;
prp = m->names[i] + strlen(from);
to_prp = jk_pool_alloc(&m->p,
(sizeof(char) *
(strlen(to) +
strlen(prp) + 1)));
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: mod_jk 1.2.22-dev test
Posted by Henri Gomez <he...@gmail.com>.
Well I couldn't see why but if I put a return (0); in top of jk_log(),
the problem disappears.
I tried with apr_xxprintf, but it didn't works better.
I wonder now if the problem is in jk_log function or in calling parameters
2007/3/12, Rainer Jung <ra...@kippdata.de>:
> Great, I hope we can get that fixed!
>
> I can stall releasing 1.2.22, I think it's not that urgent. The point
> is, that I will be away app. for a week. Maybe Mladen or Jean-Frederic
> want to jump in. It's nice, that three of us can handle the jk release
> process.
>
> Keep us informed, how your investigations proceed.
>
> Regards,
>
> Rainer
>
> Henri Gomez wrote:
> > I'm tracking right now the iSeries problem (present in 1.2.20 and
> > 1.2.21) and it's located somewhere in jk_log() (jk_util.c).
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: mod_jk 1.2.22-dev test
Posted by Rainer Jung <ra...@kippdata.de>.
Great, I hope we can get that fixed!
I can stall releasing 1.2.22, I think it's not that urgent. The point
is, that I will be away app. for a week. Maybe Mladen or Jean-Frederic
want to jump in. It's nice, that three of us can handle the jk release
process.
Keep us informed, how your investigations proceed.
Regards,
Rainer
Henri Gomez wrote:
> I'm tracking right now the iSeries problem (present in 1.2.20 and
> 1.2.21) and it's located somewhere in jk_log() (jk_util.c).
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: mod_jk 1.2.22-dev test
Posted by Henri Gomez <he...@gmail.com>.
I'm tracking right now the iSeries problem (present in 1.2.20 and
1.2.21) and it's located somewhere in jk_log() (jk_util.c).
2007/3/12, Rainer Jung <ra...@kippdata.de>:
> Hi,
>
> thanks to all for you feedback about the version numbers. I've uploaded
> mod_jk 1.2.22-dev-517211 to http://people.apache.org/~rjung/mod_jk-dev/.
>
> This release will be primarily targeted at closing BZ 41770. So there
> are intentionally no heavy changes in it. I should better say: all risky
> changes have been introduced unintentionally :).
>
> Whoever likes to investigate some spare time is invited to do a quick
> test. If I don't get any negative responses, I would adjust the STATUS,
> news and index page, tag and upload to dev/dist tomorrow evening at 7 pm
> GMT, inform the list and start the vote.
>
> The changes in 1.2.22 are:
>
> - local_worker and local_worker_only are tolerated during startup and
> logged as deprecated. This way of handling old directives was introduced
> some releases ago, but local_worker slipped our attention.
>
> - Apache: Fix startup error if no JkWorkersFile is used.
>
> - Apache: Delete unused check for empty init_map during startup.
>
> - Apache: add a better log message, in case wc_open() fails
>
> - fix logging during startup, in case the host name of a worker could
> not be resolved. We logged "localhost" instead of the configured name
>
> - logging more precise error messages, if property parsing during
> startup fails
>
> - Apache 2.3+: use ap_get_server_description() instead of
> ap_get_server_banner() (sic!) and optimize MMN detection.
>
> - Apache 2.x: Replace APR precompiler directive by httpd mpm_query to
> detect MPM threading and add an info log message about auto-detected
> pool size.
>
> - Apache: Add STDERR logging to jk_error_exit()
>
> - Apache: Increase log level for message about using default shm file
> and log file to warning
>
> - Apache 2.x: remove deprecated APLOG_NOERRNO
>
> - Apache 2.x: add virtual server instead of NULL to ap_log_error() where
> appropriate
>
> - Apache: simplify logic for shm open error log message
>
> - Apache: make code between apache 1.3 and 2.0 more consistent around
> wc_open()
>
> - Apache 2.x: Use jk return values for init_jk(), because it's not part
> of httpd API
>
> Regards,
>
> Rainer
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org