You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/12/11 22:11:26 UTC
Re: Review Request: Encoding JSON strings as ASCII (fix for binary data in
JSON strings).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8056/#review14312
-----------------------------------------------------------
third_party/libprocess/include/process/http.hpp
<https://reviews.apache.org/r/8056/#comment30471>
Let's kill the casts since they aren't needed and their presence makes me think that they are needed.
third_party/libprocess/include/process/http.hpp
<https://reviews.apache.org/r/8056/#comment30472>
Ditto.
third_party/libprocess/include/stout/json.hpp
<https://reviews.apache.org/r/8056/#comment30470>
I think it would be great to have a small comment here explaining that the spec requires four numbers thus we need to 'setw' and also cast to 'unsigned int'.
- Benjamin Hindman
On Nov. 15, 2012, 10:01 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8056/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2012, 10:01 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> At twitter, we had an executor using binary data in the TaskInfo.data field. Since we can't encode unicode / binary data, this breaks the JSON endpoint and the webui.
>
> This fixes the break, as well as allows browsing binary files in the webui (however, encoded as ASCII).
>
>
> Diffs
> -----
>
> src/tests/stout_tests.cpp efdb47f1d2401f9175a05fc65922d9ab7e383666
> third_party/libprocess/include/process/http.hpp f8d0a5886c77eaf885732346b89be326e89afad6
> third_party/libprocess/include/stout/json.hpp 1c66dfd324619222f4ed168b7cf18e8f5e558b23
>
> Diff: https://reviews.apache.org/r/8056/diff/
>
>
> Testing
> -------
>
> make check + added json test
>
>
> Thanks,
>
> Ben Mahler
>
>