You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "PhilippvK (via GitHub)" <gi...@apache.org> on 2023/03/20 08:06:04 UTC

[GitHub] [tvm] PhilippvK commented on pull request #14273: [TVMC] Expose tir and relay.qnn passes to --disable-pass argument

PhilippvK commented on PR #14273:
URL: https://github.com/apache/tvm/pull/14273#issuecomment-1475781656

   Thank you for your feedback.
   
   
   Two notes:
   - We already have such situation where a Pass with the same name exists in two different Namespaces: `relay._transform.Legalize` vs. `relay.qnn._transform.Legalize`. We either need to find a way to allow both of them or need rename the latter to `relay.qnn._transform.QNNLegalize` which might break downstream implementations…
   - The `relay._transform.` prefix is actually the most common here while `relay.transform.` seems to be odd. I have no idea why these two namings exists but would agree that these should be patched for more consistency.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org