[GitHub] Ben-Zvi commented on issue #1598: DRILL-6880: For Hash-Join hash-table build - treat null keys as an equal match

[GitBox <gi...@apache.org>]

Ben-Zvi commented on issue #1598: DRILL-6880: For Hash-Join hash-table build - treat null keys as an equal match 
URL: https://github.com/apache/drill/pull/1598#issuecomment-452168966
 
 
   Changes following the review: Added an enum *setupWork* to specify the type of work (Build, Probe or check-nulls). 
      Removed an unused parameter `isProbe` in `setupGetHash`.
     Extracted the "next" logic from the `isKeyMatch` method, which simplified few things, like no need for a global "index holder".  This works now similar to an iterator, by calling the new `nextLinkInHashChain` method. (Could not implement an iterator because the "next" jumps from one BatchHolder to another).
      And added some more comments.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services