You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dinesh Bhat (Code Review)" <ge...@cloudera.org> on 2016/07/18 23:36:44 UTC
[kudu-CR](gh-pages) Update the docs webpages to reflect the master branch
Hello Jean-Daniel Cryans, Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3672
to review the following change.
Change subject: Update the docs webpages to reflect the master branch
......................................................................
Update the docs webpages to reflect the master branch
Change-Id: I5a760ec169880954961f2da2a288f4d963e87d84
---
M docs/administration.html
M docs/configuration.html
M docs/configuration_reference.html
M docs/configuration_reference_unsupported.html
M docs/contributing.html
M docs/developing.html
M docs/index.html
M docs/installation.html
M docs/kudu-master_configuration_reference.html
M docs/kudu-master_configuration_reference_unsupported.html
M docs/kudu-tserver_configuration_reference.html
M docs/kudu-tserver_configuration_reference_unsupported.html
M docs/kudu_impala_integration.html
M docs/quickstart.html
M docs/release_notes.html
M docs/schema_design.html
M docs/style_guide.html
M docs/transaction_semantics.html
M docs/troubleshooting.html
19 files changed, 794 insertions(+), 303 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/3672/1
--
To view, visit http://gerrit.cloudera.org:8080/3672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a760ec169880954961f2da2a288f4d963e87d84
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR](gh-pages) Update the docs webpages to reflect the master branch
Posted by "Dinesh Bhat (Code Review)" <ge...@cloudera.org>.
Dinesh Bhat has abandoned this change.
Change subject: Update the docs webpages to reflect the master branch
......................................................................
Abandoned
Abandoning this patch as this is outdated now, and we are gonna publish web pages aligned with release for now. For future, as Todd suggested we can publish with an in-progress to release' label. Further I was thinking we can automate this docs/webpage update to be a one step process, i.e a post-hook to docs section could generate html pages and publish(for unreleased versions).
--
To view, visit http://gerrit.cloudera.org:8080/3672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I5a760ec169880954961f2da2a288f4d963e87d84
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](gh-pages) Update the docs webpages to reflect the master branch
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Update the docs webpages to reflect the master branch
......................................................................
Patch Set 1:
(4 comments)
We should fix some "wrong docs" before regenerating this and pushing it
Specifically we are doing 0.10.0 instead of 1.0.0 and also 0.10.0 is not released yet, which should be made clear in the docs
http://gerrit.cloudera.org:8080/#/c/3672/1/docs/release_notes.html
File docs/release_notes.html:
Line 85: <h3 id="rn_1.0.0"><a class="link" href="#rn_1.0.0">Release notes specific to 1.0.0</a></h3>
We still need to change 1.0.0 here and below to 0.10.0, also it should say something like (unreleased) I think. Maybe JD has thoughts on this
Line 288: <a href="http://getkudu.io/2016/04/26/ycsb.html">Experiments using YCSB</a> indicate that these
Undesirable change
Line 964: <p><a href="http://getkudu.io">Kudu Website</a></p>
Undesirable change
Line 1030: <li><a href="#rn_1.0.0">Release notes specific to 1.0.0</a>
says 1.0.0
--
To view, visit http://gerrit.cloudera.org:8080/3672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a760ec169880954961f2da2a288f4d963e87d84
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Update the docs webpages to reflect the master branch
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Update the docs webpages to reflect the master branch
......................................................................
Patch Set 1:
The reason they're out of date is that we typically wait for a release to publish the new docs. If we want to start publishing master ("trunk") docs, I think we should make it clear in the URL (and maybe a header on the pages) saying something like "This page refers to an unreleased development version of Apache Kudu." with some kind of link back to the latest release.
Otherwise the average user (who does not build and run trunk) will be confused when they see APIs or features that aren't available in what they're running. For example, check out what LLVM does with the big red WARNING: http://llvm.org/docs/ReleaseNotes.html
--
To view, visit http://gerrit.cloudera.org:8080/3672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a760ec169880954961f2da2a288f4d963e87d84
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR](gh-pages) Update the docs webpages to reflect the master branch
Posted by "Dinesh Bhat (Code Review)" <ge...@cloudera.org>.
Dinesh Bhat has posted comments on this change.
Change subject: Update the docs webpages to reflect the master branch
......................................................................
Patch Set 1:
Sounds good Todd, if the consensus is to generate the docs after the release, I will abandon this review, plus this diff is outdated anyways as we have gone through bunch of master docs changes lately.
--
To view, visit http://gerrit.cloudera.org:8080/3672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a760ec169880954961f2da2a288f4d963e87d84
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR](gh-pages) Update the docs webpages to reflect the master branch
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Update the docs webpages to reflect the master branch
......................................................................
Patch Set 1:
I think updating prior to release is nice, but only if we do the "this is an unreleased document" type header.
--
To view, visit http://gerrit.cloudera.org:8080/3672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a760ec169880954961f2da2a288f4d963e87d84
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No