You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/12/13 14:11:36 UTC
[GitHub] [inlong] gong opened a new pull request, #6872: [INLONG-6864][Sort] Modify hive metric computing to ensure metric data accuracy
gong opened a new pull request, #6872:
URL: https://github.com/apache/inlong/pull/6872
### Prepare a Pull Request
- [INLONG-6864][Sort] Modify hive metric computing to ensure metric data accuracy
- Fixes #6864
### Motivation
* Modify hive metric computing to ensure metric data accuracy
### Modifications
* computing metric after checkpoint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gong commented on a diff in pull request #6872: [INLONG-6864][Sort] Modify hive metric computing to ensure metric data accuracy
Posted by GitBox <gi...@apache.org>.
gong commented on code in PR #6872:
URL: https://github.com/apache/inlong/pull/6872#discussion_r1048170528
##########
inlong-sort/sort-connectors/hive/src/main/java/org/apache/inlong/sort/hive/filesystem/AbstractStreamingWriter.java:
##########
@@ -134,7 +138,17 @@ public AbstractStreamingWriter(
* Commit up to this checkpoint id.
*/
protected void commitUpToCheckpoint(long checkpointId) throws Exception {
- helper.commitUpToCheckpoint(checkpointId);
+ try {
+ helper.commitUpToCheckpoint(checkpointId);
+ if (metricData != null) {
+ metricData.invoke(rowSize, dataSize);
+ }
+ rowSize = 0L;
+ dataSize = 0L;
+ } catch (Exception e) {
+ LOG.error("hive sink commitUpToCheckpoint.", e);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap commented on a diff in pull request #6872: [INLONG-6864][Sort] Modify hive metric computing to ensure metric data accuracy
Posted by GitBox <gi...@apache.org>.
EMsnap commented on code in PR #6872:
URL: https://github.com/apache/inlong/pull/6872#discussion_r1048009387
##########
inlong-sort/sort-connectors/hive/src/main/java/org/apache/inlong/sort/hive/filesystem/AbstractStreamingWriter.java:
##########
@@ -134,7 +138,17 @@ public AbstractStreamingWriter(
* Commit up to this checkpoint id.
*/
protected void commitUpToCheckpoint(long checkpointId) throws Exception {
- helper.commitUpToCheckpoint(checkpointId);
+ try {
+ helper.commitUpToCheckpoint(checkpointId);
+ if (metricData != null) {
+ metricData.invoke(rowSize, dataSize);
+ }
+ rowSize = 0L;
+ dataSize = 0L;
+ } catch (Exception e) {
+ LOG.error("hive sink commitUpToCheckpoint.", e);
Review Comment:
hive sink commitUpToCheckpoint occurs error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #6872: [INLONG-6864][Sort] Modify hive metric computing to ensure metric data accuracy
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #6872:
URL: https://github.com/apache/inlong/pull/6872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org