You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/17 14:57:39 UTC
[GitHub] [spark] srowen commented on a change in pull request #27519:
[SPARK-30770][ML][WIP] avoid vector conversion in GMM.transform
srowen commented on a change in pull request #27519: [SPARK-30770][ML][WIP] avoid vector conversion in GMM.transform
URL: https://github.com/apache/spark/pull/27519#discussion_r380227419
##########
File path: python/pyspark/ml/clustering.py
##########
@@ -271,18 +269,18 @@ class GaussianMixture(JavaEstimator, _GaussianMixtureParams, JavaMLWritable, Jav
>>> gaussians[0].mean
DenseVector([0.825, 0.8675])
>>> gaussians[0].cov.toArray()
- array([[ 0.005625 , -0.0050625 ],
- [-0.0050625 , 0.00455625]])
+ array([[ 0.00562..., -0.00506...],
Review comment:
How much did the answer change? trying to figure out whether it's more or less accurate. Unless the perf difference is significant I wouldn't want to lose much here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org