You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/10/05 14:52:30 UTC
[03/21] hbase-site git commit: Published site at
e42741e0858a59961ae0900b5ef073e16ef6126c.
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/7ea632ae/testdevapidocs/src-html/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.html
index 51b3825..f6c2121 100644
--- a/testdevapidocs/src-html/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.html
+++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/rsgroup/TestRSGroupsBase.html
@@ -25,1139 +25,471 @@
<span class="sourceLineNo">017</span> */<a name="line.17"></a>
<span class="sourceLineNo">018</span>package org.apache.hadoop.hbase.rsgroup;<a name="line.18"></a>
<span class="sourceLineNo">019</span><a name="line.19"></a>
-<span class="sourceLineNo">020</span>import static org.junit.Assert.assertEquals;<a name="line.20"></a>
-<span class="sourceLineNo">021</span>import static org.junit.Assert.assertFalse;<a name="line.21"></a>
-<span class="sourceLineNo">022</span>import static org.junit.Assert.assertNull;<a name="line.22"></a>
-<span class="sourceLineNo">023</span>import static org.junit.Assert.assertTrue;<a name="line.23"></a>
-<span class="sourceLineNo">024</span>import static org.junit.Assert.fail;<a name="line.24"></a>
-<span class="sourceLineNo">025</span><a name="line.25"></a>
-<span class="sourceLineNo">026</span>import java.io.IOException;<a name="line.26"></a>
-<span class="sourceLineNo">027</span>import java.security.SecureRandom;<a name="line.27"></a>
-<span class="sourceLineNo">028</span>import java.util.ArrayList;<a name="line.28"></a>
-<span class="sourceLineNo">029</span>import java.util.EnumSet;<a name="line.29"></a>
-<span class="sourceLineNo">030</span>import java.util.HashSet;<a name="line.30"></a>
-<span class="sourceLineNo">031</span>import java.util.Iterator;<a name="line.31"></a>
-<span class="sourceLineNo">032</span>import java.util.LinkedList;<a name="line.32"></a>
-<span class="sourceLineNo">033</span>import java.util.List;<a name="line.33"></a>
-<span class="sourceLineNo">034</span>import java.util.Map;<a name="line.34"></a>
-<span class="sourceLineNo">035</span>import java.util.Set;<a name="line.35"></a>
-<span class="sourceLineNo">036</span>import java.util.TreeMap;<a name="line.36"></a>
-<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.ClusterMetrics;<a name="line.37"></a>
-<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.ClusterMetrics.Option;<a name="line.38"></a>
-<span class="sourceLineNo">039</span>import org.apache.hadoop.hbase.HBaseCluster;<a name="line.39"></a>
-<span class="sourceLineNo">040</span>import org.apache.hadoop.hbase.HBaseTestingUtility;<a name="line.40"></a>
-<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.HColumnDescriptor;<a name="line.41"></a>
-<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.HTableDescriptor;<a name="line.42"></a>
-<span class="sourceLineNo">043</span>import org.apache.hadoop.hbase.NamespaceDescriptor;<a name="line.43"></a>
-<span class="sourceLineNo">044</span>import org.apache.hadoop.hbase.RegionMetrics;<a name="line.44"></a>
-<span class="sourceLineNo">045</span>import org.apache.hadoop.hbase.ServerMetrics;<a name="line.45"></a>
-<span class="sourceLineNo">046</span>import org.apache.hadoop.hbase.ServerName;<a name="line.46"></a>
-<span class="sourceLineNo">047</span>import org.apache.hadoop.hbase.TableName;<a name="line.47"></a>
-<span class="sourceLineNo">048</span>import org.apache.hadoop.hbase.TableNotFoundException;<a name="line.48"></a>
-<span class="sourceLineNo">049</span>import org.apache.hadoop.hbase.Waiter;<a name="line.49"></a>
-<span class="sourceLineNo">050</span>import org.apache.hadoop.hbase.client.Admin;<a name="line.50"></a>
-<span class="sourceLineNo">051</span>import org.apache.hadoop.hbase.client.ClusterConnection;<a name="line.51"></a>
-<span class="sourceLineNo">052</span>import org.apache.hadoop.hbase.client.RegionInfo;<a name="line.52"></a>
-<span class="sourceLineNo">053</span>import org.apache.hadoop.hbase.constraint.ConstraintException;<a name="line.53"></a>
-<span class="sourceLineNo">054</span>import org.apache.hadoop.hbase.master.HMaster;<a name="line.54"></a>
-<span class="sourceLineNo">055</span>import org.apache.hadoop.hbase.net.Address;<a name="line.55"></a>
-<span class="sourceLineNo">056</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.56"></a>
-<span class="sourceLineNo">057</span>import org.junit.Assert;<a name="line.57"></a>
-<span class="sourceLineNo">058</span>import org.junit.Before;<a name="line.58"></a>
-<span class="sourceLineNo">059</span>import org.junit.Rule;<a name="line.59"></a>
-<span class="sourceLineNo">060</span>import org.junit.Test;<a name="line.60"></a>
+<span class="sourceLineNo">020</span>import static org.junit.Assert.assertTrue;<a name="line.20"></a>
+<span class="sourceLineNo">021</span><a name="line.21"></a>
+<span class="sourceLineNo">022</span>import java.io.IOException;<a name="line.22"></a>
+<span class="sourceLineNo">023</span>import java.util.EnumSet;<a name="line.23"></a>
+<span class="sourceLineNo">024</span>import java.util.HashSet;<a name="line.24"></a>
+<span class="sourceLineNo">025</span>import java.util.LinkedList;<a name="line.25"></a>
+<span class="sourceLineNo">026</span>import java.util.List;<a name="line.26"></a>
+<span class="sourceLineNo">027</span>import java.util.Map;<a name="line.27"></a>
+<span class="sourceLineNo">028</span>import java.util.Optional;<a name="line.28"></a>
+<span class="sourceLineNo">029</span>import java.util.Random;<a name="line.29"></a>
+<span class="sourceLineNo">030</span>import java.util.Set;<a name="line.30"></a>
+<span class="sourceLineNo">031</span>import java.util.TreeMap;<a name="line.31"></a>
+<span class="sourceLineNo">032</span><a name="line.32"></a>
+<span class="sourceLineNo">033</span>import org.apache.hadoop.hbase.ClusterMetrics;<a name="line.33"></a>
+<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.ClusterMetrics.Option;<a name="line.34"></a>
+<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.HBaseCluster;<a name="line.35"></a>
+<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.HBaseTestingUtility;<a name="line.36"></a>
+<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.HConstants;<a name="line.37"></a>
+<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.MiniHBaseCluster;<a name="line.38"></a>
+<span class="sourceLineNo">039</span>import org.apache.hadoop.hbase.NamespaceDescriptor;<a name="line.39"></a>
+<span class="sourceLineNo">040</span>import org.apache.hadoop.hbase.RegionMetrics;<a name="line.40"></a>
+<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.ServerMetrics;<a name="line.41"></a>
+<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.ServerName;<a name="line.42"></a>
+<span class="sourceLineNo">043</span>import org.apache.hadoop.hbase.TableName;<a name="line.43"></a>
+<span class="sourceLineNo">044</span>import org.apache.hadoop.hbase.Waiter;<a name="line.44"></a>
+<span class="sourceLineNo">045</span>import org.apache.hadoop.hbase.client.Admin;<a name="line.45"></a>
+<span class="sourceLineNo">046</span>import org.apache.hadoop.hbase.client.RegionInfo;<a name="line.46"></a>
+<span class="sourceLineNo">047</span>import org.apache.hadoop.hbase.client.TableDescriptor;<a name="line.47"></a>
+<span class="sourceLineNo">048</span>import org.apache.hadoop.hbase.coprocessor.CoprocessorHost;<a name="line.48"></a>
+<span class="sourceLineNo">049</span>import org.apache.hadoop.hbase.coprocessor.MasterCoprocessor;<a name="line.49"></a>
+<span class="sourceLineNo">050</span>import org.apache.hadoop.hbase.coprocessor.MasterCoprocessorEnvironment;<a name="line.50"></a>
+<span class="sourceLineNo">051</span>import org.apache.hadoop.hbase.coprocessor.MasterObserver;<a name="line.51"></a>
+<span class="sourceLineNo">052</span>import org.apache.hadoop.hbase.coprocessor.ObserverContext;<a name="line.52"></a>
+<span class="sourceLineNo">053</span>import org.apache.hadoop.hbase.master.HMaster;<a name="line.53"></a>
+<span class="sourceLineNo">054</span>import org.apache.hadoop.hbase.master.MasterCoprocessorHost;<a name="line.54"></a>
+<span class="sourceLineNo">055</span>import org.apache.hadoop.hbase.master.ServerManager;<a name="line.55"></a>
+<span class="sourceLineNo">056</span>import org.apache.hadoop.hbase.master.snapshot.SnapshotManager;<a name="line.56"></a>
+<span class="sourceLineNo">057</span>import org.apache.hadoop.hbase.net.Address;<a name="line.57"></a>
+<span class="sourceLineNo">058</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.58"></a>
+<span class="sourceLineNo">059</span><a name="line.59"></a>
+<span class="sourceLineNo">060</span>import org.junit.Rule;<a name="line.60"></a>
<span class="sourceLineNo">061</span>import org.junit.rules.TestName;<a name="line.61"></a>
<span class="sourceLineNo">062</span>import org.slf4j.Logger;<a name="line.62"></a>
<span class="sourceLineNo">063</span>import org.slf4j.LoggerFactory;<a name="line.63"></a>
<span class="sourceLineNo">064</span><a name="line.64"></a>
-<span class="sourceLineNo">065</span>import org.apache.hbase.thirdparty.com.google.common.collect.Lists;<a name="line.65"></a>
-<span class="sourceLineNo">066</span>import org.apache.hbase.thirdparty.com.google.common.collect.Maps;<a name="line.66"></a>
-<span class="sourceLineNo">067</span>import org.apache.hbase.thirdparty.com.google.common.collect.Sets;<a name="line.67"></a>
-<span class="sourceLineNo">068</span>import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;<a name="line.68"></a>
-<span class="sourceLineNo">069</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos;<a name="line.69"></a>
-<span class="sourceLineNo">070</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos.GetServerInfoRequest;<a name="line.70"></a>
-<span class="sourceLineNo">071</span><a name="line.71"></a>
-<span class="sourceLineNo">072</span>public abstract class TestRSGroupsBase {<a name="line.72"></a>
-<span class="sourceLineNo">073</span> protected static final Logger LOG = LoggerFactory.getLogger(TestRSGroupsBase.class);<a name="line.73"></a>
-<span class="sourceLineNo">074</span> @Rule<a name="line.74"></a>
-<span class="sourceLineNo">075</span> public TestName name = new TestName();<a name="line.75"></a>
-<span class="sourceLineNo">076</span><a name="line.76"></a>
-<span class="sourceLineNo">077</span> //shared<a name="line.77"></a>
-<span class="sourceLineNo">078</span> protected final static String groupPrefix = "Group";<a name="line.78"></a>
-<span class="sourceLineNo">079</span> protected final static String tablePrefix = "Group";<a name="line.79"></a>
-<span class="sourceLineNo">080</span> protected final static SecureRandom rand = new SecureRandom();<a name="line.80"></a>
-<span class="sourceLineNo">081</span><a name="line.81"></a>
-<span class="sourceLineNo">082</span> //shared, cluster type specific<a name="line.82"></a>
-<span class="sourceLineNo">083</span> protected static HBaseTestingUtility TEST_UTIL;<a name="line.83"></a>
-<span class="sourceLineNo">084</span> protected static Admin admin;<a name="line.84"></a>
-<span class="sourceLineNo">085</span> protected static HBaseCluster cluster;<a name="line.85"></a>
-<span class="sourceLineNo">086</span> protected static RSGroupAdmin rsGroupAdmin;<a name="line.86"></a>
-<span class="sourceLineNo">087</span> protected static HMaster master;<a name="line.87"></a>
-<span class="sourceLineNo">088</span><a name="line.88"></a>
-<span class="sourceLineNo">089</span> public final static long WAIT_TIMEOUT = 60000*5;<a name="line.89"></a>
-<span class="sourceLineNo">090</span> public final static int NUM_SLAVES_BASE = 4; //number of slaves for the smallest cluster<a name="line.90"></a>
-<span class="sourceLineNo">091</span> public static int NUM_DEAD_SERVERS = 0;<a name="line.91"></a>
-<span class="sourceLineNo">092</span><a name="line.92"></a>
-<span class="sourceLineNo">093</span> // Per test variables<a name="line.93"></a>
-<span class="sourceLineNo">094</span> TableName tableName;<a name="line.94"></a>
-<span class="sourceLineNo">095</span> @Before<a name="line.95"></a>
-<span class="sourceLineNo">096</span> public void setup() {<a name="line.96"></a>
-<span class="sourceLineNo">097</span> LOG.info(name.getMethodName());<a name="line.97"></a>
-<span class="sourceLineNo">098</span> tableName = TableName.valueOf(tablePrefix + "_" + name.getMethodName());<a name="line.98"></a>
-<span class="sourceLineNo">099</span> }<a name="line.99"></a>
-<span class="sourceLineNo">100</span><a name="line.100"></a>
-<span class="sourceLineNo">101</span> protected RSGroupInfo addGroup(String groupName, int serverCount)<a name="line.101"></a>
-<span class="sourceLineNo">102</span> throws IOException, InterruptedException {<a name="line.102"></a>
-<span class="sourceLineNo">103</span> RSGroupInfo defaultInfo = rsGroupAdmin.getRSGroupInfo(RSGroupInfo.DEFAULT_GROUP);<a name="line.103"></a>
-<span class="sourceLineNo">104</span> assertTrue(defaultInfo != null);<a name="line.104"></a>
-<span class="sourceLineNo">105</span> assertTrue(defaultInfo.getServers().size() >= serverCount);<a name="line.105"></a>
-<span class="sourceLineNo">106</span> rsGroupAdmin.addRSGroup(groupName);<a name="line.106"></a>
-<span class="sourceLineNo">107</span><a name="line.107"></a>
-<span class="sourceLineNo">108</span> Set<Address> set = new HashSet<>();<a name="line.108"></a>
-<span class="sourceLineNo">109</span> for(Address server: defaultInfo.getServers()) {<a name="line.109"></a>
-<span class="sourceLineNo">110</span> if(set.size() == serverCount) {<a name="line.110"></a>
-<span class="sourceLineNo">111</span> break;<a name="line.111"></a>
-<span class="sourceLineNo">112</span> }<a name="line.112"></a>
-<span class="sourceLineNo">113</span> set.add(server);<a name="line.113"></a>
-<span class="sourceLineNo">114</span> }<a name="line.114"></a>
-<span class="sourceLineNo">115</span> rsGroupAdmin.moveServers(set, groupName);<a name="line.115"></a>
-<span class="sourceLineNo">116</span> RSGroupInfo result = rsGroupAdmin.getRSGroupInfo(groupName);<a name="line.116"></a>
-<span class="sourceLineNo">117</span> assertTrue(result.getServers().size() >= serverCount);<a name="line.117"></a>
-<span class="sourceLineNo">118</span> return result;<a name="line.118"></a>
-<span class="sourceLineNo">119</span> }<a name="line.119"></a>
-<span class="sourceLineNo">120</span><a name="line.120"></a>
-<span class="sourceLineNo">121</span> void removeGroup(String groupName) throws IOException {<a name="line.121"></a>
-<span class="sourceLineNo">122</span> RSGroupInfo RSGroupInfo = rsGroupAdmin.getRSGroupInfo(groupName);<a name="line.122"></a>
-<span class="sourceLineNo">123</span> rsGroupAdmin.moveTables(RSGroupInfo.getTables(), RSGroupInfo.DEFAULT_GROUP);<a name="line.123"></a>
-<span class="sourceLineNo">124</span> rsGroupAdmin.moveServers(RSGroupInfo.getServers(), RSGroupInfo.DEFAULT_GROUP);<a name="line.124"></a>
-<span class="sourceLineNo">125</span> rsGroupAdmin.removeRSGroup(groupName);<a name="line.125"></a>
-<span class="sourceLineNo">126</span> }<a name="line.126"></a>
-<span class="sourceLineNo">127</span><a name="line.127"></a>
-<span class="sourceLineNo">128</span> protected void deleteTableIfNecessary() throws IOException {<a name="line.128"></a>
-<span class="sourceLineNo">129</span> for (HTableDescriptor desc : TEST_UTIL.getAdmin().listTables(tablePrefix+".*")) {<a name="line.129"></a>
-<span class="sourceLineNo">130</span> TEST_UTIL.deleteTable(desc.getTableName());<a name="line.130"></a>
-<span class="sourceLineNo">131</span> }<a name="line.131"></a>
+<span class="sourceLineNo">065</span>import org.apache.hbase.thirdparty.com.google.common.collect.Maps;<a name="line.65"></a>
+<span class="sourceLineNo">066</span>import org.apache.hbase.thirdparty.com.google.common.collect.Sets;<a name="line.66"></a>
+<span class="sourceLineNo">067</span><a name="line.67"></a>
+<span class="sourceLineNo">068</span>public abstract class TestRSGroupsBase {<a name="line.68"></a>
+<span class="sourceLineNo">069</span> protected static final Logger LOG = LoggerFactory.getLogger(TestRSGroupsBase.class);<a name="line.69"></a>
+<span class="sourceLineNo">070</span><a name="line.70"></a>
+<span class="sourceLineNo">071</span> //shared<a name="line.71"></a>
+<span class="sourceLineNo">072</span> protected final static String groupPrefix = "Group";<a name="line.72"></a>
+<span class="sourceLineNo">073</span> protected final static String tablePrefix = "Group";<a name="line.73"></a>
+<span class="sourceLineNo">074</span> protected final static Random rand = new Random();<a name="line.74"></a>
+<span class="sourceLineNo">075</span><a name="line.75"></a>
+<span class="sourceLineNo">076</span> //shared, cluster type specific<a name="line.76"></a>
+<span class="sourceLineNo">077</span> protected static HBaseTestingUtility TEST_UTIL;<a name="line.77"></a>
+<span class="sourceLineNo">078</span> protected static Admin admin;<a name="line.78"></a>
+<span class="sourceLineNo">079</span> protected static HBaseCluster cluster;<a name="line.79"></a>
+<span class="sourceLineNo">080</span> protected static RSGroupAdmin rsGroupAdmin;<a name="line.80"></a>
+<span class="sourceLineNo">081</span> protected static HMaster master;<a name="line.81"></a>
+<span class="sourceLineNo">082</span> protected static boolean INIT = false;<a name="line.82"></a>
+<span class="sourceLineNo">083</span> protected static RSGroupAdminEndpoint rsGroupAdminEndpoint;<a name="line.83"></a>
+<span class="sourceLineNo">084</span> protected static CPMasterObserver observer;<a name="line.84"></a>
+<span class="sourceLineNo">085</span><a name="line.85"></a>
+<span class="sourceLineNo">086</span> public final static long WAIT_TIMEOUT = 60000*5;<a name="line.86"></a>
+<span class="sourceLineNo">087</span> public final static int NUM_SLAVES_BASE = 4; //number of slaves for the smallest cluster<a name="line.87"></a>
+<span class="sourceLineNo">088</span> public static int NUM_DEAD_SERVERS = 0;<a name="line.88"></a>
+<span class="sourceLineNo">089</span><a name="line.89"></a>
+<span class="sourceLineNo">090</span> // Per test variables<a name="line.90"></a>
+<span class="sourceLineNo">091</span> @Rule<a name="line.91"></a>
+<span class="sourceLineNo">092</span> public TestName name = new TestName();<a name="line.92"></a>
+<span class="sourceLineNo">093</span> protected TableName tableName;<a name="line.93"></a>
+<span class="sourceLineNo">094</span><a name="line.94"></a>
+<span class="sourceLineNo">095</span> public static void setUpTestBeforeClass() throws Exception {<a name="line.95"></a>
+<span class="sourceLineNo">096</span> TEST_UTIL = new HBaseTestingUtility();<a name="line.96"></a>
+<span class="sourceLineNo">097</span> TEST_UTIL.getConfiguration().setFloat(<a name="line.97"></a>
+<span class="sourceLineNo">098</span> "hbase.master.balancer.stochastic.tableSkewCost", 6000);<a name="line.98"></a>
+<span class="sourceLineNo">099</span> TEST_UTIL.getConfiguration().set(<a name="line.99"></a>
+<span class="sourceLineNo">100</span> HConstants.HBASE_MASTER_LOADBALANCER_CLASS,<a name="line.100"></a>
+<span class="sourceLineNo">101</span> RSGroupBasedLoadBalancer.class.getName());<a name="line.101"></a>
+<span class="sourceLineNo">102</span> TEST_UTIL.getConfiguration().set(CoprocessorHost.MASTER_COPROCESSOR_CONF_KEY,<a name="line.102"></a>
+<span class="sourceLineNo">103</span> RSGroupAdminEndpoint.class.getName() + "," + CPMasterObserver.class.getName());<a name="line.103"></a>
+<span class="sourceLineNo">104</span> TEST_UTIL.startMiniCluster(NUM_SLAVES_BASE - 1);<a name="line.104"></a>
+<span class="sourceLineNo">105</span> TEST_UTIL.getConfiguration().setInt(<a name="line.105"></a>
+<span class="sourceLineNo">106</span> ServerManager.WAIT_ON_REGIONSERVERS_MINTOSTART,<a name="line.106"></a>
+<span class="sourceLineNo">107</span> NUM_SLAVES_BASE - 1);<a name="line.107"></a>
+<span class="sourceLineNo">108</span> TEST_UTIL.getConfiguration().setBoolean(SnapshotManager.HBASE_SNAPSHOT_ENABLED, true);<a name="line.108"></a>
+<span class="sourceLineNo">109</span> initialize();<a name="line.109"></a>
+<span class="sourceLineNo">110</span> }<a name="line.110"></a>
+<span class="sourceLineNo">111</span><a name="line.111"></a>
+<span class="sourceLineNo">112</span> protected static void initialize() throws Exception {<a name="line.112"></a>
+<span class="sourceLineNo">113</span> admin = TEST_UTIL.getAdmin();<a name="line.113"></a>
+<span class="sourceLineNo">114</span> cluster = TEST_UTIL.getHBaseCluster();<a name="line.114"></a>
+<span class="sourceLineNo">115</span> master = ((MiniHBaseCluster)cluster).getMaster();<a name="line.115"></a>
+<span class="sourceLineNo">116</span><a name="line.116"></a>
+<span class="sourceLineNo">117</span> //wait for balancer to come online<a name="line.117"></a>
+<span class="sourceLineNo">118</span> TEST_UTIL.waitFor(WAIT_TIMEOUT, new Waiter.Predicate<Exception>() {<a name="line.118"></a>
+<span class="sourceLineNo">119</span> @Override<a name="line.119"></a>
+<span class="sourceLineNo">120</span> public boolean evaluate() throws Exception {<a name="line.120"></a>
+<span class="sourceLineNo">121</span> return master.isInitialized() &&<a name="line.121"></a>
+<span class="sourceLineNo">122</span> ((RSGroupBasedLoadBalancer) master.getLoadBalancer()).isOnline();<a name="line.122"></a>
+<span class="sourceLineNo">123</span> }<a name="line.123"></a>
+<span class="sourceLineNo">124</span> });<a name="line.124"></a>
+<span class="sourceLineNo">125</span> admin.setBalancerRunning(false,true);<a name="line.125"></a>
+<span class="sourceLineNo">126</span> rsGroupAdmin = new VerifyingRSGroupAdminClient(<a name="line.126"></a>
+<span class="sourceLineNo">127</span> new RSGroupAdminClient(TEST_UTIL.getConnection()), TEST_UTIL.getConfiguration());<a name="line.127"></a>
+<span class="sourceLineNo">128</span> MasterCoprocessorHost host = master.getMasterCoprocessorHost();<a name="line.128"></a>
+<span class="sourceLineNo">129</span> observer = (CPMasterObserver) host.findCoprocessor(CPMasterObserver.class.getName());<a name="line.129"></a>
+<span class="sourceLineNo">130</span> rsGroupAdminEndpoint = (RSGroupAdminEndpoint)<a name="line.130"></a>
+<span class="sourceLineNo">131</span> host.findCoprocessor(RSGroupAdminEndpoint.class.getName());<a name="line.131"></a>
<span class="sourceLineNo">132</span> }<a name="line.132"></a>
<span class="sourceLineNo">133</span><a name="line.133"></a>
-<span class="sourceLineNo">134</span> protected void deleteNamespaceIfNecessary() throws IOException {<a name="line.134"></a>
-<span class="sourceLineNo">135</span> for (NamespaceDescriptor desc : TEST_UTIL.getAdmin().listNamespaceDescriptors()) {<a name="line.135"></a>
-<span class="sourceLineNo">136</span> if(desc.getName().startsWith(tablePrefix)) {<a name="line.136"></a>
-<span class="sourceLineNo">137</span> admin.deleteNamespace(desc.getName());<a name="line.137"></a>
-<span class="sourceLineNo">138</span> }<a name="line.138"></a>
-<span class="sourceLineNo">139</span> }<a name="line.139"></a>
-<span class="sourceLineNo">140</span> }<a name="line.140"></a>
-<span class="sourceLineNo">141</span><a name="line.141"></a>
-<span class="sourceLineNo">142</span> protected void deleteGroups() throws IOException {<a name="line.142"></a>
-<span class="sourceLineNo">143</span> RSGroupAdmin groupAdmin =<a name="line.143"></a>
-<span class="sourceLineNo">144</span> new RSGroupAdminClient(TEST_UTIL.getConnection());<a name="line.144"></a>
-<span class="sourceLineNo">145</span> for(RSGroupInfo group: groupAdmin.listRSGroups()) {<a name="line.145"></a>
-<span class="sourceLineNo">146</span> if(!group.getName().equals(RSGroupInfo.DEFAULT_GROUP)) {<a name="line.146"></a>
-<span class="sourceLineNo">147</span> groupAdmin.moveTables(group.getTables(), RSGroupInfo.DEFAULT_GROUP);<a name="line.147"></a>
-<span class="sourceLineNo">148</span> groupAdmin.moveServers(group.getServers(), RSGroupInfo.DEFAULT_GROUP);<a name="line.148"></a>
-<span class="sourceLineNo">149</span> groupAdmin.removeRSGroup(group.getName());<a name="line.149"></a>
-<span class="sourceLineNo">150</span> }<a name="line.150"></a>
-<span class="sourceLineNo">151</span> }<a name="line.151"></a>
-<span class="sourceLineNo">152</span> }<a name="line.152"></a>
-<span class="sourceLineNo">153</span><a name="line.153"></a>
-<span class="sourceLineNo">154</span> public Map<TableName, List<String>> getTableRegionMap() throws IOException {<a name="line.154"></a>
-<span class="sourceLineNo">155</span> Map<TableName, List<String>> map = Maps.newTreeMap();<a name="line.155"></a>
-<span class="sourceLineNo">156</span> Map<TableName, Map<ServerName, List<String>>> tableServerRegionMap<a name="line.156"></a>
-<span class="sourceLineNo">157</span> = getTableServerRegionMap();<a name="line.157"></a>
-<span class="sourceLineNo">158</span> for(TableName tableName : tableServerRegionMap.keySet()) {<a name="line.158"></a>
-<span class="sourceLineNo">159</span> if(!map.containsKey(tableName)) {<a name="line.159"></a>
-<span class="sourceLineNo">160</span> map.put(tableName, new LinkedList<>());<a name="line.160"></a>
-<span class="sourceLineNo">161</span> }<a name="line.161"></a>
-<span class="sourceLineNo">162</span> for(List<String> subset: tableServerRegionMap.get(tableName).values()) {<a name="line.162"></a>
-<span class="sourceLineNo">163</span> map.get(tableName).addAll(subset);<a name="line.163"></a>
-<span class="sourceLineNo">164</span> }<a name="line.164"></a>
-<span class="sourceLineNo">165</span> }<a name="line.165"></a>
-<span class="sourceLineNo">166</span> return map;<a name="line.166"></a>
-<span class="sourceLineNo">167</span> }<a name="line.167"></a>
-<span class="sourceLineNo">168</span><a name="line.168"></a>
-<span class="sourceLineNo">169</span> public Map<TableName, Map<ServerName, List<String>>> getTableServerRegionMap()<a name="line.169"></a>
-<span class="sourceLineNo">170</span> throws IOException {<a name="line.170"></a>
-<span class="sourceLineNo">171</span> Map<TableName, Map<ServerName, List<String>>> map = Maps.newTreeMap();<a name="line.171"></a>
-<span class="sourceLineNo">172</span> ClusterMetrics status = TEST_UTIL.getHBaseClusterInterface().getClusterMetrics();<a name="line.172"></a>
-<span class="sourceLineNo">173</span> for (Map.Entry<ServerName, ServerMetrics> entry : status.getLiveServerMetrics().entrySet()) {<a name="line.173"></a>
-<span class="sourceLineNo">174</span> ServerName serverName = entry.getKey();<a name="line.174"></a>
-<span class="sourceLineNo">175</span> for(RegionMetrics rl : entry.getValue().getRegionMetrics().values()) {<a name="line.175"></a>
-<span class="sourceLineNo">176</span> TableName tableName = null;<a name="line.176"></a>
-<span class="sourceLineNo">177</span> try {<a name="line.177"></a>
-<span class="sourceLineNo">178</span> tableName = RegionInfo.getTable(rl.getRegionName());<a name="line.178"></a>
-<span class="sourceLineNo">179</span> } catch (IllegalArgumentException e) {<a name="line.179"></a>
-<span class="sourceLineNo">180</span> LOG.warn("Failed parse a table name from regionname=" +<a name="line.180"></a>
-<span class="sourceLineNo">181</span> Bytes.toStringBinary(rl.getRegionName()));<a name="line.181"></a>
-<span class="sourceLineNo">182</span> continue;<a name="line.182"></a>
-<span class="sourceLineNo">183</span> }<a name="line.183"></a>
-<span class="sourceLineNo">184</span> if(!map.containsKey(tableName)) {<a name="line.184"></a>
-<span class="sourceLineNo">185</span> map.put(tableName, new TreeMap<>());<a name="line.185"></a>
-<span class="sourceLineNo">186</span> }<a name="line.186"></a>
-<span class="sourceLineNo">187</span> if(!map.get(tableName).containsKey(serverName)) {<a name="line.187"></a>
-<span class="sourceLineNo">188</span> map.get(tableName).put(serverName, new LinkedList<>());<a name="line.188"></a>
-<span class="sourceLineNo">189</span> }<a name="line.189"></a>
-<span class="sourceLineNo">190</span> map.get(tableName).get(serverName).add(rl.getNameAsString());<a name="line.190"></a>
-<span class="sourceLineNo">191</span> }<a name="line.191"></a>
-<span class="sourceLineNo">192</span> }<a name="line.192"></a>
-<span class="sourceLineNo">193</span> return map;<a name="line.193"></a>
-<span class="sourceLineNo">194</span> }<a name="line.194"></a>
-<span class="sourceLineNo">195</span><a name="line.195"></a>
-<span class="sourceLineNo">196</span> @Test<a name="line.196"></a>
-<span class="sourceLineNo">197</span> public void testBogusArgs() throws Exception {<a name="line.197"></a>
-<span class="sourceLineNo">198</span> assertNull(rsGroupAdmin.getRSGroupInfoOfTable(TableName.valueOf("nonexistent")));<a name="line.198"></a>
-<span class="sourceLineNo">199</span> assertNull(rsGroupAdmin.getRSGroupOfServer(Address.fromParts("bogus",123)));<a name="line.199"></a>
-<span class="sourceLineNo">200</span> assertNull(rsGroupAdmin.getRSGroupInfo("bogus"));<a name="line.200"></a>
-<span class="sourceLineNo">201</span><a name="line.201"></a>
-<span class="sourceLineNo">202</span> try {<a name="line.202"></a>
-<span class="sourceLineNo">203</span> rsGroupAdmin.removeRSGroup("bogus");<a name="line.203"></a>
-<span class="sourceLineNo">204</span> fail("Expected removing bogus group to fail");<a name="line.204"></a>
-<span class="sourceLineNo">205</span> } catch(ConstraintException ex) {<a name="line.205"></a>
-<span class="sourceLineNo">206</span> //expected<a name="line.206"></a>
-<span class="sourceLineNo">207</span> }<a name="line.207"></a>
-<span class="sourceLineNo">208</span><a name="line.208"></a>
-<span class="sourceLineNo">209</span> try {<a name="line.209"></a>
-<span class="sourceLineNo">210</span> rsGroupAdmin.moveTables(Sets.newHashSet(TableName.valueOf("bogustable")), "bogus");<a name="line.210"></a>
-<span class="sourceLineNo">211</span> fail("Expected move with bogus group to fail");<a name="line.211"></a>
-<span class="sourceLineNo">212</span> } catch(ConstraintException|TableNotFoundException ex) {<a name="line.212"></a>
-<span class="sourceLineNo">213</span> //expected<a name="line.213"></a>
-<span class="sourceLineNo">214</span> }<a name="line.214"></a>
+<span class="sourceLineNo">134</span> public static void tearDownAfterClass() throws Exception {<a name="line.134"></a>
+<span class="sourceLineNo">135</span> TEST_UTIL.shutdownMiniCluster();<a name="line.135"></a>
+<span class="sourceLineNo">136</span> }<a name="line.136"></a>
+<span class="sourceLineNo">137</span><a name="line.137"></a>
+<span class="sourceLineNo">138</span> public void setUpBeforeMethod() throws Exception {<a name="line.138"></a>
+<span class="sourceLineNo">139</span> LOG.info(name.getMethodName());<a name="line.139"></a>
+<span class="sourceLineNo">140</span> tableName = TableName.valueOf(tablePrefix + "_" + name.getMethodName());<a name="line.140"></a>
+<span class="sourceLineNo">141</span> if (!INIT) {<a name="line.141"></a>
+<span class="sourceLineNo">142</span> INIT = true;<a name="line.142"></a>
+<span class="sourceLineNo">143</span> tearDownAfterMethod();<a name="line.143"></a>
+<span class="sourceLineNo">144</span> }<a name="line.144"></a>
+<span class="sourceLineNo">145</span> observer.resetFlags();<a name="line.145"></a>
+<span class="sourceLineNo">146</span> }<a name="line.146"></a>
+<span class="sourceLineNo">147</span><a name="line.147"></a>
+<span class="sourceLineNo">148</span> public void tearDownAfterMethod() throws Exception {<a name="line.148"></a>
+<span class="sourceLineNo">149</span> deleteTableIfNecessary();<a name="line.149"></a>
+<span class="sourceLineNo">150</span> deleteNamespaceIfNecessary();<a name="line.150"></a>
+<span class="sourceLineNo">151</span> deleteGroups();<a name="line.151"></a>
+<span class="sourceLineNo">152</span><a name="line.152"></a>
+<span class="sourceLineNo">153</span> for(ServerName sn : admin.listDecommissionedRegionServers()){<a name="line.153"></a>
+<span class="sourceLineNo">154</span> admin.recommissionRegionServer(sn, null);<a name="line.154"></a>
+<span class="sourceLineNo">155</span> }<a name="line.155"></a>
+<span class="sourceLineNo">156</span> assertTrue(admin.listDecommissionedRegionServers().isEmpty());<a name="line.156"></a>
+<span class="sourceLineNo">157</span><a name="line.157"></a>
+<span class="sourceLineNo">158</span> int missing = NUM_SLAVES_BASE - getNumServers();<a name="line.158"></a>
+<span class="sourceLineNo">159</span> LOG.info("Restoring servers: "+missing);<a name="line.159"></a>
+<span class="sourceLineNo">160</span> for(int i=0; i<missing; i++) {<a name="line.160"></a>
+<span class="sourceLineNo">161</span> ((MiniHBaseCluster)cluster).startRegionServer();<a name="line.161"></a>
+<span class="sourceLineNo">162</span> }<a name="line.162"></a>
+<span class="sourceLineNo">163</span><a name="line.163"></a>
+<span class="sourceLineNo">164</span> rsGroupAdmin.addRSGroup("master");<a name="line.164"></a>
+<span class="sourceLineNo">165</span> ServerName masterServerName =<a name="line.165"></a>
+<span class="sourceLineNo">166</span> ((MiniHBaseCluster)cluster).getMaster().getServerName();<a name="line.166"></a>
+<span class="sourceLineNo">167</span><a name="line.167"></a>
+<span class="sourceLineNo">168</span> try {<a name="line.168"></a>
+<span class="sourceLineNo">169</span> rsGroupAdmin.moveServers(Sets.newHashSet(masterServerName.getAddress()), "master");<a name="line.169"></a>
+<span class="sourceLineNo">170</span> } catch (Exception ex) {<a name="line.170"></a>
+<span class="sourceLineNo">171</span> LOG.warn("Got this on setup, FYI", ex);<a name="line.171"></a>
+<span class="sourceLineNo">172</span> }<a name="line.172"></a>
+<span class="sourceLineNo">173</span> assertTrue(observer.preMoveServersCalled);<a name="line.173"></a>
+<span class="sourceLineNo">174</span> TEST_UTIL.waitFor(WAIT_TIMEOUT, new Waiter.Predicate<Exception>() {<a name="line.174"></a>
+<span class="sourceLineNo">175</span> @Override<a name="line.175"></a>
+<span class="sourceLineNo">176</span> public boolean evaluate() throws Exception {<a name="line.176"></a>
+<span class="sourceLineNo">177</span> LOG.info("Waiting for cleanup to finish " + rsGroupAdmin.listRSGroups());<a name="line.177"></a>
+<span class="sourceLineNo">178</span> //Might be greater since moving servers back to default<a name="line.178"></a>
+<span class="sourceLineNo">179</span> //is after starting a server<a name="line.179"></a>
+<span class="sourceLineNo">180</span><a name="line.180"></a>
+<span class="sourceLineNo">181</span> return rsGroupAdmin.getRSGroupInfo(RSGroupInfo.DEFAULT_GROUP).getServers().size()<a name="line.181"></a>
+<span class="sourceLineNo">182</span> == NUM_SLAVES_BASE;<a name="line.182"></a>
+<span class="sourceLineNo">183</span> }<a name="line.183"></a>
+<span class="sourceLineNo">184</span> });<a name="line.184"></a>
+<span class="sourceLineNo">185</span> }<a name="line.185"></a>
+<span class="sourceLineNo">186</span><a name="line.186"></a>
+<span class="sourceLineNo">187</span> public RSGroupInfo addGroup(String groupName, int serverCount)<a name="line.187"></a>
+<span class="sourceLineNo">188</span> throws IOException, InterruptedException {<a name="line.188"></a>
+<span class="sourceLineNo">189</span> RSGroupInfo defaultInfo = rsGroupAdmin.getRSGroupInfo(RSGroupInfo.DEFAULT_GROUP);<a name="line.189"></a>
+<span class="sourceLineNo">190</span> rsGroupAdmin.addRSGroup(groupName);<a name="line.190"></a>
+<span class="sourceLineNo">191</span> Set<Address> set = new HashSet<>();<a name="line.191"></a>
+<span class="sourceLineNo">192</span> for(Address server: defaultInfo.getServers()) {<a name="line.192"></a>
+<span class="sourceLineNo">193</span> if(set.size() == serverCount) {<a name="line.193"></a>
+<span class="sourceLineNo">194</span> break;<a name="line.194"></a>
+<span class="sourceLineNo">195</span> }<a name="line.195"></a>
+<span class="sourceLineNo">196</span> set.add(server);<a name="line.196"></a>
+<span class="sourceLineNo">197</span> }<a name="line.197"></a>
+<span class="sourceLineNo">198</span> rsGroupAdmin.moveServers(set, groupName);<a name="line.198"></a>
+<span class="sourceLineNo">199</span> RSGroupInfo result = rsGroupAdmin.getRSGroupInfo(groupName);<a name="line.199"></a>
+<span class="sourceLineNo">200</span> return result;<a name="line.200"></a>
+<span class="sourceLineNo">201</span> }<a name="line.201"></a>
+<span class="sourceLineNo">202</span><a name="line.202"></a>
+<span class="sourceLineNo">203</span> public void removeGroup(String groupName) throws IOException {<a name="line.203"></a>
+<span class="sourceLineNo">204</span> RSGroupInfo groupInfo = rsGroupAdmin.getRSGroupInfo(groupName);<a name="line.204"></a>
+<span class="sourceLineNo">205</span> rsGroupAdmin.moveTables(groupInfo.getTables(), RSGroupInfo.DEFAULT_GROUP);<a name="line.205"></a>
+<span class="sourceLineNo">206</span> rsGroupAdmin.moveServers(groupInfo.getServers(), RSGroupInfo.DEFAULT_GROUP);<a name="line.206"></a>
+<span class="sourceLineNo">207</span> rsGroupAdmin.removeRSGroup(groupName);<a name="line.207"></a>
+<span class="sourceLineNo">208</span> }<a name="line.208"></a>
+<span class="sourceLineNo">209</span><a name="line.209"></a>
+<span class="sourceLineNo">210</span> public void deleteTableIfNecessary() throws IOException {<a name="line.210"></a>
+<span class="sourceLineNo">211</span> for (TableDescriptor desc : TEST_UTIL.getAdmin().listTables(tablePrefix+".*")) {<a name="line.211"></a>
+<span class="sourceLineNo">212</span> TEST_UTIL.deleteTable(desc.getTableName());<a name="line.212"></a>
+<span class="sourceLineNo">213</span> }<a name="line.213"></a>
+<span class="sourceLineNo">214</span> }<a name="line.214"></a>
<span class="sourceLineNo">215</span><a name="line.215"></a>
-<span class="sourceLineNo">216</span> try {<a name="line.216"></a>
-<span class="sourceLineNo">217</span> rsGroupAdmin.moveServers(Sets.newHashSet(Address.fromParts("bogus",123)), "bogus");<a name="line.217"></a>
-<span class="sourceLineNo">218</span> fail("Expected move with bogus group to fail");<a name="line.218"></a>
-<span class="sourceLineNo">219</span> } catch(ConstraintException ex) {<a name="line.219"></a>
-<span class="sourceLineNo">220</span> //expected<a name="line.220"></a>
+<span class="sourceLineNo">216</span> public void deleteNamespaceIfNecessary() throws IOException {<a name="line.216"></a>
+<span class="sourceLineNo">217</span> for (NamespaceDescriptor desc : TEST_UTIL.getAdmin().listNamespaceDescriptors()) {<a name="line.217"></a>
+<span class="sourceLineNo">218</span> if(desc.getName().startsWith(tablePrefix)) {<a name="line.218"></a>
+<span class="sourceLineNo">219</span> admin.deleteNamespace(desc.getName());<a name="line.219"></a>
+<span class="sourceLineNo">220</span> }<a name="line.220"></a>
<span class="sourceLineNo">221</span> }<a name="line.221"></a>
-<span class="sourceLineNo">222</span><a name="line.222"></a>
-<span class="sourceLineNo">223</span> try {<a name="line.223"></a>
-<span class="sourceLineNo">224</span> admin.setBalancerRunning(true,true);<a name="line.224"></a>
-<span class="sourceLineNo">225</span> rsGroupAdmin.balanceRSGroup("bogus");<a name="line.225"></a>
-<span class="sourceLineNo">226</span> admin.setBalancerRunning(false,true);<a name="line.226"></a>
-<span class="sourceLineNo">227</span> fail("Expected move with bogus group to fail");<a name="line.227"></a>
-<span class="sourceLineNo">228</span> } catch(ConstraintException ex) {<a name="line.228"></a>
-<span class="sourceLineNo">229</span> //expected<a name="line.229"></a>
-<span class="sourceLineNo">230</span> }<a name="line.230"></a>
-<span class="sourceLineNo">231</span> }<a name="line.231"></a>
-<span class="sourceLineNo">232</span><a name="line.232"></a>
-<span class="sourceLineNo">233</span> @Test<a name="line.233"></a>
-<span class="sourceLineNo">234</span> public void testCreateMultiRegion() throws IOException {<a name="line.234"></a>
-<span class="sourceLineNo">235</span> byte[] end = {1,3,5,7,9};<a name="line.235"></a>
-<span class="sourceLineNo">236</span> byte[] start = {0,2,4,6,8};<a name="line.236"></a>
-<span class="sourceLineNo">237</span> byte[][] f = {Bytes.toBytes("f")};<a name="line.237"></a>
-<span class="sourceLineNo">238</span> TEST_UTIL.createTable(tableName, f,1,start,end,10);<a name="line.238"></a>
-<span class="sourceLineNo">239</span> }<a name="line.239"></a>
-<span class="sourceLineNo">240</span><a name="line.240"></a>
-<span class="sourceLineNo">241</span> @Test<a name="line.241"></a>
-<span class="sourceLineNo">242</span> public void testCreateAndDrop() throws Exception {<a name="line.242"></a>
-<span class="sourceLineNo">243</span> TEST_UTIL.createTable(tableName, Bytes.toBytes("cf"));<a name="line.243"></a>
-<span class="sourceLineNo">244</span> //wait for created table to be assigned<a name="line.244"></a>
-<span class="sourceLineNo">245</span> TEST_UTIL.waitFor(WAIT_TIMEOUT, new Waiter.Predicate<Exception>() {<a name="line.245"></a>
-<span class="sourceLineNo">246</span> @Override<a name="line.246"></a>
-<span class="sourceLineNo">247</span> public boolean evaluate() throws Exception {<a name="line.247"></a>
-<span class="sourceLineNo">248</span> return getTableRegionMap().get(tableName) != null;<a name="line.248"></a>
-<span class="sourceLineNo">249</span> }<a name="line.249"></a>
-<span class="sourceLineNo">250</span> });<a name="line.250"></a>
-<span class="sourceLineNo">251</span> TEST_UTIL.deleteTable(tableName);<a name="line.251"></a>
-<span class="sourceLineNo">252</span> }<a name="line.252"></a>
-<span class="sourceLineNo">253</span><a name="line.253"></a>
-<span class="sourceLineNo">254</span><a name="line.254"></a>
-<span class="sourceLineNo">255</span> @Test<a name="line.255"></a>
-<span class="sourceLineNo">256</span> public void testSimpleRegionServerMove() throws IOException,<a name="line.256"></a>
-<span class="sourceLineNo">257</span> InterruptedException {<a name="line.257"></a>
-<span class="sourceLineNo">258</span> int initNumGroups = rsGroupAdmin.listRSGroups().size();<a name="line.258"></a>
-<span class="sourceLineNo">259</span> RSGroupInfo appInfo = addGroup(getGroupName(name.getMethodName()), 1);<a name="line.259"></a>
-<span class="sourceLineNo">260</span> RSGroupInfo adminInfo = addGroup(getGroupName(name.getMethodName()), 1);<a name="line.260"></a>
-<span class="sourceLineNo">261</span> RSGroupInfo dInfo = rsGroupAdmin.getRSGroupInfo(RSGroupInfo.DEFAULT_GROUP);<a name="line.261"></a>
-<span class="sourceLineNo">262</span> Assert.assertEquals(initNumGroups + 2, rsGroupAdmin.listRSGroups().size());<a name="line.262"></a>
-<span class="sourceLineNo">263</span> assertEquals(1, adminInfo.getServers().size());<a name="line.263"></a>
-<span class="sourceLineNo">264</span> assertEquals(1, appInfo.getServers().size());<a name="line.264"></a>
-<span class="sourceLineNo">265</span> assertEquals(getNumServers() - 2, dInfo.getServers().size());<a name="line.265"></a>
-<span class="sourceLineNo">266</span> rsGroupAdmin.moveServers(appInfo.getServers(),<a name="line.266"></a>
-<span class="sourceLineNo">267</span> RSGroupInfo.DEFAULT_GROUP);<a name="line.267"></a>
-<span class="sourceLineNo">268</span> rsGroupAdmin.removeRSGroup(appInfo.getName());<a name="line.268"></a>
-<span class="sourceLineNo">269</span> rsGroupAdmin.moveServers(adminInfo.getServers(),<a name="line.269"></a>
-<span class="sourceLineNo">270</span> RSGroupInfo.DEFAULT_GROUP);<a name="line.270"></a>
-<span class="sourceLineNo">271</span> rsGroupAdmin.removeRSGroup(adminInfo.getName());<a name="line.271"></a>
-<span class="sourceLineNo">272</span> Assert.assertEquals(rsGroupAdmin.listRSGroups().size(), initNumGroups);<a name="line.272"></a>
-<span class="sourceLineNo">273</span> }<a name="line.273"></a>
-<span class="sourceLineNo">274</span><a name="line.274"></a>
-<span class="sourceLineNo">275</span> // return the real number of region servers, excluding the master embedded region server in 2.0+<a name="line.275"></a>
-<span class="sourceLineNo">276</span> public int getNumServers() throws IOException {<a name="line.276"></a>
-<span class="sourceLineNo">277</span> ClusterMetrics status =<a name="line.277"></a>
-<span class="sourceLineNo">278</span> admin.getClusterMetrics(EnumSet.of(Option.MASTER, Option.LIVE_SERVERS));<a name="line.278"></a>
-<span class="sourceLineNo">279</span> ServerName masterName = status.getMasterName();<a name="line.279"></a>
-<span class="sourceLineNo">280</span> int count = 0;<a name="line.280"></a>
-<span class="sourceLineNo">281</span> for (ServerName sn : status.getLiveServerMetrics().keySet()) {<a name="line.281"></a>
-<span class="sourceLineNo">282</span> if (!sn.equals(masterName)) {<a name="line.282"></a>
-<span class="sourceLineNo">283</span> count++;<a name="line.283"></a>
-<span class="sourceLineNo">284</span> }<a name="line.284"></a>
-<span class="sourceLineNo">285</span> }<a name="line.285"></a>
-<span class="sourceLineNo">286</span> return count;<a name="line.286"></a>
-<span class="sourceLineNo">287</span> }<a name="line.287"></a>
-<span class="sourceLineNo">288</span><a name="line.288"></a>
-<span class="sourceLineNo">289</span> @Test<a name="line.289"></a>
-<span class="sourceLineNo">290</span> public void testMoveServers() throws Exception {<a name="line.290"></a>
-<span class="sourceLineNo">291</span> //create groups and assign servers<a name="line.291"></a>
-<span class="sourceLineNo">292</span> addGroup("bar", 3);<a name="line.292"></a>
-<span class="sourceLineNo">293</span> rsGroupAdmin.addRSGroup("foo");<a name="line.293"></a>
+<span class="sourceLineNo">222</span> }<a name="line.222"></a>
+<span class="sourceLineNo">223</span><a name="line.223"></a>
+<span class="sourceLineNo">224</span> public void deleteGroups() throws IOException {<a name="line.224"></a>
+<span class="sourceLineNo">225</span> RSGroupAdmin groupAdmin = new RSGroupAdminClient(TEST_UTIL.getConnection());<a name="line.225"></a>
+<span class="sourceLineNo">226</span> for(RSGroupInfo group: groupAdmin.listRSGroups()) {<a name="line.226"></a>
+<span class="sourceLineNo">227</span> if(!group.getName().equals(RSGroupInfo.DEFAULT_GROUP)) {<a name="line.227"></a>
+<span class="sourceLineNo">228</span> groupAdmin.moveTables(group.getTables(), RSGroupInfo.DEFAULT_GROUP);<a name="line.228"></a>
+<span class="sourceLineNo">229</span> groupAdmin.moveServers(group.getServers(), RSGroupInfo.DEFAULT_GROUP);<a name="line.229"></a>
+<span class="sourceLineNo">230</span> groupAdmin.removeRSGroup(group.getName());<a name="line.230"></a>
+<span class="sourceLineNo">231</span> }<a name="line.231"></a>
+<span class="sourceLineNo">232</span> }<a name="line.232"></a>
+<span class="sourceLineNo">233</span> }<a name="line.233"></a>
+<span class="sourceLineNo">234</span><a name="line.234"></a>
+<span class="sourceLineNo">235</span> public Map<TableName, List<String>> getTableRegionMap() throws IOException {<a name="line.235"></a>
+<span class="sourceLineNo">236</span> Map<TableName, List<String>> map = Maps.newTreeMap();<a name="line.236"></a>
+<span class="sourceLineNo">237</span> Map<TableName, Map<ServerName, List<String>>> tableServerRegionMap<a name="line.237"></a>
+<span class="sourceLineNo">238</span> = getTableServerRegionMap();<a name="line.238"></a>
+<span class="sourceLineNo">239</span> for(TableName tableName : tableServerRegionMap.keySet()) {<a name="line.239"></a>
+<span class="sourceLineNo">240</span> if(!map.containsKey(tableName)) {<a name="line.240"></a>
+<span class="sourceLineNo">241</span> map.put(tableName, new LinkedList<>());<a name="line.241"></a>
+<span class="sourceLineNo">242</span> }<a name="line.242"></a>
+<span class="sourceLineNo">243</span> for(List<String> subset: tableServerRegionMap.get(tableName).values()) {<a name="line.243"></a>
+<span class="sourceLineNo">244</span> map.get(tableName).addAll(subset);<a name="line.244"></a>
+<span class="sourceLineNo">245</span> }<a name="line.245"></a>
+<span class="sourceLineNo">246</span> }<a name="line.246"></a>
+<span class="sourceLineNo">247</span> return map;<a name="line.247"></a>
+<span class="sourceLineNo">248</span> }<a name="line.248"></a>
+<span class="sourceLineNo">249</span><a name="line.249"></a>
+<span class="sourceLineNo">250</span> public Map<TableName, Map<ServerName, List<String>>> getTableServerRegionMap()<a name="line.250"></a>
+<span class="sourceLineNo">251</span> throws IOException {<a name="line.251"></a>
+<span class="sourceLineNo">252</span> Map<TableName, Map<ServerName, List<String>>> map = Maps.newTreeMap();<a name="line.252"></a>
+<span class="sourceLineNo">253</span> ClusterMetrics status = TEST_UTIL.getHBaseClusterInterface().getClusterMetrics();<a name="line.253"></a>
+<span class="sourceLineNo">254</span> for (Map.Entry<ServerName, ServerMetrics> entry : status.getLiveServerMetrics().entrySet()) {<a name="line.254"></a>
+<span class="sourceLineNo">255</span> ServerName serverName = entry.getKey();<a name="line.255"></a>
+<span class="sourceLineNo">256</span> for(RegionMetrics rl : entry.getValue().getRegionMetrics().values()) {<a name="line.256"></a>
+<span class="sourceLineNo">257</span> TableName tableName = null;<a name="line.257"></a>
+<span class="sourceLineNo">258</span> try {<a name="line.258"></a>
+<span class="sourceLineNo">259</span> tableName = RegionInfo.getTable(rl.getRegionName());<a name="line.259"></a>
+<span class="sourceLineNo">260</span> } catch (IllegalArgumentException e) {<a name="line.260"></a>
+<span class="sourceLineNo">261</span> LOG.warn("Failed parse a table name from regionname=" +<a name="line.261"></a>
+<span class="sourceLineNo">262</span> Bytes.toStringBinary(rl.getRegionName()));<a name="line.262"></a>
+<span class="sourceLineNo">263</span> continue;<a name="line.263"></a>
+<span class="sourceLineNo">264</span> }<a name="line.264"></a>
+<span class="sourceLineNo">265</span> if(!map.containsKey(tableName)) {<a name="line.265"></a>
+<span class="sourceLineNo">266</span> map.put(tableName, new TreeMap<>());<a name="line.266"></a>
+<span class="sourceLineNo">267</span> }<a name="line.267"></a>
+<span class="sourceLineNo">268</span> if(!map.get(tableName).containsKey(serverName)) {<a name="line.268"></a>
+<span class="sourceLineNo">269</span> map.get(tableName).put(serverName, new LinkedList<>());<a name="line.269"></a>
+<span class="sourceLineNo">270</span> }<a name="line.270"></a>
+<span class="sourceLineNo">271</span> map.get(tableName).get(serverName).add(rl.getNameAsString());<a name="line.271"></a>
+<span class="sourceLineNo">272</span> }<a name="line.272"></a>
+<span class="sourceLineNo">273</span> }<a name="line.273"></a>
+<span class="sourceLineNo">274</span> return map;<a name="line.274"></a>
+<span class="sourceLineNo">275</span> }<a name="line.275"></a>
+<span class="sourceLineNo">276</span><a name="line.276"></a>
+<span class="sourceLineNo">277</span> // return the real number of region servers, excluding the master embedded region server in 2.0+<a name="line.277"></a>
+<span class="sourceLineNo">278</span> public int getNumServers() throws IOException {<a name="line.278"></a>
+<span class="sourceLineNo">279</span> ClusterMetrics status =<a name="line.279"></a>
+<span class="sourceLineNo">280</span> admin.getClusterMetrics(EnumSet.of(Option.MASTER, Option.LIVE_SERVERS));<a name="line.280"></a>
+<span class="sourceLineNo">281</span> ServerName masterName = status.getMasterName();<a name="line.281"></a>
+<span class="sourceLineNo">282</span> int count = 0;<a name="line.282"></a>
+<span class="sourceLineNo">283</span> for (ServerName sn : status.getLiveServerMetrics().keySet()) {<a name="line.283"></a>
+<span class="sourceLineNo">284</span> if (!sn.equals(masterName)) {<a name="line.284"></a>
+<span class="sourceLineNo">285</span> count++;<a name="line.285"></a>
+<span class="sourceLineNo">286</span> }<a name="line.286"></a>
+<span class="sourceLineNo">287</span> }<a name="line.287"></a>
+<span class="sourceLineNo">288</span> return count;<a name="line.288"></a>
+<span class="sourceLineNo">289</span> }<a name="line.289"></a>
+<span class="sourceLineNo">290</span><a name="line.290"></a>
+<span class="sourceLineNo">291</span> public String getGroupName(String baseName) {<a name="line.291"></a>
+<span class="sourceLineNo">292</span> return groupPrefix+"_"+baseName+"_"+rand.nextInt(Integer.MAX_VALUE);<a name="line.292"></a>
+<span class="sourceLineNo">293</span> }<a name="line.293"></a>
<span class="sourceLineNo">294</span><a name="line.294"></a>
-<span class="sourceLineNo">295</span> RSGroupInfo barGroup = rsGroupAdmin.getRSGroupInfo("bar");<a name="line.295"></a>
-<span class="sourceLineNo">296</span> RSGroupInfo fooGroup = rsGroupAdmin.getRSGroupInfo("foo");<a name="line.296"></a>
-<span class="sourceLineNo">297</span> assertEquals(3, barGroup.getServers().size());<a name="line.297"></a>
-<span class="sourceLineNo">298</span> assertEquals(0, fooGroup.getServers().size());<a name="line.298"></a>
-<span class="sourceLineNo">299</span><a name="line.299"></a>
-<span class="sourceLineNo">300</span> //test fail bogus server move<a name="line.300"></a>
-<span class="sourceLineNo">301</span> try {<a name="line.301"></a>
-<span class="sourceLineNo">302</span> rsGroupAdmin.moveServers(Sets.newHashSet(Address.fromString("foo:9999")),"foo");<a name="line.302"></a>
-<span class="sourceLineNo">303</span> fail("Bogus servers shouldn't have been successfully moved.");<a name="line.303"></a>
-<span class="sourceLineNo">304</span> } catch(IOException ex) {<a name="line.304"></a>
-<span class="sourceLineNo">305</span> String exp = "Source RSGroup for server foo:9999 does not exist.";<a name="line.305"></a>
-<span class="sourceLineNo">306</span> String msg = "Expected '"+exp+"' in exception message: ";<a name="line.306"></a>
-<span class="sourceLineNo">307</span> assertTrue(msg+" "+ex.getMessage(), ex.getMessage().contains(exp));<a name="line.307"></a>
-<span class="sourceLineNo">308</span> }<a name="line.308"></a>
-<span class="sourceLineNo">309</span><a name="line.309"></a>
-<span class="sourceLineNo">310</span> //test success case<a name="line.310"></a>
-<span class="sourceLineNo">311</span> LOG.info("moving servers "+barGroup.getServers()+" to group foo");<a name="line.311"></a>
-<span class="sourceLineNo">312</span> rsGroupAdmin.moveServers(barGroup.getServers(), fooGroup.getName());<a name="line.312"></a>
-<span class="sourceLineNo">313</span><a name="line.313"></a>
-<span class="sourceLineNo">314</span> barGroup = rsGroupAdmin.getRSGroupInfo("bar");<a name="line.314"></a>
-<span class="sourceLineNo">315</span> fooGroup = rsGroupAdmin.getRSGroupInfo("foo");<a name="line.315"></a>
-<span class="sourceLineNo">316</span> assertEquals(0,barGroup.getServers().size());<a name="line.316"></a>
-<span class="sourceLineNo">317</span> assertEquals(3,fooGroup.getServers().size());<a name="line.317"></a>
+<span class="sourceLineNo">295</span> public static class CPMasterObserver implements MasterCoprocessor, MasterObserver {<a name="line.295"></a>
+<span class="sourceLineNo">296</span> boolean preBalanceRSGroupCalled = false;<a name="line.296"></a>
+<span class="sourceLineNo">297</span> boolean postBalanceRSGroupCalled = false;<a name="line.297"></a>
+<span class="sourceLineNo">298</span> boolean preMoveServersCalled = false;<a name="line.298"></a>
+<span class="sourceLineNo">299</span> boolean postMoveServersCalled = false;<a name="line.299"></a>
+<span class="sourceLineNo">300</span> boolean preMoveTablesCalled = false;<a name="line.300"></a>
+<span class="sourceLineNo">301</span> boolean postMoveTablesCalled = false;<a name="line.301"></a>
+<span class="sourceLineNo">302</span> boolean preAddRSGroupCalled = false;<a name="line.302"></a>
+<span class="sourceLineNo">303</span> boolean postAddRSGroupCalled = false;<a name="line.303"></a>
+<span class="sourceLineNo">304</span> boolean preRemoveRSGroupCalled = false;<a name="line.304"></a>
+<span class="sourceLineNo">305</span> boolean postRemoveRSGroupCalled = false;<a name="line.305"></a>
+<span class="sourceLineNo">306</span> boolean preRemoveServersCalled = false;<a name="line.306"></a>
+<span class="sourceLineNo">307</span> boolean postRemoveServersCalled = false;<a name="line.307"></a>
+<span class="sourceLineNo">308</span> boolean preMoveServersAndTables = false;<a name="line.308"></a>
+<span class="sourceLineNo">309</span> boolean postMoveServersAndTables = false;<a name="line.309"></a>
+<span class="sourceLineNo">310</span> boolean preGetRSGroupInfoCalled = false;<a name="line.310"></a>
+<span class="sourceLineNo">311</span> boolean postGetRSGroupInfoCalled = false;<a name="line.311"></a>
+<span class="sourceLineNo">312</span> boolean preGetRSGroupInfoOfTableCalled = false;<a name="line.312"></a>
+<span class="sourceLineNo">313</span> boolean postGetRSGroupInfoOfTableCalled = false;<a name="line.313"></a>
+<span class="sourceLineNo">314</span> boolean preListRSGroupsCalled = false;<a name="line.314"></a>
+<span class="sourceLineNo">315</span> boolean postListRSGroupsCalled = false;<a name="line.315"></a>
+<span class="sourceLineNo">316</span> boolean preGetRSGroupInfoOfServerCalled = false;<a name="line.316"></a>
+<span class="sourceLineNo">317</span> boolean postGetRSGroupInfoOfServerCalled = false;<a name="line.317"></a>
<span class="sourceLineNo">318</span><a name="line.318"></a>
-<span class="sourceLineNo">319</span> LOG.info("moving servers "+fooGroup.getServers()+" to group default");<a name="line.319"></a>
-<span class="sourceLineNo">320</span> rsGroupAdmin.moveServers(fooGroup.getServers(), RSGroupInfo.DEFAULT_GROUP);<a name="line.320"></a>
-<span class="sourceLineNo">321</span><a name="line.321"></a>
-<span class="sourceLineNo">322</span> TEST_UTIL.waitFor(WAIT_TIMEOUT, new Waiter.Predicate<Exception>() {<a name="line.322"></a>
-<span class="sourceLineNo">323</span> @Override<a name="line.323"></a>
-<span class="sourceLineNo">324</span> public boolean evaluate() throws Exception {<a name="line.324"></a>
-<span class="sourceLineNo">325</span> return getNumServers() ==<a name="line.325"></a>
-<span class="sourceLineNo">326</span> rsGroupAdmin.getRSGroupInfo(RSGroupInfo.DEFAULT_GROUP).getServers().size();<a name="line.326"></a>
-<span class="sourceLineNo">327</span> }<a name="line.327"></a>
-<span class="sourceLineNo">328</span> });<a name="line.328"></a>
-<span class="sourceLineNo">329</span><a name="line.329"></a>
-<span class="sourceLineNo">330</span> fooGroup = rsGroupAdmin.getRSGroupInfo("foo");<a name="line.330"></a>
-<span class="sourceLineNo">331</span> assertEquals(0,fooGroup.getServers().size());<a name="line.331"></a>
-<span class="sourceLineNo">332</span><a name="line.332"></a>
-<span class="sourceLineNo">333</span> //test group removal<a name="line.333"></a>
-<span class="sourceLineNo">334</span> LOG.info("Remove group "+barGroup.getName());<a name="line.334"></a>
-<span class="sourceLineNo">335</span> rsGroupAdmin.removeRSGroup(barGroup.getName());<a name="line.335"></a>
-<span class="sourceLineNo">336</span> Assert.assertEquals(null, rsGroupAdmin.getRSGroupInfo(barGroup.getName()));<a name="line.336"></a>
-<span class="sourceLineNo">337</span> LOG.info("Remove group "+fooGroup.getName());<a name="line.337"></a>
-<span class="sourceLineNo">338</span> rsGroupAdmin.removeRSGroup(fooGroup.getName());<a name="line.338"></a>
-<span class="sourceLineNo">339</span> Assert.assertEquals(null, rsGroupAdmin.getRSGroupInfo(fooGroup.getName()));<a name="line.339"></a>
-<span class="sourceLineNo">340</span> }<a name="line.340"></a>
-<span class="sourceLineNo">341</span><a name="line.341"></a>
-<span class="sourceLineNo">342</span> @Test<a name="line.342"></a>
-<span class="sourceLineNo">343</span> public void testMoveServersFromDefaultGroup() throws Exception {<a name="line.343"></a>
-<span class="sourceLineNo">344</span> //create groups and assign servers<a name="line.344"></a>
-<span class="sourceLineNo">345</span> rsGroupAdmin.addRSGroup("foo");<a name="line.345"></a>
-<span class="sourceLineNo">346</span><a name="line.346"></a>
-<span class="sourceLineNo">347</span> RSGroupInfo fooGroup = rsGroupAdmin.getRSGroupInfo("foo");<a name="line.347"></a>
-<span class="sourceLineNo">348</span> assertEquals(0, fooGroup.getServers().size());<a name="line.348"></a>
-<span class="sourceLineNo">349</span> RSGroupInfo defaultGroup = rsGroupAdmin.getRSGroupInfo(RSGroupInfo.DEFAULT_GROUP);<a name="line.349"></a>
-<span class="sourceLineNo">350</span><a name="line.350"></a>
-<span class="sourceLineNo">351</span> //test remove all servers from default<a name="line.351"></a>
-<span class="sourceLineNo">352</span> try {<a name="line.352"></a>
-<span class="sourceLineNo">353</span> rsGroupAdmin.moveServers(defaultGroup.getServers(), fooGroup.getName());<a name="line.353"></a>
-<span class="sourceLineNo">354</span> fail(RSGroupAdminServer.KEEP_ONE_SERVER_IN_DEFAULT_ERROR_MESSAGE);<a name="line.354"></a>
-<span class="sourceLineNo">355</span> } catch (ConstraintException ex) {<a name="line.355"></a>
-<span class="sourceLineNo">356</span> assertTrue(ex.getMessage().contains(RSGroupAdminServer<a name="line.356"></a>
-<span class="sourceLineNo">357</span> .KEEP_ONE_SERVER_IN_DEFAULT_ERROR_MESSAGE));<a name="line.357"></a>
-<span class="sourceLineNo">358</span> }<a name="line.358"></a>
-<span class="sourceLineNo">359</span><a name="line.359"></a>
-<span class="sourceLineNo">360</span> //test success case, remove one server from default ,keep at least one server<a name="line.360"></a>
-<span class="sourceLineNo">361</span> if (defaultGroup.getServers().size() > 1) {<a name="line.361"></a>
-<span class="sourceLineNo">362</span> Address serverInDefaultGroup = defaultGroup.getServers().iterator().next();<a name="line.362"></a>
-<span class="sourceLineNo">363</span> LOG.info("moving server " + serverInDefaultGroup + " from group default to group " +<a name="line.363"></a>
-<span class="sourceLineNo">364</span> fooGroup.getName());<a name="line.364"></a>
-<span class="sourceLineNo">365</span> rsGroupAdmin.moveServers(Sets.newHashSet(serverInDefaultGroup), fooGroup.getName());<a name="line.365"></a>
+<span class="sourceLineNo">319</span> public void resetFlags() {<a name="line.319"></a>
+<span class="sourceLineNo">320</span> preBalanceRSGroupCalled = false;<a name="line.320"></a>
+<span class="sourceLineNo">321</span> postBalanceRSGroupCalled = false;<a name="line.321"></a>
+<span class="sourceLineNo">322</span> preMoveServersCalled = false;<a name="line.322"></a>
+<span class="sourceLineNo">323</span> postMoveServersCalled = false;<a name="line.323"></a>
+<span class="sourceLineNo">324</span> preMoveTablesCalled = false;<a name="line.324"></a>
+<span class="sourceLineNo">325</span> postMoveTablesCalled = false;<a name="line.325"></a>
+<span class="sourceLineNo">326</span> preAddRSGroupCalled = false;<a name="line.326"></a>
+<span class="sourceLineNo">327</span> postAddRSGroupCalled = false;<a name="line.327"></a>
+<span class="sourceLineNo">328</span> preRemoveRSGroupCalled = false;<a name="line.328"></a>
+<span class="sourceLineNo">329</span> postRemoveRSGroupCalled = false;<a name="line.329"></a>
+<span class="sourceLineNo">330</span> preRemoveServersCalled = false;<a name="line.330"></a>
+<span class="sourceLineNo">331</span> postRemoveServersCalled = false;<a name="line.331"></a>
+<span class="sourceLineNo">332</span> preMoveServersAndTables = false;<a name="line.332"></a>
+<span class="sourceLineNo">333</span> postMoveServersAndTables = false;<a name="line.333"></a>
+<span class="sourceLineNo">334</span> preGetRSGroupInfoCalled = false;<a name="line.334"></a>
+<span class="sourceLineNo">335</span> postGetRSGroupInfoCalled = false;<a name="line.335"></a>
+<span class="sourceLineNo">336</span> preGetRSGroupInfoOfTableCalled = false;<a name="line.336"></a>
+<span class="sourceLineNo">337</span> postGetRSGroupInfoOfTableCalled = false;<a name="line.337"></a>
+<span class="sourceLineNo">338</span> preListRSGroupsCalled = false;<a name="line.338"></a>
+<span class="sourceLineNo">339</span> postListRSGroupsCalled = false;<a name="line.339"></a>
+<span class="sourceLineNo">340</span> preGetRSGroupInfoOfServerCalled = false;<a name="line.340"></a>
+<span class="sourceLineNo">341</span> postGetRSGroupInfoOfServerCalled = false;<a name="line.341"></a>
+<span class="sourceLineNo">342</span> }<a name="line.342"></a>
+<span class="sourceLineNo">343</span><a name="line.343"></a>
+<span class="sourceLineNo">344</span> @Override<a name="line.344"></a>
+<span class="sourceLineNo">345</span> public Optional<MasterObserver> getMasterObserver() {<a name="line.345"></a>
+<span class="sourceLineNo">346</span> return Optional.of(this);<a name="line.346"></a>
+<span class="sourceLineNo">347</span> }<a name="line.347"></a>
+<span class="sourceLineNo">348</span><a name="line.348"></a>
+<span class="sourceLineNo">349</span> @Override<a name="line.349"></a>
+<span class="sourceLineNo">350</span> public void preMoveServersAndTables(final ObserverContext<MasterCoprocessorEnvironment> ctx,<a name="line.350"></a>
+<span class="sourceLineNo">351</span> Set<Address> servers, Set<TableName> tables, String targetGroup) throws IOException {<a name="line.351"></a>
+<span class="sourceLineNo">352</span> preMoveServersAndTables = true;<a name="line.352"></a>
+<span class="sourceLineNo">353</span> }<a name="line.353"></a>
+<span class="sourceLineNo">354</span><a name="line.354"></a>
+<span class="sourceLineNo">355</span> @Override<a name="line.355"></a>
+<span class="sourceLineNo">356</span> public void postMoveServersAndTables(final ObserverContext<MasterCoprocessorEnvironment> ctx,<a name="line.356"></a>
+<span class="sourceLineNo">357</span> Set<Address> servers, Set<TableName> tables, String targetGroup) throws IOException {<a name="line.357"></a>
+<span class="sourceLineNo">358</span> postMoveServersAndTables = true;<a name="line.358"></a>
+<span class="sourceLineNo">359</span> }<a name="line.359"></a>
+<span class="sourceLineNo">360</span><a name="line.360"></a>
+<span class="sourceLineNo">361</span> @Override<a name="line.361"></a>
+<span class="sourceLineNo">362</span> public void preRemoveServers(<a name="line.362"></a>
+<span class="sourceLineNo">363</span> final ObserverContext<MasterCoprocessorEnvironment> ctx,<a name="line.363"></a>
+<span class="sourceLineNo">364</span> Set<Address> servers) throws IOException {<a name="line.364"></a>
+<span class="sourceLineNo">365</span> preRemoveServersCalled = true;<a name="line.365"></a>
<span class="sourceLineNo">366</span> }<a name="line.366"></a>
<span class="sourceLineNo">367</span><a name="line.367"></a>
-<span class="sourceLineNo">368</span> fooGroup = rsGroupAdmin.getRSGroupInfo("foo");<a name="line.368"></a>
-<span class="sourceLineNo">369</span> LOG.info("moving servers " + fooGroup.getServers() + " to group default");<a name="line.369"></a>
-<span class="sourceLineNo">370</span> rsGroupAdmin.moveServers(fooGroup.getServers(), RSGroupInfo.DEFAULT_GROUP);<a name="line.370"></a>
-<span class="sourceLineNo">371</span><a name="line.371"></a>
-<span class="sourceLineNo">372</span> TEST_UTIL.waitFor(WAIT_TIMEOUT, new Waiter.Predicate<Exception>() {<a name="line.372"></a>
-<span class="sourceLineNo">373</span> @Override<a name="line.373"></a>
-<span class="sourceLineNo">374</span> public boolean evaluate() throws Exception {<a name="line.374"></a>
-<span class="sourceLineNo">375</span> return getNumServers() ==<a name="line.375"></a>
-<span class="sourceLineNo">376</span> rsGroupAdmin.getRSGroupInfo(RSGroupInfo.DEFAULT_GROUP).getServers().size();<a name="line.376"></a>
-<span class="sourceLineNo">377</span> }<a name="line.377"></a>
-<span class="sourceLineNo">378</span> });<a name="line.378"></a>
-<span class="sourceLineNo">379</span><a name="line.379"></a>
-<span class="sourceLineNo">380</span> fooGroup = rsGroupAdmin.getRSGroupInfo("foo");<a name="line.380"></a>
-<span class="sourceLineNo">381</span> assertEquals(0, fooGroup.getServers().size());<a name="line.381"></a>
-<span class="sourceLineNo">382</span><a name="line.382"></a>
-<span class="sourceLineNo">383</span> //test group removal<a name="line.383"></a>
-<span class="sourceLineNo">384</span> LOG.info("Remove group " + fooGroup.getName());<a name="line.384"></a>
-<span class="sourceLineNo">385</span> rsGroupAdmin.removeRSGroup(fooGroup.getName());<a name="line.385"></a>
-<span class="sourceLineNo">386</span> Assert.assertEquals(null, rsGroupAdmin.getRSGroupInfo(fooGroup.getName()));<a name="line.386"></a>
-<span class="sourceLineNo">387</span> }<a name="line.387"></a>
-<span class="sourceLineNo">388</span><a name="line.388"></a>
-<span class="sourceLineNo">389</span> @Test<a name="line.389"></a>
-<span class="sourceLineNo">390</span> public void testTableMoveTruncateAndDrop() throws Exception {<a name="line.390"></a>
-<span class="sourceLineNo">391</span> final byte[] familyNameBytes = Bytes.toBytes("f");<a name="line.391"></a>
-<span class="sourceLineNo">392</span> String newGroupName = getGroupName(name.getMethodName());<a name="line.392"></a>
-<span class="sourceLineNo">393</span> final RSGroupInfo newGroup = addGroup(newGroupName, 2);<a name="line.393"></a>
-<span class="sourceLineNo">394</span><a name="line.394"></a>
-<span class="sourceLineNo">395</span> TEST_UTIL.createMultiRegionTable(tableName, familyNameBytes, 5);<a name="line.395"></a>
-<span class="sourceLineNo">396</span> TEST_UTIL.waitFor(WAIT_TIMEOUT, new Waiter.Predicate<Exception>() {<a name="line.396"></a>
-<span class="sourceLineNo">397</span> @Override<a name="line.397"></a>
-<span class="sourceLineNo">398</span> public boolean evaluate() throws Exception {<a name="line.398"></a>
-<span class="sourceLineNo">399</span> List<String> regions = getTableRegionMap().get(tableName);<a name="line.399"></a>
-<span class="sourceLineNo">400</span> if (regions == null) {<a name="line.400"></a>
-<span class="sourceLineNo">401</span> return false;<a name="line.401"></a>
-<span class="sourceLineNo">402</span> }<a name="line.402"></a>
-<span class="sourceLineNo">403</span><a name="line.403"></a>
-<span class="sourceLineNo">404</span> return getTableRegionMap().get(tableName).size() >= 5;<a name="line.404"></a>
-<span class="sourceLineNo">405</span> }<a name="line.405"></a>
-<span class="sourceLineNo">406</span> });<a name="line.406"></a>
-<span class="sourceLineNo">407</span><a name="line.407"></a>
-<span class="sourceLineNo">408</span> RSGroupInfo tableGrp = rsGroupAdmin.getRSGroupInfoOfTable(tableName);<a name="line.408"></a>
-<span class="sourceLineNo">409</span> assertTrue(tableGrp.getName().equals(RSGroupInfo.DEFAULT_GROUP));<a name="line.409"></a>
+<span class="sourceLineNo">368</span> @Override<a name="line.368"></a>
+<span class="sourceLineNo">369</span> public void postRemoveServers(<a name="line.369"></a>
+<span class="sourceLineNo">370</span> final ObserverContext<MasterCoprocessorEnvironment> ctx,<a name="line.370"></a>
+<span class="sourceLineNo">371</span> Set<Address> servers) throws IOException {<a name="line.371"></a>
+<span class="sourceLineNo">372</span> postRemoveServersCalled = true;<a name="line.372"></a>
+<span class="sourceLineNo">373</span> }<a name="line.373"></a>
+<span class="sourceLineNo">374</span><a name="line.374"></a>
+<span class="sourceLineNo">375</span> @Override<a name="line.375"></a>
+<span class="sourceLineNo">376</span> public void preRemoveRSGroup(final ObserverContext<MasterCoprocessorEnvironment> ctx,<a name="line.376"></a>
+<span class="sourceLineNo">377</span> String name) throws IOException {<a name="line.377"></a>
+<span class="sourceLineNo">378</span> preRemoveRSGroupCalled = true;<a name="line.378"></a>
+<span class="sourceLineNo">379</span> }<a name="line.379"></a>
+<span class="sourceLineNo">380</span><a name="line.380"></a>
+<span class="sourceLineNo">381</span> @Override<a name="line.381"></a>
+<span class="sourceLineNo">382</span> public void postRemoveRSGroup(final ObserverContext<MasterCoprocessorEnvironment> ctx,<a name="line.382"></a>
+<span class="sourceLineNo">383</span> String name) throws IOException {<a name="line.383"></a>
+<span class="sourceLineNo">384</span> postRemoveRSGroupCalled = true;<a name="line.384"></a>
+<span class="sourceLineNo">385</span> }<a name="line.385"></a>
+<span class="sourceLineNo">386</span><a name="line.386"></a>
+<span class="sourceLineNo">387</span> @Override<a name="line.387"></a>
+<span class="sourceLineNo">388</span> public void preAddRSGroup(final ObserverContext<MasterCoprocessorEnvironment> ctx,<a name="line.388"></a>
+<span class="sourceLineNo">389</span> String name) throws IOException {<a name="line.389"></a>
+<span class="sourceLineNo">390</span> preAddRSGroupCalled = true;<a name="line.390"></a>
+<span class="sourceLineNo">391</span> }<a name="line.391"></a>
+<span class="sourceLineNo">392</span><a name="line.392"></a>
+<span class="sourceLineNo">393</span> @Override<a name="line.393"></a>
+<span class="sourceLineNo">394</span> public void postAddRSGroup(final ObserverContext<MasterCoprocessorEnvironment> ctx,<a name="line.394"></a>
+<span class="sourceLineNo">395</span> String name) throws IOException {<a name="line.395"></a>
+<span class="sourceLineNo">396</span> postAddRSGroupCalled = true;<a name="line.396"></a>
+<span class="sourceLineNo">397</span> }<a name="line.397"></a>
+<span class="sourceLineNo">398</span><a name="line.398"></a>
+<span class="sourceLineNo">399</span> @Override<a name="line.399"></a>
+<span class="sourceLineNo">400</span> public void preMoveTables(final ObserverContext<MasterCoprocessorEnvironment> ctx,<a name="line.400"></a>
+<span class="sourceLineNo">401</span> Set<TableName> tables, String targetGroup) throws IOException {<a name="line.401"></a>
+<span class="sourceLineNo">402</span> preMoveTablesCalled = true;<a name="line.402"></a>
+<span class="sourceLineNo">403</span> }<a name="line.403"></a>
+<span class="sourceLineNo">404</span><a name="line.404"></a>
+<span class="sourceLineNo">405</span> @Override<a name="line.405"></a>
+<span class="sourceLineNo">406</span> public void postMoveTables(final ObserverContext<MasterCoprocessorEnvironment> ctx,<a name="line.406"></a>
+<span class="sourceLineNo">407</span> Set<TableName> tables, String targetGroup) throws IOException {<a name="line.407"></a>
+<span class="sourceLineNo">408</span> postMoveTablesCalled = true;<a name="line.408"></a>
+<span class="sourceLineNo">409</span> }<a name="line.409"></a>
<span class="sourceLineNo">410</span><a name="line.410"></a>
-<span class="sourceLineNo">411</span> //change table's group<a name="line.411"></a>
-<span class="sourceLineNo">412</span> LOG.info("Moving table "+tableName+" to "+newGroup.getName());<a name="line.412"></a>
-<span class="sourceLineNo">413</span> rsGroupAdmin.moveTables(Sets.newHashSet(tableName), newGroup.getName());<a name="line.413"></a>
-<span class="sourceLineNo">414</span><a name="line.414"></a>
-<span class="sourceLineNo">415</span> //verify group change<a name="line.415"></a>
-<span class="sourceLineNo">416</span> Assert.assertEquals(newGroup.getName(),<a name="line.416"></a>
-<span class="sourceLineNo">417</span> rsGroupAdmin.getRSGroupInfoOfTable(tableName).getName());<a name="line.417"></a>
-<span class="sourceLineNo">418</span><a name="line.418"></a>
-<span class="sourceLineNo">419</span> TEST_UTIL.waitFor(WAIT_TIMEOUT, new Waiter.Predicate<Exception>() {<a name="line.419"></a>
-<span class="sourceLineNo">420</span> @Override<a name="line.420"></a>
-<span class="sourceLineNo">421</span> public boolean evaluate() throws Exception {<a name="line.421"></a>
-<span class="sourceLineNo">422</span> Map<ServerName, List<String>> serverMap = getTableServerRegionMap().get(tableName);<a name="line.422"></a>
-<span class="sourceLineNo">423</span> int count = 0;<a name="line.423"></a>
-<span class="sourceLineNo">424</span> if (serverMap != null) {<a name="line.424"></a>
-<span class="sourceLineNo">425</span> for (ServerName rs : serverMap.keySet()) {<a name="line.425"></a>
-<span class="sourceLineNo">426</span> if (newGroup.containsServer(rs.getAddress())) {<a name="line.426"></a>
-<span class="sourceLineNo">427</span> count += serverMap.get(rs).size();<a name="line.427"></a>
-<span class="sourceLineNo">428</span> }<a name="line.428"></a>
-<span class="sourceLineNo">429</span> }<a name="line.429"></a>
-<span class="sourceLineNo">430</span> }<a name="line.430"></a>
-<span class="sourceLineNo">431</span> return count == 5;<a name="line.431"></a>
-<span class="sourceLineNo">432</span> }<a name="line.432"></a>
-<span class="sourceLineNo">433</span> });<a name="line.433"></a>
+<span class="sourceLineNo">411</span> @Override<a name="line.411"></a>
+<span class="sourceLineNo">412</span> public void preMoveServers(final ObserverContext<MasterCoprocessorEnvironment> ctx,<a name="line.412"></a>
+<span class="sourceLineNo">413</span> Set<Address> servers, String targetGroup) throws IOException {<a name="line.413"></a>
+<span class="sourceLineNo">414</span> preMoveServersCalled = true;<a name="line.414"></a>
+<span class="sourceLineNo">415</span> }<a name="line.415"></a>
+<span class="sourceLineNo">416</span><a name="line.416"></a>
+<span class="sourceLineNo">417</span> @Override<a name="line.417"></a>
+<span class="sourceLineNo">418</span> public void postMoveServers(final ObserverContext<MasterCoprocessorEnvironment> ctx,<a name="line.418"></a>
+<span class="sourceLineNo">419</span> Set<Address> servers, String targetGroup) throws IOException {<a name="line.419"></a>
+<span class="sourceLineNo">420</span> postMoveServersCalled = true;<a name="line.420"></a>
+<span class="sourceLineNo">421</span> }<a name="line.421"></a>
+<span class="sourceLineNo">422</span><a name="line.422"></a>
+<span class="sourceLineNo">423</span> @Override<a name="line.423"></a>
+<span class="sourceLineNo">424</span> public void preBalanceRSGroup(final ObserverContext<MasterCoprocessorEnvironment> ctx,<a name="line.424"></a>
+<span class="sourceLineNo">425</span> String groupName) throws IOException {<a name="line.425"></a>
+<span class="sourceLineNo">426</span> preBalanceRSGroupCalled = true;<a name="line.426"></a>
+<span class="sourceLineNo">427</span> }<a name="line.427"></a>
+<span class="sourceLineNo">428</span><a name="line.428"></a>
+<span class="sourceLineNo">429</span> @Override<a name="line.429"></a>
+<span class="sourceLineNo">430</span> public void postBalanceRSGroup(final ObserverContext<MasterCoprocessorEnvironment> ctx,<a name="line.430"></a>
+<span class="sourceLineNo">431</span> String groupName, boolean balancerRan) throws IOException {<a name="line.431"></a>
+<span class="sourceLineNo">432</span> postBalanceRSGroupCalled = true;<a name="line.432"></a>
+<span class="sourceLineNo">433</span> }<a name="line.433"></a>
<span class="sourceLineNo">434</span><a name="line.434"></a>
-<span class="sourceLineNo">435</span> //test truncate<a name="line.435"></a>
-<span class="sourceLineNo">436</span> admin.disableTable(tableName);<a name="line.436"></a>
-<span class="sourceLineNo">437</span> admin.truncateTable(tableName, true);<a name="line.437"></a>
-<span class="sourceLineNo">438</span> Assert.assertEquals(1, rsGroupAdmin.getRSGroupInfo(newGroup.getName()).getTables().size());<a name="line.438"></a>
-<span class="sourceLineNo">439</span> Assert.assertEquals(tableName, rsGroupAdmin.getRSGroupInfo(<a name="line.439"></a>
-<span class="sourceLineNo">440</span> newGroup.getName()).getTables().first());<a name="line.440"></a>
-<span class="sourceLineNo">441</span><a name="line.441"></a>
-<span class="sourceLineNo">442</span> //verify removed table is removed from group<a name="line.442"></a>
-<span class="sourceLineNo">443</span> TEST_UTIL.deleteTable(tableName);<a name="line.443"></a>
-<span class="sourceLineNo">444</span> Assert.assertEquals(0, rsGroupAdmin.getRSGroupInfo(newGroup.getName()).getTables().size());<a name="line.444"></a>
-<span class="sourceLineNo">445</span> }<a name="line.445"></a>
+<span class="sourceLineNo">435</span> @Override<a name="line.435"></a>
+<span class="sourceLineNo">436</span> public void preGetRSGroupInfo(final ObserverContext<MasterCoprocessorEnvironment> ctx,<a name="line.436"></a>
+<span class="sourceLineNo">437</span> final String groupName) throws IOException {<a name="line.437"></a>
+<span class="sourceLineNo">438</span> preGetRSGroupInfoCalled = true;<a name="line.438"></a>
+<span class="sourceLineNo">439</span> }<a name="line.439"></a>
+<span class="sourceLineNo">440</span><a name="line.440"></a>
+<span class="sourceLineNo">441</span> @Override<a name="line.441"></a>
+<span class="sourceLineNo">442</span> public void postGetRSGroupInfo(final ObserverContext<MasterCoprocessorEnvironment> ctx,<a name="line.442"></a>
+<span class="sourceLineNo">443</span> final String groupName) throws IOException {<a name="line.443"></a>
+<span class="sourceLineNo">444</span> postGetRSGroupInfoCalled = true;<a name="line.444"></a>
+<span class="sourceLineNo">445</span> }<a name="line.445"></a>
<span class="sourceLineNo">446</span><a name="line.446"></a>
-<span class="sourceLineNo">447</span> @Test<a name="line.447"></a>
-<span class="sourceLineNo">448</span> public void testGroupBalance() throws Exception {<a name="line.448"></a>
-<span class="sourceLineNo">449</span> LOG.info(name.getMethodName());<a name="line.449"></a>
-<span class="sourceLineNo">450</span> String newGroupName = getGroupName(name.getMethodName());<a name="line.450"></a>
-<span class="sourceLineNo">451</span> final RSGroupInfo newGroup = addGroup(newGroupName, 3);<a name="line.451"></a>
+<span class="sourceLineNo">447</span> @Override<a name="line.447"></a>
+<span class="sourceLineNo">448</span> public void preGetRSGroupInfoOfTable(final ObserverContext<MasterCoprocessorEnvironment> ctx,<a name="line.448"></a>
+<span class="sourceLineNo">449</span> final TableName tableName) throws IOException {<a name="line.449"></a>
+<span class="sourceLineNo">450</span> preGetRSGroupInfoOfTableCalled = true;<a name="line.450"></a>
+<span class="sourceLineNo">451</span> }<a name="line.451"></a>
<span class="sourceLineNo">452</span><a name="line.452"></a>
-<span class="sourceLineNo">453</span> final TableName tableName = TableName.valueOf(tablePrefix+"_ns", name.getMethodName());<a name="line.453"></a>
-<span class="sourceLineNo">454</span> admin.createNamespace(<a name="line.454"></a>
-<span class="sourceLineNo">455</span> NamespaceDescriptor.create(tableName.getNamespaceAsString())<a name="line.455"></a>
-<span class="sourceLineNo">456</span> .addConfiguration(RSGroupInfo.NAMESPACE_DESC_PROP_GROUP, newGroupName).build());<a name="line.456"></a>
-<span class="sourceLineNo">457</span> final byte[] familyNameBytes = Bytes.toBytes("f");<a name="line.457"></a>
-<span class="sourceLineNo">458</span> final HTableDescriptor desc = new HTableDescriptor(tableName);<a name="line.458"></a>
-<span class="sourceLineNo">459</span> desc.addFamily(new HColumnDescriptor("f"));<a name="line.459"></a>
-<span class="sourceLineNo">460</span> byte [] startKey = Bytes.toBytes("aaaaa");<a name="line.460"></a>
-<span class="sourceLineNo">461</span> byte [] endKey = Bytes.toBytes("zzzzz");<a name="line.461"></a>
-<span class="sourceLineNo">462</span> admin.createTable(desc, startKey, endKey, 6);<a name="line.462"></a>
-<span class="sourceLineNo">463</span> TEST_UTIL.waitFor(WAIT_TIMEOUT, new Waiter.Predicate<Exception>() {<a name="line.463"></a>
-<span class="sourceLineNo">464</span> @Override<a name="line.464"></a>
-<span class="sourceLineNo">465</span> public boolean evaluate() throws Exception {<a name="line.465"></a>
-<span class="sourceLineNo">466</span> List<String> regions = getTableRegionMap().get(tableName);<a name="line.466"></a>
-<span class="sourceLineNo">467</span> if (regions == null) {<a name="line.467"></a>
-<span class="sourceLineNo">468</span> return false;<a name="line.468"></a>
-<span class="sourceLineNo">469</span> }<a name="line.469"></a>
-<span class="sourceLineNo">470</span> return regions.size() >= 6;<a name="line.470"></a>
-<span class="sourceLineNo">471</span> }<a name="line.471"></a>
-<span class="sourceLineNo">472</span> });<a name="line.472"></a>
-<span class="sourceLineNo">473</span><a name="line.473"></a>
-<span class="sourceLineNo">474</span> //make assignment uneven, move all regions to one server<a name="line.474"></a>
-<span class="sourceLineNo">475</span> Map<ServerName,List<String>> assignMap =<a name="line.475"></a>
-<span class="sourceLineNo">476</span> getTableServerRegionMap().get(tableName);<a name="line.476"></a>
-<span class="sourceLineNo">477</span> final ServerName first = assignMap.entrySet().iterator().next().getKey();<a name="line.477"></a>
-<span class="sourceLineNo">478</span> for(RegionInfo region: admin.getTableRegions(tableName)) {<a name="line.478"></a>
-<span class="sourceLineNo">479</span> if(!assignMap.get(first).contains(region.getRegionNameAsString())) {<a name="line.479"></a>
-<span class="sourceLineNo">480</span> admin.move(region.getEncodedNameAsBytes(), Bytes.toBytes(first.getServerName()));<a name="line.480"></a>
-<span class="sourceLineNo">481</span> }<a name="line.481"></a>
-<span class="sourceLineNo">482</span> }<a name="line.482"></a>
-<span class="sourceLineNo">483</span> TEST_UTIL.waitFor(WAIT_TIMEOUT, new Waiter.Predicate<Exception>() {<a name="line.483"></a>
-<span class="sourceLineNo">484</span> @Override<a name="line.484"></a>
-<span class="sourceLineNo">485</span> public boolean evaluate() throws Exception {<a name="line.485"></a>
-<span class="sourceLineNo">486</span> Map<ServerName, List<String>> map = getTableServerRegionMap().get(tableName);<a name="line.486"></a>
-<span class="sourceLineNo">487</span>
<TRUNCATED>