[GitHub] commons-lang issue #245: Use foreach

[PascalSchumacher <gi...@git.apache.org>]

Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-lang/pull/245
  
    For time to time there are discussion concerning the use of the for-each loop on the mailing list. (e.g. http://markmail.org/thread/wmedbgqmewmpiptk#query:+page:1+mid:gbo5cpywwfxl5p4w+state:results) As far as I remember the consensus was to use it only for arrays, because there it does not have any negative impact on performance. When used with iterables it has some impact on performance (because it requires the creation of an iterator). Therefore some contributors were against using it with iterables in a low level library like commons-lang.
    
    Most of your changes concern arrays, so if you remove the iterable parts I think this is safe to merge.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---