You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/05 09:42:22 UTC
[GitHub] [skywalking] wankai123 opened a new pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
wankai123 opened a new pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495
### Support metrics grouped by scope labels in MAL, no need global labels as before
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [x] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
For example, the metrics data as below:
```
samples=[
Sample(name=null, labels={idc=t1}, value=50.0, timestamp=0),
Sample(name=null, labels={idc=t3, region=cn, svc=catalog}, value=51.0, timestamp=0),
Sample(name=null, labels={idc=t1, region=us, svc=product}, value=50.0, timestamp=0),
Sample(name=null, labels={idc=t1, region=us, instance=10.0.0.1}, value=100.0, timestamp=0),
Sample(name=null, labels={idc=t3, region=cn, instance=10.0.0.1}, value=3.0, timestamp=0)
]
```
The rule is `http_success_request.sum(['idc']).service(['idc'])`
As before，
MAL would match the label `idc` value `t1` as the `serviceName` set to `MeterEntity` from the **first** sample. Obviously it‘s lost `t3` as another `serviceName` and `MeterEntity`. MAL can't support this scenario unless all samples label `idc` value are `t1`.
After this PR,
MAL would group the samples by scope labels, mapping the grouped samples to different `MeterEntity`.
More scenario can see the testcase code in `ScopeTest.java`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (1757802) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `5.67%`.
> The diff coverage is `65.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.64% 47.96% -5.68%
+ Complexity 4056 2822 -1234
============================================
Files 1778 836 -942
Lines 37770 20620 -17150
Branches 4155 1948 -2207
============================================
- Hits 20260 9891 -10369
+ Misses 16536 9952 -6584
+ Partials 974 777 -197
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-10.44%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.55% <68.75%> (-11.17%)` | `70.00 <11.00> (-2.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1346 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (1757802) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `3.60%`.
> The diff coverage is `65.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.64% 50.03% -3.61%
+ Complexity 4056 2962 -1094
============================================
Files 1778 836 -942
Lines 37770 20638 -17132
Branches 4155 1949 -2206
============================================
- Hits 20260 10327 -9933
+ Misses 16536 9475 -7061
+ Partials 974 836 -138
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-10.44%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.55% <68.75%> (-11.17%)` | `70.00 <11.00> (-2.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1322 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (fbb4bcf) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `20.79%`.
> The diff coverage is `62.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 56.58% 35.78% -20.80%
+ Complexity 4034 2116 -1918
=============================================
Files 1005 809 -196
Lines 24760 19692 -5068
Branches 2403 1859 -544
=============================================
- Hits 14010 7047 -6963
- Misses 9518 12115 +2597
+ Partials 1232 530 -702
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.37% <63.63%> (-12.16%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (-10.32%)` | `55.00 <6.00> (-17.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [474 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...fbb4bcf](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (fbb4bcf) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `9.27%`.
> The diff coverage is `74.28%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 47.30% -9.28%
+ Complexity 4034 2872 -1162
============================================
Files 1005 839 -166
Lines 24760 20734 -4026
Branches 2403 1962 -441
============================================
- Hits 14010 9809 -4201
- Misses 9518 10180 +662
+ Partials 1232 745 -487
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.81% <75.92%> (-1.77%)` | `62.00 <8.00> (-10.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.48% <79.54%> (-1.05%)` | `24.00 <13.00> (+6.00)` | :arrow_down: |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...n/jdbc/postgresql/dao/PostgreSQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvcG9zdGdyZXNxbC9kYW8vUG9zdGdyZVNRTFRyYWNlUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [283 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...fbb4bcf](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b240c3b) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `15.78%`.
> The diff coverage is `53.39%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 53.64% 37.85% -15.79%
+ Complexity 4056 2746 -1310
=============================================
Files 1778 957 -821
Lines 37770 23169 -14601
Branches 4155 2232 -1923
=============================================
- Hits 20260 8770 -11490
+ Misses 16536 13653 -2883
+ Partials 974 746 -228
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...f/dynamic/watcher/IgnoreSuffixPatternsWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvSWdub3JlU3VmZml4UGF0dGVybnNXYXRjaGVyLmphdmE=) | `76.47% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...core/conf/dynamic/watcher/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `70.00% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <ø> (-43.59%)` | `8.00 <0.00> (-1.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `51.85% <31.81%> (-29.88%)` | `15.00 <8.00> (-3.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.34% <50.00%> (-15.22%)` | `25.00 <1.00> (ø)` | |
| [...nt/core/conf/dynamic/watcher/SpanLimitWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU3BhbkxpbWl0V2F0Y2hlci5qYXZh) | `66.66% <66.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `24.59% <68.75%> (-43.14%)` | `30.00 <11.00> (-42.00)` | |
| [...gent/core/context/ContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==) | `74.19% <100.00%> (-15.47%)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1374 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-799968660
Please resolve the conflicts and make the CI running.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (2fcb790) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `15.96%`.
> The diff coverage is `60.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 56.58% 40.62% -15.97%
+ Complexity 4034 2463 -1571
=============================================
Files 1005 839 -166
Lines 24760 20627 -4133
Branches 2403 1950 -453
=============================================
- Hits 14010 8379 -5631
- Misses 9518 11617 +2099
+ Partials 1232 631 -601
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-11.23%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.14% <72.72%> (-8.44%)` | `56.00 <6.00> (-16.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [390 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **increase** coverage by `2.48%`.
> The diff coverage is `65.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
+ Coverage 52.61% 55.09% +2.48%
+ Complexity 3945 3920 -25
============================================
Files 1783 994 -789
Lines 38122 24704 -13418
Branches 4201 2411 -1790
============================================
- Hits 20056 13610 -6446
+ Misses 17087 9880 -7207
- Partials 979 1214 +235
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `73.39% <64.44%> (+1.27%)` | `23.00 <13.00> (+6.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.40% <72.22%> (+0.76%)` | `56.00 <6.00> (-9.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1276 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (d73396a) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `2.74%`.
> The diff coverage is `69.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.99% 51.25% -2.75%
+ Complexity 4079 3654 -425
============================================
Files 1779 990 -789
Lines 37794 24345 -13449
Branches 4157 2365 -1792
============================================
- Hits 20408 12477 -7931
+ Misses 16403 10832 -5571
- Partials 983 1036 +53
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `77.14% <0.00%> (-14.04%)` | `10.00 <0.00> (-1.00)` | |
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.13% <0.00%> (-0.39%)` | `6.00 <0.00> (ø)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.81% <75.92%> (-1.92%)` | `62.00 <8.00> (-10.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.73% <80.00%> (-1.00%)` | `23.00 <12.00> (+5.00)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1290 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (2fcb790) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `12.84%`.
> The diff coverage is `60.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 56.58% 43.74% -12.85%
+ Complexity 4034 2648 -1386
=============================================
Files 1005 839 -166
Lines 24760 20628 -4132
Branches 2403 1954 -449
=============================================
- Hits 14010 9023 -4987
- Misses 9518 10916 +1398
+ Partials 1232 689 -543
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-11.23%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.57% <72.72%> (-8.01%)` | `56.00 <6.00> (-16.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [355 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `2.78%`.
> The diff coverage is `63.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 51.39% -2.79%
+ Complexity 4150 3674 -476
============================================
Files 1783 995 -788
Lines 38193 24660 -13533
Branches 4209 2403 -1806
============================================
- Hits 20695 12675 -8020
+ Misses 16511 10922 -5589
- Partials 987 1063 +76
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-9.21%)` | `22.00 <12.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (-10.47%)` | `55.00 <6.00> (-17.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `77.77% <83.33%> (+2.77%)` | `8.00 <1.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1297 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3b206ef) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `17.31%`.
> The diff coverage is `59.82%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 53.99% 36.68% -17.32%
+ Complexity 4079 2159 -1920
=============================================
Files 1779 809 -970
Lines 37794 19722 -18072
Branches 4157 1864 -2293
=============================================
- Hits 20408 7235 -13173
+ Misses 16403 11937 -4466
+ Partials 983 550 -433
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.13% <0.00%> (-0.39%)` | `6.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.72% <64.44%> (-12.01%)` | `21.00 <12.00> (+3.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (-10.47%)` | `55.00 <6.00> (-17.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1430 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ad6c827) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `34.01%`.
> The diff coverage is `62.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 34.01% +34.01%
- Complexity 0 2139 +2139
=============================================
Files 195 838 +643
Lines 4675 20521 +15846
Branches 544 1941 +1397
=============================================
+ Hits 0 6980 +6980
- Misses 4675 13015 +8340
- Partials 0 526 +526
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.44% <63.63%> (ø)` | `21.00 <12.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (ø)` | `55.00 <6.00> (?)` | |
| [...walking/apm/agent/core/context/RuntimeContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dC5qYXZh) | | | |
| [...apache/skywalking/apm/toolkit/meter/Histogram.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvSGlzdG9ncmFtLmphdmE=) | | | |
| [...ent/core/plugin/match/ProtectiveShieldMatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1Byb3RlY3RpdmVTaGllbGRNYXRjaGVyLmphdmE=) | | | |
| [...alking/apm/agent/core/context/trace/EntrySpan.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9FbnRyeVNwYW4uamF2YQ==) | | | |
| [...xecutor/ConfigurationDiscoveryCommandExecutor.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvZXhlY3V0b3IvQ29uZmlndXJhdGlvbkRpc2NvdmVyeUNvbW1hbmRFeGVjdXRvci5qYXZh) | | | |
| ... and [1004 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `3.01%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 51.16% -3.02%
+ Complexity 4150 3784 -366
============================================
Files 1783 1786 +3
Lines 38193 38152 -41
Branches 4209 4202 -7
============================================
- Hits 20695 19522 -1173
- Misses 16511 17649 +1138
+ Partials 987 981 -6
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `73.63% <66.66%> (-7.14%)` | `23.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.87% <70.37%> (-9.86%)` | `55.00 <6.00> (-17.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `77.77% <83.33%> (+2.77%)` | `8.00 <1.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `60.97% <100.00%> (-1.82%)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [101 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (2fcb790) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `12.86%`.
> The diff coverage is `60.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 56.58% 43.71% -12.87%
+ Complexity 4034 2646 -1388
=============================================
Files 1005 839 -166
Lines 24760 20627 -4133
Branches 2403 1950 -453
=============================================
- Hits 14010 9018 -4992
- Misses 9518 10918 +1400
+ Partials 1232 691 -541
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-11.23%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.14% <72.72%> (-8.44%)` | `56.00 <6.00> (-16.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [358 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **decrease** coverage by `0.64%`.
> The diff coverage is `65.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 52.61% 51.96% -0.65%
+ Complexity 3945 3775 -170
============================================
Files 1783 994 -789
Lines 38122 24645 -13477
Branches 4201 2401 -1800
============================================
- Hits 20056 12807 -7249
+ Misses 17087 10690 -6397
- Partials 979 1148 +169
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-0.56%)` | `22.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.97% <72.22%> (+0.33%)` | `56.00 <6.00> (-9.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1275 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (5a5db0e) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `22.45%`.
> The diff coverage is `58.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 56.58% 34.13% -22.46%
+ Complexity 4034 2089 -1945
=============================================
Files 1005 808 -197
Lines 24760 19695 -5065
Branches 2403 1859 -544
=============================================
- Hits 14010 6722 -7288
- Misses 9518 12463 +2945
+ Partials 1232 510 -722
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.44% <63.63%> (-13.08%)` | `21.00 <12.00> (+3.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.44% <69.09%> (-10.14%)` | `55.00 <6.00> (-17.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [507 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (5a5db0e) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `7.15%`.
> The diff coverage is `64.06%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 49.42% -7.16%
+ Complexity 4034 3599 -435
============================================
Files 1005 1782 +777
Lines 24760 37761 +13001
Branches 2403 4151 +1748
============================================
+ Hits 14010 18664 +4654
- Misses 9518 18118 +8600
+ Partials 1232 979 -253
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `44.44% <44.44%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.64% <63.63%> (-11.89%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.74% <74.54%> (-7.84%)` | `56.00 <6.00> (-16.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1274 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ad6c827) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `15.85%`.
> The diff coverage is `63.80%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 26.10% 41.95% +15.85%
- Complexity 1925 2285 +360
=============================================
Files 987 1772 +785
Lines 23812 37405 +13593
Branches 2329 4310 +1981
=============================================
+ Hits 6215 15692 +9477
- Misses 17123 20717 +3594
- Partials 474 996 +522
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.80% <63.63%> (+0.84%)` | `21.00 <12.00> (+5.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.87% <70.37%> (+1.70%)` | `55.00 <6.00> (-7.00)` | :arrow_up: |
| [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (-81.82%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `8.33% <0.00%> (-75.00%)` | `3.00% <0.00%> (-6.00%)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <0.00%> (-61.52%)` | `3.00% <0.00%> (ø%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `32.43% <0.00%> (-59.88%)` | `2.00% <0.00%> (ø%)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `23.52% <0.00%> (-43.14%)` | `2.00% <0.00%> (ø%)` | |
| ... and [1341 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `1.63%`.
> The diff coverage is `63.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 52.54% -1.64%
+ Complexity 4150 3759 -391
============================================
Files 1783 995 -788
Lines 38193 24688 -13505
Branches 4209 2408 -1801
============================================
- Hits 20695 12973 -7722
+ Misses 16511 10635 -5876
- Partials 987 1080 +93
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `72.47% <64.44%> (-8.30%)` | `23.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (-10.47%)` | `55.00 <6.00> (-17.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `77.77% <83.33%> (+2.77%)` | `8.00 <1.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1287 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `40.88%`.
> The diff coverage is `62.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 40.88% +40.88%
- Complexity 0 3024 +3024
=============================================
Files 195 991 +796
Lines 4675 24204 +19529
Branches 544 2355 +1811
=============================================
+ Hits 0 9895 +9895
- Misses 4675 13451 +8776
- Partials 0 858 +858
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.44% <63.63%> (ø)` | `21.00 <12.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (ø)` | `55.00 <6.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | | | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | | | |
| [...t/core/plugin/bytebuddy/ArgumentTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bcmd1bWVudFR5cGVOYW1lTWF0Y2guamF2YQ==) | | | |
| [...pache/skywalking/apm/agent/core/meter/Counter.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlci5qYXZh) | | | |
| ... and [1000 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (1757802) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `0.98%`.
> The diff coverage is `66.99%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.64% 52.65% -0.99%
+ Complexity 4056 3763 -293
============================================
Files 1778 988 -790
Lines 37770 24292 -13478
Branches 4155 2360 -1795
============================================
- Hits 20260 12791 -7469
+ Misses 16536 10348 -6188
- Partials 974 1153 +179
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...f/dynamic/watcher/IgnoreSuffixPatternsWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvSWdub3JlU3VmZml4UGF0dGVybnNXYXRjaGVyLmphdmE=) | `76.47% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...core/conf/dynamic/watcher/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `70.00% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <ø> (-43.59%)` | `8.00 <0.00> (-1.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `53.26% <50.00%> (-16.31%)` | `25.00 <1.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-10.44%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...nt/core/conf/dynamic/watcher/SpanLimitWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU3BhbkxpbWl0V2F0Y2hlci5qYXZh) | `66.66% <66.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.96% <68.75%> (-10.77%)` | `70.00 <11.00> (-2.00)` | |
| [...gent/core/context/ContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==) | `74.19% <100.00%> (-15.47%)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1273 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3b206ef) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `6.03%`.
> The diff coverage is `59.82%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.99% 47.96% -6.04%
+ Complexity 4079 2852 -1227
============================================
Files 1779 839 -940
Lines 37794 20637 -17157
Branches 4157 1954 -2203
============================================
- Hits 20408 9899 -10509
+ Misses 16403 9958 -6445
+ Partials 983 780 -203
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.13% <0.00%> (-0.39%)` | `6.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-10.18%)` | `22.00 <12.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.69% <68.51%> (-10.04%)` | `55.00 <6.00> (-17.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1349 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b240c3b) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `15.77%`.
> The diff coverage is `53.39%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 53.64% 37.86% -15.78%
+ Complexity 4056 2747 -1309
=============================================
Files 1778 957 -821
Lines 37770 23169 -14601
Branches 4155 2232 -1923
=============================================
- Hits 20260 8774 -11486
+ Misses 16536 13648 -2888
+ Partials 974 747 -227
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...f/dynamic/watcher/IgnoreSuffixPatternsWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvSWdub3JlU3VmZml4UGF0dGVybnNXYXRjaGVyLmphdmE=) | `76.47% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...core/conf/dynamic/watcher/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `70.00% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <ø> (-41.03%)` | `9.00 <0.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `51.85% <31.81%> (-29.88%)` | `15.00 <8.00> (-3.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.34% <50.00%> (-15.22%)` | `25.00 <1.00> (ø)` | |
| [...nt/core/conf/dynamic/watcher/SpanLimitWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU3BhbkxpbWl0V2F0Y2hlci5qYXZh) | `66.66% <66.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `24.59% <68.75%> (-43.14%)` | `30.00 <11.00> (-42.00)` | |
| [...gent/core/context/ContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==) | `74.19% <100.00%> (-15.47%)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1373 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `1.49%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 52.69% -1.50%
+ Complexity 4150 3941 -209
============================================
Files 1783 1786 +3
Lines 38193 38152 -41
Branches 4209 4203 -6
============================================
- Hits 20695 20104 -591
- Misses 16511 17069 +558
+ Partials 987 979 -8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `73.63% <66.66%> (-7.14%)` | `23.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.29% <70.37%> (-9.43%)` | `55.00 <6.00> (-17.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `77.77% <83.33%> (+2.77%)` | `8.00 <1.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `60.97% <100.00%> (-1.82%)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [60 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3b206ef) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `12.65%`.
> The diff coverage is `59.82%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 53.99% 41.34% -12.66%
+ Complexity 4079 2480 -1599
=============================================
Files 1779 839 -940
Lines 37794 20619 -17175
Branches 4157 1953 -2204
=============================================
- Hits 20408 8525 -11883
+ Misses 16403 11456 -4947
+ Partials 983 638 -345
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.13% <0.00%> (-0.39%)` | `6.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-10.18%)` | `22.00 <12.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.69% <68.51%> (-10.04%)` | `55.00 <6.00> (-17.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1386 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ad6c827) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `36.59%`.
> The diff coverage is `62.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 36.59% +36.59%
- Complexity 0 2285 +2285
=============================================
Files 198 838 +640
Lines 4691 20521 +15830
Branches 544 1941 +1397
=============================================
+ Hits 0 7509 +7509
- Misses 4691 12440 +7749
- Partials 0 572 +572
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.44% <63.63%> (ø)` | `21.00 <12.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (ø)` | `55.00 <6.00> (?)` | |
| [...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh) | | | |
| [.../apm/agent/core/boot/ServiceConflictException.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9TZXJ2aWNlQ29uZmxpY3RFeGNlcHRpb24uamF2YQ==) | | | |
| [.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=) | | | |
| [...ore/plugin/bootstrap/BootstrapInstrumentBoost.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBJbnN0cnVtZW50Qm9vc3QuamF2YQ==) | | | |
| [...ache/skywalking/apm/agent/core/meter/MeterTag.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUYWcuamF2YQ==) | | | |
| ... and [1008 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#discussion_r588251446
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -376,15 +374,63 @@ public SampleFamily endpoint(List<String> serviceKeys, List<String> endpointKeys
if (this == EMPTY) {
return EMPTY;
}
- this.context.setMeterEntity(MeterEntity.newEndpoint(dim(serviceKeys), dim(endpointKeys)));
- return left(io.vavr.collection.Stream.concat(serviceKeys, endpointKeys).asJava());
+ return createMeterSamples(serviceKeys, endpointKeys, ScopeType.ENDPOINT);
+ }
+
+ private SampleFamily createMeterSamples(List<String> serviceKeys, List<String> level2keys, ScopeType scopeType) {
+ final List<String> labelKeys = io.vavr.collection.Stream.concat(serviceKeys, level2keys).asJava();
+ Map<MeterEntity, Sample[]> meterSamples = new HashMap<>();
+ Arrays.stream(samples)
+ .collect(groupingBy(it -> getLabels(labelKeys, it), mapping(identity(), toList())))
+ .forEach((labels, samples) -> {
+ MeterEntity meterEntity = getMeterEntity(samples, serviceKeys, level2keys, scopeType);
+ Preconditions.checkNotNull(meterEntity);
+ meterSamples.put(meterEntity, left(labelKeys, samples));
+ });
+
+ this.context.setMeterSamples(meterSamples);
+ //This samples is original, The grouped samples is in context which mapping with MeterEntity
+ return SampleFamily.build(this.context, samples);
+ }
+
+ private MeterEntity getMeterEntity(List<Sample> samples,
+ List<String> serviceKeys,
+ List<String> level2keys,
+ ScopeType scopeType) {
+ switch (scopeType) {
+ case SERVICE:
+ return MeterEntity.newService(dim(serviceKeys, samples));
+ case SERVICE_INSTANCE:
+ return MeterEntity.newServiceInstance(dim(serviceKeys, samples), dim(level2keys, samples));
+ case ENDPOINT:
+ return MeterEntity.newEndpoint(dim(serviceKeys, samples), dim(level2keys, samples));
+ }
+ return null;
}
private String dim(List<String> labelKeys) {
Review comment:
This is never used, if not useful, please remove this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `57.76%`.
> The diff coverage is `76.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 57.76% +57.76%
- Complexity 0 4052 +4052
=============================================
Files 198 991 +793
Lines 4691 24444 +19753
Branches 544 2376 +1832
=============================================
+ Hits 0 14121 +14121
- Misses 4691 9107 +4416
- Partials 0 1216 +1216
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `83.33% <79.54%> (ø)` | `24.00 <13.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `67.94% <79.62%> (ø)` | `63.00 <8.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...ache/skywalking/apm/agent/core/meter/MeterTag.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUYWcuamF2YQ==) | | | |
| [...apache/skywalking/apm/toolkit/meter/BaseMeter.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQmFzZU1ldGVyLmphdmE=) | | | |
| [...ent/core/jvm/memorypool/SerialCollectorModule.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvU2VyaWFsQ29sbGVjdG9yTW9kdWxlLmphdmE=) | | | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | | | |
| ... and [1003 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (7ccff4e) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `7.96%`.
> The diff coverage is `61.26%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 48.61% -7.97%
+ Complexity 4034 3490 -544
============================================
Files 1005 991 -14
Lines 24760 24256 -504
Branches 2403 2356 -47
============================================
- Hits 14010 11792 -2218
- Misses 9518 11410 +1892
+ Partials 1232 1054 -178
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `37.28% <0.00%> (-2.21%)` | `5.00 <0.00> (-1.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-11.23%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.97% <72.22%> (-8.61%)` | `56.00 <6.00> (-16.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [186 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...fbb4bcf](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on a change in pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
wankai123 commented on a change in pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#discussion_r589188288
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/EntityDescription/EndpointEntityDescription.java
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.meter.analyzer.dsl.EntityDescription;
+
+import java.util.List;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+import org.apache.skywalking.oap.server.core.analysis.meter.ScopeType;
+
+public class EndpointEntityDescription implements EntityDescription {
+ private ScopeType scopeType = ScopeType.ENDPOINT;
+
+ private List<String> serviceKeys;
+
+ private List<String> endpointkeys;
Review comment:
changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-792430719
Others are good to me. @hanahmily Please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **increase** coverage by `1.01%`.
> The diff coverage is `65.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
+ Coverage 52.61% 53.62% +1.01%
+ Complexity 3945 3863 -82
============================================
Files 1783 994 -789
Lines 38122 24703 -13419
Branches 4201 2407 -1794
============================================
- Hits 20056 13246 -6810
+ Misses 17087 10271 -6816
- Partials 979 1186 +207
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `73.39% <64.44%> (+1.27%)` | `23.00 <13.00> (+6.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.97% <72.22%> (+0.33%)` | `56.00 <6.00> (-9.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1281 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (c1e9a11) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `17.89%`.
> The diff coverage is `2.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 53.99% 36.10% -17.90%
+ Complexity 4079 2596 -1483
=============================================
Files 1779 961 -818
Lines 37794 23162 -14632
Branches 4157 2232 -1925
=============================================
- Hits 20408 8363 -12045
+ Misses 16403 14087 -2316
+ Partials 983 712 -271
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `80.00% <0.00%> (-11.18%)` | `11.00 <0.00> (ø)` | |
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `9.95% <0.00%> (-57.78%)` | `9.00 <0.00> (-63.00)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.98% <0.00%> (+0.45%)` | `6.00 <0.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `18.34% <4.44%> (-63.39%)` | `4.00 <1.00> (-14.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1397 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (2fcb790) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `13.69%`.
> The diff coverage is `60.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 56.58% 42.89% -13.70%
+ Complexity 4034 2597 -1437
=============================================
Files 1005 839 -166
Lines 24760 20627 -4133
Branches 2403 1950 -453
=============================================
- Hits 14010 8847 -5163
- Misses 9518 11101 +1583
+ Partials 1232 679 -553
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-11.23%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.14% <72.72%> (-8.44%)` | `56.00 <6.00> (-16.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [368 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `55.68%`.
> The diff coverage is `76.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 55.68% +55.68%
- Complexity 0 3966 +3966
=============================================
Files 195 991 +796
Lines 4675 24416 +19741
Branches 544 2370 +1826
=============================================
+ Hits 0 13596 +13596
- Misses 4675 9629 +4954
- Partials 0 1191 +1191
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `83.33% <79.54%> (ø)` | `24.00 <13.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `67.52% <79.62%> (ø)` | `63.00 <8.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...ache/skywalking/apm/toolkit/meter/BaseBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQmFzZUJ1aWxkZXIuamF2YQ==) | | | |
| [...che/skywalking/apm/agent/core/meter/BaseMeter.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQmFzZU1ldGVyLmphdmE=) | | | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | | | |
| [...ache/skywalking/apm/agent/core/meter/MeterTag.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUYWcuamF2YQ==) | | | |
| ... and [1000 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3b206ef) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `5.50%`.
> The diff coverage is `59.82%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.99% 48.49% -5.51%
+ Complexity 4079 2874 -1205
============================================
Files 1779 839 -940
Lines 37794 20637 -17157
Branches 4157 1954 -2203
============================================
- Hits 20408 10008 -10400
+ Misses 16403 9847 -6556
+ Partials 983 782 -201
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.13% <0.00%> (-0.39%)` | `6.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-10.18%)` | `22.00 <12.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.69% <68.51%> (-10.04%)` | `55.00 <6.00> (-17.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1347 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on a change in pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
wankai123 commented on a change in pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#discussion_r589133884
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -376,15 +374,63 @@ public SampleFamily endpoint(List<String> serviceKeys, List<String> endpointKeys
if (this == EMPTY) {
return EMPTY;
}
- this.context.setMeterEntity(MeterEntity.newEndpoint(dim(serviceKeys), dim(endpointKeys)));
- return left(io.vavr.collection.Stream.concat(serviceKeys, endpointKeys).asJava());
+ return createMeterSamples(serviceKeys, endpointKeys, ScopeType.ENDPOINT);
+ }
+
+ private SampleFamily createMeterSamples(List<String> serviceKeys, List<String> level2keys, ScopeType scopeType) {
+ final List<String> labelKeys = io.vavr.collection.Stream.concat(serviceKeys, level2keys).asJava();
Review comment:
down
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (af503ce) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `0.47%`.
> The diff coverage is `72.65%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 56.10% -0.48%
+ Complexity 4034 3966 -68
============================================
Files 1005 991 -14
Lines 24760 24447 -313
Branches 2403 2371 -32
============================================
- Hits 14010 13717 -293
- Misses 9518 9571 +53
+ Partials 1232 1159 -73
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.95% <76.36%> (-1.63%)` | `62.00 <8.00> (-10.00)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `77.77% <77.77%> (ø)` | `4.00 <4.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.55% <79.54%> (-1.97%)` | `23.00 <12.00> (+5.00)` | :arrow_down: |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <0.00%> (-73.81%)` | `1.00% <0.00%> (-6.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2AlarmQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQWxhcm1RdWVyeURBTy5qYXZh) | `6.97% <0.00%> (-72.10%)` | `1.00% <0.00%> (-4.00%)` | |
| ... and [81 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#discussion_r588795368
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -376,15 +374,63 @@ public SampleFamily endpoint(List<String> serviceKeys, List<String> endpointKeys
if (this == EMPTY) {
return EMPTY;
}
- this.context.setMeterEntity(MeterEntity.newEndpoint(dim(serviceKeys), dim(endpointKeys)));
- return left(io.vavr.collection.Stream.concat(serviceKeys, endpointKeys).asJava());
+ return createMeterSamples(serviceKeys, endpointKeys, ScopeType.ENDPOINT);
+ }
+
+ private SampleFamily createMeterSamples(List<String> serviceKeys, List<String> level2keys, ScopeType scopeType) {
+ final List<String> labelKeys = io.vavr.collection.Stream.concat(serviceKeys, level2keys).asJava();
+ Map<MeterEntity, Sample[]> meterSamples = new HashMap<>();
+ Arrays.stream(samples)
+ .collect(groupingBy(it -> getLabels(labelKeys, it), mapping(identity(), toList())))
+ .forEach((labels, samples) -> {
+ MeterEntity meterEntity = getMeterEntity(samples, serviceKeys, level2keys, scopeType);
+ Preconditions.checkNotNull(meterEntity);
+ meterSamples.put(meterEntity, left(labelKeys, samples));
+ });
+
+ this.context.setMeterSamples(meterSamples);
+ //This samples is original, The grouped samples is in context which mapping with MeterEntity
+ return SampleFamily.build(this.context, samples);
+ }
+
+ private MeterEntity getMeterEntity(List<Sample> samples,
+ List<String> serviceKeys,
+ List<String> level2keys,
+ ScopeType scopeType) {
+ switch (scopeType) {
+ case SERVICE:
+ return MeterEntity.newService(dim(serviceKeys, samples));
+ case SERVICE_INSTANCE:
+ return MeterEntity.newServiceInstance(dim(serviceKeys, samples), dim(level2keys, samples));
+ case ENDPOINT:
+ return MeterEntity.newEndpoint(dim(serviceKeys, samples), dim(level2keys, samples));
+ }
+ return null;
}
private String dim(List<String> labelKeys) {
- String name = labelKeys.stream().map(k -> samples[0].labels.getOrDefault(k, "")).collect(Collectors.joining("."));
+ String name = labelKeys.stream()
+ .map(k -> samples[0].labels.getOrDefault(k, ""))
+ .collect(Collectors.joining("."));
+ return CharMatcher.is('.').trimFrom(name);
+ }
+
+ private String dim(List<String> labelKeys, List<Sample> samples) {
+ String name = labelKeys.stream()
+ .map(k -> samples.get(0).labels.getOrDefault(k, ""))
+ .collect(Collectors.joining("."));
return CharMatcher.is('.').trimFrom(name);
}
+ private Sample[] left(List<String> labelKeys, List<Sample> samples) {
Review comment:
The `private` methods could not be accessed from expression, hence we don't have to convert them to static.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `18.62%`.
> The diff coverage is `8.64%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 54.18% 35.56% -18.63%
+ Complexity 4150 2587 -1563
=============================================
Files 1783 963 -820
Lines 38193 23400 -14793
Branches 4209 2263 -1946
=============================================
- Hits 20695 8322 -12373
+ Misses 16511 14372 -2139
+ Partials 987 706 -281
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `9.95% <0.00%> (-57.78%)` | `9.00 <0.00> (-63.00)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `18.34% <4.44%> (-62.43%)` | `4.00 <1.00> (-14.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `40.74% <83.33%> (-34.26%)` | `4.00 <1.00> (-4.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1404 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **decrease** coverage by `0.74%`.
> The diff coverage is `65.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 52.61% 51.86% -0.75%
+ Complexity 3945 3766 -179
============================================
Files 1783 994 -789
Lines 38122 24645 -13477
Branches 4201 2401 -1800
============================================
- Hits 20056 12783 -7273
+ Misses 17087 10714 -6373
- Partials 979 1148 +169
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-0.56%)` | `22.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.97% <72.22%> (+0.33%)` | `56.00 <6.00> (-9.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1273 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (2fcb790) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `1.01%`.
> The diff coverage is `74.21%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 55.56% -1.02%
+ Complexity 4034 3926 -108
============================================
Files 1005 990 -15
Lines 24760 24397 -363
Branches 2403 2367 -36
============================================
- Hits 14010 13556 -454
- Misses 9518 9644 +126
+ Partials 1232 1197 -35
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `77.77% <77.77%> (ø)` | `4.00 <4.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `82.40% <79.54%> (-0.12%)` | `24.00 <13.00> (+6.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `68.08% <80.00%> (+0.50%)` | `63.00 <8.00> (-9.00)` | :arrow_up: |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [90 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ad6c827) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `33.93%`.
> The diff coverage is `62.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 33.93% +33.93%
- Complexity 0 2135 +2135
=============================================
Files 195 838 +643
Lines 4675 20521 +15846
Branches 544 1941 +1397
=============================================
+ Hits 0 6963 +6963
- Misses 4675 13031 +8356
- Partials 0 527 +527
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.44% <63.63%> (ø)` | `21.00 <12.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (ø)` | `55.00 <6.00> (?)` | |
| [...skywalking/apm/agent/core/plugin/PluginFinder.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkZpbmRlci5qYXZh) | | | |
| [...king/apm/agent/core/dictionary/DictionaryUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvZGljdGlvbmFyeS9EaWN0aW9uYXJ5VXRpbC5qYXZh) | | | |
| [...ing/apm/agent/core/logging/core/PatternLogger.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1BhdHRlcm5Mb2dnZXIuamF2YQ==) | | | |
| [.../agent/core/plugin/match/ClassAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL0NsYXNzQW5ub3RhdGlvbk1hdGNoLmphdmE=) | | | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | | | |
| ... and [1004 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (af503ce) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `2.12%`.
> The diff coverage is `72.65%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 54.46% -2.13%
+ Complexity 4034 3880 -154
============================================
Files 1005 991 -14
Lines 24760 24419 -341
Branches 2403 2366 -37
============================================
- Hits 14010 13299 -711
- Misses 9518 9978 +460
+ Partials 1232 1142 -90
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.95% <76.36%> (-1.63%)` | `62.00 <8.00> (-10.00)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `77.77% <77.77%> (ø)` | `4.00 <4.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.55% <79.54%> (-1.97%)` | `23.00 <12.00> (+5.00)` | :arrow_down: |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (-81.82%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| ... and [85 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `55.52%`.
> The diff coverage is `76.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 55.52% +55.52%
- Complexity 0 3957 +3957
=============================================
Files 195 991 +796
Lines 4675 24416 +19741
Branches 544 2370 +1826
=============================================
+ Hits 0 13557 +13557
- Misses 4675 9678 +5003
- Partials 0 1181 +1181
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `83.33% <79.54%> (ø)` | `24.00 <13.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `67.52% <79.62%> (ø)` | `63.00 <8.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...pache/skywalking/apm/agent/core/meter/MeterId.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJJZC5qYXZh) | | | |
| [...che/skywalking/apm/toolkit/meter/MeterFactory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvTWV0ZXJGYWN0b3J5LmphdmE=) | | | |
| [...che/skywalking/apm/agent/core/meter/Histogram.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvSGlzdG9ncmFtLmphdmE=) | | | |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | | | |
| ... and [1000 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `46.87%`.
> The diff coverage is `62.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 46.87% +46.87%
- Complexity 0 3400 +3400
=============================================
Files 195 991 +796
Lines 4675 24213 +19538
Branches 544 2355 +1811
=============================================
+ Hits 0 11351 +11351
- Misses 4675 11884 +7209
- Partials 0 978 +978
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.44% <63.63%> (ø)` | `21.00 <12.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (ø)` | `55.00 <6.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | | | |
| [...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=) | | | |
| [...che/skywalking/apm/agent/core/meter/Histogram.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvSGlzdG9ncmFtLmphdmE=) | | | |
| [...che/skywalking/apm/agent/core/meter/BaseMeter.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQmFzZU1ldGVyLmphdmE=) | | | |
| ... and [1000 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on a change in pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
wankai123 commented on a change in pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#discussion_r589134493
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -477,7 +523,7 @@ static RunningContext instance() {
.build();
}
- MeterEntity meterEntity;
+ private Map<MeterEntity, Sample[]> meterSamples;
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (d73396a) into [master](https://codecov.io/gh/apache/skywalking/commit/1a7cc805afc4f944a13edd474e6a4cf5dff5a248?el=desc) (1a7cc80) will **decrease** coverage by `1.75%`.
> The diff coverage is `77.35%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.17% 52.42% -1.76%
+ Complexity 4107 3979 -128
============================================
Files 1779 1782 +3
Lines 37794 37822 +28
Branches 4156 4158 +2
============================================
- Hits 20474 19827 -647
- Misses 16340 17012 +672
- Partials 980 983 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.81% <80.00%> (+0.08%)` | `24.00 <13.00> (+6.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `68.08% <81.48%> (+0.35%)` | `63.00 <8.00> (-9.00)` | :arrow_up: |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [43 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...70e1d19](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `3.01%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 51.17% -3.02%
+ Complexity 4150 3785 -365
============================================
Files 1783 1786 +3
Lines 38193 38152 -41
Branches 4209 4203 -6
============================================
- Hits 20695 19524 -1171
- Misses 16511 17648 +1137
+ Partials 987 980 -7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `73.63% <66.66%> (-7.14%)` | `23.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.29% <70.37%> (-9.43%)` | `55.00 <6.00> (-17.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `77.77% <83.33%> (+2.77%)` | `8.00 <1.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `60.97% <100.00%> (-1.82%)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [100 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (d73396a) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `0.43%`.
> The diff coverage is `70.79%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.99% 53.56% -0.44%
+ Complexity 4079 3806 -273
============================================
Files 1779 991 -788
Lines 37794 24403 -13391
Branches 4157 2369 -1788
============================================
- Hits 20408 13071 -7337
+ Misses 16403 10238 -6165
- Partials 983 1094 +111
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `39.83% <0.00%> (+1.30%)` | `6.00 <0.00> (ø)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.81% <75.92%> (-1.92%)` | `62.00 <8.00> (-10.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.73% <80.00%> (-1.00%)` | `23.00 <12.00> (+5.00)` | :arrow_down: |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `91.42% <100.00%> (+0.25%)` | `12.00 <0.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1267 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `55.68%`.
> The diff coverage is `76.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 55.68% +55.68%
- Complexity 0 3966 +3966
=============================================
Files 195 991 +796
Lines 4675 24416 +19741
Branches 544 2370 +1826
=============================================
+ Hits 0 13596 +13596
- Misses 4675 9629 +4954
- Partials 0 1191 +1191
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `83.33% <79.54%> (ø)` | `24.00 <13.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `67.52% <79.62%> (ø)` | `63.00 <8.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [.../agent/core/context/util/ThrowableTransformer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1Rocm93YWJsZVRyYW5zZm9ybWVyLmphdmE=) | | | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | | | |
| [...g/apache/skywalking/apm/toolkit/meter/Counter.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQ291bnRlci5qYXZh) | | | |
| [...t/core/plugin/bytebuddy/ArgumentTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bcmd1bWVudFR5cGVOYW1lTWF0Y2guamF2YQ==) | | | |
| ... and [1000 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `55.81%`.
> The diff coverage is `76.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 55.81% +55.81%
- Complexity 0 3975 +3975
=============================================
Files 195 991 +796
Lines 4675 24416 +19741
Branches 544 2370 +1826
=============================================
+ Hits 0 13628 +13628
- Misses 4675 9597 +4922
- Partials 0 1191 +1191
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `83.33% <79.54%> (ø)` | `24.00 <13.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `67.52% <79.62%> (ø)` | `63.00 <8.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | | | |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | | | |
| [...che/skywalking/apm/agent/core/meter/BaseMeter.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQmFzZU1ldGVyLmphdmE=) | | | |
| [...g/apache/skywalking/apm/toolkit/meter/Counter.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQ291bnRlci5qYXZh) | | | |
| ... and [1000 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **increase** coverage by `3.20%`.
> The diff coverage is `65.09%`.
> :exclamation: Current head 3dd7696 differs from pull request most recent head b92c02b. Consider uploading reports for the commit b92c02b to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
+ Coverage 52.61% 55.81% +3.20%
- Complexity 3945 3960 +15
============================================
Files 1783 994 -789
Lines 38122 24704 -13418
Branches 4201 2411 -1790
============================================
- Hits 20056 13788 -6268
+ Misses 17087 9692 -7395
- Partials 979 1224 +245
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `73.39% <64.44%> (+1.27%)` | `23.00 <13.00> (+6.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.40% <72.22%> (+0.76%)` | `56.00 <6.00> (-9.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1270 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (1757802) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `15.44%`.
> The diff coverage is `65.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 53.64% 38.19% -15.45%
+ Complexity 4056 2334 -1722
=============================================
Files 1778 836 -942
Lines 37770 20552 -17218
Branches 4155 1941 -2214
=============================================
- Hits 20260 7849 -12411
+ Misses 16536 12127 -4409
+ Partials 974 576 -398
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.44% <63.63%> (-12.29%)` | `21.00 <12.00> (+3.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `54.91% <68.75%> (-12.81%)` | `67.00 <11.00> (-5.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1385 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b240c3b) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `11.30%`.
> The diff coverage is `53.39%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 53.64% 42.33% -11.31%
+ Complexity 4056 2998 -1058
=============================================
Files 1778 957 -821
Lines 37770 23210 -14560
Branches 4155 2235 -1920
=============================================
- Hits 20260 9826 -10434
+ Misses 16536 12537 -3999
+ Partials 974 847 -127
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...f/dynamic/watcher/IgnoreSuffixPatternsWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvSWdub3JlU3VmZml4UGF0dGVybnNXYXRjaGVyLmphdmE=) | `76.47% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...core/conf/dynamic/watcher/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `70.00% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <ø> (-41.03%)` | `9.00 <0.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `51.85% <31.81%> (-29.88%)` | `15.00 <8.00> (-3.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.34% <50.00%> (-15.22%)` | `25.00 <1.00> (ø)` | |
| [...nt/core/conf/dynamic/watcher/SpanLimitWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU3BhbkxpbWl0V2F0Y2hlci5qYXZh) | `66.66% <66.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `24.59% <68.75%> (-43.14%)` | `30.00 <11.00> (-42.00)` | |
| [...gent/core/context/ContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==) | `74.19% <100.00%> (-15.47%)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1354 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (d73396a) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `3.21%`.
> The diff coverage is `69.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.99% 50.77% -3.22%
+ Complexity 4079 3618 -461
============================================
Files 1779 990 -789
Lines 37794 24345 -13449
Branches 4157 2365 -1792
============================================
- Hits 20408 12362 -8046
+ Misses 16403 10960 -5443
- Partials 983 1023 +40
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `77.14% <0.00%> (-14.04%)` | `10.00 <0.00> (-1.00)` | |
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.13% <0.00%> (-0.39%)` | `6.00 <0.00> (ø)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.81% <75.92%> (-1.92%)` | `62.00 <8.00> (-10.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.73% <80.00%> (-1.00%)` | `23.00 <12.00> (+5.00)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1295 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (1757802) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `1.23%`.
> The diff coverage is `76.36%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.64% 52.40% -1.24%
+ Complexity 4056 3950 -106
============================================
Files 1778 1779 +1
Lines 37770 37812 +42
Branches 4155 4157 +2
============================================
- Hits 20260 19814 -446
- Misses 16536 17012 +476
- Partials 974 986 +12
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...f/dynamic/watcher/IgnoreSuffixPatternsWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvSWdub3JlU3VmZml4UGF0dGVybnNXYXRjaGVyLmphdmE=) | `94.11% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...core/conf/dynamic/watcher/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `85.00% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `74.35% <ø> (-2.57%)` | `9.00 <0.00> (ø)` | |
| [...m/plugin/kafka/CallbackConstructorInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4va2Fma2EtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4va2Fma2EvQ2FsbGJhY2tDb25zdHJ1Y3RvckludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ywalking/apm/plugin/kafka/CallbackInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4va2Fma2EtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4va2Fma2EvQ2FsbGJhY2tJbnRlcmNlcHRvci5qYXZh) | `71.42% <0.00%> (-5.50%)` | `0.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.71% <78.12%> (-2.02%)` | `77.00 <11.00> (+5.00)` | :arrow_down: |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.65% <79.54%> (-0.08%)` | `24.00 <13.00> (+6.00)` | :arrow_down: |
| [...nt/core/conf/dynamic/watcher/SpanLimitWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU3BhbkxpbWl0V2F0Y2hlci5qYXZh) | `83.33% <83.33%> (ø)` | `7.00 <7.00> (?)` | |
| [...gent/core/context/ContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==) | `90.32% <100.00%> (+0.66%)` | `8.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `69.72% <100.00%> (+0.16%)` | `25.00 <1.00> (ø)` | |
| ... and [51 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...9bfafa7](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (af503ce) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `5.49%`.
> The diff coverage is `58.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 51.08% -5.50%
+ Complexity 4034 3671 -363
============================================
Files 1005 990 -15
Lines 24760 24240 -520
Branches 2403 2353 -50
============================================
- Hits 14010 12383 -1627
- Misses 9518 10788 +1270
+ Partials 1232 1069 -163
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-11.23%)` | `22.00 <12.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.44% <69.09%> (-10.14%)` | `55.00 <6.00> (-17.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...n/jdbc/postgresql/dao/PostgreSQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvcG9zdGdyZXNxbC9kYW8vUG9zdGdyZVNRTFRyYWNlUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [148 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **increase** coverage by `3.57%`.
> The diff coverage is `65.09%`.
> :exclamation: Current head 3dd7696 differs from pull request most recent head b92c02b. Consider uploading reports for the commit b92c02b to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
+ Coverage 52.61% 56.18% +3.57%
- Complexity 3945 3978 +33
============================================
Files 1783 994 -789
Lines 38122 24707 -13415
Branches 4201 2411 -1790
============================================
- Hits 20056 13882 -6174
+ Misses 17087 9597 -7490
- Partials 979 1228 +249
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `73.39% <64.44%> (+1.27%)` | `23.00 <13.00> (+6.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.40% <72.22%> (+0.76%)` | `56.00 <6.00> (-9.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1268 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (fbb4bcf) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `13.90%`.
> The diff coverage is `62.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 56.58% 42.67% -13.91%
+ Complexity 4034 2617 -1417
=============================================
Files 1005 839 -166
Lines 24760 20598 -4162
Branches 2403 1949 -454
=============================================
- Hits 14010 8790 -5220
- Misses 9518 11117 +1599
+ Partials 1232 691 -541
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.37% <63.63%> (-12.16%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (-10.32%)` | `55.00 <6.00> (-17.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...er/storage/plugin/jdbc/mysql/MySQLLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxMb2dRdWVyeURBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [366 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...fbb4bcf](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (d73396a) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `0.45%`.
> The diff coverage is `70.79%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.99% 53.54% -0.46%
+ Complexity 4079 3803 -276
============================================
Files 1779 991 -788
Lines 37794 24403 -13391
Branches 4157 2369 -1788
============================================
- Hits 20408 13066 -7342
+ Misses 16403 10243 -6160
- Partials 983 1094 +111
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `39.83% <0.00%> (+1.30%)` | `6.00 <0.00> (ø)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.81% <75.92%> (-1.92%)` | `62.00 <8.00> (-10.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.73% <80.00%> (-1.00%)` | `23.00 <12.00> (+5.00)` | :arrow_down: |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `91.42% <100.00%> (+0.25%)` | `12.00 <0.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1270 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3b206ef) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `8.84%`.
> The diff coverage is `59.82%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.99% 45.15% -8.85%
+ Complexity 4079 2666 -1413
============================================
Files 1779 839 -940
Lines 37794 20619 -17175
Branches 4157 1953 -2204
============================================
- Hits 20408 9311 -11097
+ Misses 16403 10600 -5803
+ Partials 983 708 -275
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.13% <0.00%> (-0.39%)` | `6.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-10.18%)` | `22.00 <12.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.69% <68.51%> (-10.04%)` | `55.00 <6.00> (-17.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1375 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **decrease** coverage by `17.44%`.
> The diff coverage is `49.05%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 55.09% 37.65% -17.45%
+ Complexity 3945 2861 -1084
=============================================
Files 991 994 +3
Lines 24628 24436 -192
Branches 2402 2368 -34
=============================================
- Hits 13570 9201 -4369
- Misses 9878 14438 +4560
+ Partials 1180 797 -383
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `49.54% <28.88%> (-23.28%)` | `14.00 <7.00> (-3.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `38.88% <70.37%> (-19.56%)` | `32.00 <6.00> (-33.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [258 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (2fcb790) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `17.79%`.
> The diff coverage is `60.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 56.58% 38.78% -17.80%
+ Complexity 4034 2377 -1657
=============================================
Files 1005 839 -166
Lines 24760 20627 -4133
Branches 2403 1950 -453
=============================================
- Hits 14010 8000 -6010
- Misses 9518 12028 +2510
+ Partials 1232 599 -633
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-11.23%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.14% <72.72%> (-8.44%)` | `56.00 <6.00> (-16.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [408 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (7ccff4e) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `7.98%`.
> The diff coverage is `61.26%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 48.60% -7.99%
+ Complexity 4034 3488 -546
============================================
Files 1005 991 -14
Lines 24760 24256 -504
Branches 2403 2356 -47
============================================
- Hits 14010 11789 -2221
- Misses 9518 11413 +1895
+ Partials 1232 1054 -178
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `37.28% <0.00%> (-2.21%)` | `5.00 <0.00> (-1.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-11.23%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.97% <72.22%> (-8.61%)` | `56.00 <6.00> (-16.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [187 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...fbb4bcf](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **decrease** coverage by `21.47%`.
> The diff coverage is `49.05%`.
> :exclamation: Current head 3dd7696 differs from pull request most recent head b92c02b. Consider uploading reports for the commit b92c02b to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 55.09% 33.62% -21.48%
+ Complexity 3945 2028 -1917
=============================================
Files 991 812 -179
Lines 24628 19937 -4691
Branches 2402 1877 -525
=============================================
- Hits 13570 6703 -6867
- Misses 9878 12735 +2857
+ Partials 1180 499 -681
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `49.54% <28.88%> (-23.28%)` | `14.00 <7.00> (-3.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `38.88% <70.37%> (-19.56%)` | `32.00 <6.00> (-33.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [449 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (8189591) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `10.34%`.
> The diff coverage is `59.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 53.99% 43.64% -10.35%
+ Complexity 4079 3138 -941
=============================================
Files 1779 961 -818
Lines 37794 23377 -14417
Branches 4157 2271 -1886
=============================================
- Hits 20408 10204 -10204
+ Misses 16403 12274 -4129
+ Partials 983 899 -84
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `80.00% <0.00%> (-11.18%)` | `11.00 <0.00> (ø)` | |
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `39.83% <0.00%> (+1.30%)` | `6.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-10.18%)` | `22.00 <12.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (-10.47%)` | `55.00 <6.00> (-17.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1337 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...00e1f4d](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (7ccff4e) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `16.52%`.
> The diff coverage is `47.74%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 56.58% 40.05% -16.53%
+ Complexity 4034 2957 -1077
=============================================
Files 1005 991 -14
Lines 24760 24095 -665
Branches 2403 2326 -77
=============================================
- Hits 14010 9651 -4359
- Misses 9518 13616 +4098
+ Partials 1232 828 -404
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `5.08% <0.00%> (-34.42%)` | `1.00 <0.00> (-5.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `53.70% <31.81%> (-28.83%)` | `16.00 <9.00> (-2.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `38.88% <70.37%> (-28.70%)` | `32.00 <6.00> (-40.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [297 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...fbb4bcf](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (1757802) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `13.74%`.
> The diff coverage is `65.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 53.64% 39.89% -13.75%
+ Complexity 4056 2445 -1611
=============================================
Files 1778 836 -942
Lines 37770 20552 -17218
Branches 4155 1941 -2214
=============================================
- Hits 20260 8200 -12060
+ Misses 16536 11743 -4793
+ Partials 974 609 -365
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.44% <63.63%> (-12.29%)` | `21.00 <12.00> (+3.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `54.91% <68.75%> (-12.81%)` | `67.00 <11.00> (-5.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1378 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#discussion_r588175876
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -376,15 +374,63 @@ public SampleFamily endpoint(List<String> serviceKeys, List<String> endpointKeys
if (this == EMPTY) {
return EMPTY;
}
- this.context.setMeterEntity(MeterEntity.newEndpoint(dim(serviceKeys), dim(endpointKeys)));
- return left(io.vavr.collection.Stream.concat(serviceKeys, endpointKeys).asJava());
+ return createMeterSamples(serviceKeys, endpointKeys, ScopeType.ENDPOINT);
+ }
+
+ private SampleFamily createMeterSamples(List<String> serviceKeys, List<String> level2keys, ScopeType scopeType) {
+ final List<String> labelKeys = io.vavr.collection.Stream.concat(serviceKeys, level2keys).asJava();
+ Map<MeterEntity, Sample[]> meterSamples = new HashMap<>();
+ Arrays.stream(samples)
+ .collect(groupingBy(it -> getLabels(labelKeys, it), mapping(identity(), toList())))
+ .forEach((labels, samples) -> {
+ MeterEntity meterEntity = getMeterEntity(samples, serviceKeys, level2keys, scopeType);
+ Preconditions.checkNotNull(meterEntity);
+ meterSamples.put(meterEntity, left(labelKeys, samples));
+ });
+
+ this.context.setMeterSamples(meterSamples);
+ //This samples is original, The grouped samples is in context which mapping with MeterEntity
+ return SampleFamily.build(this.context, samples);
+ }
+
+ private MeterEntity getMeterEntity(List<Sample> samples,
Review comment:
```suggestion
private MeterEntity buildMeterEntity(List<Sample> samples,
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (d73396a) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `5.12%`.
> The diff coverage is `69.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.99% 48.87% -5.13%
+ Complexity 4079 3402 -677
============================================
Files 1779 960 -819
Lines 37794 23498 -14296
Branches 4157 2281 -1876
============================================
- Hits 20408 11484 -8924
+ Misses 16403 11051 -5352
+ Partials 983 963 -20
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `77.14% <0.00%> (-14.04%)` | `10.00 <0.00> (-1.00)` | |
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.13% <0.00%> (-0.39%)` | `6.00 <0.00> (ø)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.81% <75.92%> (-1.92%)` | `62.00 <8.00> (-10.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.73% <80.00%> (-1.00%)` | `23.00 <12.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1321 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (2fcb790) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **increase** coverage by `0.67%`.
> The diff coverage is `74.21%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
+ Coverage 56.58% 57.26% +0.67%
+ Complexity 4034 4028 -6
============================================
Files 1005 990 -15
Lines 24760 24425 -335
Branches 2403 2372 -31
============================================
- Hits 14010 13986 -24
+ Misses 9518 9213 -305
+ Partials 1232 1226 -6
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `77.77% <77.77%> (ø)` | `4.00 <4.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `82.40% <79.54%> (-0.12%)` | `24.00 <13.00> (+6.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `68.08% <80.00%> (+0.50%)` | `63.00 <8.00> (-9.00)` | :arrow_up: |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | |
| [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `13.63% <0.00%> (-68.19%)` | `1.00% <0.00%> (-5.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| [...rest/ManagementServiceReportPropertiesHandler.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VSZXBvcnRQcm9wZXJ0aWVzSGFuZGxlci5qYXZh) | `27.58% <0.00%> (-62.07%)` | `2.00% <0.00%> (-2.00%)` | |
| ... and [63 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (d73396a) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `0.81%`.
> The diff coverage is `70.79%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.99% 53.18% -0.82%
+ Complexity 4079 3783 -296
============================================
Files 1779 991 -788
Lines 37794 24403 -13391
Branches 4157 2369 -1788
============================================
- Hits 20408 12979 -7429
+ Misses 16403 10341 -6062
- Partials 983 1083 +100
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `39.83% <0.00%> (+1.30%)` | `6.00 <0.00> (ø)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.81% <75.92%> (-1.92%)` | `62.00 <8.00> (-10.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.73% <80.00%> (-1.00%)` | `23.00 <12.00> (+5.00)` | :arrow_down: |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `91.42% <100.00%> (+0.25%)` | `12.00 <0.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1273 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#discussion_r589142106
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -477,10 +447,74 @@ static RunningContext instance() {
.build();
}
- MeterEntity meterEntity;
+ private Map<MeterEntity, Sample[]> meterSamples = new HashMap<>();
private HistogramType histogramType;
private TimeUnit defaultHistogramBucketUnit;
}
+
+ private static class InternalOps {
+
+ private static Sample[] left(List<Sample> samples, List<String> labelKeys) {
+ return samples.stream().map(s -> {
+ ImmutableMap<String, String> ll = ImmutableMap.<String, String>builder()
+ .putAll(Maps.filterKeys(s.labels, key -> !labelKeys.contains(key)))
+ .build();
+ return s.toBuilder().labels(ll).build();
+ }).toArray(Sample[]::new);
+ }
+
+ private static String dim(List<Sample> samples, List<String> labelKeys) {
+ String name = labelKeys.stream()
+ .map(k -> samples.get(0).labels.getOrDefault(k, ""))
+ .collect(Collectors.joining("."));
+ return CharMatcher.is('.').trimFrom(name);
+ }
+
+ private static MeterEntity buildMeterEntity(List<Sample> samples,
+ EntityDescription entityDescription) {
+ switch (entityDescription.getScopeType()) {
+ case SERVICE:
+ return MeterEntity.newService(InternalOps.dim(samples, entityDescription.getServiceKeys()));
+ case SERVICE_INSTANCE:
+ return MeterEntity.newServiceInstance(
+ InternalOps.dim(samples, entityDescription.getServiceKeys()),
+ InternalOps.dim(samples, entityDescription.getInstanceKeys())
+ );
+ case ENDPOINT:
+ return MeterEntity.newEndpoint(
+ InternalOps.dim(samples, entityDescription.getServiceKeys()),
+ InternalOps.dim(samples, entityDescription.getEndpointKeys())
+ );
+ }
+ return null;
Review comment:
I prefer to throw exception here, rather than facing unexpected NPE one day.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `11.00%`.
> The diff coverage is `41.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 54.18% 43.18% -11.01%
+ Complexity 4150 3150 -1000
=============================================
Files 1783 995 -788
Lines 38193 24514 -13679
Branches 4209 2372 -1837
=============================================
- Hits 20695 10586 -10109
+ Misses 16511 13055 -3456
+ Partials 987 873 -114
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `53.21% <31.11%> (-27.56%)` | `16.00 <8.00> (-2.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `25.64% <50.00%> (-42.09%)` | `20.00 <3.00> (-52.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `62.96% <83.33%> (-12.04%)` | `6.00 <1.00> (-2.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1335 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#discussion_r588251760
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -376,15 +374,63 @@ public SampleFamily endpoint(List<String> serviceKeys, List<String> endpointKeys
if (this == EMPTY) {
return EMPTY;
}
- this.context.setMeterEntity(MeterEntity.newEndpoint(dim(serviceKeys), dim(endpointKeys)));
- return left(io.vavr.collection.Stream.concat(serviceKeys, endpointKeys).asJava());
+ return createMeterSamples(serviceKeys, endpointKeys, ScopeType.ENDPOINT);
+ }
+
+ private SampleFamily createMeterSamples(List<String> serviceKeys, List<String> level2keys, ScopeType scopeType) {
+ final List<String> labelKeys = io.vavr.collection.Stream.concat(serviceKeys, level2keys).asJava();
+ Map<MeterEntity, Sample[]> meterSamples = new HashMap<>();
+ Arrays.stream(samples)
+ .collect(groupingBy(it -> getLabels(labelKeys, it), mapping(identity(), toList())))
+ .forEach((labels, samples) -> {
+ MeterEntity meterEntity = getMeterEntity(samples, serviceKeys, level2keys, scopeType);
+ Preconditions.checkNotNull(meterEntity);
+ meterSamples.put(meterEntity, left(labelKeys, samples));
+ });
+
+ this.context.setMeterSamples(meterSamples);
+ //This samples is original, The grouped samples is in context which mapping with MeterEntity
+ return SampleFamily.build(this.context, samples);
+ }
+
+ private MeterEntity getMeterEntity(List<Sample> samples,
+ List<String> serviceKeys,
+ List<String> level2keys,
+ ScopeType scopeType) {
+ switch (scopeType) {
+ case SERVICE:
+ return MeterEntity.newService(dim(serviceKeys, samples));
+ case SERVICE_INSTANCE:
+ return MeterEntity.newServiceInstance(dim(serviceKeys, samples), dim(level2keys, samples));
+ case ENDPOINT:
+ return MeterEntity.newEndpoint(dim(serviceKeys, samples), dim(level2keys, samples));
+ }
+ return null;
}
private String dim(List<String> labelKeys) {
- String name = labelKeys.stream().map(k -> samples[0].labels.getOrDefault(k, "")).collect(Collectors.joining("."));
+ String name = labelKeys.stream()
+ .map(k -> samples[0].labels.getOrDefault(k, ""))
+ .collect(Collectors.joining("."));
+ return CharMatcher.is('.').trimFrom(name);
+ }
+
+ private String dim(List<String> labelKeys, List<Sample> samples) {
+ String name = labelKeys.stream()
+ .map(k -> samples.get(0).labels.getOrDefault(k, ""))
+ .collect(Collectors.joining("."));
return CharMatcher.is('.').trimFrom(name);
}
+ private Sample[] left(List<String> labelKeys, List<Sample> samples) {
+ return samples.stream().map(s -> {
+ ImmutableMap<String, String> ll = ImmutableMap.<String, String>builder()
+ .putAll(Maps.filterKeys(s.labels, key -> !labelKeys.contains(key)))
+ .build();
+ return s.toBuilder().labels(ll).build();
+ }).toArray(Sample[]::new);
+ }
+
private SampleFamily left(List<String> labelKeys) {
Review comment:
This is never used, if not useful, please remove this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `0.90%`.
> The diff coverage is `68.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 53.27% -0.91%
+ Complexity 4150 4001 -149
============================================
Files 1783 1786 +3
Lines 38193 38152 -41
Branches 4209 4203 -6
============================================
- Hits 20695 20327 -368
- Misses 16511 16849 +338
+ Partials 987 976 -11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `75.45% <66.66%> (-5.32%)` | `23.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `60.00% <74.07%> (-7.73%)` | `56.00 <6.00> (-16.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `77.77% <83.33%> (+2.77%)` | `8.00 <1.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `60.97% <100.00%> (-1.82%)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [44 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (d73396a) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **increase** coverage by `1.68%`.
> The diff coverage is `72.56%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
+ Coverage 53.99% 55.68% +1.68%
+ Complexity 4079 3964 -115
============================================
Files 1779 991 -788
Lines 37794 24441 -13353
Branches 4157 2371 -1786
============================================
- Hits 20408 13610 -6798
+ Misses 16403 9669 -6734
- Partials 983 1162 +179
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `39.83% <0.00%> (+1.30%)` | `6.00 <0.00> (ø)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `67.52% <79.62%> (-0.21%)` | `63.00 <8.00> (-9.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `82.56% <80.00%> (+0.83%)` | `23.00 <12.00> (+5.00)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `91.42% <100.00%> (+0.25%)` | `12.00 <0.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1247 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **decrease** coverage by `3.54%`.
> The diff coverage is `65.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 52.61% 49.06% -3.55%
+ Complexity 3945 3633 -312
============================================
Files 1783 994 -789
Lines 38122 24626 -13496
Branches 4201 2401 -1800
============================================
- Hits 20056 12083 -7973
+ Misses 17087 11482 -5605
- Partials 979 1061 +82
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-0.56%)` | `22.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.97% <72.22%> (+0.33%)` | `56.00 <6.00> (-9.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1283 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (fbb4bcf) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `9.55%`.
> The diff coverage is `74.28%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 47.02% -9.56%
+ Complexity 4034 2859 -1175
============================================
Files 1005 839 -166
Lines 24760 20734 -4026
Branches 2403 1962 -441
============================================
- Hits 14010 9751 -4259
- Misses 9518 10231 +713
+ Partials 1232 752 -480
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.81% <75.92%> (-1.77%)` | `62.00 <8.00> (-10.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.48% <79.54%> (-1.05%)` | `24.00 <13.00> (+6.00)` | :arrow_down: |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...n/jdbc/postgresql/dao/PostgreSQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvcG9zdGdyZXNxbC9kYW8vUG9zdGdyZVNRTFRyYWNlUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [293 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...fbb4bcf](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **increase** coverage by `0.19%`.
> The diff coverage is `65.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
+ Coverage 52.61% 52.80% +0.19%
+ Complexity 3945 3828 -117
============================================
Files 1783 994 -789
Lines 38122 24686 -13436
Branches 4201 2406 -1795
============================================
- Hits 20056 13036 -7020
+ Misses 17087 10476 -6611
- Partials 979 1174 +195
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-0.56%)` | `22.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.97% <72.22%> (+0.33%)` | `56.00 <6.00> (-9.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1284 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (2fcb790) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `12.43%`.
> The diff coverage is `60.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 56.58% 44.14% -12.44%
+ Complexity 4034 2667 -1367
=============================================
Files 1005 839 -166
Lines 24760 20641 -4119
Branches 2403 1954 -449
=============================================
- Hits 14010 9112 -4898
- Misses 9518 10828 +1310
+ Partials 1232 701 -531
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-11.23%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.57% <72.72%> (-8.01%)` | `56.00 <6.00> (-16.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [348 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on a change in pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
wankai123 commented on a change in pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#discussion_r589188413
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/EntityDescription/InstanceEntityDescription.java
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.meter.analyzer.dsl.EntityDescription;
+
+import java.util.List;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+import org.apache.skywalking.oap.server.core.analysis.meter.ScopeType;
+
+public class InstanceEntityDescription implements EntityDescription {
Review comment:
done
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -477,10 +447,74 @@ static RunningContext instance() {
.build();
}
- MeterEntity meterEntity;
+ private Map<MeterEntity, Sample[]> meterSamples = new HashMap<>();
private HistogramType histogramType;
private TimeUnit defaultHistogramBucketUnit;
}
+
+ private static class InternalOps {
+
+ private static Sample[] left(List<Sample> samples, List<String> labelKeys) {
+ return samples.stream().map(s -> {
+ ImmutableMap<String, String> ll = ImmutableMap.<String, String>builder()
+ .putAll(Maps.filterKeys(s.labels, key -> !labelKeys.contains(key)))
+ .build();
+ return s.toBuilder().labels(ll).build();
+ }).toArray(Sample[]::new);
+ }
+
+ private static String dim(List<Sample> samples, List<String> labelKeys) {
+ String name = labelKeys.stream()
+ .map(k -> samples.get(0).labels.getOrDefault(k, ""))
+ .collect(Collectors.joining("."));
+ return CharMatcher.is('.').trimFrom(name);
+ }
+
+ private static MeterEntity buildMeterEntity(List<Sample> samples,
+ EntityDescription entityDescription) {
+ switch (entityDescription.getScopeType()) {
+ case SERVICE:
+ return MeterEntity.newService(InternalOps.dim(samples, entityDescription.getServiceKeys()));
+ case SERVICE_INSTANCE:
+ return MeterEntity.newServiceInstance(
+ InternalOps.dim(samples, entityDescription.getServiceKeys()),
+ InternalOps.dim(samples, entityDescription.getInstanceKeys())
+ );
+ case ENDPOINT:
+ return MeterEntity.newEndpoint(
+ InternalOps.dim(samples, entityDescription.getServiceKeys()),
+ InternalOps.dim(samples, entityDescription.getEndpointKeys())
+ );
+ }
+ return null;
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `2.59%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 51.58% -2.60%
+ Complexity 4150 3808 -342
============================================
Files 1783 1786 +3
Lines 38193 38152 -41
Branches 4209 4203 -6
============================================
- Hits 20695 19681 -1014
- Misses 16511 17491 +980
+ Partials 987 980 -7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `73.63% <66.66%> (-7.14%)` | `23.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.29% <70.37%> (-9.43%)` | `55.00 <6.00> (-17.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `77.77% <83.33%> (+2.77%)` | `8.00 <1.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `60.97% <100.00%> (-1.82%)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [95 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `2.63%`.
> The diff coverage is `63.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 51.55% -2.64%
+ Complexity 4150 3684 -466
============================================
Files 1783 995 -788
Lines 38193 24660 -13533
Branches 4209 2403 -1806
============================================
- Hits 20695 12713 -7982
+ Misses 16511 10881 -5630
- Partials 987 1066 +79
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-9.21%)` | `22.00 <12.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (-10.47%)` | `55.00 <6.00> (-17.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `77.77% <83.33%> (+2.77%)` | `8.00 <1.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1297 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (262a4a5) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `21.52%`.
> The diff coverage is `40.35%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 54.18% 32.66% -21.53%
+ Complexity 4150 1969 -2181
=============================================
Files 1783 811 -972
Lines 38193 19836 -18357
Branches 4209 1865 -2344
=============================================
- Hits 20695 6479 -14216
+ Misses 16511 12903 -3608
+ Partials 987 454 -533
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `49.54% <28.88%> (-31.23%)` | `14.00 <6.00> (-4.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `25.64% <50.00%> (-42.09%)` | `20.00 <3.00> (-52.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `62.96% <83.33%> (-12.04%)` | `6.00 <1.00> (-2.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1449 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `47.08%`.
> The diff coverage is `62.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 47.08% +47.08%
- Complexity 0 3408 +3408
=============================================
Files 195 991 +796
Lines 4675 24213 +19538
Branches 544 2355 +1811
=============================================
+ Hits 0 11400 +11400
- Misses 4675 11834 +7159
- Partials 0 979 +979
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.37% <63.63%> (ø)` | `22.00 <13.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (ø)` | `55.00 <6.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...apache/skywalking/apm/toolkit/meter/Histogram.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvSGlzdG9ncmFtLmphdmE=) | | | |
| [...ache/skywalking/apm/toolkit/meter/BaseBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQmFzZUJ1aWxkZXIuamF2YQ==) | | | |
| [.../apache/skywalking/apm/agent/core/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvR2F1Z2UuamF2YQ==) | | | |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | | | |
| ... and [1000 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `55.28%`.
> The diff coverage is `76.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 55.28% +55.28%
- Complexity 0 3948 +3948
=============================================
Files 195 991 +796
Lines 4675 24416 +19741
Branches 544 2370 +1826
=============================================
+ Hits 0 13499 +13499
- Misses 4675 9751 +5076
- Partials 0 1166 +1166
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `83.33% <79.54%> (ø)` | `24.00 <13.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `67.52% <79.62%> (ø)` | `63.00 <8.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...ache/skywalking/apm/agent/core/meter/MeterTag.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUYWcuamF2YQ==) | | | |
| [.../agent/core/context/util/ThrowableTransformer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1Rocm93YWJsZVRyYW5zZm9ybWVyLmphdmE=) | | | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | | | |
| [...apache/skywalking/apm/toolkit/meter/Histogram.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvSGlzdG9ncmFtLmphdmE=) | | | |
| ... and [1000 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `8.57%`.
> The diff coverage is `41.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 45.61% -8.58%
+ Complexity 4150 3299 -851
============================================
Files 1783 995 -788
Lines 38193 24514 -13679
Branches 4209 2372 -1837
============================================
- Hits 20695 11182 -9513
+ Misses 16511 12405 -4106
+ Partials 987 927 -60
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `53.21% <31.11%> (-27.56%)` | `16.00 <8.00> (-2.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `25.64% <50.00%> (-42.09%)` | `20.00 <3.00> (-52.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `62.96% <83.33%> (-12.04%)` | `6.00 <1.00> (-2.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1326 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **increase** coverage by `0.04%`.
> The diff coverage is `65.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
+ Coverage 52.61% 52.65% +0.04%
+ Complexity 3945 3824 -121
============================================
Files 1783 994 -789
Lines 38122 24686 -13436
Branches 4201 2406 -1795
============================================
- Hits 20056 12998 -7058
+ Misses 17087 10523 -6564
- Partials 979 1165 +186
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-0.56%)` | `22.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.97% <72.22%> (+0.33%)` | `56.00 <6.00> (-9.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1283 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3b206ef) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `12.07%`.
> The diff coverage is `59.82%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 53.99% 41.92% -12.08%
+ Complexity 4079 2415 -1664
=============================================
Files 1779 809 -970
Lines 37794 19802 -17992
Branches 4157 1873 -2284
=============================================
- Hits 20408 8301 -12107
+ Misses 16403 10876 -5527
+ Partials 983 625 -358
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.13% <0.00%> (-0.39%)` | `6.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-10.18%)` | `22.00 <12.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.69% <68.51%> (-10.04%)` | `55.00 <6.00> (-17.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1407 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (d73396a) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `3.10%`.
> The diff coverage is `69.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.99% 50.89% -3.11%
+ Complexity 4079 3626 -453
============================================
Files 1779 990 -789
Lines 37794 24345 -13449
Branches 4157 2365 -1792
============================================
- Hits 20408 12391 -8017
+ Misses 16403 10924 -5479
- Partials 983 1030 +47
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `77.14% <0.00%> (-14.04%)` | `10.00 <0.00> (-1.00)` | |
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.13% <0.00%> (-0.39%)` | `6.00 <0.00> (ø)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.81% <75.92%> (-1.92%)` | `62.00 <8.00> (-10.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.73% <80.00%> (-1.00%)` | `23.00 <12.00> (+5.00)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1295 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#discussion_r588169502
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -376,15 +374,63 @@ public SampleFamily endpoint(List<String> serviceKeys, List<String> endpointKeys
if (this == EMPTY) {
return EMPTY;
}
- this.context.setMeterEntity(MeterEntity.newEndpoint(dim(serviceKeys), dim(endpointKeys)));
- return left(io.vavr.collection.Stream.concat(serviceKeys, endpointKeys).asJava());
+ return createMeterSamples(serviceKeys, endpointKeys, ScopeType.ENDPOINT);
+ }
+
+ private SampleFamily createMeterSamples(List<String> serviceKeys, List<String> level2keys, ScopeType scopeType) {
+ final List<String> labelKeys = io.vavr.collection.Stream.concat(serviceKeys, level2keys).asJava();
Review comment:
`o.vavr.collection.Stream` Full class name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b92c02b) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **decrease** coverage by `17.49%`.
> The diff coverage is `39.62%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 52.61% 35.11% -17.50%
+ Complexity 3945 2105 -1840
=============================================
Files 1783 812 -971
Lines 38122 19883 -18239
Branches 4201 1869 -2332
=============================================
- Hits 20056 6981 -13075
+ Misses 17087 12381 -4706
+ Partials 979 521 -458
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `53.21% <31.11%> (-18.91%)` | `16.00 <8.00> (-1.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `25.64% <50.00%> (-33.00%)` | `20.00 <3.00> (-45.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1416 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `58.73%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 58.73% +58.73%
- Complexity 0 829 +829
=============================================
Files 195 172 -23
Lines 4675 4202 -473
Branches 544 482 -62
=============================================
+ Hits 0 2468 +2468
+ Misses 4675 1420 -3255
- Partials 0 314 +314
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | | | |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | | | |
| [...che/skywalking/apm/agent/core/meter/BaseMeter.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQmFzZU1ldGVyLmphdmE=) | | | |
| [...g/apache/skywalking/apm/toolkit/meter/Counter.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQ291bnRlci5qYXZh) | | | |
| [...che/skywalking/apm/toolkit/meter/MeterFactory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvTWV0ZXJGYWN0b3J5LmphdmE=) | | | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | | | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | | | |
| [...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=) | | | |
| [...t/core/plugin/bytebuddy/ArgumentTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bcmd1bWVudFR5cGVOYW1lTWF0Y2guamF2YQ==) | | | |
| ... and [176 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **decrease** coverage by `1.11%`.
> The diff coverage is `65.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 52.61% 51.49% -1.12%
+ Complexity 3945 3751 -194
============================================
Files 1783 994 -789
Lines 38122 24645 -13477
Branches 4201 2401 -1800
============================================
- Hits 20056 12691 -7365
+ Misses 17087 10827 -6260
- Partials 979 1127 +148
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-0.56%)` | `22.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.97% <72.22%> (+0.33%)` | `56.00 <6.00> (-9.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1275 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (262a4a5) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `21.02%`.
> The diff coverage is `40.35%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 54.18% 33.16% -21.03%
+ Complexity 4150 1995 -2155
=============================================
Files 1783 812 -971
Lines 38193 19871 -18322
Branches 4209 1869 -2340
=============================================
- Hits 20695 6590 -14105
+ Misses 16511 12817 -3694
+ Partials 987 464 -523
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `49.54% <28.88%> (-31.23%)` | `14.00 <6.00> (-4.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `25.64% <50.00%> (-42.09%)` | `20.00 <3.00> (-52.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `62.96% <83.33%> (-12.04%)` | `6.00 <1.00> (-2.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1446 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (fbb4bcf) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `13.18%`.
> The diff coverage is `62.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 56.58% 43.39% -13.19%
+ Complexity 4034 2659 -1375
=============================================
Files 1005 839 -166
Lines 24760 20598 -4162
Branches 2403 1949 -454
=============================================
- Hits 14010 8939 -5071
- Misses 9518 10964 +1446
+ Partials 1232 695 -537
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.37% <63.63%> (-12.16%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (-10.32%)` | `55.00 <6.00> (-17.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [356 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...fbb4bcf](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (5a5db0e) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `7.15%`.
> The diff coverage is `64.06%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 49.42% -7.16%
+ Complexity 4034 3599 -435
============================================
Files 1005 1782 +777
Lines 24760 37761 +13001
Branches 2403 4151 +1748
============================================
+ Hits 14010 18664 +4654
- Misses 9518 18118 +8600
+ Partials 1232 979 -253
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `44.44% <44.44%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.64% <63.63%> (-11.89%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.74% <74.54%> (-7.84%)` | `56.00 <6.00> (-16.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1274 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...fbb4bcf](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (1757802) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `12.89%`.
> The diff coverage is `65.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 53.64% 40.74% -12.90%
+ Complexity 4056 2499 -1557
=============================================
Files 1778 836 -942
Lines 37770 20552 -17218
Branches 4155 1941 -2214
=============================================
- Hits 20260 8373 -11887
+ Misses 16536 11559 -4977
+ Partials 974 620 -354
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.44% <63.63%> (-12.29%)` | `21.00 <12.00> (+3.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `54.91% <68.75%> (-12.81%)` | `67.00 <11.00> (-5.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1372 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (af503ce) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `3.93%`.
> The diff coverage is `72.65%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 52.64% -3.94%
+ Complexity 4034 3770 -264
============================================
Files 1005 990 -15
Lines 24760 24344 -416
Branches 2403 2361 -42
============================================
- Hits 14010 12816 -1194
- Misses 9518 10425 +907
+ Partials 1232 1103 -129
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.95% <76.36%> (-1.63%)` | `62.00 <8.00> (-10.00)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `77.77% <77.77%> (ø)` | `4.00 <4.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.55% <79.54%> (-1.97%)` | `23.00 <12.00> (+5.00)` | :arrow_down: |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...n/jdbc/postgresql/dao/PostgreSQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvcG9zdGdyZXNxbC9kYW8vUG9zdGdyZVNRTFRyYWNlUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-84.62%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [124 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `55.82%`.
> The diff coverage is `76.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 55.82% +55.82%
- Complexity 0 3975 +3975
=============================================
Files 195 991 +796
Lines 4675 24417 +19742
Branches 544 2374 +1830
=============================================
+ Hits 0 13630 +13630
- Misses 4675 9597 +4922
- Partials 0 1190 +1190
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `83.33% <79.54%> (ø)` | `24.00 <13.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `67.94% <79.62%> (ø)` | `63.00 <8.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...pache/skywalking/apm/agent/core/meter/MeterId.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJJZC5qYXZh) | | | |
| [...che/skywalking/apm/toolkit/meter/MeterFactory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvTWV0ZXJGYWN0b3J5LmphdmE=) | | | |
| [...che/skywalking/apm/agent/core/meter/Histogram.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvSGlzdG9ncmFtLmphdmE=) | | | |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | | | |
| ... and [1000 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `51.15%`.
> The diff coverage is `64.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 51.15% +51.15%
- Complexity 0 3660 +3660
=============================================
Files 195 991 +796
Lines 4675 24291 +19616
Branches 544 2361 +1817
=============================================
+ Hits 0 12427 +12427
- Misses 4675 10801 +6126
- Partials 0 1063 +1063
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `72.22% <63.63%> (ø)` | `22.00 <13.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.97% <72.22%> (ø)` | `56.00 <6.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | | | |
| [...g/apache/skywalking/apm/toolkit/meter/MeterId.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvTWV0ZXJJZC5qYXZh) | | | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | | | |
| [.../agent/core/context/util/ThrowableTransformer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1Rocm93YWJsZVRyYW5zZm9ybWVyLmphdmE=) | | | |
| ... and [1000 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `55.81%`.
> The diff coverage is `76.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 55.81% +55.81%
- Complexity 0 3975 +3975
=============================================
Files 195 991 +796
Lines 4675 24416 +19741
Branches 544 2370 +1826
=============================================
+ Hits 0 13628 +13628
- Misses 4675 9597 +4922
- Partials 0 1191 +1191
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `83.33% <79.54%> (ø)` | `24.00 <13.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `67.52% <79.62%> (ø)` | `63.00 <8.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...pache/skywalking/apm/agent/core/meter/MeterId.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJJZC5qYXZh) | | | |
| [...g/apache/skywalking/apm/toolkit/meter/Counter.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQ291bnRlci5qYXZh) | | | |
| [...ache/skywalking/apm/toolkit/meter/BaseBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQmFzZUJ1aWxkZXIuamF2YQ==) | | | |
| [...t/core/plugin/bytebuddy/ArgumentTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bcmd1bWVudFR5cGVOYW1lTWF0Y2guamF2YQ==) | | | |
| ... and [1000 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (7ccff4e) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `4.78%`.
> The diff coverage is `62.16%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 51.79% -4.79%
+ Complexity 4034 3751 -283
============================================
Files 1005 1782 +777
Lines 24760 37750 +12990
Branches 2403 4151 +1748
============================================
+ Hits 14010 19552 +5542
- Misses 9518 17217 +7699
+ Partials 1232 981 -251
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.84% <0.00%> (-0.66%)` | `6.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `73.39% <63.63%> (-9.13%)` | `23.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `60.00% <74.07%> (-7.58%)` | `56.00 <6.00> (-16.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1279 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...fbb4bcf](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (1757802) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `8.44%`.
> The diff coverage is `65.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.64% 45.19% -8.45%
+ Complexity 4056 2708 -1348
============================================
Files 1778 836 -942
Lines 37770 20598 -17172
Branches 4155 1947 -2208
============================================
- Hits 20260 9310 -10950
+ Misses 16536 10601 -5935
+ Partials 974 687 -287
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.44% <63.63%> (-12.29%)` | `21.00 <12.00> (+3.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `54.91% <68.75%> (-12.81%)` | `67.00 <11.00> (-5.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1351 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `0.75%`.
> The diff coverage is `68.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 53.43% -0.76%
+ Complexity 4150 4011 -139
============================================
Files 1783 1786 +3
Lines 38193 38152 -41
Branches 4209 4203 -6
============================================
- Hits 20695 20386 -309
- Misses 16511 16790 +279
+ Partials 987 976 -11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `75.45% <66.66%> (-5.32%)` | `23.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `60.00% <74.07%> (-7.73%)` | `56.00 <6.00> (-16.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `77.77% <83.33%> (+2.77%)` | `8.00 <1.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `60.97% <100.00%> (-1.82%)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [42 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (fbb4bcf) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `14.56%`.
> The diff coverage is `62.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 56.58% 42.01% -14.57%
+ Complexity 4034 2576 -1458
=============================================
Files 1005 839 -166
Lines 24760 20570 -4190
Branches 2403 1944 -459
=============================================
- Hits 14010 8643 -5367
- Misses 9518 11244 +1726
+ Partials 1232 683 -549
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.37% <63.63%> (-12.16%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (-10.32%)` | `55.00 <6.00> (-17.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [375 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...fbb4bcf](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (1757802) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `10.63%`.
> The diff coverage is `65.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 53.64% 43.00% -10.64%
+ Complexity 4056 2626 -1430
=============================================
Files 1778 836 -942
Lines 37770 20581 -17189
Branches 4155 1946 -2209
=============================================
- Hits 20260 8851 -11409
+ Misses 16536 11071 -5465
+ Partials 974 659 -315
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.44% <63.63%> (-12.29%)` | `21.00 <12.00> (+3.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `54.91% <68.75%> (-12.81%)` | `67.00 <11.00> (-5.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1362 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (1757802) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `4.09%`.
> The diff coverage is `65.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.64% 49.54% -4.10%
+ Complexity 4056 2939 -1117
============================================
Files 1778 836 -942
Lines 37770 20638 -17132
Branches 4155 1949 -2206
============================================
- Hits 20260 10225 -10035
+ Misses 16536 9590 -6946
+ Partials 974 823 -151
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-10.44%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.55% <68.75%> (-11.17%)` | `70.00 <11.00> (-2.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1327 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (af503ce) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **increase** coverage by `0.32%`.
> The diff coverage is `72.65%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
+ Coverage 56.58% 56.90% +0.32%
+ Complexity 4034 4020 -14
============================================
Files 1005 991 -14
Lines 24760 24448 -312
Branches 2403 2375 -28
============================================
- Hits 14010 13913 -97
+ Misses 9518 9362 -156
+ Partials 1232 1173 -59
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `66.38% <76.36%> (-1.20%)` | `62.00 <8.00> (-10.00)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `77.77% <77.77%> (ø)` | `4.00 <4.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.48% <79.54%> (-1.05%)` | `24.00 <13.00> (+6.00)` | :arrow_down: |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | |
| [.../core/analysis/meter/function/sum/SumFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vc3VtL1N1bUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-69.50%)` | `0.00% <0.00%> (-12.00%)` | |
| [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `13.63% <0.00%> (-68.19%)` | `1.00% <0.00%> (-5.00%)` | |
| [...er/storage/plugin/jdbc/mysql/MySQLLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxMb2dRdWVyeURBTy5qYXZh) | `40.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| ... and [68 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (2fcb790) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **increase** coverage by `0.23%`.
> The diff coverage is `74.21%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
+ Coverage 56.58% 56.81% +0.23%
+ Complexity 4034 4009 -25
============================================
Files 1005 990 -15
Lines 24760 24425 -335
Branches 2403 2372 -31
============================================
- Hits 14010 13877 -133
+ Misses 9518 9329 -189
+ Partials 1232 1219 -13
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `77.77% <77.77%> (ø)` | `4.00 <4.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `82.40% <79.54%> (-0.12%)` | `24.00 <13.00> (+6.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `68.08% <80.00%> (+0.50%)` | `63.00 <8.00> (-9.00)` | :arrow_up: |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <0.00%> (-73.81%)` | `1.00% <0.00%> (-6.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2AlarmQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQWxhcm1RdWVyeURBTy5qYXZh) | `6.97% <0.00%> (-72.10%)` | `1.00% <0.00%> (-4.00%)` | |
| [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `13.63% <0.00%> (-68.19%)` | `1.00% <0.00%> (-5.00%)` | |
| ... and [70 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#discussion_r588174198
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -376,15 +374,63 @@ public SampleFamily endpoint(List<String> serviceKeys, List<String> endpointKeys
if (this == EMPTY) {
return EMPTY;
}
- this.context.setMeterEntity(MeterEntity.newEndpoint(dim(serviceKeys), dim(endpointKeys)));
- return left(io.vavr.collection.Stream.concat(serviceKeys, endpointKeys).asJava());
+ return createMeterSamples(serviceKeys, endpointKeys, ScopeType.ENDPOINT);
+ }
+
+ private SampleFamily createMeterSamples(List<String> serviceKeys, List<String> level2keys, ScopeType scopeType) {
Review comment:
Basically, I prefer to remove the name `level2*`. This doesn't exist in the SkyWalking, I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (af503ce) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **increase** coverage by `0.49%`.
> The diff coverage is `72.65%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
+ Coverage 56.58% 57.08% +0.49%
+ Complexity 4034 4031 -3
============================================
Files 1005 991 -14
Lines 24760 24448 -312
Branches 2403 2375 -28
============================================
- Hits 14010 13955 -55
+ Misses 9518 9319 -199
+ Partials 1232 1174 -58
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `66.38% <76.36%> (-1.20%)` | `62.00 <8.00> (-10.00)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `77.77% <77.77%> (ø)` | `4.00 <4.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.48% <79.54%> (-1.05%)` | `24.00 <13.00> (+6.00)` | :arrow_down: |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | |
| [.../core/analysis/meter/function/sum/SumFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vc3VtL1N1bUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-69.50%)` | `0.00% <0.00%> (-12.00%)` | |
| [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `13.63% <0.00%> (-68.19%)` | `1.00% <0.00%> (-5.00%)` | |
| [...er/storage/plugin/jdbc/mysql/MySQLLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxMb2dRdWVyeURBTy5qYXZh) | `40.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| ... and [75 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (af503ce) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `4.68%`.
> The diff coverage is `58.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 51.90% -4.69%
+ Complexity 4034 3608 -426
============================================
Files 1005 960 -45
Lines 24760 23423 -1337
Branches 2403 2273 -130
============================================
- Hits 14010 12157 -1853
- Misses 9518 10211 +693
+ Partials 1232 1055 -177
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-11.23%)` | `22.00 <12.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.44% <69.09%> (-10.14%)` | `55.00 <6.00> (-17.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...n/jdbc/postgresql/dao/PostgreSQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvcG9zdGdyZXNxbC9kYW8vUG9zdGdyZVNRTFRyYWNlUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [177 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (8189591) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `12.85%`.
> The diff coverage is `59.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 53.99% 41.14% -12.86%
+ Complexity 4079 2959 -1120
=============================================
Files 1779 961 -818
Lines 37794 23338 -14456
Branches 4157 2270 -1887
=============================================
- Hits 20408 9602 -10806
+ Misses 16403 12893 -3510
+ Partials 983 843 -140
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `80.00% <0.00%> (-11.18%)` | `11.00 <0.00> (ø)` | |
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.13% <0.00%> (-0.39%)` | `6.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.72% <64.44%> (-12.01%)` | `21.00 <12.00> (+3.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (-10.47%)` | `55.00 <6.00> (-17.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1366 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...00e1f4d](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **decrease** coverage by `12.51%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 55.09% 42.58% -12.52%
+ Complexity 3945 3177 -768
=============================================
Files 991 994 +3
Lines 24628 24445 -183
Branches 2402 2368 -34
=============================================
- Hits 13570 10409 -3161
- Misses 9878 13149 +3271
+ Partials 1180 887 -293
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `53.21% <31.11%> (-19.61%)` | `16.00 <9.00> (-1.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `38.88% <70.37%> (-19.56%)` | `32.00 <6.00> (-33.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [210 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (af503ce) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `16.71%`.
> The diff coverage is `39.06%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 56.58% 39.86% -16.72%
+ Complexity 4034 2330 -1704
=============================================
Files 1005 809 -196
Lines 24760 19634 -5126
Branches 2403 1836 -567
=============================================
- Hits 14010 7828 -6182
- Misses 9518 11216 +1698
+ Partials 1232 590 -642
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `48.14% <29.54%> (-34.38%)` | `13.00 <6.00> (-5.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `25.95% <50.90%> (-41.63%)` | `20.00 <3.00> (-52.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [430 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (262a4a5) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `17.60%`.
> The diff coverage is `57.01%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 54.18% 36.58% -17.61%
+ Complexity 4150 2158 -1992
=============================================
Files 1783 812 -971
Lines 38193 19985 -18208
Branches 4209 1877 -2332
=============================================
- Hits 20695 7311 -13384
+ Misses 16511 12177 -4334
+ Partials 987 497 -490
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `64.22% <48.88%> (-16.55%)` | `20.00 <9.00> (+2.00)` | :arrow_down: |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `41.88% <66.66%> (-25.85%)` | `30.00 <5.00> (-42.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `62.96% <83.33%> (-12.04%)` | `6.00 <1.00> (-2.00)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1435 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (a6c716c) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `12.15%`.
> The diff coverage is `2.53%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 53.99% 41.84% -12.16%
+ Complexity 4079 2504 -1575
=============================================
Files 1779 839 -940
Lines 37794 20420 -17374
Branches 4157 1914 -2243
=============================================
- Hits 20408 8545 -11863
+ Misses 16403 11224 -5179
+ Partials 983 651 -332
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `9.95% <0.00%> (-57.78%)` | `9.00 <0.00> (-63.00)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `5.08% <0.00%> (-33.44%)` | `1.00 <0.00> (-5.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `18.34% <4.44%> (-63.39%)` | `4.00 <1.00> (-14.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/meter/analyzer/dsl/Sample.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1383 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...00e1f4d](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (1757802) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `5.87%`.
> The diff coverage is `65.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.64% 47.76% -5.88%
+ Complexity 4056 2817 -1239
============================================
Files 1778 836 -942
Lines 37770 20620 -17150
Branches 4155 1948 -2207
============================================
- Hits 20260 9849 -10411
+ Misses 16536 10006 -6530
+ Partials 974 765 -209
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-10.44%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.55% <68.75%> (-11.17%)` | `70.00 <11.00> (-2.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1346 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **increase** coverage by `0.07%`.
> The diff coverage is `65.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
+ Coverage 52.61% 52.68% +0.07%
+ Complexity 3945 3825 -120
============================================
Files 1783 994 -789
Lines 38122 24686 -13436
Branches 4201 2406 -1795
============================================
- Hits 20056 13007 -7049
+ Misses 17087 10514 -6573
- Partials 979 1165 +186
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-0.56%)` | `22.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.97% <72.22%> (+0.33%)` | `56.00 <6.00> (-9.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1284 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `56.47%`.
> The diff coverage is `76.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 56.47% +56.47%
- Complexity 0 4001 +4001
=============================================
Files 195 991 +796
Lines 4675 24427 +19752
Branches 544 2375 +1831
=============================================
+ Hits 0 13796 +13796
- Misses 4675 9425 +4750
- Partials 0 1206 +1206
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `83.33% <79.54%> (ø)` | `24.00 <13.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `67.94% <79.62%> (ø)` | `63.00 <8.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | | | |
| [.../agent/core/context/util/ThrowableTransformer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1Rocm93YWJsZVRyYW5zZm9ybWVyLmphdmE=) | | | |
| [...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh) | | | |
| [...apache/skywalking/apm/toolkit/meter/BaseMeter.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQmFzZU1ldGVyLmphdmE=) | | | |
| ... and [1000 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (2fcb790) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **increase** coverage by `1.07%`.
> The diff coverage is `74.21%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
+ Coverage 56.58% 57.66% +1.07%
- Complexity 4034 4056 +22
============================================
Files 1005 990 -15
Lines 24760 24425 -335
Branches 2403 2372 -31
============================================
+ Hits 14010 14084 +74
+ Misses 9518 9120 -398
+ Partials 1232 1221 -11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `77.77% <77.77%> (ø)` | `4.00 <4.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `82.40% <79.54%> (-0.12%)` | `24.00 <13.00> (+6.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `68.08% <80.00%> (+0.50%)` | `63.00 <8.00> (-9.00)` | :arrow_up: |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | |
| [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `13.63% <0.00%> (-68.19%)` | `1.00% <0.00%> (-5.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| [...ap/server/core/storage/ttl/DataTTLKeeperTimer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS90dGwvRGF0YVRUTEtlZXBlclRpbWVyLmphdmE=) | `29.03% <0.00%> (-48.39%)` | `2.00% <0.00%> (-4.00%)` | |
| ... and [67 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `1.15%`.
> The diff coverage is `63.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 53.03% -1.16%
+ Complexity 4150 3784 -366
============================================
Files 1783 995 -788
Lines 38193 24701 -13492
Branches 4209 2408 -1801
============================================
- Hits 20695 13100 -7595
+ Misses 16511 10500 -6011
- Partials 987 1101 +114
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `72.47% <64.44%> (-8.30%)` | `23.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (-10.47%)` | `55.00 <6.00> (-17.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `77.77% <83.33%> (+2.77%)` | `8.00 <1.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1284 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (af503ce) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `0.88%`.
> The diff coverage is `72.65%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 55.70% -0.89%
+ Complexity 4034 3943 -91
============================================
Files 1005 991 -14
Lines 24760 24447 -313
Branches 2403 2371 -32
============================================
- Hits 14010 13617 -393
- Misses 9518 9672 +154
+ Partials 1232 1158 -74
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.95% <76.36%> (-1.63%)` | `62.00 <8.00> (-10.00)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `77.77% <77.77%> (ø)` | `4.00 <4.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.55% <79.54%> (-1.97%)` | `23.00 <12.00> (+5.00)` | :arrow_down: |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <0.00%> (-73.81%)` | `1.00% <0.00%> (-6.00%)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2AlarmQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQWxhcm1RdWVyeURBTy5qYXZh) | `6.97% <0.00%> (-72.10%)` | `1.00% <0.00%> (-4.00%)` | |
| ... and [81 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#discussion_r588252751
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -376,15 +374,63 @@ public SampleFamily endpoint(List<String> serviceKeys, List<String> endpointKeys
if (this == EMPTY) {
return EMPTY;
}
- this.context.setMeterEntity(MeterEntity.newEndpoint(dim(serviceKeys), dim(endpointKeys)));
- return left(io.vavr.collection.Stream.concat(serviceKeys, endpointKeys).asJava());
+ return createMeterSamples(serviceKeys, endpointKeys, ScopeType.ENDPOINT);
+ }
+
+ private SampleFamily createMeterSamples(List<String> serviceKeys, List<String> level2keys, ScopeType scopeType) {
+ final List<String> labelKeys = io.vavr.collection.Stream.concat(serviceKeys, level2keys).asJava();
+ Map<MeterEntity, Sample[]> meterSamples = new HashMap<>();
+ Arrays.stream(samples)
+ .collect(groupingBy(it -> getLabels(labelKeys, it), mapping(identity(), toList())))
+ .forEach((labels, samples) -> {
+ MeterEntity meterEntity = getMeterEntity(samples, serviceKeys, level2keys, scopeType);
+ Preconditions.checkNotNull(meterEntity);
+ meterSamples.put(meterEntity, left(labelKeys, samples));
+ });
+
+ this.context.setMeterSamples(meterSamples);
+ //This samples is original, The grouped samples is in context which mapping with MeterEntity
+ return SampleFamily.build(this.context, samples);
+ }
+
+ private MeterEntity getMeterEntity(List<Sample> samples,
+ List<String> serviceKeys,
+ List<String> level2keys,
+ ScopeType scopeType) {
+ switch (scopeType) {
+ case SERVICE:
+ return MeterEntity.newService(dim(serviceKeys, samples));
+ case SERVICE_INSTANCE:
+ return MeterEntity.newServiceInstance(dim(serviceKeys, samples), dim(level2keys, samples));
+ case ENDPOINT:
+ return MeterEntity.newEndpoint(dim(serviceKeys, samples), dim(level2keys, samples));
+ }
+ return null;
}
private String dim(List<String> labelKeys) {
- String name = labelKeys.stream().map(k -> samples[0].labels.getOrDefault(k, "")).collect(Collectors.joining("."));
+ String name = labelKeys.stream()
+ .map(k -> samples[0].labels.getOrDefault(k, ""))
+ .collect(Collectors.joining("."));
+ return CharMatcher.is('.').trimFrom(name);
+ }
+
+ private String dim(List<String> labelKeys, List<Sample> samples) {
+ String name = labelKeys.stream()
+ .map(k -> samples.get(0).labels.getOrDefault(k, ""))
+ .collect(Collectors.joining("."));
return CharMatcher.is('.').trimFrom(name);
}
+ private Sample[] left(List<String> labelKeys, List<Sample> samples) {
Review comment:
@hanahmily These `dim` and `left` seem internal APIs, and as it takes `List<Sample> samples` as object, we should change these 2 methods as static. Please confirm.
@wankai123 `List<Sample> samples` should be the 1st parameter as the target.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **decrease** coverage by `0.95%`.
> The diff coverage is `65.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 52.61% 51.65% -0.96%
+ Complexity 3945 3757 -188
============================================
Files 1783 994 -789
Lines 38122 24645 -13477
Branches 4201 2401 -1800
============================================
- Hits 20056 12730 -7326
+ Misses 17087 10781 -6306
- Partials 979 1134 +155
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-0.56%)` | `22.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.97% <72.22%> (+0.33%)` | `56.00 <6.00> (-9.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1274 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (2fcb790) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `0.12%`.
> The diff coverage is `74.21%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 56.45% -0.13%
+ Complexity 4034 3977 -57
============================================
Files 1005 990 -15
Lines 24760 24397 -363
Branches 2403 2367 -36
============================================
- Hits 14010 13774 -236
+ Misses 9518 9410 -108
+ Partials 1232 1213 -19
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `77.77% <77.77%> (ø)` | `4.00 <4.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `82.40% <79.54%> (-0.12%)` | `24.00 <13.00> (+6.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `68.08% <80.00%> (+0.50%)` | `63.00 <8.00> (-9.00)` | :arrow_up: |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...er/core/alarm/provider/CompositeRuleEvaluator.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Db21wb3NpdGVSdWxlRXZhbHVhdG9yLmphdmE=) | `9.52% <0.00%> (-73.81%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [76 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (1757802) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **increase** coverage by `0.60%`.
> The diff coverage is `75.72%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
+ Coverage 53.64% 54.24% +0.60%
+ Complexity 4056 3868 -188
============================================
Files 1778 988 -790
Lines 37770 24396 -13374
Branches 4155 2368 -1787
============================================
- Hits 20260 13233 -7027
+ Misses 16536 9978 -6558
- Partials 974 1185 +211
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...f/dynamic/watcher/IgnoreSuffixPatternsWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvSWdub3JlU3VmZml4UGF0dGVybnNXYXRjaGVyLmphdmE=) | `76.47% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...core/conf/dynamic/watcher/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `70.00% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <ø> (-41.03%)` | `9.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.34% <50.00%> (-15.22%)` | `25.00 <1.00> (ø)` | |
| [...nt/core/conf/dynamic/watcher/SpanLimitWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU3BhbkxpbWl0V2F0Y2hlci5qYXZh) | `66.66% <66.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.16% <75.00%> (-2.57%)` | `77.00 <11.00> (+5.00)` | :arrow_down: |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `82.40% <79.54%> (+0.67%)` | `24.00 <13.00> (+6.00)` | |
| [...gent/core/context/ContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==) | `74.19% <100.00%> (-15.47%)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1259 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **decrease** coverage by `15.07%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 55.09% 40.02% -15.08%
+ Complexity 3945 3007 -938
=============================================
Files 991 994 +3
Lines 24628 24445 -183
Branches 2402 2368 -34
=============================================
- Hits 13570 9785 -3785
- Misses 9878 13822 +3944
+ Partials 1180 838 -342
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `53.21% <31.11%> (-19.61%)` | `16.00 <9.00> (-1.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `38.88% <70.37%> (-19.56%)` | `32.00 <6.00> (-33.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [237 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (a6c716c) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `12.15%`.
> The diff coverage is `2.53%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 53.99% 41.84% -12.16%
+ Complexity 4079 2504 -1575
=============================================
Files 1779 839 -940
Lines 37794 20420 -17374
Branches 4157 1914 -2243
=============================================
- Hits 20408 8545 -11863
+ Misses 16403 11224 -5179
+ Partials 983 651 -332
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `9.95% <0.00%> (-57.78%)` | `9.00 <0.00> (-63.00)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `5.08% <0.00%> (-33.44%)` | `1.00 <0.00> (-5.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `18.34% <4.44%> (-63.39%)` | `4.00 <1.00> (-14.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ache/skywalking/oap/meter/analyzer/dsl/Sample.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1383 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `51.33%`.
> The diff coverage is `64.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 51.33% +51.33%
- Complexity 0 3665 +3665
=============================================
Files 195 991 +796
Lines 4675 24291 +19616
Branches 544 2361 +1817
=============================================
+ Hits 0 12469 +12469
- Misses 4675 10747 +6072
- Partials 0 1075 +1075
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `72.22% <63.63%> (ø)` | `22.00 <13.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.97% <72.22%> (ø)` | `56.00 <6.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...pache/skywalking/apm/agent/core/meter/MeterId.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJJZC5qYXZh) | | | |
| [...che/skywalking/apm/toolkit/meter/MeterFactory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvTWV0ZXJGYWN0b3J5LmphdmE=) | | | |
| [...che/skywalking/apm/agent/core/meter/Histogram.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvSGlzdG9ncmFtLmphdmE=) | | | |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | | | |
| ... and [1000 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (2fcb790) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `15.98%`.
> The diff coverage is `60.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 56.58% 40.60% -15.99%
+ Complexity 4034 2461 -1573
=============================================
Files 1005 839 -166
Lines 24760 20627 -4133
Branches 2403 1950 -453
=============================================
- Hits 14010 8375 -5635
- Misses 9518 11621 +2103
+ Partials 1232 631 -601
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-11.23%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.14% <72.72%> (-8.44%)` | `56.00 <6.00> (-16.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [391 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (262a4a5) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `8.60%`.
> The diff coverage is `73.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 45.57% -8.61%
+ Complexity 4150 3276 -874
============================================
Files 1783 963 -820
Lines 38193 23779 -14414
Branches 4209 2317 -1892
============================================
- Hits 20695 10838 -9857
+ Misses 16511 12027 -4484
+ Partials 987 914 -73
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.81% <75.92%> (-1.92%)` | `62.00 <8.00> (-10.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.73% <80.00%> (-0.04%)` | `23.00 <12.00> (+5.00)` | :arrow_down: |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `77.77% <83.33%> (+2.77%)` | `8.00 <1.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1343 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (d73396a) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `8.46%`.
> The diff coverage is `69.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.99% 45.53% -8.47%
+ Complexity 4079 3210 -869
============================================
Files 1779 960 -819
Lines 37794 23498 -14296
Branches 4157 2281 -1876
============================================
- Hits 20408 10700 -9708
+ Misses 16403 11894 -4509
+ Partials 983 904 -79
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `77.14% <0.00%> (-14.04%)` | `10.00 <0.00> (-1.00)` | |
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.13% <0.00%> (-0.39%)` | `6.00 <0.00> (ø)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.81% <75.92%> (-1.92%)` | `62.00 <8.00> (-10.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.73% <80.00%> (-1.00%)` | `23.00 <12.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1334 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (262a4a5) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `9.37%`.
> The diff coverage is `73.68%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 44.80% -9.38%
+ Complexity 4150 3342 -808
============================================
Files 1783 994 -789
Lines 38193 24682 -13511
Branches 4209 2405 -1804
============================================
- Hits 20695 11059 -9636
+ Misses 16511 12701 -3810
+ Partials 987 922 -65
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.81% <75.92%> (-1.92%)` | `62.00 <8.00> (-10.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.73% <80.00%> (-0.04%)` | `23.00 <12.00> (+5.00)` | :arrow_down: |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `77.77% <83.33%> (+2.77%)` | `8.00 <1.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1321 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **increase** coverage by `1.90%`.
> The diff coverage is `65.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
+ Coverage 52.61% 54.51% +1.90%
+ Complexity 3945 3897 -48
============================================
Files 1783 994 -789
Lines 38122 24703 -13419
Branches 4201 2407 -1794
============================================
- Hits 20056 13468 -6588
+ Misses 17087 10023 -7064
- Partials 979 1212 +233
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `73.39% <64.44%> (+1.27%)` | `23.00 <13.00> (+6.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.97% <72.22%> (+0.33%)` | `56.00 <6.00> (-9.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1279 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b240c3b) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `8.06%`.
> The diff coverage is `53.39%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.64% 45.57% -8.07%
+ Complexity 4056 3264 -792
============================================
Files 1778 987 -791
Lines 37770 24078 -13692
Branches 4155 2320 -1835
============================================
- Hits 20260 10973 -9287
+ Misses 16536 12179 -4357
+ Partials 974 926 -48
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...f/dynamic/watcher/IgnoreSuffixPatternsWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvSWdub3JlU3VmZml4UGF0dGVybnNXYXRjaGVyLmphdmE=) | `76.47% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...core/conf/dynamic/watcher/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `70.00% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <ø> (-41.03%)` | `9.00 <0.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `53.70% <31.81%> (-28.03%)` | `16.00 <8.00> (-2.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.34% <50.00%> (-15.22%)` | `25.00 <1.00> (ø)` | |
| [...nt/core/conf/dynamic/watcher/SpanLimitWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU3BhbkxpbWl0V2F0Y2hlci5qYXZh) | `66.66% <66.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `24.59% <68.75%> (-43.14%)` | `30.00 <11.00> (-42.00)` | |
| [...gent/core/context/ContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==) | `74.19% <100.00%> (-15.47%)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1317 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ad6c827) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `34.83%`.
> The diff coverage is `62.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 34.83% +34.83%
- Complexity 0 2176 +2176
=============================================
Files 197 838 +641
Lines 4686 20521 +15835
Branches 544 1941 +1397
=============================================
+ Hits 0 7149 +7149
- Misses 4686 12831 +8145
- Partials 0 541 +541
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.44% <63.63%> (ø)` | `21.00 <12.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (ø)` | `55.00 <6.00> (?)` | |
| [...king/apm/agent/core/jvm/thread/ThreadProvider.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL3RocmVhZC9UaHJlYWRQcm92aWRlci5qYXZh) | | | |
| [.../apm/agent/core/boot/ServiceConflictException.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9TZXJ2aWNlQ29uZmxpY3RFeGNlcHRpb24uamF2YQ==) | | | |
| [.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=) | | | |
| [...ore/plugin/bootstrap/BootstrapInstrumentBoost.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBJbnN0cnVtZW50Qm9vc3QuamF2YQ==) | | | |
| [...ache/skywalking/apm/agent/core/meter/MeterTag.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUYWcuamF2YQ==) | | | |
| ... and [1006 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#discussion_r589189392
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/Analyzer.java
##########
@@ -110,52 +116,56 @@ public void analyse(final ImmutableMap<String, SampleFamily> sampleFamilies) {
return;
}
SampleFamily.RunningContext ctx = r.getData().context;
- Sample[] ss = r.getData().samples;
- generateTraffic(ctx.getMeterEntity());
- switch (metricType) {
- case single:
- AcceptableValue<Long> sv = meterSystem.buildMetrics(metricName, Long.class);
- sv.accept(ctx.getMeterEntity(), getValue(ss[0]));
- send(sv, ss[0].getTimestamp());
- break;
- case labeled:
- AcceptableValue<DataTable> lv = meterSystem.buildMetrics(metricName, DataTable.class);
- DataTable dt = new DataTable();
- for (Sample each : ss) {
- dt.put(composeGroup(each.getLabels()), getValue(each));
- }
- lv.accept(ctx.getMeterEntity(), dt);
- send(lv, ss[0].getTimestamp());
- break;
- case histogram:
- case histogramPercentile:
- Stream.of(ss).map(s -> Tuple.of(composeGroup(s.getLabels(), k -> !Objects.equals("le", k)), s))
- .collect(groupingBy(Tuple2::_1, mapping(Tuple2::_2, toList())))
- .forEach((group, subSs) -> {
- if (subSs.size() < 1) {
- return;
- }
- long[] bb = new long[subSs.size()];
- long[] vv = new long[bb.length];
- for (int i = 0; i < subSs.size(); i++) {
- Sample s = subSs.get(i);
- bb[i] = Long.parseLong(s.getLabels().get("le"));
- vv[i] = getValue(s);
- }
- BucketedValues bv = new BucketedValues(bb, vv);
- long time = subSs.get(0).getTimestamp();
- if (metricType == MetricType.histogram) {
- AcceptableValue<BucketedValues> v = meterSystem.buildMetrics(metricName, BucketedValues.class);
- v.accept(ctx.getMeterEntity(), bv);
+ Map<MeterEntity, Sample[]> meterSamples = ctx.getMeterSamples();
+ meterSamples.forEach((meterEntity, ss) -> {
+ generateTraffic(meterEntity);
+ switch (metricType) {
+ case single:
+ AcceptableValue<Long> sv = meterSystem.buildMetrics(metricName, Long.class);
+ sv.accept(meterEntity, getValue(ss[0]));
+ send(sv, ss[0].getTimestamp());
+ break;
+ case labeled:
+ AcceptableValue<DataTable> lv = meterSystem.buildMetrics(metricName, DataTable.class);
+ DataTable dt = new DataTable();
+ for (Sample each : ss) {
+ dt.put(composeGroup(each.getLabels()), getValue(each));
+ }
+ lv.accept(meterEntity, dt);
+ send(lv, ss[0].getTimestamp());
+ break;
+ case histogram:
+ case histogramPercentile:
+ Stream.of(ss).map(s -> Tuple.of(composeGroup(s.getLabels(), k -> !Objects.equals("le", k)), s))
+ .collect(groupingBy(Tuple2::_1, mapping(Tuple2::_2, toList())))
+ .forEach((group, subSs) -> {
Review comment:
`group` should be set into `BucketedValues` in order to support the label system for histogram and percentile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (d73396a) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `2.27%`.
> The diff coverage is `69.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.99% 51.72% -2.28%
+ Complexity 4079 3682 -397
============================================
Files 1779 990 -789
Lines 37794 24358 -13436
Branches 4157 2365 -1792
============================================
- Hits 20408 12599 -7809
+ Misses 16403 10715 -5688
- Partials 983 1044 +61
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `77.14% <0.00%> (-14.04%)` | `10.00 <0.00> (-1.00)` | |
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.13% <0.00%> (-0.39%)` | `6.00 <0.00> (ø)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.81% <75.92%> (-1.92%)` | `62.00 <8.00> (-10.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.73% <80.00%> (-1.00%)` | `23.00 <12.00> (+5.00)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1282 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `55.68%`.
> The diff coverage is `76.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 55.68% +55.68%
- Complexity 0 3966 +3966
=============================================
Files 195 991 +796
Lines 4675 24416 +19741
Branches 544 2370 +1826
=============================================
+ Hits 0 13596 +13596
- Misses 4675 9629 +4954
- Partials 0 1191 +1191
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `83.33% <79.54%> (ø)` | `24.00 <13.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `67.52% <79.62%> (ø)` | `63.00 <8.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | | | |
| [...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=) | | | |
| [...che/skywalking/apm/agent/core/meter/Histogram.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvSGlzdG9ncmFtLmphdmE=) | | | |
| [...che/skywalking/apm/agent/core/meter/BaseMeter.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQmFzZU1ldGVyLmphdmE=) | | | |
| ... and [1000 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (d73396a) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **increase** coverage by `1.84%`.
> The diff coverage is `72.56%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
+ Coverage 53.99% 55.84% +1.84%
+ Complexity 4079 3970 -109
============================================
Files 1779 991 -788
Lines 37794 24441 -13353
Branches 4157 2371 -1786
============================================
- Hits 20408 13649 -6759
+ Misses 16403 9619 -6784
- Partials 983 1173 +190
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `39.83% <0.00%> (+1.30%)` | `6.00 <0.00> (ø)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `67.52% <79.62%> (-0.21%)` | `63.00 <8.00> (-9.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `82.56% <80.00%> (+0.83%)` | `23.00 <12.00> (+5.00)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `91.42% <100.00%> (+0.25%)` | `12.00 <0.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1247 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b240c3b) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `4.68%`.
> The diff coverage is `66.99%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.64% 48.95% -4.69%
+ Complexity 4056 3521 -535
============================================
Files 1778 988 -790
Lines 37770 24254 -13516
Branches 4155 2354 -1801
============================================
- Hits 20260 11873 -8387
+ Misses 16536 11363 -5173
- Partials 974 1018 +44
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...f/dynamic/watcher/IgnoreSuffixPatternsWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvSWdub3JlU3VmZml4UGF0dGVybnNXYXRjaGVyLmphdmE=) | `76.47% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...core/conf/dynamic/watcher/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `70.00% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <ø> (-41.03%)` | `9.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.34% <50.00%> (-15.22%)` | `25.00 <1.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-10.44%)` | `22.00 <12.00> (+4.00)` | :arrow_down: |
| [...nt/core/conf/dynamic/watcher/SpanLimitWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU3BhbkxpbWl0V2F0Y2hlci5qYXZh) | `66.66% <66.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `54.91% <68.75%> (-12.81%)` | `67.00 <11.00> (-5.00)` | |
| [...gent/core/context/ContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==) | `74.19% <100.00%> (-15.47%)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1297 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (5a5db0e) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `22.91%`.
> The diff coverage is `58.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 56.58% 33.66% -22.92%
+ Complexity 4034 2059 -1975
=============================================
Files 1005 808 -197
Lines 24760 19695 -5065
Branches 2403 1859 -544
=============================================
- Hits 14010 6631 -7379
- Misses 9518 12558 +3040
+ Partials 1232 506 -726
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.44% <63.63%> (-13.08%)` | `21.00 <12.00> (+3.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.44% <69.09%> (-10.14%)` | `55.00 <6.00> (-17.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [517 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (7ccff4e) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `5.44%`.
> The diff coverage is `62.16%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 51.13% -5.45%
+ Complexity 4034 3675 -359
============================================
Files 1005 1782 +777
Lines 24760 37749 +12989
Branches 2403 4150 +1747
============================================
+ Hits 14010 19303 +5293
- Misses 9518 17465 +7947
+ Partials 1232 981 -251
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `37.19% <0.00%> (-2.31%)` | `6.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `73.39% <63.63%> (-9.13%)` | `23.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.57% <74.07%> (-8.01%)` | `56.00 <6.00> (-16.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1286 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...fbb4bcf](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `11.73%`.
> The diff coverage is `41.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 54.18% 42.44% -11.74%
+ Complexity 4150 3125 -1025
=============================================
Files 1783 995 -788
Lines 38193 24514 -13679
Branches 4209 2372 -1837
=============================================
- Hits 20695 10406 -10289
+ Misses 16511 13247 -3264
+ Partials 987 861 -126
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `53.21% <31.11%> (-27.56%)` | `16.00 <8.00> (-2.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `25.64% <50.00%> (-42.09%)` | `20.00 <3.00> (-52.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `62.96% <83.33%> (-12.04%)` | `6.00 <1.00> (-2.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1336 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `56.47%`.
> The diff coverage is `76.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 56.47% +56.47%
- Complexity 0 4001 +4001
=============================================
Files 195 991 +796
Lines 4675 24427 +19752
Branches 544 2375 +1831
=============================================
+ Hits 0 13796 +13796
- Misses 4675 9425 +4750
- Partials 0 1206 +1206
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `83.33% <79.54%> (ø)` | `24.00 <13.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `67.94% <79.62%> (ø)` | `63.00 <8.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | | | |
| [...g/apache/skywalking/apm/toolkit/meter/Counter.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQ291bnRlci5qYXZh) | | | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | | | |
| [.../apache/skywalking/apm/agent/core/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvR2F1Z2UuamF2YQ==) | | | |
| ... and [1000 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (7ccff4e) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `9.93%`.
> The diff coverage is `61.26%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 46.64% -9.94%
+ Complexity 4034 3394 -640
============================================
Files 1005 991 -14
Lines 24760 24256 -504
Branches 2403 2356 -47
============================================
- Hits 14010 11315 -2695
- Misses 9518 11948 +2430
+ Partials 1232 993 -239
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `5.08% <0.00%> (-34.42%)` | `1.00 <0.00> (-5.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-11.23%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.97% <72.22%> (-8.61%)` | `56.00 <6.00> (-16.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [207 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...fbb4bcf](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on a change in pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
wankai123 commented on a change in pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#discussion_r589133884
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -376,15 +374,63 @@ public SampleFamily endpoint(List<String> serviceKeys, List<String> endpointKeys
if (this == EMPTY) {
return EMPTY;
}
- this.context.setMeterEntity(MeterEntity.newEndpoint(dim(serviceKeys), dim(endpointKeys)));
- return left(io.vavr.collection.Stream.concat(serviceKeys, endpointKeys).asJava());
+ return createMeterSamples(serviceKeys, endpointKeys, ScopeType.ENDPOINT);
+ }
+
+ private SampleFamily createMeterSamples(List<String> serviceKeys, List<String> level2keys, ScopeType scopeType) {
+ final List<String> labelKeys = io.vavr.collection.Stream.concat(serviceKeys, level2keys).asJava();
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (1757802) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `6.62%`.
> The diff coverage is `65.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.64% 47.01% -6.63%
+ Complexity 4056 2790 -1266
============================================
Files 1778 836 -942
Lines 37770 20620 -17150
Branches 4155 1948 -2207
============================================
- Hits 20260 9695 -10565
+ Misses 16536 10185 -6351
+ Partials 974 740 -234
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-10.44%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.55% <68.75%> (-11.17%)` | `70.00 <11.00> (-2.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1349 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (d73396a) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `0.51%`.
> The diff coverage is `70.79%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.99% 53.48% -0.52%
+ Complexity 4079 3797 -282
============================================
Files 1779 991 -788
Lines 37794 24403 -13391
Branches 4157 2369 -1788
============================================
- Hits 20408 13052 -7356
+ Misses 16403 10257 -6146
- Partials 983 1094 +111
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `39.83% <0.00%> (+1.30%)` | `6.00 <0.00> (ø)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.81% <75.92%> (-1.92%)` | `62.00 <8.00> (-10.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.73% <80.00%> (-1.00%)` | `23.00 <12.00> (+5.00)` | :arrow_down: |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `91.42% <100.00%> (+0.25%)` | `12.00 <0.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1271 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on a change in pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
wankai123 commented on a change in pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#discussion_r589134323
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -376,15 +374,63 @@ public SampleFamily endpoint(List<String> serviceKeys, List<String> endpointKeys
if (this == EMPTY) {
return EMPTY;
}
- this.context.setMeterEntity(MeterEntity.newEndpoint(dim(serviceKeys), dim(endpointKeys)));
- return left(io.vavr.collection.Stream.concat(serviceKeys, endpointKeys).asJava());
+ return createMeterSamples(serviceKeys, endpointKeys, ScopeType.ENDPOINT);
+ }
+
+ private SampleFamily createMeterSamples(List<String> serviceKeys, List<String> level2keys, ScopeType scopeType) {
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b240c3b) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `5.30%`.
> The diff coverage is `66.99%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.64% 48.33% -5.31%
+ Complexity 4056 3479 -577
============================================
Files 1778 988 -790
Lines 37770 24254 -13516
Branches 4155 2354 -1801
============================================
- Hits 20260 11724 -8536
+ Misses 16536 11516 -5020
- Partials 974 1014 +40
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...f/dynamic/watcher/IgnoreSuffixPatternsWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvSWdub3JlU3VmZml4UGF0dGVybnNXYXRjaGVyLmphdmE=) | `76.47% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...core/conf/dynamic/watcher/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `70.00% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <ø> (-41.03%)` | `9.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.34% <50.00%> (-15.22%)` | `25.00 <1.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-10.44%)` | `22.00 <12.00> (+4.00)` | :arrow_down: |
| [...nt/core/conf/dynamic/watcher/SpanLimitWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU3BhbkxpbWl0V2F0Y2hlci5qYXZh) | `66.66% <66.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `54.91% <68.75%> (-12.81%)` | `67.00 <11.00> (-5.00)` | |
| [...gent/core/context/ContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==) | `74.19% <100.00%> (-15.47%)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1300 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `46.51%`.
> The diff coverage is `62.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 46.51% +46.51%
- Complexity 0 3371 +3371
=============================================
Files 195 991 +796
Lines 4675 24213 +19538
Branches 544 2355 +1811
=============================================
+ Hits 0 11262 +11262
- Misses 4675 11980 +7305
- Partials 0 971 +971
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.44% <63.63%> (ø)` | `21.00 <12.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (ø)` | `55.00 <6.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | | | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | | | |
| [.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==) | | | |
| [...ache/skywalking/apm/agent/core/meter/MeterTag.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUYWcuamF2YQ==) | | | |
| ... and [1000 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ad6c827) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `34.55%`.
> The diff coverage is `62.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 34.55% +34.55%
- Complexity 0 2163 +2163
=============================================
Files 197 838 +641
Lines 4686 20521 +15835
Branches 544 1941 +1397
=============================================
+ Hits 0 7091 +7091
- Misses 4686 12889 +8203
- Partials 0 541 +541
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.44% <63.63%> (ø)` | `21.00 <12.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (ø)` | `55.00 <6.00> (?)` | |
| [...apache/skywalking/apm/toolkit/meter/Histogram.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvSGlzdG9ncmFtLmphdmE=) | | | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | | | |
| [...core/conf/dynamic/watcher/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | | | |
| [.../apache/skywalking/apm/agent/core/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvR2F1Z2UuamF2YQ==) | | | |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | | | |
| ... and [1006 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (fbb4bcf) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `3.77%`.
> The diff coverage is `74.28%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.99% 50.22% -3.78%
+ Complexity 4079 3673 -406
============================================
Files 1779 991 -788
Lines 37794 24387 -13407
Branches 4157 2369 -1788
============================================
- Hits 20408 12248 -8160
+ Misses 16403 11087 -5316
- Partials 983 1052 +69
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.81% <75.92%> (-1.92%)` | `62.00 <8.00> (-10.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.48% <79.54%> (-0.25%)` | `24.00 <13.00> (+6.00)` | :arrow_down: |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1267 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3b206ef) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `17.27%`.
> The diff coverage is `59.82%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 53.99% 36.72% -17.28%
+ Complexity 4079 2161 -1918
=============================================
Files 1779 809 -970
Lines 37794 19723 -18071
Branches 4157 1868 -2289
=============================================
- Hits 20408 7243 -13165
+ Misses 16403 11934 -4469
+ Partials 983 546 -437
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.13% <0.00%> (-0.39%)` | `6.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.72% <64.44%> (-12.01%)` | `21.00 <12.00> (+3.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.69% <68.51%> (-10.04%)` | `55.00 <6.00> (-17.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1429 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (d73396a) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `10.69%`.
> The diff coverage is `69.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 53.99% 43.30% -10.70%
+ Complexity 4079 3088 -991
=============================================
Files 1779 960 -819
Lines 37794 23434 -14360
Branches 4157 2275 -1882
=============================================
- Hits 20408 10148 -10260
+ Misses 16403 12428 -3975
+ Partials 983 858 -125
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `77.14% <0.00%> (-14.04%)` | `10.00 <0.00> (-1.00)` | |
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.13% <0.00%> (-0.39%)` | `6.00 <0.00> (ø)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.81% <75.92%> (-1.92%)` | `62.00 <8.00> (-10.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.73% <80.00%> (-1.00%)` | `23.00 <12.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1343 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3b206ef) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `7.27%`.
> The diff coverage is `59.82%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.99% 46.72% -7.28%
+ Complexity 4079 2781 -1298
============================================
Files 1779 839 -940
Lines 37794 20637 -17157
Branches 4157 1954 -2203
============================================
- Hits 20408 9642 -10766
+ Misses 16403 10241 -6162
+ Partials 983 754 -229
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.13% <0.00%> (-0.39%)` | `6.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-10.18%)` | `22.00 <12.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.69% <68.51%> (-10.04%)` | `55.00 <6.00> (-17.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1357 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **increase** coverage by `3.15%`.
> The diff coverage is `65.09%`.
> :exclamation: Current head 3dd7696 differs from pull request most recent head b92c02b. Consider uploading reports for the commit b92c02b to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
+ Coverage 52.61% 55.76% +3.15%
- Complexity 3945 3953 +8
============================================
Files 1783 994 -789
Lines 38122 24704 -13418
Branches 4201 2411 -1790
============================================
- Hits 20056 13777 -6279
+ Misses 17087 9703 -7384
- Partials 979 1224 +245
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `73.39% <64.44%> (+1.27%)` | `23.00 <13.00> (+6.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.40% <72.22%> (+0.76%)` | `56.00 <6.00> (-9.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1276 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `53.61%`.
> The diff coverage is `76.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 53.61% +53.61%
- Complexity 0 3808 +3808
=============================================
Files 195 991 +796
Lines 4675 24398 +19723
Branches 544 2369 +1825
=============================================
+ Hits 0 13081 +13081
- Misses 4675 10190 +5515
- Partials 0 1127 +1127
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `83.33% <79.54%> (ø)` | `24.00 <13.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `67.52% <79.62%> (ø)` | `63.00 <8.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | | | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | | | |
| [...t/core/plugin/bytebuddy/ArgumentTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bcmd1bWVudFR5cGVOYW1lTWF0Y2guamF2YQ==) | | | |
| [...pache/skywalking/apm/agent/core/meter/Counter.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlci5qYXZh) | | | |
| ... and [1000 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (7ccff4e) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `5.65%`.
> The diff coverage is `62.16%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 50.92% -5.66%
+ Complexity 4034 3654 -380
============================================
Files 1005 1782 +777
Lines 24760 37749 +12989
Branches 2403 4150 +1747
============================================
+ Hits 14010 19224 +5214
- Misses 9518 17542 +8024
+ Partials 1232 983 -249
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `37.19% <0.00%> (-2.31%)` | `6.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `72.47% <63.63%> (-10.05%)` | `23.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.57% <74.07%> (-8.01%)` | `56.00 <6.00> (-16.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1285 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...fbb4bcf](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (fbb4bcf) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `10.28%`.
> The diff coverage is `74.28%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 56.58% 46.29% -10.29%
+ Complexity 4034 2825 -1209
=============================================
Files 1005 839 -166
Lines 24760 20731 -4029
Branches 2403 1962 -441
=============================================
- Hits 14010 9598 -4412
- Misses 9518 10384 +866
+ Partials 1232 749 -483
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.81% <75.92%> (-1.77%)` | `62.00 <8.00> (-10.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.48% <79.54%> (-1.05%)` | `24.00 <13.00> (+6.00)` | :arrow_down: |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...n/jdbc/postgresql/dao/PostgreSQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvcG9zdGdyZXNxbC9kYW8vUG9zdGdyZVNRTFRyYWNlUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [309 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...fbb4bcf](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (7ccff4e) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `9.95%`.
> The diff coverage is `61.26%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 46.62% -9.96%
+ Complexity 4034 3392 -642
============================================
Files 1005 991 -14
Lines 24760 24256 -504
Branches 2403 2356 -47
============================================
- Hits 14010 11310 -2700
- Misses 9518 11952 +2434
+ Partials 1232 994 -238
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `5.08% <0.00%> (-34.42%)` | `1.00 <0.00> (-5.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-11.23%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.97% <72.22%> (-8.61%)` | `56.00 <6.00> (-16.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [209 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...fbb4bcf](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (fbb4bcf) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `8.86%`.
> The diff coverage is `74.28%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 47.71% -8.87%
+ Complexity 4034 2891 -1143
============================================
Files 1005 839 -166
Lines 24760 20747 -4013
Branches 2403 1962 -441
============================================
- Hits 14010 9900 -4110
- Misses 9518 10091 +573
+ Partials 1232 756 -476
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.81% <75.92%> (-1.77%)` | `62.00 <8.00> (-10.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.48% <79.54%> (-1.05%)` | `24.00 <13.00> (+6.00)` | :arrow_down: |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...n/jdbc/postgresql/dao/PostgreSQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvcG9zdGdyZXNxbC9kYW8vUG9zdGdyZVNRTFRyYWNlUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0.00% <0.00%> (-98.86%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [279 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...fbb4bcf](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (d73396a) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **increase** coverage by `1.06%`.
> The diff coverage is `70.79%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
+ Coverage 53.99% 55.05% +1.06%
+ Complexity 4079 3923 -156
============================================
Files 1779 991 -788
Lines 37794 24405 -13389
Branches 4157 2369 -1788
============================================
- Hits 20408 13437 -6971
+ Misses 16403 9827 -6576
- Partials 983 1141 +158
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `39.83% <0.00%> (+1.30%)` | `6.00 <0.00> (ø)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.81% <75.92%> (-1.92%)` | `62.00 <8.00> (-10.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.73% <80.00%> (-1.00%)` | `23.00 <12.00> (+5.00)` | :arrow_down: |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `91.42% <100.00%> (+0.25%)` | `12.00 <0.00> (+1.00)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1249 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **decrease** coverage by `3.50%`.
> The diff coverage is `65.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 52.61% 49.10% -3.51%
+ Complexity 3945 3634 -311
============================================
Files 1783 994 -789
Lines 38122 24626 -13496
Branches 4201 2401 -1800
============================================
- Hits 20056 12093 -7963
+ Misses 17087 11471 -5616
- Partials 979 1062 +83
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-0.56%)` | `22.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.97% <72.22%> (+0.33%)` | `56.00 <6.00> (-9.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1283 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3b206ef) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `5.73%`.
> The diff coverage is `59.82%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.99% 48.26% -5.74%
+ Complexity 4079 2867 -1212
============================================
Files 1779 839 -940
Lines 37794 20637 -17157
Branches 4157 1954 -2203
============================================
- Hits 20408 9960 -10448
+ Misses 16403 9897 -6506
+ Partials 983 780 -203
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.13% <0.00%> (-0.39%)` | `6.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-10.18%)` | `22.00 <12.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.69% <68.51%> (-10.04%)` | `55.00 <6.00> (-17.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1347 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (8189591) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `10.03%`.
> The diff coverage is `59.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 53.99% 43.96% -10.04%
+ Complexity 4079 3152 -927
=============================================
Files 1779 961 -818
Lines 37794 23377 -14417
Branches 4157 2271 -1886
=============================================
- Hits 20408 10278 -10130
+ Misses 16403 12189 -4214
+ Partials 983 910 -73
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `80.00% <0.00%> (-11.18%)` | `11.00 <0.00> (ø)` | |
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `39.83% <0.00%> (+1.30%)` | `6.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-10.18%)` | `22.00 <12.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (-10.47%)` | `55.00 <6.00> (-17.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1335 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...00e1f4d](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **increase** coverage by `1.17%`.
> The diff coverage is `65.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
+ Coverage 52.61% 53.78% +1.17%
+ Complexity 3945 3870 -75
============================================
Files 1783 994 -789
Lines 38122 24703 -13419
Branches 4201 2407 -1794
============================================
- Hits 20056 13287 -6769
+ Misses 17087 10222 -6865
- Partials 979 1194 +215
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `73.39% <64.44%> (+1.27%)` | `23.00 <13.00> (+6.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.97% <72.22%> (+0.33%)` | `56.00 <6.00> (-9.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1282 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **increase** coverage by `0.79%`.
> The diff coverage is `66.98%`.
> :exclamation: Current head 3dd7696 differs from pull request most recent head b92c02b. Consider uploading reports for the commit b92c02b to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
+ Coverage 52.61% 53.40% +0.79%
- Complexity 3945 3996 +51
============================================
Files 1783 1786 +3
Lines 38122 38152 +30
Branches 4201 4203 +2
============================================
+ Hits 20056 20375 +319
+ Misses 17087 16790 -297
- Partials 979 987 +8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `74.54% <66.66%> (+2.43%)` | `23.00 <13.00> (+6.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `60.00% <74.07%> (+1.36%)` | `56.00 <6.00> (-9.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-81.49%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| ... and [65 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `49.22%`.
> The diff coverage is `64.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 49.22% +49.22%
- Complexity 0 3554 +3554
=============================================
Files 195 991 +796
Lines 4675 24272 +19597
Branches 544 2361 +1817
=============================================
+ Hits 0 11947 +11947
- Misses 4675 11299 +6624
- Partials 0 1026 +1026
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `72.22% <63.63%> (ø)` | `22.00 <13.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.97% <72.22%> (ø)` | `56.00 <6.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...che/skywalking/apm/agent/core/meter/BaseMeter.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQmFzZU1ldGVyLmphdmE=) | | | |
| [...che/skywalking/apm/agent/core/meter/Histogram.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvSGlzdG9ncmFtLmphdmE=) | | | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | | | |
| [...ache/skywalking/apm/agent/core/meter/MeterTag.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUYWcuamF2YQ==) | | | |
| ... and [1000 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `4.23%`.
> The diff coverage is `63.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 49.95% -4.24%
+ Complexity 4150 3611 -539
============================================
Files 1783 995 -788
Lines 38193 24660 -13533
Branches 4209 2403 -1806
============================================
- Hits 20695 12318 -8377
+ Misses 16511 11304 -5207
- Partials 987 1038 +51
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-9.21%)` | `22.00 <12.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (-10.47%)` | `55.00 <6.00> (-17.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `77.77% <83.33%> (+2.77%)` | `8.00 <1.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1299 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (5a5db0e) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `11.83%`.
> The diff coverage is `60.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 56.58% 44.75% -11.84%
+ Complexity 4034 3328 -706
=============================================
Files 1005 991 -14
Lines 24760 24270 -490
Branches 2403 2358 -45
=============================================
- Hits 14010 10861 -3149
- Misses 9518 12465 +2947
+ Partials 1232 944 -288
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-11.23%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.14% <72.72%> (-8.44%)` | `56.00 <6.00> (-16.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [237 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `2.18%`.
> The diff coverage is `63.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 51.99% -2.19%
+ Complexity 4150 3721 -429
============================================
Files 1783 995 -788
Lines 38193 24660 -13533
Branches 4209 2403 -1806
============================================
- Hits 20695 12823 -7872
+ Misses 16511 10764 -5747
- Partials 987 1073 +86
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-9.21%)` | `22.00 <12.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (-10.47%)` | `55.00 <6.00> (-17.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `77.77% <83.33%> (+2.77%)` | `8.00 <1.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1289 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3b206ef) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `11.77%`.
> The diff coverage is `59.82%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 53.99% 42.21% -11.78%
+ Complexity 4079 2512 -1567
=============================================
Files 1779 839 -940
Lines 37794 20619 -17175
Branches 4157 1953 -2204
=============================================
- Hits 20408 8705 -11703
+ Misses 16403 11273 -5130
+ Partials 983 641 -342
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.13% <0.00%> (-0.39%)` | `6.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-10.18%)` | `22.00 <12.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.69% <68.51%> (-10.04%)` | `55.00 <6.00> (-17.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1382 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (7ccff4e) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `5.41%`.
> The diff coverage is `62.16%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 51.16% -5.42%
+ Complexity 4034 3681 -353
============================================
Files 1005 1782 +777
Lines 24760 37749 +12989
Branches 2403 4150 +1747
============================================
+ Hits 14010 19315 +5305
- Misses 9518 17454 +7936
+ Partials 1232 980 -252
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `37.19% <0.00%> (-2.31%)` | `6.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `73.39% <63.63%> (-9.13%)` | `23.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.57% <74.07%> (-8.01%)` | `56.00 <6.00> (-16.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1286 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...fbb4bcf](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `49.32%`.
> The diff coverage is `64.76%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 49.32% +49.32%
- Complexity 0 3564 +3564
=============================================
Files 195 991 +796
Lines 4675 24272 +19597
Branches 544 2361 +1817
=============================================
+ Hits 0 11972 +11972
- Misses 4675 11275 +6600
- Partials 0 1025 +1025
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `72.22% <63.63%> (ø)` | `22.00 <13.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.97% <72.22%> (ø)` | `56.00 <6.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...ache/skywalking/apm/toolkit/meter/BaseBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQmFzZUJ1aWxkZXIuamF2YQ==) | | | |
| [...che/skywalking/apm/agent/core/meter/BaseMeter.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQmFzZU1ldGVyLmphdmE=) | | | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | | | |
| [...ache/skywalking/apm/agent/core/meter/MeterTag.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUYWcuamF2YQ==) | | | |
| ... and [1000 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (5a5db0e) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `11.16%`.
> The diff coverage is `60.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 56.58% 45.41% -11.17%
+ Complexity 4034 3267 -767
=============================================
Files 1005 961 -44
Lines 24760 23453 -1307
Branches 2403 2278 -125
=============================================
- Hits 14010 10651 -3359
- Misses 9518 11868 +2350
+ Partials 1232 934 -298
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-11.23%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.14% <72.72%> (-8.44%)` | `56.00 <6.00> (-16.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [262 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (1757802) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `10.15%`.
> The diff coverage is `65.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 53.64% 43.48% -10.16%
+ Complexity 4056 2645 -1411
=============================================
Files 1778 836 -942
Lines 37770 20584 -17186
Branches 4155 1946 -2209
=============================================
- Hits 20260 8951 -11309
+ Misses 16536 10973 -5563
+ Partials 974 660 -314
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.44% <63.63%> (-12.29%)` | `21.00 <12.00> (+3.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `54.91% <68.75%> (-12.81%)` | `67.00 <11.00> (-5.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1360 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (5a5db0e) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `25.11%`.
> The diff coverage is `58.59%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 56.58% 31.46% -25.12%
+ Complexity 4034 1918 -2116
=============================================
Files 1005 808 -197
Lines 24760 19686 -5074
Branches 2403 1859 -544
=============================================
- Hits 14010 6195 -7815
- Misses 9518 13018 +3500
+ Partials 1232 473 -759
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.44% <63.63%> (-13.08%)` | `21.00 <12.00> (+3.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.44% <69.09%> (-10.14%)` | `55.00 <6.00> (-17.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [540 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (7ccff4e) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `5.55%`.
> The diff coverage is `62.16%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 51.03% -5.56%
+ Complexity 4034 3665 -369
============================================
Files 1005 1782 +777
Lines 24760 37749 +12989
Branches 2403 4150 +1747
============================================
+ Hits 14010 19264 +5254
- Misses 9518 17502 +7984
+ Partials 1232 983 -249
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `37.19% <0.00%> (-2.31%)` | `6.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `72.47% <63.63%> (-10.05%)` | `23.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.57% <74.07%> (-8.01%)` | `56.00 <6.00> (-16.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1285 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...fbb4bcf](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `4.32%`.
> The diff coverage is `63.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 49.85% -4.33%
+ Complexity 4150 3605 -545
============================================
Files 1783 995 -788
Lines 38193 24660 -13533
Branches 4209 2403 -1806
============================================
- Hits 20695 12295 -8400
+ Misses 16511 11327 -5184
- Partials 987 1038 +51
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-9.21%)` | `22.00 <12.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (-10.47%)` | `55.00 <6.00> (-17.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `77.77% <83.33%> (+2.77%)` | `8.00 <1.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1300 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `1.59%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 52.59% -1.60%
+ Complexity 4150 3935 -215
============================================
Files 1783 1786 +3
Lines 38193 38152 -41
Branches 4209 4203 -6
============================================
- Hits 20695 20065 -630
- Misses 16511 17108 +597
+ Partials 987 979 -8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `73.63% <66.66%> (-7.14%)` | `23.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.29% <70.37%> (-9.43%)` | `55.00 <6.00> (-17.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `77.77% <83.33%> (+2.77%)` | `8.00 <1.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `60.97% <100.00%> (-1.82%)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [62 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `18.34%`.
> The diff coverage is `8.64%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 54.18% 35.83% -18.35%
+ Complexity 4150 2607 -1543
=============================================
Files 1783 964 -819
Lines 38193 23445 -14748
Branches 4209 2267 -1942
=============================================
- Hits 20695 8402 -12293
+ Misses 16511 14327 -2184
+ Partials 987 716 -271
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `9.95% <0.00%> (-57.78%)` | `9.00 <0.00> (-63.00)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `18.34% <4.44%> (-62.43%)` | `4.00 <1.00> (-14.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `40.74% <83.33%> (-34.26%)` | `4.00 <1.00> (-4.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [1401 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `3.01%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 51.17% -3.02%
+ Complexity 4150 3785 -365
============================================
Files 1783 1786 +3
Lines 38193 38152 -41
Branches 4209 4203 -6
============================================
- Hits 20695 19524 -1171
- Misses 16511 17648 +1137
+ Partials 987 980 -7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `73.63% <66.66%> (-7.14%)` | `23.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.29% <70.37%> (-9.43%)` | `55.00 <6.00> (-17.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `77.77% <83.33%> (+2.77%)` | `8.00 <1.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `60.97% <100.00%> (-1.82%)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [100 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (1757802) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `0.82%`.
> The diff coverage is `66.99%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.64% 52.81% -0.83%
+ Complexity 4056 3769 -287
============================================
Files 1778 988 -790
Lines 37770 24292 -13478
Branches 4155 2360 -1795
============================================
- Hits 20260 12831 -7429
+ Misses 16536 10299 -6237
- Partials 974 1162 +188
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...f/dynamic/watcher/IgnoreSuffixPatternsWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvSWdub3JlU3VmZml4UGF0dGVybnNXYXRjaGVyLmphdmE=) | `76.47% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...core/conf/dynamic/watcher/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `70.00% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <ø> (-43.59%)` | `8.00 <0.00> (-1.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `53.26% <50.00%> (-16.31%)` | `25.00 <1.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-10.44%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...nt/core/conf/dynamic/watcher/SpanLimitWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU3BhbkxpbWl0V2F0Y2hlci5qYXZh) | `66.66% <66.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.96% <68.75%> (-10.77%)` | `70.00 <11.00> (-2.00)` | |
| [...gent/core/context/ContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==) | `74.19% <100.00%> (-15.47%)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1274 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (1757802) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `3.83%`.
> The diff coverage is `65.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.64% 49.80% -3.84%
+ Complexity 4056 2947 -1109
============================================
Files 1778 836 -942
Lines 37770 20638 -17132
Branches 4155 1949 -2206
============================================
- Hits 20260 10279 -9981
+ Misses 16536 9522 -7014
+ Partials 974 837 -137
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-10.44%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.55% <68.75%> (-11.17%)` | `70.00 <11.00> (-2.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1326 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (af503ce) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `2.51%`.
> The diff coverage is `72.65%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 54.06% -2.52%
+ Complexity 4034 3857 -177
============================================
Files 1005 991 -14
Lines 24760 24406 -354
Branches 2403 2366 -37
============================================
- Hits 14010 13195 -815
- Misses 9518 10081 +563
+ Partials 1232 1130 -102
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.95% <76.36%> (-1.63%)` | `62.00 <8.00> (-10.00)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `77.77% <77.77%> (ø)` | `4.00 <4.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.55% <79.54%> (-1.97%)` | `23.00 <12.00> (+5.00)` | :arrow_down: |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (-81.82%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | |
| ... and [91 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b240c3b) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `20.58%`.
> The diff coverage is `47.36%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 53.64% 33.05% -20.59%
+ Complexity 4056 1969 -2087
=============================================
Files 1778 805 -973
Lines 37770 19529 -18241
Branches 4155 1825 -2330
=============================================
- Hits 20260 6455 -13805
+ Misses 16536 12617 -3919
+ Partials 974 457 -517
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `51.85% <31.81%> (-29.88%)` | `15.00 <8.00> (-3.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `24.59% <68.75%> (-43.14%)` | `30.00 <11.00> (-42.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1429 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **decrease** coverage by `17.08%`.
> The diff coverage is `49.05%`.
> :exclamation: Current head 3dd7696 differs from pull request most recent head b92c02b. Consider uploading reports for the commit b92c02b to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 55.09% 38.01% -17.09%
+ Complexity 3945 2789 -1156
=============================================
Files 991 963 -28
Lines 24628 23533 -1095
Branches 2402 2280 -122
=============================================
- Hits 13570 8947 -4623
- Misses 9878 13808 +3930
+ Partials 1180 778 -402
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `49.54% <28.88%> (-23.28%)` | `14.00 <7.00> (-3.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `38.88% <70.37%> (-19.56%)` | `32.00 <6.00> (-33.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [286 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `3.43%`.
> The diff coverage is `63.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 50.74% -3.44%
+ Complexity 4150 3645 -505
============================================
Files 1783 995 -788
Lines 38193 24660 -13533
Branches 4209 2403 -1806
============================================
- Hits 20695 12514 -8181
+ Misses 16511 11101 -5410
- Partials 987 1045 +58
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-9.21%)` | `22.00 <12.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (-10.47%)` | `55.00 <6.00> (-17.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `77.77% <83.33%> (+2.77%)` | `8.00 <1.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1297 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#discussion_r588795712
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -376,15 +374,63 @@ public SampleFamily endpoint(List<String> serviceKeys, List<String> endpointKeys
if (this == EMPTY) {
return EMPTY;
}
- this.context.setMeterEntity(MeterEntity.newEndpoint(dim(serviceKeys), dim(endpointKeys)));
- return left(io.vavr.collection.Stream.concat(serviceKeys, endpointKeys).asJava());
+ return createMeterSamples(serviceKeys, endpointKeys, ScopeType.ENDPOINT);
+ }
+
+ private SampleFamily createMeterSamples(List<String> serviceKeys, List<String> level2keys, ScopeType scopeType) {
+ final List<String> labelKeys = io.vavr.collection.Stream.concat(serviceKeys, level2keys).asJava();
+ Map<MeterEntity, Sample[]> meterSamples = new HashMap<>();
+ Arrays.stream(samples)
+ .collect(groupingBy(it -> getLabels(labelKeys, it), mapping(identity(), toList())))
+ .forEach((labels, samples) -> {
+ MeterEntity meterEntity = getMeterEntity(samples, serviceKeys, level2keys, scopeType);
+ Preconditions.checkNotNull(meterEntity);
+ meterSamples.put(meterEntity, left(labelKeys, samples));
+ });
+
+ this.context.setMeterSamples(meterSamples);
+ //This samples is original, The grouped samples is in context which mapping with MeterEntity
+ return SampleFamily.build(this.context, samples);
+ }
+
+ private MeterEntity getMeterEntity(List<Sample> samples,
+ List<String> serviceKeys,
+ List<String> level2keys,
+ ScopeType scopeType) {
+ switch (scopeType) {
+ case SERVICE:
+ return MeterEntity.newService(dim(serviceKeys, samples));
+ case SERVICE_INSTANCE:
+ return MeterEntity.newServiceInstance(dim(serviceKeys, samples), dim(level2keys, samples));
+ case ENDPOINT:
+ return MeterEntity.newEndpoint(dim(serviceKeys, samples), dim(level2keys, samples));
+ }
+ return null;
}
private String dim(List<String> labelKeys) {
- String name = labelKeys.stream().map(k -> samples[0].labels.getOrDefault(k, "")).collect(Collectors.joining("."));
+ String name = labelKeys.stream()
+ .map(k -> samples[0].labels.getOrDefault(k, ""))
+ .collect(Collectors.joining("."));
+ return CharMatcher.is('.').trimFrom(name);
+ }
+
+ private String dim(List<String> labelKeys, List<Sample> samples) {
+ String name = labelKeys.stream()
+ .map(k -> samples.get(0).labels.getOrDefault(k, ""))
+ .collect(Collectors.joining("."));
return CharMatcher.is('.').trimFrom(name);
}
+ private Sample[] left(List<String> labelKeys, List<Sample> samples) {
Review comment:
Technically, yes. I asked for better class layout, because it becomes more and more complex.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (2fcb790) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `3.75%`.
> The diff coverage is `60.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 52.83% -3.76%
+ Complexity 4034 3769 -265
============================================
Files 1005 990 -15
Lines 24760 24273 -487
Branches 2403 2358 -45
============================================
- Hits 14010 12824 -1186
- Misses 9518 10299 +781
+ Partials 1232 1150 -82
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-11.23%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.57% <72.72%> (-8.01%)` | `56.00 <6.00> (-16.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [124 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `0.87%`.
> The diff coverage is `68.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 53.31% -0.88%
+ Complexity 4150 4005 -145
============================================
Files 1783 1786 +3
Lines 38193 38152 -41
Branches 4209 4203 -6
============================================
- Hits 20695 20339 -356
- Misses 16511 16837 +326
+ Partials 987 976 -11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `75.45% <66.66%> (-5.32%)` | `23.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `60.00% <74.07%> (-7.73%)` | `56.00 <6.00> (-16.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `77.77% <83.33%> (+2.77%)` | `8.00 <1.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `60.97% <100.00%> (-1.82%)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [43 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (1757802) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `12.47%`.
> The diff coverage is `65.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 53.64% 41.16% -12.48%
+ Complexity 4056 2519 -1537
=============================================
Files 1778 836 -942
Lines 37770 20552 -17218
Branches 4155 1941 -2214
=============================================
- Hits 20260 8461 -11799
+ Misses 16536 11470 -5066
+ Partials 974 621 -353
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.44% <63.63%> (-12.29%)` | `21.00 <12.00> (+3.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `54.91% <68.75%> (-12.81%)` | `67.00 <11.00> (-5.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1371 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `56.44%`.
> The diff coverage is `76.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 56.44% +56.44%
- Complexity 0 3998 +3998
=============================================
Files 195 991 +796
Lines 4675 24427 +19752
Branches 544 2375 +1831
=============================================
+ Hits 0 13789 +13789
- Misses 4675 9432 +4757
- Partials 0 1206 +1206
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `83.33% <79.54%> (ø)` | `24.00 <13.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `67.94% <79.62%> (ø)` | `63.00 <8.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh) | | | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | | | |
| [...pache/skywalking/apm/agent/core/meter/MeterId.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJJZC5qYXZh) | | | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | | | |
| ... and [1000 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (d73396a) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `3.52%`.
> The diff coverage is `69.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.99% 50.47% -3.53%
+ Complexity 4079 3605 -474
============================================
Files 1779 990 -789
Lines 37794 24345 -13449
Branches 4157 2365 -1792
============================================
- Hits 20408 12288 -8120
+ Misses 16403 11037 -5366
- Partials 983 1020 +37
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `77.14% <0.00%> (-14.04%)` | `10.00 <0.00> (-1.00)` | |
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.13% <0.00%> (-0.39%)` | `6.00 <0.00> (ø)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.81% <75.92%> (-1.92%)` | `62.00 <8.00> (-10.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.73% <80.00%> (-1.00%)` | `23.00 <12.00> (+5.00)` | :arrow_down: |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1295 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `57.79%`.
> The diff coverage is `76.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 57.79% +57.79%
- Complexity 0 4055 +4055
=============================================
Files 198 991 +793
Lines 4691 24444 +19753
Branches 544 2376 +1832
=============================================
+ Hits 0 14127 +14127
- Misses 4691 9101 +4410
- Partials 0 1216 +1216
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `83.33% <79.54%> (ø)` | `24.00 <13.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `67.94% <79.62%> (ø)` | `63.00 <8.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...king/apm/agent/core/context/ExtensionInjector.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25JbmplY3Rvci5qYXZh) | | | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | | | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | | | |
| [...g/apache/skywalking/apm/toolkit/meter/MeterId.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvTWV0ZXJJZC5qYXZh) | | | |
| ... and [1003 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **decrease** coverage by `1.47%`.
> The diff coverage is `65.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 52.61% 51.13% -1.48%
+ Complexity 3945 3736 -209
============================================
Files 1783 994 -789
Lines 38122 24645 -13477
Branches 4201 2401 -1800
============================================
- Hits 20056 12603 -7453
+ Misses 17087 10925 -6162
- Partials 979 1117 +138
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-0.56%)` | `22.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.97% <72.22%> (+0.33%)` | `56.00 <6.00> (-9.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1275 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `48.41%`.
> The diff coverage is `62.85%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 48.41% +48.41%
- Complexity 0 3493 +3493
=============================================
Files 195 991 +796
Lines 4675 24222 +19547
Branches 544 2355 +1811
=============================================
+ Hits 0 11726 +11726
- Misses 4675 11494 +6819
- Partials 0 1002 +1002
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.37% <63.63%> (ø)` | `22.00 <13.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (ø)` | `55.00 <6.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [.../agent/core/context/util/ThrowableTransformer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1Rocm93YWJsZVRyYW5zZm9ybWVyLmphdmE=) | | | |
| [.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==) | | | |
| [...ache/skywalking/apm/agent/core/meter/MeterTag.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUYWcuamF2YQ==) | | | |
| [...apache/skywalking/apm/toolkit/meter/Histogram.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvSGlzdG9ncmFtLmphdmE=) | | | |
| ... and [1000 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (7ccff4e) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `5.96%`.
> The diff coverage is `62.16%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 50.61% -5.97%
+ Complexity 4034 3642 -392
============================================
Files 1005 1782 +777
Lines 24760 37749 +12989
Branches 2403 4150 +1747
============================================
+ Hits 14010 19108 +5098
- Misses 9518 17658 +8140
+ Partials 1232 983 -249
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `37.19% <0.00%> (-2.31%)` | `6.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `72.47% <63.63%> (-10.05%)` | `23.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.57% <74.07%> (-8.01%)` | `56.00 <6.00> (-16.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1285 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...fbb4bcf](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (1757802) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **increase** coverage by `0.50%`.
> The diff coverage is `75.72%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
+ Coverage 53.64% 54.14% +0.50%
+ Complexity 4056 3859 -197
============================================
Files 1778 988 -790
Lines 37770 24396 -13374
Branches 4155 2368 -1787
============================================
- Hits 20260 13209 -7051
+ Misses 16536 10002 -6534
- Partials 974 1185 +211
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...f/dynamic/watcher/IgnoreSuffixPatternsWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvSWdub3JlU3VmZml4UGF0dGVybnNXYXRjaGVyLmphdmE=) | `76.47% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...core/conf/dynamic/watcher/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `70.00% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `35.89% <ø> (-41.03%)` | `9.00 <0.00> (ø)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `54.34% <50.00%> (-15.22%)` | `25.00 <1.00> (ø)` | |
| [...nt/core/conf/dynamic/watcher/SpanLimitWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU3BhbkxpbWl0V2F0Y2hlci5qYXZh) | `66.66% <66.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.16% <75.00%> (-2.57%)` | `77.00 <11.00> (+5.00)` | :arrow_down: |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `82.40% <79.54%> (+0.67%)` | `24.00 <13.00> (+6.00)` | |
| [...gent/core/context/ContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==) | `74.19% <100.00%> (-15.47%)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1261 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `1.98%`.
> The diff coverage is `63.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 52.19% -1.99%
+ Complexity 4150 3729 -421
============================================
Files 1783 995 -788
Lines 38193 24660 -13533
Branches 4209 2403 -1806
============================================
- Hits 20695 12872 -7823
+ Misses 16511 10714 -5797
- Partials 987 1074 +87
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `72.47% <64.44%> (-8.30%)` | `23.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (-10.47%)` | `55.00 <6.00> (-17.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `77.77% <83.33%> (+2.77%)` | `8.00 <1.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1289 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (1757802) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `1.48%`.
> The diff coverage is `66.99%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.64% 52.15% -1.49%
+ Complexity 4056 3740 -316
============================================
Files 1778 988 -790
Lines 37770 24279 -13491
Branches 4155 2360 -1795
============================================
- Hits 20260 12663 -7597
+ Misses 16536 10483 -6053
- Partials 974 1133 +159
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...f/dynamic/watcher/IgnoreSuffixPatternsWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvSWdub3JlU3VmZml4UGF0dGVybnNXYXRjaGVyLmphdmE=) | `76.47% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...core/conf/dynamic/watcher/SamplingRateWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU2FtcGxpbmdSYXRlV2F0Y2hlci5qYXZh) | `70.00% <ø> (ø)` | `7.00 <0.00> (?)` | |
| [...lking/apm/agent/core/sampling/SamplingService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvc2FtcGxpbmcvU2FtcGxpbmdTZXJ2aWNlLmphdmE=) | `33.33% <ø> (-43.59%)` | `8.00 <0.00> (-1.00)` | |
| [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `53.26% <50.00%> (-16.31%)` | `25.00 <1.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-10.44%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...nt/core/conf/dynamic/watcher/SpanLimitWatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL3dhdGNoZXIvU3BhbkxpbWl0V2F0Y2hlci5qYXZh) | `66.66% <66.66%> (ø)` | `7.00 <7.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.96% <68.75%> (-10.77%)` | `70.00 <11.00> (-2.00)` | |
| [...gent/core/context/ContextManagerExtendService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0TWFuYWdlckV4dGVuZFNlcnZpY2UuamF2YQ==) | `74.19% <100.00%> (-15.47%)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1266 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (1757802) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `6.25%`.
> The diff coverage is `65.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.64% 47.38% -6.26%
+ Complexity 4056 2806 -1250
============================================
Files 1778 836 -942
Lines 37770 20620 -17150
Branches 4155 1948 -2207
============================================
- Hits 20260 9770 -10490
+ Misses 16536 10106 -6430
+ Partials 974 744 -230
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-10.44%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.55% <68.75%> (-11.17%)` | `70.00 <11.00> (-2.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1347 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (fbb4bcf) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `6.87%`.
> The diff coverage is `74.28%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 49.70% -6.88%
+ Complexity 4034 3635 -399
============================================
Files 1005 990 -15
Lines 24760 24342 -418
Branches 2403 2365 -38
============================================
- Hits 14010 12099 -1911
- Misses 9518 11213 +1695
+ Partials 1232 1030 -202
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.81% <75.92%> (-1.77%)` | `62.00 <8.00> (-10.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.48% <79.54%> (-1.05%)` | `24.00 <13.00> (+6.00)` | :arrow_down: |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...n/jdbc/postgresql/dao/PostgreSQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvcG9zdGdyZXNxbC9kYW8vUG9zdGdyZVNRTFRyYWNlUXVlcnlEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [146 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...fbb4bcf](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (af503ce) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `10.48%`.
> The diff coverage is `39.84%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 56.58% 46.09% -10.49%
+ Complexity 4034 3226 -808
=============================================
Files 1005 960 -45
Lines 24760 23248 -1512
Branches 2403 2239 -164
=============================================
- Hits 14010 10717 -3293
- Misses 9518 11614 +2096
+ Partials 1232 917 -315
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `53.70% <31.81%> (-28.83%)` | `16.00 <8.00> (-2.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `25.95% <50.90%> (-41.63%)` | `20.00 <3.00> (-52.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [245 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (1757802) into [master](https://codecov.io/gh/apache/skywalking/commit/9f00af6c5050448300bad753b64c86af55d61c5f?el=desc) (9f00af6) will **decrease** coverage by `3.57%`.
> The diff coverage is `65.78%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 53.64% 50.06% -3.58%
+ Complexity 4056 2964 -1092
============================================
Files 1778 836 -942
Lines 37770 20639 -17131
Branches 4155 1953 -2202
============================================
- Hits 20260 10332 -9928
+ Misses 16536 9472 -7064
+ Partials 974 835 -139
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-10.44%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.96% <68.75%> (-10.77%)` | `70.00 <11.00> (-2.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1321 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [80a9a5e...b240c3b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (2fcb790) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `3.12%`.
> The diff coverage is `60.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 53.46% -3.13%
+ Complexity 4034 3805 -229
============================================
Files 1005 990 -15
Lines 24760 24276 -484
Branches 2403 2358 -45
============================================
- Hits 14010 12978 -1032
- Misses 9518 10145 +627
+ Partials 1232 1153 -79
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `73.14% <63.63%> (-9.38%)` | `23.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.57% <72.72%> (-8.01%)` | `56.00 <6.00> (-16.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [106 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `7.21%`.
> The diff coverage is `41.22%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 46.96% -7.22%
+ Complexity 4150 3389 -761
============================================
Files 1783 995 -788
Lines 38193 24514 -13679
Branches 4209 2372 -1837
============================================
- Hits 20695 11514 -9181
+ Misses 16511 12050 -4461
+ Partials 987 950 -37
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `53.21% <31.11%> (-27.56%)` | `16.00 <8.00> (-2.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `25.64% <50.00%> (-42.09%)` | `20.00 <3.00> (-52.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `62.96% <83.33%> (-12.04%)` | `6.00 <1.00> (-2.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1319 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#discussion_r589136860
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/EntityDescription/EndpointEntityDescription.java
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.meter.analyzer.dsl.EntityDescription;
+
+import java.util.List;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+import org.apache.skywalking.oap.server.core.analysis.meter.ScopeType;
+
+public class EndpointEntityDescription implements EntityDescription {
+ private ScopeType scopeType = ScopeType.ENDPOINT;
+
+ private List<String> serviceKeys;
+
+ private List<String> endpointkeys;
Review comment:
```suggestion
private List<String> endpointKeys;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (1757802) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `4.18%`.
> The diff coverage is `78.94%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 52.40% -4.19%
+ Complexity 4034 3950 -84
============================================
Files 1005 1779 +774
Lines 24760 37812 +13052
Branches 2403 4157 +1754
============================================
+ Hits 14010 19814 +5804
- Misses 9518 17012 +7494
+ Partials 1232 986 -246
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.71% <78.12%> (-1.87%)` | `77.00 <11.00> (+5.00)` | :arrow_down: |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.65% <79.54%> (-0.88%)` | `24.00 <13.00> (+6.00)` | :arrow_down: |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `3.60% <0.00%> (-83.79%)` | `2.00% <0.00%> (-9.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.36% <0.00%> (-79.09%)` | `1.00% <0.00%> (-10.00%)` | |
| [...e/plugin/jdbc/h2/dao/H2ProfileTaskLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRhc2tMb2dRdWVyeURBTy5qYXZh) | `13.04% <0.00%> (-77.87%)` | `1.00% <0.00%> (-3.00%)` | |
| [...age/plugin/influxdb/query/ProfileTaskLogQuery.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGFza0xvZ1F1ZXJ5LmphdmE=) | `16.12% <0.00%> (-77.42%)` | `2.00% <0.00%> (-4.00%)` | |
| [...le/provider/handler/ProfileTaskServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctcHJvZmlsZS1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9wcm9maWxlL3Byb3ZpZGVyL2hhbmRsZXIvUHJvZmlsZVRhc2tTZXJ2aWNlSGFuZGxlci5qYXZh) | `18.64% <0.00%> (-71.02%)` | `3.00% <0.00%> (-6.00%)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <0.00%> (-61.52%)` | `3.00% <0.00%> (ø%)` | |
| [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `41.66% <0.00%> (-58.34%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [1239 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **decrease** coverage by `0.29%`.
> The diff coverage is `65.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 52.61% 52.31% -0.30%
+ Complexity 3945 3805 -140
============================================
Files 1783 994 -789
Lines 38122 24673 -13449
Branches 4201 2406 -1795
============================================
- Hits 20056 12908 -7148
+ Misses 17087 10611 -6476
- Partials 979 1154 +175
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-0.56%)` | `22.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.97% <72.22%> (+0.33%)` | `56.00 <6.00> (-9.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| ... and [1278 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `1.40%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 52.78% -1.41%
+ Complexity 4150 3947 -203
============================================
Files 1783 1786 +3
Lines 38193 38152 -41
Branches 4209 4203 -6
============================================
- Hits 20695 20138 -557
- Misses 16511 17035 +524
+ Partials 987 979 -8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `73.63% <66.66%> (-7.14%)` | `23.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.29% <70.37%> (-9.43%)` | `55.00 <6.00> (-17.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `77.77% <83.33%> (+2.77%)` | `8.00 <1.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `60.97% <100.00%> (-1.82%)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [58 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ad6c827) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `15.85%`.
> The diff coverage is `63.80%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 26.10% 41.95% +15.85%
- Complexity 1925 2285 +360
=============================================
Files 987 1772 +785
Lines 23812 37405 +13593
Branches 2329 4310 +1981
=============================================
+ Hits 6215 15692 +9477
- Misses 17123 20717 +3594
- Partials 474 996 +522
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.80% <63.63%> (+0.84%)` | `21.00 <12.00> (+5.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.87% <70.37%> (+1.70%)` | `55.00 <6.00> (-7.00)` | :arrow_up: |
| [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (-81.82%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../storage/plugin/jdbc/tidb/TiDBStorageProvider.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCU3RvcmFnZVByb3ZpZGVyLmphdmE=) | `8.33% <0.00%> (-75.00%)` | `3.00% <0.00%> (-6.00%)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `31.81% <0.00%> (-61.52%)` | `3.00% <0.00%> (ø%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `32.43% <0.00%> (-59.88%)` | `2.00% <0.00%> (ø%)` | |
| [...er/meter/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyLmphdmE=) | `23.52% <0.00%> (-43.14%)` | `2.00% <0.00%> (ø%)` | |
| ... and [1341 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...8189591](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **decrease** coverage by `5.36%`.
> The diff coverage is `65.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 52.61% 47.24% -5.37%
+ Complexity 3945 3481 -464
============================================
Files 1783 994 -789
Lines 38122 24608 -13514
Branches 4201 2400 -1801
============================================
- Hits 20056 11625 -8431
+ Misses 17087 11981 -5106
- Partials 979 1002 +23
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.55% <64.44%> (-0.56%)` | `22.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.97% <72.22%> (+0.33%)` | `56.00 <6.00> (-9.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1305 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `1.30%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 52.87% -1.31%
+ Complexity 4150 3965 -185
============================================
Files 1783 1786 +3
Lines 38193 38152 -41
Branches 4209 4203 -6
============================================
- Hits 20695 20174 -521
- Misses 16511 17000 +489
+ Partials 987 978 -9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `73.63% <66.66%> (-7.14%)` | `23.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.29% <70.37%> (-9.43%)` | `55.00 <6.00> (-17.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `77.77% <83.33%> (+2.77%)` | `8.00 <1.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `60.97% <100.00%> (-1.82%)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../receiver/zabbix/provider/config/ZabbixConfig.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/provider/handler/MeterServiceHandlerCompat.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvaGFuZGxlci9NZXRlclNlcnZpY2VIYW5kbGVyQ29tcGF0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [53 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **increase** coverage by `2.51%`.
> The diff coverage is `65.09%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
+ Coverage 52.61% 55.12% +2.51%
+ Complexity 3945 3922 -23
============================================
Files 1783 994 -789
Lines 38122 24704 -13418
Branches 4201 2411 -1790
============================================
- Hits 20056 13619 -6437
+ Misses 17087 9871 -7216
- Partials 979 1214 +235
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `73.39% <64.44%> (+1.27%)` | `23.00 <13.00> (+6.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.40% <72.22%> (+0.76%)` | `56.00 <6.00> (-9.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1276 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (af503ce) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `1.92%`.
> The diff coverage is `72.65%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 54.65% -1.93%
+ Complexity 4034 3887 -147
============================================
Files 1005 991 -14
Lines 24760 24419 -341
Branches 2403 2366 -37
============================================
- Hits 14010 13347 -663
- Misses 9518 9928 +410
+ Partials 1232 1144 -88
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.95% <76.36%> (-1.63%)` | `62.00 <8.00> (-10.00)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `77.77% <77.77%> (ø)` | `4.00 <4.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.55% <79.54%> (-1.97%)` | `23.00 <12.00> (+5.00)` | :arrow_down: |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| [.../server/library/server/ssl/AbstractSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3NzbC9BYnN0cmFjdFNzbENvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [84 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on a change in pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
wankai123 commented on a change in pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#discussion_r589134407
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -376,15 +374,63 @@ public SampleFamily endpoint(List<String> serviceKeys, List<String> endpointKeys
if (this == EMPTY) {
return EMPTY;
}
- this.context.setMeterEntity(MeterEntity.newEndpoint(dim(serviceKeys), dim(endpointKeys)));
- return left(io.vavr.collection.Stream.concat(serviceKeys, endpointKeys).asJava());
+ return createMeterSamples(serviceKeys, endpointKeys, ScopeType.ENDPOINT);
+ }
+
+ private SampleFamily createMeterSamples(List<String> serviceKeys, List<String> level2keys, ScopeType scopeType) {
+ final List<String> labelKeys = io.vavr.collection.Stream.concat(serviceKeys, level2keys).asJava();
+ Map<MeterEntity, Sample[]> meterSamples = new HashMap<>();
+ Arrays.stream(samples)
+ .collect(groupingBy(it -> getLabels(labelKeys, it), mapping(identity(), toList())))
+ .forEach((labels, samples) -> {
+ MeterEntity meterEntity = getMeterEntity(samples, serviceKeys, level2keys, scopeType);
+ Preconditions.checkNotNull(meterEntity);
+ meterSamples.put(meterEntity, left(labelKeys, samples));
+ });
+
+ this.context.setMeterSamples(meterSamples);
+ //This samples is original, The grouped samples is in context which mapping with MeterEntity
+ return SampleFamily.build(this.context, samples);
+ }
+
+ private MeterEntity getMeterEntity(List<Sample> samples,
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (7ccff4e) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `23.43%`.
> The diff coverage is `47.74%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 56.58% 33.14% -23.44%
+ Complexity 4034 1974 -2060
=============================================
Files 1005 809 -196
Lines 24760 19629 -5131
Branches 2403 1839 -564
=============================================
- Hits 14010 6506 -7504
- Misses 9518 12654 +3136
+ Partials 1232 469 -763
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `0.00% <0.00%> (-39.50%)` | `0.00 <0.00> (-6.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `53.70% <31.81%> (-28.83%)` | `16.00 <9.00> (-2.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `38.88% <70.37%> (-28.70%)` | `32.00 <6.00> (-40.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [498 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...fbb4bcf](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **decrease** coverage by `13.12%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 55.09% 41.97% -13.13%
+ Complexity 3945 3135 -810
=============================================
Files 991 994 +3
Lines 24628 24445 -183
Branches 2402 2368 -34
=============================================
- Hits 13570 10260 -3310
- Misses 9878 13302 +3424
+ Partials 1180 883 -297
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `53.21% <31.11%> (-19.61%)` | `16.00 <9.00> (-1.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `38.88% <70.37%> (-19.56%)` | `32.00 <6.00> (-33.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [221 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (7ccff4e) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `6.72%`.
> The diff coverage is `62.16%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 49.85% -6.73%
+ Complexity 4034 3595 -439
============================================
Files 1005 1782 +777
Lines 24760 37749 +12989
Branches 2403 4150 +1747
============================================
+ Hits 14010 18820 +4810
- Misses 9518 17946 +8428
+ Partials 1232 983 -249
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `36.36% <0.00%> (-3.14%)` | `5.00 <0.00> (-1.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `72.47% <63.63%> (-10.05%)` | `23.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.57% <74.07%> (-8.01%)` | `56.00 <6.00> (-16.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1282 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...fbb4bcf](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `57.77%`.
> The diff coverage is `76.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 57.77% +57.77%
- Complexity 0 4054 +4054
=============================================
Files 198 991 +793
Lines 4691 24444 +19753
Branches 544 2376 +1832
=============================================
+ Hits 0 14123 +14123
- Misses 4691 9105 +4414
- Partials 0 1216 +1216
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `83.33% <79.54%> (ø)` | `24.00 <13.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `67.94% <79.62%> (ø)` | `63.00 <8.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...ache/skywalking/apm/toolkit/meter/BaseBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQmFzZUJ1aWxkZXIuamF2YQ==) | | | |
| [...t/core/plugin/bytebuddy/ArgumentTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bcmd1bWVudFR5cGVOYW1lTWF0Y2guamF2YQ==) | | | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | | | |
| [.../apache/skywalking/apm/agent/core/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvR2F1Z2UuamF2YQ==) | | | |
| ... and [1003 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (7ccff4e) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `13.69%`.
> The diff coverage is `47.74%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 56.58% 42.88% -13.70%
+ Complexity 4034 3144 -890
=============================================
Files 1005 991 -14
Lines 24760 24108 -652
Branches 2403 2326 -77
=============================================
- Hits 14010 10339 -3671
- Misses 9518 12879 +3361
+ Partials 1232 890 -342
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `5.08% <0.00%> (-34.42%)` | `1.00 <0.00> (-5.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `53.70% <31.81%> (-28.83%)` | `16.00 <9.00> (-2.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `38.88% <70.37%> (-28.70%)` | `32.00 <6.00> (-40.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [265 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...fbb4bcf](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (d73396a) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `1.76%`.
> The diff coverage is `77.35%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 52.42% -1.77%
+ Complexity 4150 3979 -171
============================================
Files 1783 1782 -1
Lines 38193 37822 -371
Branches 4209 4158 -51
============================================
- Hits 20695 19827 -868
- Misses 16511 17012 +501
+ Partials 987 983 -4
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `81.81% <80.00%> (+1.04%)` | `24.00 <13.00> (+6.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `68.08% <81.48%> (+0.35%)` | `63.00 <8.00> (-9.00)` | :arrow_up: |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-90.09%)` | `1.00% <0.00%> (-10.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [79 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `2.56%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 51.61% -2.57%
+ Complexity 4150 3812 -338
============================================
Files 1783 1786 +3
Lines 38193 38152 -41
Branches 4209 4203 -6
============================================
- Hits 20695 19694 -1001
- Misses 16511 17478 +967
+ Partials 987 980 -7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `73.63% <66.66%> (-7.14%)` | `23.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `58.29% <70.37%> (-9.43%)` | `55.00 <6.00> (-17.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `77.77% <83.33%> (+2.77%)` | `8.00 <1.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `60.97% <100.00%> (-1.82%)` | `0.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [93 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3b206ef) into [master](https://codecov.io/gh/apache/skywalking/commit/ba282bb2432d9d5b013f4038f72a71fab7ac444b?el=desc) (ba282bb) will **decrease** coverage by `17.28%`.
> The diff coverage is `59.82%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 53.99% 36.71% -17.29%
+ Complexity 4079 2160 -1919
=============================================
Files 1779 809 -970
Lines 37794 19723 -18071
Branches 4157 1868 -2289
=============================================
- Hits 20408 7241 -13167
+ Misses 16403 11935 -4468
+ Partials 983 547 -436
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/storage/plugin/jdbc/h2/dao/H2TraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVHJhY2VRdWVyeURBTy5qYXZh) | `38.13% <0.00%> (-0.39%)` | `6.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `69.72% <64.44%> (-12.01%)` | `21.00 <12.00> (+3.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.69% <68.51%> (-10.04%)` | `55.00 <6.00> (-17.00)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1430 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [1a7cc80...3b206ef](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (2fcb790) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `16.86%`.
> The diff coverage is `60.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
- Coverage 56.58% 39.71% -16.87%
+ Complexity 4034 2424 -1610
=============================================
Files 1005 839 -166
Lines 24760 20627 -4133
Branches 2403 1950 -453
=============================================
- Hits 14010 8193 -5817
- Misses 9518 11821 +2303
+ Partials 1232 613 -619
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `71.29% <63.63%> (-11.23%)` | `22.00 <13.00> (+4.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.14% <72.72%> (-8.44%)` | `56.00 <6.00> (-16.00)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/oap/server/analyzer/event/EventAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9ldmVudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL2V2ZW50L0V2ZW50QW5hbHl6ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [398 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (af503ce) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **decrease** coverage by `2.13%`.
> The diff coverage is `72.65%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 56.58% 54.44% -2.14%
+ Complexity 4034 3879 -155
============================================
Files 1005 991 -14
Lines 24760 24419 -341
Branches 2403 2366 -37
============================================
- Hits 14010 13295 -715
- Misses 9518 9982 +464
+ Partials 1232 1142 -90
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.95% <76.36%> (-1.63%)` | `62.00 <8.00> (-10.00)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `77.77% <77.77%> (ø)` | `4.00 <4.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.55% <79.54%> (-1.97%)` | `23.00 <12.00> (+5.00)` | :arrow_down: |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `0.00% <0.00%> (-81.82%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | |
| [...ap/server/core/alarm/AlarmStandardPersistence.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1TdGFuZGFyZFBlcnNpc3RlbmNlLmphdmE=) | `11.76% <0.00%> (-76.48%)` | `2.00% <0.00%> (-2.00%)` | |
| ... and [86 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#discussion_r588228796
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -477,7 +523,7 @@ static RunningContext instance() {
.build();
}
- MeterEntity meterEntity;
+ private Map<MeterEntity, Sample[]> meterSamples;
Review comment:
This could be never initialized, if there is no `service`/`instance`/`endpoint` called. Then could cause NPE in the Analyzer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (3dd7696) into [master](https://codecov.io/gh/apache/skywalking/commit/0be76ace5a491ef9d076649f918b48c92e91b2ff?el=desc) (0be76ac) will **increase** coverage by `2.67%`.
> The diff coverage is `65.09%`.
> :exclamation: Current head 3dd7696 differs from pull request most recent head b92c02b. Consider uploading reports for the commit b92c02b to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
+ Coverage 52.61% 55.28% +2.67%
+ Complexity 3945 3932 -13
============================================
Files 1783 994 -789
Lines 38122 24704 -13418
Branches 4201 2411 -1790
============================================
- Hits 20056 13657 -6399
+ Misses 17087 9830 -7257
- Partials 979 1217 +238
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `73.39% <64.44%> (+1.27%)` | `23.00 <13.00> (+6.00)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `59.40% <72.22%> (+0.76%)` | `56.00 <6.00> (-9.00)` | :arrow_up: |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1276 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [0be76ac...b92c02b](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (b4a60c3) into [master](https://codecov.io/gh/apache/skywalking/commit/254f755a5d96d5d4b016df3cc4794ae3c2c90b4b?el=desc) (254f755) will **increase** coverage by `57.77%`.
> The diff coverage is `76.19%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
=============================================
+ Coverage 0.00% 57.77% +57.77%
- Complexity 0 4054 +4054
=============================================
Files 198 991 +793
Lines 4691 24444 +19753
Branches 544 2376 +1832
=============================================
+ Hits 0 14123 +14123
- Misses 4691 9105 +4414
- Partials 0 1216 +1216
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `33.33% <33.33%> (ø)` | `1.00 <1.00> (?)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `83.33% <79.54%> (ø)` | `24.00 <13.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `67.94% <79.62%> (ø)` | `63.00 <8.00> (?)` | |
| [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `1.00% <0.00%> (+1.00%)` | |
| [...ache/skywalking/apm/toolkit/meter/BaseBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQmFzZUJ1aWxkZXIuamF2YQ==) | | | |
| [...che/skywalking/apm/agent/core/meter/BaseMeter.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQmFzZU1ldGVyLmphdmE=) | | | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | | | |
| [...ache/skywalking/apm/agent/core/meter/MeterTag.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUYWcuamF2YQ==) | | | |
| ... and [1003 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [254f755...ad6c827](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (ae97037) into [master](https://codecov.io/gh/apache/skywalking/commit/1bd397db9b3a5cdbcc82736dcba2e869391ad7b7?el=desc) (1bd397d) will **decrease** coverage by `1.31%`.
> The diff coverage is `63.15%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
- Coverage 54.18% 52.87% -1.32%
+ Complexity 4150 3778 -372
============================================
Files 1783 995 -788
Lines 38193 24701 -13492
Branches 4209 2408 -1801
============================================
- Hits 20695 13060 -7635
+ Misses 16511 10549 -5962
- Partials 987 1092 +105
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `50.00% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `72.47% <64.44%> (-8.30%)` | `23.00 <13.00> (+5.00)` | :arrow_down: |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `57.26% <68.51%> (-10.47%)` | `55.00 <6.00> (-17.00)` | |
| [...e/skywalking/oap/meter/analyzer/MetricConvert.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvTWV0cmljQ29udmVydC5qYXZh) | `77.77% <83.33%> (+2.77%)` | `8.00 <1.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1284 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [c2fa8ba...262a4a5](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#discussion_r588169502
##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamily.java
##########
@@ -376,15 +374,63 @@ public SampleFamily endpoint(List<String> serviceKeys, List<String> endpointKeys
if (this == EMPTY) {
return EMPTY;
}
- this.context.setMeterEntity(MeterEntity.newEndpoint(dim(serviceKeys), dim(endpointKeys)));
- return left(io.vavr.collection.Stream.concat(serviceKeys, endpointKeys).asJava());
+ return createMeterSamples(serviceKeys, endpointKeys, ScopeType.ENDPOINT);
+ }
+
+ private SampleFamily createMeterSamples(List<String> serviceKeys, List<String> level2keys, ScopeType scopeType) {
+ final List<String> labelKeys = io.vavr.collection.Stream.concat(serviceKeys, level2keys).asJava();
Review comment:
`o.vavr.collection.Stream` Full class name? I can't other part of the codes using this `io.vavr`. Could you switch back to official JDK's Stream?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6495: Support metrics grouped by scope labelValue in MAL, no need global same labelValue as before.
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6495:
URL: https://github.com/apache/skywalking/pull/6495#issuecomment-791399220
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=h1) Report
> Merging [#6495](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=desc) (af503ce) into [master](https://codecov.io/gh/apache/skywalking/commit/20425c3aa5039899ed73ca8ffbe17062a73285cb?el=desc) (20425c3) will **increase** coverage by `0.20%`.
> The diff coverage is `72.65%`.
[](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6495 +/- ##
============================================
+ Coverage 56.58% 56.79% +0.20%
+ Complexity 4034 4009 -25
============================================
Files 1005 991 -14
Lines 24760 24447 -313
Branches 2403 2371 -32
============================================
- Hits 14010 13884 -126
+ Misses 9518 9388 -130
+ Partials 1232 1175 -57
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/EntityDescription/EndpointEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0VuZHBvaW50RW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `65.95% <76.36%> (-1.63%)` | `62.00 <8.00> (-10.00)` | |
| [...sl/EntityDescription/ServiceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL1NlcnZpY2VFbnRpdHlEZXNjcmlwdGlvbi5qYXZh) | `77.77% <77.77%> (ø)` | `4.00 <4.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `80.55% <79.54%> (-1.97%)` | `23.00 <12.00> (+5.00)` | :arrow_down: |
| [...l/EntityDescription/InstanceEntityDescription.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0VudGl0eURlc2NyaXB0aW9uL0luc3RhbmNlRW50aXR5RGVzY3JpcHRpb24uamF2YQ==) | `90.00% <90.00%> (ø)` | `5.00 <5.00> (?)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `7.29% <0.00%> (-79.57%)` | `2.00% <0.00%> (-11.00%)` | |
| [.../core/analysis/meter/function/sum/SumFunction.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vc3VtL1N1bUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-69.50%)` | `0.00% <0.00%> (-12.00%)` | |
| [...storage/plugin/jdbc/tidb/TiDBHistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS10aWRiLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvdGlkYi9UaURCSGlzdG9yeURlbGV0ZURBTy5qYXZh) | `13.63% <0.00%> (-68.19%)` | `1.00% <0.00%> (-5.00%)` | |
| [...er/storage/plugin/jdbc/mysql/MySQLLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxMb2dRdWVyeURBTy5qYXZh) | `40.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| ... and [64 more](https://codecov.io/gh/apache/skywalking/pull/6495/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=footer). Last update [20425c3...af503ce](https://codecov.io/gh/apache/skywalking/pull/6495?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org