You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/07/23 16:52:00 UTC
[GitHub] [trafficserver] randall opened a new pull request #7034: Move to blocklists and allowlists
randall opened a new pull request #7034:
URL: https://github.com/apache/trafficserver/pull/7034
The words blocklist and allowlist are equally descriptive as their racially
charged alternatives and gaining industry-wide acceptance.
Co-Authored-By: Randall Meyer <rr...@apache.org>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #7034: Move to denylists and allowlists
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #7034:
URL: https://github.com/apache/trafficserver/pull/7034#issuecomment-665146736
@ywkaras Thanks for the feedback! Should be updated now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on a change in pull request #7034: Move to denylists and allowlists
Posted by GitBox <gi...@apache.org>.
ywkaras commented on a change in pull request #7034:
URL: https://github.com/apache/trafficserver/pull/7034#discussion_r461640995
##########
File path: doc/admin-guide/plugins/cachekey.en.rst
##########
@@ -179,10 +179,10 @@ Cache key structure and related plugin parameters
^^^^^^^^^^^^^^^
* If no query related plugin parameters are used, the query string is included in the `cache key`.
-* ``--exclude-params`` (default: empty list) - comma-separated list of query params to be black-listed in the `cache key`. If the list is empty then no black-list is applied (no query parameters will be excluded from the `cache key`). The exclude list overrides the include list.
-* ``--include-params`` (default: empty list) - comma-separated list of query params to be white-listed in the `cache key`. If the list is empty then no white-list is applied (all query parameters will be included in the `cache key`).
-* ``--include-match-params`` (default: empty list) - regular expression matching query parameter names which will be white-listed in the `cache key`.
-* ``--exclude-match-params`` (default: empty list) - regular expression matching query parameter names which will be black-listed in the `cache key`.
+* ``--exclude-params`` (default: empty list) - comma-separated list of query params to be block-listed in the `cache key`. If the list is empty then no block-list is applied (no query parameters will be excluded from the `cache key`). The exclude list overrides the include list.
+* ``--include-params`` (default: empty list) - comma-separated list of query params to be allow-listed in the `cache key`. If the list is empty then no allow-list is applied (all query parameters will be included in the `cache key`).
+* ``--include-match-params`` (default: empty list) - regular expression matching query parameter names which will be allow-listed in the `cache key`.
+* ``--exclude-match-params`` (default: empty list) - regular expression matching query parameter names which will be block-listed in the `cache key`.
Review comment:
Should these be deny not block?
##########
File path: doc/admin-guide/plugins/cachekey.en.rst
##########
@@ -377,7 +377,7 @@ The following will make sure only query parameters ``a`` and ``c`` will be used
If the URI has the following query string ``c=1&a=1&b=2&x=1&k=1&u=1&y=1`` the `cache key` will use ``c=1&a=1``
-White-list + black-list certain parameters using multiple parameters in the same remap rule.
+Allow-list + block-list certain parameters using multiple parameters in the same remap rule.
""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""
Review comment:
ditto
##########
File path: doc/admin-guide/plugins/cachekey.en.rst
##########
@@ -390,7 +390,7 @@ If the plugin is used with the following plugin parameters in the remap rule: ::
and if the URI has the following query string ``c=1&a=1&b=2&x=1&k=1&u=1&y=1`` the `cache key` will use ``c=1&b=1``
-White-list + black-list certain parameters using multiple parameters in the same remap rule and regular expressions (PCRE).
+Allow-list + block-list certain parameters using multiple parameters in the same remap rule and regular expressions (PCRE).
"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""
Review comment:
ditto
##########
File path: doc/admin-guide/plugins/cachekey.en.rst
##########
@@ -585,12 +585,12 @@ and if ``browser_agents.config`` contains: ::
then ``browser`` will be used when constructing the key.
-User-Agent black-list classifier
+User-Agent block-list classifier
Review comment:
another
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #7034: Move to blocklists and allowlists
Posted by GitBox <gi...@apache.org>.
randall commented on pull request #7034:
URL: https://github.com/apache/trafficserver/pull/7034#issuecomment-663116397
This was originally #6913
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7034: Move to denylists and allowlists
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7034:
URL: https://github.com/apache/trafficserver/pull/7034#issuecomment-668332654
Cherry-picked to v9.0.x branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall merged pull request #7034: Move to denylists and allowlists
Posted by GitBox <gi...@apache.org>.
randall merged pull request #7034:
URL: https://github.com/apache/trafficserver/pull/7034
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org