[jira] [Commented] (ISIS-1571) Should throw metamodel validation error if omit choices or autoComplete for parameter collection type.

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ISIS-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15863515#comment-15863515 ] 

ASF subversion and git services commented on ISIS-1571:
-------------------------------------------------------

Commit e402f2311a776687ec653f5cf9270053fbd2f0bc in isis's branch refs/heads/maint-1.14.0 from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e402f23 ]

ISIS-1571: checks that every action collection parameter has a supporting choices or autoComplete facet.

Implementing this required moving the metamodel validation to be run within a session.  This results in potentially more object specs to validate, and in particular resulted in a validation failure that java.lang.Object and FreeStandingList had the same object type.  So this commit also incorporates a fix for that, by only comparing specs that are entities or view models.


> Should throw metamodel validation error if omit choices or autoComplete for parameter collection type.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: ISIS-1571
>                 URL: https://issues.apache.org/jira/browse/ISIS-1571
>             Project: Isis
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.13.2.1
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>            Priority: Minor
>             Fix For: 1.14.0
>
>
> The current implementation of collection parameters (as per ISIS-785) requires that a choices or autoComplete facet is required for the parameter.
> This ticket is to check this requirement early using a metamodel validator.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)